- 31 Dec, 2020 3 commits
-
-
Jakob Gruber authored
Tbr: machenbach@chromium.org Bug: v8:11255 Change-Id: Ic7dc95306f637af5973764e8c39e2454d959ac23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606337Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#71897}
-
Jakob Gruber authored
.. to verify that the trampoline_pc has been set. Bug: chromium:1161357 Change-Id: If7e1a13cff9919e2e8a65c095d80dfcef2dc05cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606333 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#71896}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1016d67..b3c270e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3b39cef..364205c TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4130d3e2ea1335fc6fbf6782ee3e602e2804c8d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2607771Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71895}
-
- 30 Dec, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7c34525..1016d67 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia059af587d2b72fc76fa58a7369c953958f19ac9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606555Reviewed-by:
-
- 29 Dec, 2020 10 commits
-
-
Benedikt Meurer authored
The "imports" and "exports" that were exposed on WebAssembly frames via Debug-Evaluate aren't useful for the DWARF C/C++ extension (and likely not for any other language extension), since they only expose static information that's easily available (upfront) by reading the Wasm wire bytes. In fact, there are already standardized functions in the WebAssembly specification, namely `WebAssembly.Module.imports(module)` and `WebAssembly.Module.exports(module)`, which yield static information about the imports and exports of a Wasm module. So instead of exposing special, non-standard "imports" and "exports", we now instead expose both the "instance" and the "module" objects via both the Debug Proxy and the Scope view, and also add internal [[Exports]] and [[Imports]] properties to WasmModuleObject, which under the hood use the standard methods mentioned above. Fixed: chromium:1162069 Bug: chromium:1071432, chromium:1083146 Screenshot: https://imgur.com/lcaW2jL.png Doc: https://docs.google.com/document/d/1rqbu0jKTl3q_xCxLnKzkjGXWEsHnJ9aERVhKV9RNDgE#bookmark=id.925bb2qgou38 Change-Id: Ie27e55bb08ea5f90493c57375bf2b48dfb11a4d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606050 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#71893}
-
Benedikt Meurer authored
For JSArrayBuffer instances (which map to both v8::ArrayBuffer and v8::SharedArrayBuffer), we add a couple of synthetic views to its ValueMirror to make it easy for developers to peak into the contents of the JSArrayBuffer. These were previously real properties, but that's just wrong (both intuitively and semantically), and they should instead be internal properties. Drive-by-fix: The [[IsDetached]] internal property should only be shown on actually detached JSArrayBuffer's to reduce visual clutter. And for detached JSArrayBuffers creating views on them throws TypeErrors per specification, so we shouldn't attempt to display views on them. Bug: v8:9308, chromium:1162229 Change-Id: Ia006de7873ca4b27aae7d00d46e1b69d2e326449 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606047 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Bug: chromium:116229 Change-Id: I16e185c2156dd7ba812f7d484c2e281febfa3635 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2606048 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
We accidentally compiled the source for Debug-Evaluate on Wasm frames twice, and used the first script result as outer function info for the second, actual compile (which goes via the `eval` machinery). Also unify DebugEvaluate::Local and DebugEvaluate::WebAssembly, since they are essentially very similar, except for the context. Bug: chromium:1127914 Change-Id: I8eb85c128c05ab1d4fcb73061de89b0942d1e5c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2605198 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
LiuYu authored
This fix the following instructions: kExprI32SConvertF64 in mips32, RecordSpillsInSafepoint in mips32 and mips64. Change-Id: I762fe4a7afa06fa8470fb0de932756a145d66099 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2605905 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71889}
-
Zhi An Ng authored
Prototype these 4 instructions: - i64x2.widen_low_i32x4_s - i64x2.widen_high_i32x4_s - i64x2.widen_low_i32x4_u - i64x2.widen_high_i32x4_u Bug: v8:10972 Change-Id: I3defd0a2431252bc3f5bb45e022e62b37beb34ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601012 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#71888}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ffd4756..7c34525 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/46ef281..3b39cef TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3881d27d5aec152fbb1059e8db3a2e85337a6b77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2605670Reviewed-by:
-
Zhi An Ng authored
Bug: v8:10971 Change-Id: I60186a445f3a5ad366cba4e6bcb16519098aa6ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601009 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Zhi An Ng authored
This will make these functions usable from Liftoff when we later implement extended multiply instructions in Liftoff. Bug: v8:11262 Change-Id: I5fb105bc0184675eb60cd8ae63cc13955b0f767d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601876 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Zhi An Ng authored
In AVX, it is better to use the appropriate integer or floating point moves depending on which instructions produce/consume these moves, since there can be a delay moving from integer to floating point domain. On SSE systems, it is less important, and we can move movaps/movups which is 1 byte shorter than movdqa/movdqu. This patch cleans up a couple of places, and defines macro-assembler functions Movdqa, Movdqu, Movapd, to call into movaps/movups when AVX is not supported. Change-Id: Iba6c54e218875f1a70f61792978d7b3f69edfb4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599843 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 28 Dec, 2020 3 commits
-
-
Milad Fa authored
Change-Id: Idae6adfd81889da96e7f9dad8781c9a285bea72a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601343Reviewed-by:
-
Benedikt Meurer authored
With https://crrev.com/c/2087396 we introduced a new CDP method `Debugger.executeWasmEvaluator()`, which we originally intended to use as the foundation for Debug-Evaluate on Wasm frames. However in the process of prototyping we learned that it is too costly and too inefficient to use WebAssembly modules here, and we switched to regular Debug-Evaluate with JavaScript instead (with a special debug proxy exposed that allows JavaScript to peak into the Wasm frame), since JavaScript is better suited for short-lived / short-running snippets and we don't need clang and wasm-ld then to generate these snippets. The JavaScript exposed debug proxy (as described in [1]) not only enables more powerful and flexible Debug-Evaluate for the DWARF C/C++ extension, but also serves as the basis for various aspects of the Basic Wasm Developer Experience. In order to pay down technical debt and to keep the maintenance overhead low, we should remove the initial prototype now, also to ensure that we don't accidentally attract other users of CDP to rely on this unsupported API (despite it being marked as "experimental"). [1]: https://docs.google.com/document/d/1VZOJrU2VsqOZe3IUzbwQWQQSZwgGySsm5119Ust1gUA Fixed: chromium:1162062 Bug: chromium:1020120, chromium:1068571, chromium:1127914 Change-Id: I6dba8c906a8675ce6c29a52e3c32bb6626a27247 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2605186 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3d38a62..ffd4756 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2692889cddf15d7d9adfbe9594bd94fa41aea87c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2604592Reviewed-by:
-
- 27 Dec, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c5cfdff..3d38a62 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/ea9f1f7..2277272 Rolling v8/buildtools/linux64: git_revision:53d92014bf94c3893886470a1c7c1289f8818db0..git_revision:0d67e272bdb8145f87d238bc0b2cb8bf80ccec90 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic602dc2aafdb1224b64b1407de0415acc1453ae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2604148Reviewed-by:
-
- 26 Dec, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ff0b5c1..c5cfdff TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If817e8ac8400c0b4c5a0b16f5901ac71f0136891 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2603920Reviewed-by:
-
- 25 Dec, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2d94fa5..ff0b5c1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/67e1228..46ef281 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7fd43af962a4b7da6e1641e6990776aedb46fb84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2603522Reviewed-by:
-
- 24 Dec, 2020 5 commits
-
-
Milad Fa authored
Change-Id: If9bb55c0fa3297b5e0453cc9bc89bb906a905bf8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601342Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71877}
-
Yang Guo authored
If we attempt to pause, we'd check whether frames are framework code which we pattern match with a regexp. That could cause re-entering regexp, which is not allowed. Fixed: chromium:1125934 Change-Id: I3b52b202a5570f7929def39176cfe5e52be3dfd5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2602948 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
JavaScript scopes are reported from inner-most to outer-most, while previously we would report WebAssembly frames from outer-most to inner-most. This is quite confusing for developers, and also doesn't really make sense, so this CL fixes this inconsistency. Bug: chromium:1071432 Change-Id: I6a4742f13b9a0df33e50c6fcd40992873996aaf5 Fixed: chromium:1159309 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2602947 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
LiuYu authored
CallRecordWriteStub Port: 6b3994e8 Bug: chromium:1146813 Change-Id: I552f49193188d91d64a1d75307cd3390138c9e7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599426Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#71874}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d4fcf57..2d94fa5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2752abe..3f5c581 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic1879d10e5d79bbc8bafa07603679cde9be6c327 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2600522Reviewed-by:
-
- 23 Dec, 2020 7 commits
-
-
Milad Fa authored
Instructions include: vupkhsw vupklsh vupkhsh vupklsb vupkhsb Change-Id: Ie11961dbf1f4838e96efe6704c8d938a62213b93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601660Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#71872}
-
LiuYu authored
Port: bee5992a Bug: v8:7748 Change-Id: I5985eaf9cfaf3786e19ac6d1678630828e4c77be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599397Reviewed-by:
-
LiuYu authored
Port: 1215f2a8 Bug: v8:11262 Change-Id: I307619aaea7adda16d52155255830e6d4cefcd1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2600836Reviewed-by:
-
Andrey Kosyakov authored
This adds ExecutionContextDescription.uniqueId for a system-unique way to identify an execution context and supports it in Runtime.evaluate. This allows a client to avoid accidentally executing an expression in a context different from that originally intended if a navigation occurs while Runtime.evaluate is in flight. Design doc: https://docs.google.com/document/d/1vGVWvKP9FTTX6kimcUJR_PAfVgDeIzXXITFpl0SyghQ Bug: v8:11268, chromium:1101897 Change-Id: I4c6bec562ffc85312559316f639d641780144039 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2594538 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Zhi An Ng authored
Bug: v8:11262 Change-Id: I746e1bf819d69a010efee2ec907a49dbc05dda64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599845Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71868}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3e20802..d4fcf57 Rolling v8/third_party/aemu-linux-x64: GI8QGXYA44_uicQ1AX9ecXBzIK4dImUA90X-kMlohyIC..eNKL3iFnDydKoCyqA9rVhylE7ud5a_9wRt0b0HFtLvIC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8d43e58..2752abe TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6a54d437519d43d8a874bfaadb43cb955d38440f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2601509Reviewed-by:
-
Zhi An Ng authored
Detect AVX2 support and use vpbroadcastb or vpbroadcastw. No new assembler helpers required because we are only emitting the VEX-128 versions of these instructions. Bug: v8:11258 Change-Id: Ic50178daa6fc8fe767dfc788e61e67538066bdea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596582 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 22 Dec, 2020 8 commits
-
-
Milad Fa authored
Change-Id: I4e70f176fa08c9a6b6f40683248d4c32c8e16f59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2598588Reviewed-by:
-
Andrey Kosyakov authored
This lets embedder to produce an id with sufficient entropy to facilitate an id appropriate for a multi-process system and immune to regular RNG seed being overriden, while maintaining deterministic id allocation for tests. Design doc: https://docs.google.com/document/d/1vGVWvKP9FTTX6kimcUJR_PAfVgDeIzXXITFpl0SyghQ Related blink-side change: https://chromium-review.googlesource.com/c/chromium/src/+/2600273 Bug: v8:11268 Change-Id: I1a4d12463cf56d4378859dfa3ee4d717e176d468 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2600442Reviewed-by:
-
Milad Fa authored
Port 1215f2a8 Original Commit Message: The codegen is the same as on TurboFan, using Smull, Umull, Smull2, and Umull2. The rest of the changes are adding skeleton functions to the different archs, which bailout for now. Actual codegen will come in future patches. R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I58bc84ede44a9c90e315d6dc3346ea09b31deaf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2600731Reviewed-by:
-
Zhi An Ng authored
Change-Id: I6ae8699032efc4e55f3e6f808620591c4ad8fc3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599841Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#71862}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/34da458..3e20802 Rolling v8/third_party/aemu-linux-x64: qMq36BPvKEIxjpVFBefO08HoyM51jARe3EuX0vcgzWsC..GI8QGXYA44_uicQ1AX9ecXBzIK4dImUA90X-kMlohyIC Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d324a17..1283870 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ief40dcfffd3dee29abd267149af5a9e57907675f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2600368Reviewed-by:
-
Zhi An Ng authored
When a 8x16 shuffle matches a 32x4 shuffle (every group of 4 indices are consecutive), and the first 2 indices are in the range [0-3], and the other 2 indices are in the range [4-7], then we can match it to a shufps. E.g. [0,2,4,6], [1,3,5,7]. These shuffles are commonly used to extract odd/even floats. Change-Id: I031fe44f71a13bbc72115c22b02a5eaaf29d3794 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596579 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Zhi An Ng authored
The codegen is the same as on TurboFan, using Smull, Umull, Smull2, and Umull2. The rest of the changes are adding skeleton functions to the different archs, which bailout for now. Actual codegen will come in future patches. Bug: v8:11262 Change-Id: I06f0b018b85b5cca29382ab730510959e1a81ab6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2589064Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Andrew Comminos authored
As a first step towards freeing CodeEntry objects that are neither still referenced by JS or stored in a profile, enable freeing of refcounted strings by CodeEntry instances. For now, this leaves behaviour unchanged until we receive CodeEntry destruction events. Bug: v8:11054 Change-Id: Iabd05aa730343cd1a879ff5b04326f23e68aa948 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2590604 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#71858}
-
