- 28 Nov, 2016 31 commits
-
-
rodolph.perfetta authored
BUG= Review-Url: https://codereview.chromium.org/2537453003 Cr-Commit-Position: refs/heads/master@{#41325}
-
rmcilroy authored
Revert of [turbofan] Utilize String comparison feedback. (patchset #1 id:1 of https://codereview.chromium.org/2523463002/ ) Reason for revert: Seems to regress speedometer on Ignition and doesn't cause any improvements elsewhere. BUG=chromium:668651 Original issue's description: > [turbofan] Utilize String comparison feedback. > > Make use of the previously introduced String feedback for compare > operations in TurboFan. > > R=jarin@chromium.org > BUG=v8:5267,v8:5400 > > Committed: https://crrev.com/5d4253ecfb6ddcbbd7eb5654e728efa9559284a2 > Cr-Commit-Position: refs/heads/master@{#41163} TBR=jarin@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5267,v8:5400 Review-Url: https://codereview.chromium.org/2531183003 Cr-Commit-Position: refs/heads/master@{#41324}
-
mstarzinger authored
This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org Committed: https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70 Review-Url: https://codereview.chromium.org/2529343003 Cr-Original-Commit-Position: refs/heads/master@{#41318} Cr-Commit-Position: refs/heads/master@{#41323}
-
zhengxing.li authored
The reason: The CL #41255 (https://codereview.chromium.org/2520363002 ) reimplemnt the Number.prototype.toString and the added number-tostring test cases failed at x87. Similar to many previos fixing CLs, i.e.: CL #37371 (https://codereview.chromium.org/2111493002 ), the root reason is: The Gcc compiler and it's dependent C++ libraris on linux platform use x87 in extended 80-bit double precision by default. So the reimplemented DoubleToRadixCString() will generate extended 80-bit double precision result which isn't the expected standard 64-bit double precision value. Although modifying DoubleToRadixCString() function to manually do the 80-bit <--> 64-bit conversion for each double/float computation step can fix this issue, but it wll drop the DoubleToRadixCString() function's performance of other architectures. This CL put the failed number-tostring test cases into number-tostring-big-integer.js and disables it for x87. BUG= Review-Url: https://codereview.chromium.org/2532073002 Cr-Commit-Position: refs/heads/master@{#41322}
-
tebbi authored
Removed a redundant check: If completion is not normal, then #iterator cannot be undefined. Review-Url: https://codereview.chromium.org/2533803002 Cr-Commit-Position: refs/heads/master@{#41321}
-
vogelheim authored
BUG=chromium:663410 Review-Url: https://codereview.chromium.org/2533463002 Cr-Commit-Position: refs/heads/master@{#41320}
-
mstarzinger authored
Revert of [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. (patchset #2 id:20001 of https://codereview.chromium.org/2529343003/ ) Reason for revert: Seems to break TSAN builds. https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/12897/steps/Check/logs/stack-traces Original issue's description: > [deoptimizer] Remove dead Code::LookupRangeInHandlerTable. > > This removes the supporting function to perform a range-lookup in the > exception handler table for unoptimized code. Such tables are by now > guaranteed to be empty, the deoptimizer cannot encounter this case. > > R=jarin@chromium.org > > Committed: https://crrev.com/1f27ed9d7da78904e0418364c6394f913eabbe70 > Cr-Commit-Position: refs/heads/master@{#41318} TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2536673002 Cr-Commit-Position: refs/heads/master@{#41319}
-
mstarzinger authored
This removes the supporting function to perform a range-lookup in the exception handler table for unoptimized code. Such tables are by now guaranteed to be empty, the deoptimizer cannot encounter this case. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2529343003 Cr-Commit-Position: refs/heads/master@{#41318}
-
jgruber authored
BUG=v8:5339 NOTRY=true Review-Url: https://codereview.chromium.org/2532013003 Cr-Commit-Position: refs/heads/master@{#41317}
-
clemensh authored
Before, the encoded variant was stored in the compiled module, and the decoded one in the debug info (per instance). The decoded table was a FixedArray of ByteArrays. Now, also the decoded table is a flat ByteArray, and it encodes whether it is encoded or decoded. This saves memory and allows to store encoded and decoded variant in the same field. The table is automatically decoded on the first use. This CL also removes some unused and unimplemented methods from WasmDebugInfo (probably merge artifacts). That class is now pretty much empty, but we might still need it for breakpoint support. R=titzer@chromium.org, ahaas@chromium.org Review-Url: https://codereview.chromium.org/2522953002 Cr-Commit-Position: refs/heads/master@{#41316}
-
jkummerow authored
Introducing a TF_BUILTIN macro that wraps CodeStubAssembler usage into a convenient interface (using a subclass under the hood). No changes since previous attempt; this was only reverted because it blocked another revert. Original review: https://codereview.chromium.org/2517833005/ TBR=ishell@chromium.org Review-Url: https://codereview.chromium.org/2529373002 Cr-Commit-Position: refs/heads/master@{#41315}
-
jarin authored
BUG=chromium:668760 Review-Url: https://codereview.chromium.org/2530403002 Cr-Commit-Position: refs/heads/master@{#41314}
-
petermarshall authored
All super constructor calls go through the ignition + turbofan pipeline, so this is dead code. BUG=v8:5657 Review-Url: https://codereview.chromium.org/2525233003 Cr-Commit-Position: refs/heads/master@{#41313}
-
yangguo authored
BUG=v8:5510 R=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2535733002 Cr-Commit-Position: refs/heads/master@{#41312}
-
yangguo authored
BUG=v8:5510 R=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2536573002 Cr-Commit-Position: refs/heads/master@{#41311}
-
Jochen Eisinger authored
R=verwaest@chromium.org TBR=marja@chromium.org, verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/2531233002 . Cr-Commit-Position: refs/heads/master@{#41310}
-
jochen authored
They're supposed to be stable across several parse passes, so we'll also store them in the associated SharedFunctionInfos To achieve this, the PreParser and Parser need to generated the same number of FunctionLiterals. To achieve this, we teach the PreParser about desuggaring of class literals. For regular functions, the function IDs are assigned in the order they occur in the source. For arrow functions, however, we only know that it's an arrow function after parsing the parameter list, and so the ID assigned to the arrow function is larger than the IDs assigned to functions defined in the parameter list. This implies that we have to reset the function ID counter to before the parameter list when re-parsing an arrow function. To be able to do this, we store the number of function literals found in the parameter list of arrow functions as well. BUG=v8:5589 Review-Url: https://codereview.chromium.org/2481163002 Cr-Commit-Position: refs/heads/master@{#41309}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5510 Review-Url: https://codereview.chromium.org/2532893002 Cr-Commit-Position: refs/heads/master@{#41308}
-
marja authored
ThreadedList is more memory-efficient than ZoneList. This also enables us to use ThreadedList when making Preparser track parameters (upcoming work). BUG=v8:5501 Review-Url: https://codereview.chromium.org/2531593002 Cr-Commit-Position: refs/heads/master@{#41307}
-
jkummerow authored
Reducing visual clutter. No changes since previous attempt; this was only reverted because it blocked another revert. Original review: https://codereview.chromium.org/2519093002/ TBR=ishell@chromium.org Review-Url: https://codereview.chromium.org/2532063002 Cr-Commit-Position: refs/heads/master@{#41306}
-
cbruni authored
R=machenbach@chromium.org BUG=v8:5677 NOTRY=true Review-Url: https://codereview.chromium.org/2528363002 Cr-Commit-Position: refs/heads/master@{#41305}
-
machenbach authored
BUG=v8:5435 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe Review-Url: https://codereview.chromium.org/2373783002 Cr-Commit-Position: refs/heads/master@{#41304}
-
rmcilroy authored
The BytecodeGraphBuilder assumes that deoptimization is always enabled, so always enable it when compiling from bytecode. BUG=chromium:668654 Review-Url: https://codereview.chromium.org/2531683004 Cr-Commit-Position: refs/heads/master@{#41303}
-
ahaas authored
Up until now assertThrows allows to check the type field of an exception, which is, however, a custom field introduced in a single regression test. With the change assertThrows allows to check the message field of an exception, which is set for standard V8 exceptions by default. I use the new assertThrows to refactor test/mjsunit/wasm/divrem-trap.js R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2525313003 Cr-Commit-Position: refs/heads/master@{#41302}
-
cbruni authored
A missing @@IsConcatSpreadable check caused the fast path inside the slow path to be incorrect and follow the default concat strategy when the arguments arrays contain only doubles. BUG=chromium:668414 Review-Url: https://codereview.chromium.org/2527173002 Cr-Commit-Position: refs/heads/master@{#41301}
-
jochen authored
R=yangguo@chromium.org,machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2529333002 Cr-Commit-Position: refs/heads/master@{#41300}
-
jgruber authored
AsyncTaskEvents are not exposed through the inspector interface. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2532693002 Cr-Commit-Position: refs/heads/master@{#41299}
-
bmeurer authored
This code is no longer used by full-codegen since all functions which use new.target, rest parameters or the internal this function binding now grow through Ignition first, and never tier up to fullcodegen. BUG=v8:5657 R=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2528293002 Cr-Commit-Position: refs/heads/master@{#41298}
-
machenbach authored
BUG=v8:5603 NOTRY=true Review-Url: https://codereview.chromium.org/2534813002 Cr-Commit-Position: refs/heads/master@{#41297}
-
machenbach authored
BUG=chromium:668958 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2531183002 Cr-Commit-Position: refs/heads/master@{#41296}
-
bmeurer authored
For a couple of those Array builtins we can specify a useful type that will help us to eliminate a couple of checks on their outputs. R=yangguo@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2529233002 Cr-Commit-Position: refs/heads/master@{#41295}
-
- 27 Nov, 2016 1 commit
-
-
bmeurer authored
Assign types to the remaining builtins on the String.prototype where we know a meaningful type, i.e. where the type is not dependent on some callable function that is pass or loaded. BUG=v8:5267 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2532463002 Cr-Commit-Position: refs/heads/master@{#41294}
-
- 26 Nov, 2016 1 commit
-
-
rmcilroy authored
If code has AsmWasm data we shouldn't try to optimize the JS as well, since it will instead be optimized using the WASM data. BUG= Review-Url: https://codereview.chromium.org/2534463003 Cr-Commit-Position: refs/heads/master@{#41293}
-
- 25 Nov, 2016 7 commits
-
-
ziyang authored
Since the page size of PPC 64 bit machines is 64K, memory smaller than 64K cannot be freed causing the committed memory of code space to be exactly 2M. Changing the test case to accomodate this. R=mlippautz@chromium.org, ulan@chromium.org, vogelheim@chromium.org BUG= Review-Url: https://codereview.chromium.org/2523293002 Cr-Commit-Position: refs/heads/master@{#41292}
-
bbudge authored
- Adds vmov, vswp instructions for QwNeonRegisters. - Refactors existing vswp implementation, moves non-Neon adaption to MacroAssembler. - Adds simd128 support to CodeGenerator AssembleMove, AssembleSwap. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2523933002 Cr-Commit-Position: refs/heads/master@{#41291}
-
hpayer authored
Review-Url: https://codereview.chromium.org/2531873003 Cr-Commit-Position: refs/heads/master@{#41290}
-
mlippautz authored
BUG= Review-Url: https://codereview.chromium.org/2529113002 Cr-Commit-Position: refs/heads/master@{#41289}
-
mlippautz authored
Trivial parts of the reverted CL: https://codereview.chromium.org/2516303006/ BUG= Review-Url: https://codereview.chromium.org/2531093002 Cr-Commit-Position: refs/heads/master@{#41288}
-
hpayer authored
Review-Url: https://codereview.chromium.org/2531073002 Cr-Commit-Position: refs/heads/master@{#41287}
-
yangguo authored
TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2533583002 Cr-Commit-Position: refs/heads/master@{#41286}
-