- 10 Aug, 2020 1 commit
-
-
Marja Hölttä authored
Bug: chromium:1105318 Change-Id: I105fc4cfc1b781dc0a481c7bee9faee1923f474f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2343071 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#69299}
-
- 07 Aug, 2020 1 commit
-
-
Zeynep Cankara authored
This CL unifies the custom events by creating classes specialised based on the event type. Multiple entry selection causes panels to emit 'showentries' event. Single entry selection causes panels to emit 'showentrydetail' event. The events are received by the controller App class and updates the view of the panels and state of the app. Bug: v8:10644 Change-Id: Ibe26223459ba605c6d6d3f0025bf3a556dfb0578 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335188 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69286}
-
- 06 Aug, 2020 3 commits
-
-
Leszek Swirski authored
Changes the isolate's string table into an off-heap structure. This allows the string table to be resized without allocating on the V8 heap, and potentially triggering a GC. This allows existing strings to be inserted into the string table without requiring allocation. This has two important benefits: 1) It allows the deserializer to insert strings directly into the string table, rather than having to defer string insertion until deserialization completes. 2) It simplifies the concurrent string table lookup to allow resizing the table inside the write lock, therefore eliminating the race where two concurrent lookups could both resize the table. The off-heap string table has the following properties: 1) The general hashmap behaviour matches the HashTable, i.e. open addressing, power-of-two sized, quadratic probing. This could, of course, now be changed. 2) The empty and deleted sentinels are changed to Smi 0 and 1, respectively, to make those comparisons a bit cheaper and not require roots access. 3) When the HashTable is resized, the old elements array is kept alive in a linked list of previous arrays, so that concurrent lookups don't lose the data they're accessing. This linked list is cleared by the GC, as then we know that all threads are in a safepoint. 4) The GC treats the hash table entries as weak roots, and only walks them for non-live reference clearing and for evacuation. 5) Since there is no longer a FixedArray to serialize for the startup snapshot, there is now a custom serialization of the string table, and the string table root is considered unserializable during weak root iteration. As a bonus, the custom serialization is more efficient, as it skips non-string entries. As a drive-by, rename LookupStringExists_NoAllocate to TryStringToIndexOrLookupExisting, to make it clearer that it returns a non-string for the case when the string is an array index. As another drive-by, extract StringSet into a separate header. Bug: v8:10729 Change-Id: I9c990fb2d74d1fe222920408670974a70e969bca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339104 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#69270}
-
Zeynep Cankara authored
This CL sync the timeline-tracks positions upon receiving a horizontal scrolling event. Bug: v8:10644 Change-Id: I69bc1066a3f5da6ddc978ad71fe77820df8066bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2336806 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69263}
-
Michael Achenbach authored
This reverts commit 3927c9c4. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20NumFuzz%20-%20debug/10732 Original change's description: > Override _runner_flags for num_fuzzer.py > > This CL ensures that we add the > '--fuzzing' flag to the num_fuzzer script. > Please note that NumFuzzer does not inherit the > StandardTestRunner class but it inherits > BaseTestRunner so we had to override _runner_flags. > > Bug: v8:10755 > Change-Id: Ifb779ba402106b8f2ce4d0e13090ef2db468a6ae > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335185 > Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69241} TBR=machenbach@chromium.org,liviurau@chromium.org,almuthanna@chromium.org Change-Id: Ie39fb87a0e53c5cbbc276f8efb6e4a89ce44bb74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10755 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2340902Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#69255}
-
- 05 Aug, 2020 3 commits
-
-
Zeynep Cankara authored
This CL aligns the timeline tracks by tracking the global start and end timestamps of both Map and IC events. Bug: v8:10644, v8:10735 Change-Id: Ib0ad086cdcb8ae3ae734df6480c5567f1f5125c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335183Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69242}
-
Almothana Athamneh authored
This CL ensures that we add the '--fuzzing' flag to the num_fuzzer script. Please note that NumFuzzer does not inherit the StandardTestRunner class but it inherits BaseTestRunner so we had to override _runner_flags. Bug: v8:10755 Change-Id: Ifb779ba402106b8f2ce4d0e13090ef2db468a6ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335185 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#69241}
-
Zeynep Cankara authored
This CL initialises the change theme button in correct place and adds the functionality to change theme after the data load. Bug: v8:10644 Change-Id: I7397933ff9d12a2ac270d025df1b3327801d89be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2336800Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69238}
-
- 04 Aug, 2020 2 commits
-
-
Zeynep Cankara authored
Add functionality to emit an event upon double clicking on an event type on the timeline track selected entries panel. Bug: v8:10644 Change-Id: I54d4397abfeab471f01c2b24bae4eb1ff705afcd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2328787Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69222}
-
Zeynep Cankara authored
This CL aims to clean the code in App Class to handle State, View according to the Model-View-Controller design pattern. Bug: v8:10644, v8:10735 Link: https://docs.google.com/presentation/d/1ssCIWKS5TIp_PHZRUx2BfElEz6JFrYzz_Ce1h1g8ZBg/edit?usp=sharing Change-Id: Ie36d437df0df574f505a4396b26526a82215f237 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2324247 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69218}
-
- 03 Aug, 2020 2 commits
-
-
Dirk Pranke authored
I tripped over this str/bytes issue as part of bringing up the Chromium build under Python3. Bug: chromium:1112471 Change-Id: I723c7d9df8bcac24c160c549a03dcbd34c1d92f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2334222 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69210}
-
Jakob Kummerow authored
This is a stop-gap solution (while we wait for a proper spec) that lets managed WasmGC objects perform round-trips through JavaScript. On the JavaScript side, they appear as empty/opaque. Bug: v8:7748 Change-Id: I0dd368bc14d622f3ef41871484228267359e9b5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316306 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#69207}
-
- 31 Jul, 2020 1 commit
-
-
Michael Achenbach authored
This is a JavaScript fuzzer originally authored by Oliver Chang. It is a mutation based fuzzer using Babel code transformations. For more information see the included README.md. The original code was altered: - Add new V8 copyright headers. - Make the test expectation generator aware of the headers. - Fix file endings for presubmit checks. - Fix `npm test` on fresh checkout with a new fake DB. - Make test skipping work with new v8/tools location. - OWNERS file. - New title section in README.md. No-Try: true Bug: chromium:1109770 Change-Id: Ie71752c0a37491a50500c49060a3c526716ef933 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320330 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#69164}
-
- 30 Jul, 2020 4 commits
-
-
Frank Tang authored
This is a reland of 482c3bbf Original change's description: > [Intl] Sync Intl.Segmenter to latest version > > https://tc39.es/proposal-intl-segmenter/ > > TC39 passed Intl.Segmenter to stage 3 in Jul 21. > This CL move our earlier prototype to the current spec. > > Bug: v8:6891 > Change-Id: I07234beed54f671c26bdbfb3983c5bc2fa5a29b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219413 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Frank Tang <ftang@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69080} Bug: v8:6891 Change-Id: Ie3a02d8ddf6f95f0632f97b38b613b185abeb592 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2321118Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69153}
-
Liviu Rau authored
This reverts commit 5ee39a50. Reason for revert: To trigger builders again Original change's description: > Whitespace to trigger builders > > TBR: clemensb@chromium.org > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: Id8dba0dad4b7bfd68ed7c0300ddfeac2b9c349b2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330012 > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Commit-Queue: Liviu Rau <liviurau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69146} TBR=clemensb@chromium.org,liviurau@chromium.org Change-Id: Iff68a4ab57a30bdc594a49f3ff0cff43740b6634 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330015Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#69147}
-
Liviu Rau authored
TBR: clemensb@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Id8dba0dad4b7bfd68ed7c0300ddfeac2b9c349b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2330012Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#69146}
-
Gus Caplan authored
Bug: v8:9891 Change-Id: Ief289a9990ac545aa479f564094e3bbde4144aae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2293709 Commit-Queue: Gus Caplan <snek@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#69145}
-
- 29 Jul, 2020 2 commits
-
-
Zeynep Cankara authored
This CL aims to clean dead code across the app and use private class fields for storing private information. Bug: v8:10644, v8:10735 Change-Id: I1129104925f230bed922cc76abdb432d536d2111 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2323352Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69125}
-
Anton Bikineev authored
The CL add two files: 1) copy.bara.sky - source file for copybara that needs to migrate cppgc from v8 repo to GitHub; 2) export_to_github.sh - top level bash script that runs copybara and generates CMake files if needed. Bug: v8:10724 Change-Id: I6a5f0ed1d007533914d578203a37fab2c3e9774a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320651Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#69123}
-
- 28 Jul, 2020 6 commits
-
-
Jakob Kummerow authored
This adds two convenience scripts: - update-vscode.sh downloads/updates Visual Studio Code - update-compile-commands.py prepares for code indexers like clangd by creating compile_commands.json (for all architectures), updating generated sources, and compiling the Torque Language Server. No-try: true Change-Id: I64a15dc298f4312a9b296762593234c40f542b06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317355 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69105}
-
Igor Sheludko authored
Also use outer-function name as a ZONE_NAME instead of file:line and give explicit names to parser and preparser zones. Bug: v8:10572 Change-Id: I9b5acb23322889d8538a34bc888fd6f610eb6893 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2322627 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#69104}
-
Zeynep Cankara authored
This CL creates a timeline track component to make the timeline view extensible as different data sources added. The timeline track component will take data source and display it with respect to time axis of timeline overview. Bug: v8:10644, v8:10735 Change-Id: I1c88dd2dc967be68e6235e517dcf8554a891eee4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2302053 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69102}
-
Anton Bikineev authored
Bug: v8:10724 Change-Id: Ia0b6d6d25e6b9d7b44b4dfa94705e9cd5103cc8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316303Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#69094}
-
Zeynep Cankara authored
This CL use the introduce color variables to adapt light theme feature to increase accessibility. Bug: v8:10644 Change-Id: I179831aef384527b0457c6ae93fa4d42a1814834 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305891 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69093}
-
Clemens Backes authored
This follows https://crrev.com/c/2317298. TBR=machenbach@chromium.org No-Try: true Change-Id: I26608a7234145ac1f6cd234024054fc372946d3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320652 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#69087}
-
- 27 Jul, 2020 4 commits
-
-
Michael Achenbach authored
Updating was prepared on depot_tools side by https://crbug.com/1098560. No-Try: true Bug: v8:10619 Change-Id: If24aec3344e83857c09ce165be4203846b3a91b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316302Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#69083}
-
Shu-yu Guo authored
This reverts commit 482c3bbf. Reason for revert: Test failure https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/29160? Original change's description: > [Intl] Sync Intl.Segmenter to latest version > > https://tc39.es/proposal-intl-segmenter/ > > TC39 passed Intl.Segmenter to stage 3 in Jul 21. > This CL move our earlier prototype to the current spec. > > Bug: v8:6891 > Change-Id: I07234beed54f671c26bdbfb3983c5bc2fa5a29b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219413 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Frank Tang <ftang@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69080} TBR=jkummerow@chromium.org,tebbi@chromium.org,ftang@chromium.org,syg@chromium.org Change-Id: I1488d5fd50012c5e8873a4fed2fa7638d86d5c6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6891 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320741Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#69081}
-
Frank Tang authored
https://tc39.es/proposal-intl-segmenter/ TC39 passed Intl.Segmenter to stage 3 in Jul 21. This CL move our earlier prototype to the current spec. Bug: v8:6891 Change-Id: I07234beed54f671c26bdbfb3983c5bc2fa5a29b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219413Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69080}
-
Zeynep Cankara authored
This CL adds a generic Event Class to unify common methods of IC and Map events. The Entry Class for IC Events and V8Map Class for Map Events inherits from this generic Event Class. Bug: v8:10644, v8:10735 Change-Id: I77d68fb40ee0ffbe297fcd1a13c3e2b746938168 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317309 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69066}
-
- 24 Jul, 2020 3 commits
-
-
Zeynep Cankara authored
This CL adds a Timeline Class to handle data interaction between panels. The timeline class enables to filter the data based on selected time range. Bug: v8:10644, v8:10735 Change-Id: I7fbbe1741abc69d2889b0547113e5da10b7f5510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315983 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69056}
-
Jakob Kummerow authored
Now the following command builds mkgrokdump for x64.release and runs it to update v8heapconst.py: gm.py mkgrokdump Building the binary for other architectures still works as before. No-Try: true Change-Id: Iacfa1a50702b0452d00ba18e1306423b161ffe65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317352 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#69054}
-
Zeynep Cankara authored
This CL adds a link to v8.dev/tools to direct to all available versions of the tool. Also fixes margin in between text and card div. Bug: v8:10664 Change-Id: I8c0b137ffbdd88c4a41fd1ab8038985595056ada Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315988Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Zeynep Cankara <zcankara@google.com> Cr-Commit-Position: refs/heads/master@{#69031}
-
- 23 Jul, 2020 3 commits
-
-
Anton Bikineev authored
The parser is capable of processing full GN grammar. The generator uses the visitor and the builder patterns. The visitor handles call expressions (e.g. target declarations), GN expressions (e.g. is_clang && !is_win), conditional and assignment statements. Builder is used to generate a particular output. For example, this CL brings in CMakeBuilder for cmake generation, but same infrastructure can be reused for generation of amalgamated sources. Things that are not yet automatically generated: 1) Automatic generation of config variables (from declare_args). 2) Dependency scanning. Since we only have limited number of targets, this is not a big issue at the moment. Followup CLs will include: - test targets; - sample targets. Bug: v8:10724 Change-Id: I0b31910aca67f0e02ab142b2d35f4338345e7f29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2306790 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#69017}
-
Zeynep Cankara authored
This CL enables the hide panel functionality upon uploading a new file. File reader emits fileuploadstart event when it receives a new file which hides the panels. Bug: v8:10644 Change-Id: Ic26cce1a92559efd494f2ef1e32b514897a73324 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305892 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69015}
-
Zeynep Cankara authored
This CL decouples the timeline panel view handling from map panel view handling. Having separate panel view handling for each panel aims to encapsulate panel behaviours force panels to emit events rather than depending on other panels. Bug: v8:10644, v8:10735 Change-Id: Icd6e8ee8a0e8d1fdbbaaf2754f272300e0499bf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305894 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69014}
-
- 22 Jul, 2020 5 commits
-
-
Michael Achenbach authored
This summarizes more dupes of https://crbug.com/1042556 TBR=mslekova@chromium.org No-Try: true Bug: chromium:1108048,chromium:1108322 Change-Id: If572b5eeeac9c2750eb1a630dd76490529e60d4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2314476Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#69011}
-
Zeynep Cankara authored
This CL redesigns the IC Panel to emit events upon time range selection. IC entry time range specified from the input fields and entries falling into the selected time range bubbled up to the App controller. The IC panel emits events upon selection of a map or a source file location. Bug: v8:10644 Change-Id: I468dc52b7a6c62dbdee096e80cc6110ceb994f69 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305893 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69006}
-
Zeynep Cankara authored
This CL encapsulates map panel behaviour with custom web components map-details for displaying information and map-transitions to show map transition tree. The web components emit/receive events to interact with the app. Bug: v8:10644 Change-Id: Ic61c2794ed7ab854ee61fa1e7c8fe9b1c3c31b7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305889 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69004}
-
Maya Lekova authored
This reverts commit d8f8a7e2. Reason for revert: Breaks code_serializer variant - https://cr-buildbucket.appspot.com/build/8874070652992164976 Original change's description: > Reland "[flags] warn about contradictory flags" > > This is a reland of b8f91666 > Difference to previous CL: Additional functionality to specify > incompatible flags based on GN variables and extra-flags, used > to fix the issues that came up on the waterfall. > > This also changes the rules regarding repeated flags: While > explicitly repeated flags are allowed for boolean values as long > as they are identical, repeated flags or explicit flags in the > presence of an active implication are disallowed for non-boolean > flags. The latter simplifies specifying conflict rules in > variants.py. Otherwise a rule like > > INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = { > "--gc-interval=*": ["--gc-interval=*"], > } > > wouldn't work because specifying the same GC interval twice > wouldn't actually count as a conflict. This was an issue with > test/mjsunit/wasm/gc-buffer.js, which specifies > --gc-interval=500 exactly like the extra flag by the stress bot. > > Also, this now expands contradictory flags checking to d8 flags > for consistency. > > Original change's description: > > [flags] warn about contradictory flags > > > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/ > > > > Bug: v8:10577 > > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792 > > Reviewed-by: Clemens Backes <clemensb@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Reviewed-by: Georg Neis <neis@chromium.org> > > Reviewed-by: Tamer Tas <tmrts@chromium.org> > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#68168} > > Bug: v8:10577 > Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68989} TBR=machenbach@chromium.org,neis@chromium.org,clemensb@chromium.org,tebbi@chromium.org,tmrts@chromium.org Change-Id: I7969065b0edbc463a94e530485bc2ab623d77b62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10577 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2312782Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#68992}
-
Tobias Tebbi authored
This is a reland of b8f91666 Difference to previous CL: Additional functionality to specify incompatible flags based on GN variables and extra-flags, used to fix the issues that came up on the waterfall. This also changes the rules regarding repeated flags: While explicitly repeated flags are allowed for boolean values as long as they are identical, repeated flags or explicit flags in the presence of an active implication are disallowed for non-boolean flags. The latter simplifies specifying conflict rules in variants.py. Otherwise a rule like INCOMPATIBLE_FLAGS_PER_EXTRA_FLAG = { "--gc-interval=*": ["--gc-interval=*"], } wouldn't work because specifying the same GC interval twice wouldn't actually count as a conflict. This was an issue with test/mjsunit/wasm/gc-buffer.js, which specifies --gc-interval=500 exactly like the extra flag by the stress bot. Also, this now expands contradictory flags checking to d8 flags for consistency. Original change's description: > [flags] warn about contradictory flags > > Design Doc: https://docs.google.com/document/d/1lkvu8crkK7Ei39qjkPCFijpNyxWXsOktG9GB-7K34jM/ > > Bug: v8:10577 > Change-Id: Ib9cfdffa401c48c895bf31caed5ee03545beddab > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2154792 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68168} Bug: v8:10577 Change-Id: I268e590ee18a535b13dee14eeb15ddd0a9ee8341 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235115 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68989}
-