- 31 May, 2022 13 commits
-
-
Dominik Inführ authored
WorkerThreads access the queue to get new tasks, that's why all of them need to stop before we can destroy the queue. This hopefully fixes the linked race/crash since I can't reproduce this locally. Bug: v8:12914 Change-Id: Icbfd462f106a4a1f0bbd525f0b7f342e9857a539 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672421Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80841}
-
Darius M authored
This is a reland of commit ab76ffc8. Original change's description: > [builtins] use SIMD IndexOf/includes on large arrays > > Change-Id: If751e813c7f45a4d18b84e8c0314a54c84894d61 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3639203 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Darius Mercadier <dmercadier@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80771} Change-Id: I81dcf3c97a15b95fd42927ff8e91602f109db315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3672418Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80840}
-
Dominik Inführ authored
Replace all usages of UPDATE_WEAK_WRITE_BARRIER with UPDATE_WRITE_BARRIER. The barrier wasn't hot, so the additional branch for the marking barrier shouldn't be a problem. Performing the marking barrier could in theory cause more floating garbage. However in this case the write barrier is only run once directly after e.g. allocating a Code or NativeContext object. Since UPDATE_WEAK_WRITE_BARRIER only skips the marking barrier, we should only observe different behavior when marking is on. But since we already have black allocation for objects in old space, we will not cause additional floating garbage. In case of performance regression, we should also be able to replace those usages with SKIP_WRITE_BARRIER, since NativeContext and Code objects are never allocated in the young generation, so running the generational barrier shouldn't be necessary. It's just hard to DCHECK that SKIP_WRITE_BARRIER is valid here. Bug: v8:11708 Change-Id: I25d760a46d1d7ec973cc589f51ddf80ca3b5419d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663080Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I0196169d5bfe80df23179414f37c418db775cefb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663341 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80838}
-
Leszek Swirski authored
Print polymorphic feedback, and include instance type in printed maps. Change-Id: I34b71fbd5c94a1b615b17646dcd7a729a4ff4eac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677299Reviewed-by:
-
jameslahm authored
... disasm-loong64-unittest. Bug: v8:12781 Change-Id: I81b5ff789d8e5d7eb0ce8e4c6fa1531f52199918 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676638Reviewed-by:
-
jameslahm authored
... disasm-pcc-unittest. Bug: v8:12781 Change-Id: I239c5101a0b978b0b824bac8e31a6e62b3e7e836 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676639Reviewed-by:
-
jameslahm authored
... disasm-mips64-unittest. Bug: v8:12781 Change-Id: I5c4e2b95d4d30962c671c1f2a625f6e97fecad15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676640 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
jameslahm authored
... disasm-riscv64-unittest. Bug: v8:12781 Change-Id: I0d4c0ffbda5757db6a6b906e9f51ce28bc5f6f11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676641 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
jameslahm authored
... disasm-arm-unittest. Bug: v8:12781 Change-Id: Ice4bafdf89e2eb9ddbef7b613eef1e6ceb56133b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676637Reviewed-by:
-
jameslahm authored
... diy-fp-unittest. Bug: v8:12781 Change-Id: I7cb996c095ec0c946ed2db311dfd815e1cbd459b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676643Reviewed-by:
-
jameslahm authored
... decls-unittest. Bug: v8:12781 Change-Id: I0c2915bade2b5a6f6eeeba3db81542d3220bcd66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676644 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
jameslahm authored
... disasm-s390-unittest. Bug: v8:12781 Change-Id: I52155e0f6667202ce2f3c7bd59cb0031694edbc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676642 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
- 30 May, 2022 27 commits
-
-
Junliang Yan authored
Change-Id: I3bf465381df92dc2ec3181f1082463a2d7903854 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677332Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80828}
-
Clark DuVall authored
Bug: chromium:1328448 Change-Id: If0c3d02070071b5bb25df5bca51cf8c4cfc424d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673420Reviewed-by:
-
Pan, Tao authored
If the optimized code is deoptimized and the deoptimized exit offset is inside of the optimized OSR code related loop, the optimized OSR code is also out of date, remove the optimized OSR code, it will avoid hit the optimized OSR code and soon later deoptimization of the optimized OSR code. This CL will reduce deoptimization. E.g. Deoptimization of JetStream2 case navier-stokes function addFields is reduced from twice to once. Change-Id: I5bbf3039e916c3736b5b967d1f36b6ea90cfd40b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3648219Reviewed-by:
-
Seth Brenith authored
This is a reland of commit c8848cf4 This change was reverted due to a problem in a preceding change. This relanded version differs in its implementations of the CompilationCacheScript member functions Lookup, Put, and Age, because the intent is to not change any behavior. Original change's description: > CompilationSubCache has some complexity regarding generations of tables > which is only used by one subclass, CompilationCacheRegExp. This change > adjusts the class hierarchy so that classes only contain the necessary > member functions. > > Bug: v8:12808 > Change-Id: I4f4cf15bbf9b80c2de0c18aea82a0c238804759d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629603 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#80506} Bug: v8:12808 Change-Id: Ib0621b7de8da86a89752c66907f6a56adff9075d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3665936Reviewed-by:
-
Jakob Kummerow authored
The previous implementation would simply crash when command-line parameters to the bigint_shell weren't valid integers (where integers were expected). Change-Id: Ia9987ab241ae9cac8dad4517766bfdd0b8cc98b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3677295 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#80824}
-
Andy Wingo authored
Bug: v8:12868 Change-Id: Ied5e985db139517ec34446bcb8b16041e5d79af7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663092 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80823}
-
Milad Fa authored
This CL fixed the following compilation error: ``` error: inline declaration of 'Union(...)' follows declaration with attribute 'noinline' ``` Change-Id: I9672ca89d245e5f018f7dada57e30be1fc170115 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673194Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80822}
-
Manos Koukoutos authored
See crrev.com/c/v8/v8/+/3660248 for context on typed wasm nodes. Bug: chromium:1329939 Change-Id: I58ce7790e75fa1e228ae5ea6a84216889099a203 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676852 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Milad Fa authored
Port 3ac47847 R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I06a988b81c4fb711784fee5a700a51858ee5fbbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673193Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80820}
-
Camillo Bruni authored
Allow fast branches in the case the accumulator's live range doesn't extend beyond the branch test. Previously we were more restrictive and only allowed fast branches the test itself didn't use the accumulator register. Bug: v8:7700 Change-Id: Iec98028b3ddb04eeb51e98436a0bdc48f22920ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3663744Reviewed-by:
-
Dominik Inführ authored
NativeContexts are always allocated in old space and thus cannot die or move during minor GCs. Bug: v8:11708 Change-Id: I01ec7775aa1186d91ca620c464f570f24ac9f215 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3666617Reviewed-by:
-
Clemens Backes authored
The number of fields gets huge, and we get a lot of repetitive code. Use a macro to simplify things. R=jkummerow@chromium.org Bug: v8:12425 Change-Id: I5282d03724fb7fe966ac9b281398adabfd339dcd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667505 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
design doc: https://docs.google.com/document/d/1h4nxeEkMrVBd3QUmLBFGCqbq9BPUPFfkU6L0-IdvJdE/edit?usp=sharing Bug: v8:5210, chromium:1269989, chromium:1313647 Change-Id: I31cc6c0756b3754b61c02f7c5ddde6b5016abcd0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3613322Reviewed-by:
Darius Mercadier <dmercadier@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#80816}
-
Leszek Swirski authored
Bug: v8:12920 Change-Id: Iec1f4a2effc45299e30ecf8a586c535dbb22ee20 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676860 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80815}
-
Dominik Inführ authored
Get some test coverage before restarting the map space compaction finch again. This should test whether slots in invalidated objects are now properly ignored when the invalidated object is dead. Bug: v8:12578 Change-Id: I5b6f30b97c2db895183216ae5d5dbd4e5fa9d0c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676855Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80814}
-
Thibaud Michaud authored
R=gdeepti@chromium.org,clemensb@chromium.org Bug: v8:12284 Change-Id: Id003edadabb061aff074ad69602caf9322bda07e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667085Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=gdeepti@chromium.org,clemensb@chromium.org Bug: v8:12284 Change-Id: Idc2fb6b2ee8453ed84b1be1b23e6bdae878989b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3667504 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Change-Id: Ic150f990ac7329bf93b0f9c1c87c4c13be3e3c06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669252Reviewed-by:
-
Igor Sheludko authored
... when external code space is enabled. Since we are using near jump/call instruction only for [tail]calling builtins, we can increase the code range as long as we can guarantee that the remapped builtins are always reachable. We can do that by remapping embedded builtins into the middle of the code range. Bug: v8:11880, v8:12689 Change-Id: I69901634586df3c35618ea7bd5311102e4675f6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669107Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#80810}
-
Danylo Boiko authored
Change-Id: If1414fd2c01816461983d9bcebeaef5785ef355a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669694Reviewed-by:
-
Nikolaos Papaspyrou authored
Mostly in comments, again, not much to be said... Bug: v8:12425 Change-Id: I75b4b244e6fa259a29f6cf28bd8258b035af4be6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673536Reviewed-by:
-
Lu Yahan authored
Change-Id: I8594ee09c127bb996811585ffe1f0eb2d567d9fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676880 Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80807}
-
Clemens Backes authored
Similar to https://crrev.com/c/3634781, this switches some {BitVector}s in the regular top-tier register allocator to {SparseBitVector}. For functions with a huge amount of virtual registers, this would save a significant amount of memory, and also performance. For small number of registers though we probably introduce a slight regression, because there is one more dynamic check to be performed before accessing the bits. R=mslekova@chromium.org Bug: chromium:1313379, v8:12780 Change-Id: Ib65d22ad0a8e2c933f7178f4fefc36e500be623c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650602Reviewed-by:
-
Andrey Kosyakov authored
... with [[nodiscard]] removed following the revert of https://crrev.com/c/v8/v8/+/3662540 Change-Id: Ie35f54af1e22a2002c10325642b980f94f666321 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669472 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#80805}
-
Danylo Boiko authored
Change-Id: Ic2c2ccbc68b95d02aed610e96c57ee5739836cc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673299Reviewed-by:
-
Joyee Cheung authored
This simplifies the code and removes the runtime overhead of spontaneously adding strings to the cache. Bug: v8:12718 Change-Id: I2ed49bd82e3baf2563eeb8f463be72c0308c52c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616553Reviewed-by:
-
jameslahm authored
Bug: v8:12781 Change-Id: I01416a638abbb0f2c590f806869c00356b0fcba5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3675732Reviewed-by:
-
