- 09 Jun, 2021 11 commits
-
-
Santiago Aboy Solanes authored
It was added years ago and in 2017 it was enabled by default[1], which means enough time has passed and we can remove the flag. [1]: https://chromium-review.googlesource.com/c/v8/v8/+/528076/ Change-Id: I059417d4683910e86ebfddd93f504006094fa342 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947406Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75039}
-
Igor Sheludko authored
... and add regression test for contextual stores to JSGlobalObject with interceptor in the prototype chain. Bug: chromium:1216437 Change-Id: Ibd344288c6327b35f3276f59517995d591acb967 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944895 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#75038}
-
Patrick Thier authored
--stress-concurrent-inlining has a negative implication for --lazy-feedback-allocation. We need to explicitly add --no-stress-concurrent-inlining, since the test relies on lazy feedback allocation. Bug: v8:11853 Change-Id: I2bd8f0da05a766dd7282cdb3b70c4a1b478c71cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2948647 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75037}
-
Wenyu Zhao authored
* Skip 8 tests that timeout due to the low-performance of current MMTk non-moving GC. - This will be enabled after TPH performance issues are addressed. * Skip 2 new tests that creates a second isolate -- TPH does not support it at the moment. * Skip 1 test that expects concurrent sweeping behavior of cppgc. Bug: v8:11641 Change-Id: If86cdcc303b01536d278368886bb30d91da5c5c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909692 Auto-Submit: Wenyu Zhao <wenyu.zhao@anu.edu.au> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#75036}
-
Jakob Gruber authored
Tbr: neis@chromium.org Bug: v8:7790 Change-Id: Iaa094977b3c1099880ead9819df8418bc85e3dde Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947416Reviewed-by:
-
Maya Lekova authored
This reverts commit 7ef67b2e. Reason for revert: Speculative revert for a blocked roll - https://chromium-review.googlesource.com/c/chromium/src/+/2947365 Original change's description: > heap: Fix initial GC configuration for C++-only heaps > > Heaps in V8 start with a large limit that is shrunk upon young > generation GCs, based on some liveness estimate. This provides best > throughput during startup while at the same time finding a reasonable > first limit. > > For C++ (embedder memory) there is no estimate which is why it was > piggy-backing on V8. This breaks in scenarios where no JS memory is > allocated. > > In this fix we start a memory reducer after embedder memory has hit > the activation threshold if no GC happened so far. As soon as a single > Scavenger has happened, we leave it up to the JS estimate to figure > out a limit. Memory reducing GCs will then find a regular limit based > on the initial live size. > > Drive-by: Give embedders the same activiation threshold of 8MB as JS. > > Bug: chromium:1217076 > Change-Id: I8469696002ac2af8d75d6b47def062d2608387a1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944935 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75012} Bug: chromium:1217076 Change-Id: Ic1530162e846c2a767ea5ea902a01a21967d8e35 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947419 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75034}
-
Jakob Gruber authored
This is a step towards making JSObjectRef non-serialized. Change JSObjectRef::RawFastPropertyAt to use a direct load with relaxed semantics. Special handling of `uninitialized` sentinel values is moved to the only use-site. A new lock `boilerplate_migration_access` protects against concurrent boilerplate migrations while we are iterating over properties. Bug: v8:7790 Change-Id: Ic9de54ca16c1f3364d497a77058cfa33d48dd4a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928184 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75033}
-
Maya Lekova authored
This reverts commit eb3ce72b. Reason for revert: Broke Android Arm64 Builder, see https://bugs.chromium.org/p/chromium/issues/detail?id=1217912 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8870cb4..921ea58 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a8bae77..df0a59a > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b508ecd..b14cdae > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0c64e83..d987b04 > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Change-Id: I8906ce650c866bd771910fea5db6c735bfe0c7e2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947396 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#75029} Change-Id: I4d83f012cf04ab94eb66bab9a8ebec04ed098fbf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947417 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75032}
-
Iain Ireland authored
In issue 11290, we disabled the propagation of EAL data out of lookarounds, because it was incorrect for lookahead nodes in loops. This caused performance regressions: for example, `/^\P{Letter}+$/u` (matching only characters that are not in Unicode's Letter category) uses negative lookahead when matching lone surrogates, and became about 2x slower. I spent some time looking into fixes, and this is what I've settled on. Some background: the implementation of lookarounds in irregexp is split between positive and negative lookaheads. (Lookbehinds aren't relevant here, because backwards matches always have EAL=0.) Positive lookaheads are wrapped in BEGIN_SUBMATCH and POSITIVE_SUBMATCH_SUCCESS ActionNodes. BEGIN_SUBMATCH saves the current state. POSITIVE_SUBMATCH_SUCCESS restores the necessary state (while leaving any captures that occurred during the lookaround intact). Negative lookaheads also begin with a BEGIN_SUBMATCH node, but follow it with a NegativeLookaroundChoiceNode. This node has two successors: a lookaround node, and a continue node. It only executes the continue node if the lookaround node backtracks, which automatically restores the previous state. Negative lookarounds also can't update captures. This affects EAL calculations. It turns out that negative lookaheads are already doing the right thing: EatsAtLeastPropagator only propagates information from the continue node, ignoring the lookaround node. The same is true for quick checks (see the comment in RegExpLookaround:Builder::ForMatch). A BEGIN_SUBMATCH for a negative lookahead can simply propagate the EAL data from its successor like any other ActionNode, and everything works. Positive lookaheads are harder. I tried saving a pointer to the successor in BEGIN_SUBMATCH, but ran into problems in FillInBMInfo, because the EAL value corresponded to the nodes after the lookahead, but the analysis was still looking at the nodes inside. I fell back to a more modest approach: split BEGIN_SUBMATCH in two, and propagate EAL info for BEGIN_NEGATIVE_SUBMATCH while keeping the current behaviour for BEGIN_POSITIVE_SUBMATCH. This fixes the performance regression at hand. Two potential approaches for fixing EAL for positive lookahead are: 1. Handling positive lookahead with its own dedicated choice node, like NegativeLookaroundChoiceNode. 2. Adding an eats_at_least_inside_loop field to EatsAtLeastInfo, which is <= eats_at_least_from_possibly_start, and using that value in EatsAtLeastFromLoopEntry. Both of those approaches are more complex than I want to tackle right now, though. Bug: v8:11844 Change-Id: I2a43509c2c21194b8c18f0a587fa21c194db76c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2934858Reviewed-by: -
Frank Tang authored
The test push stack boundary and too flaky (timeout) while running machine with more memory. Bug: v8:11845 Change-Id: I5b603f05270d224de71c735ece5dd65a27311c25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939082Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#75030}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8870cb4..921ea58 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a8bae77..df0a59a Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b508ecd..b14cdae Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0c64e83..d987b04 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I8906ce650c866bd771910fea5db6c735bfe0c7e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947396Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75029}
-
- 08 Jun, 2021 29 commits
-
-
Jakob Kummerow authored
Due to the limits of ia32's calling convention, being able to avoid construction of "Digits" objects (thanks to inlining) helps a lot for microbenchmarks. Fixed: chromium:1192133 Change-Id: I5676640d96a99dc6422f3946c608bcc93ef222ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947410 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#75028}
-
Frank Tang authored
Add "calendar", and "dateTimeField" Add option for languageDisplay https://tc39.es/intl-displaynames-v2/ https://chromestatus.com/feature/5082027281874944 Design Doc: https://docs.google.com/document/d/17hQz4nOC7PJYhxc_MU-BRoT6BnYGZv66XlU1iGX0ywQ/edit# Bug: v8:11637 Change-Id: Ie7dc80d16956f0e668b11e600e47f5bafb081ff7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2924523 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75027}
-
Junliang Yan authored
Change-Id: I3a4e827f9407286c8665ee032fbbc4552ebd1d89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2945272 Commit-Queue: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Auto-Submit: Junliang Yan <junyan@redhat.com> Reviewed-by:
Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75026}
-
Frank Tang authored
Only return "subset of" the requested Locales. Bug: v8:11860 Change-Id: I917753c6f0f5dfc7a52d071febbe03abfab45b04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2946746Reviewed-by:
-
Michael Lippautz authored
GetName() is very generic and arleady exists as virtual method in Blink. Bug: chromium:1056170 Change-Id: I7aa6e869a06c048e7baea45939894717c872d89e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947404 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
See set_parent https://source.chromium.org/chromium/chromium/src/+/main:v8/src/objects/string-inl.h;l=857;drc=a6207b54d010a5bee8611a6ef08f9bee9a9768cf Change-Id: I2fa5718c04b281016e2d4cae07b7f36e37176d6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2947402Reviewed-by:
-
Thibaud Michaud authored
Add a new testing tier based on Liftoff. In this tier, the Liftoff compiler takes an address to a counter, and decrements that counter at every instruction. When the counter reaches 0, execution aborts. R=clemensb@chromium.org Bug: v8:11856 Change-Id: I20970e323ff19f7cb6ab6855377c678ca391421e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944440Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#75022}
-
Vicky Kontoura authored
This CL updates Realm.eval() to also handle reading source code as a JavaScript function or from a file. To distinguish between different argument types, an additional options bag needs to be provided. If no options bag is provided, the behavior defaults to the current one, which is reading source code from a string. Bug: v8:11525, v8:11706 Change-Id: I68238335eb91171041dca2c83db211c40dd68359 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944435Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#75021}
-
Vicky Kontoura authored
Currently, the serializer and deserializer assume that all top-level declarations to be serialized will be objects. This CL removes this assumption. Bug: v8:11525, v8:11706 Change-Id: I5acf5e7a3b73aba5ffc5b1d5eb9cb51b3804a4af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2945178Reviewed-by:
-
Georg Neis authored
This is needed for JSCallReducer. Bug: chromium:1217562 Change-Id: I1f06040a74c393598c134301ba0cf04a46380107 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2945184Reviewed-by:
-
Milad Fa authored
Port f68e1be7 Original Commit Message: Directly use the correct registers for calling the RecordWrite stubs in sparkplug. To keep changes to existing builtins minimal there are certain register requirements which are now made explicit in WriteBarrierDescriptor::Verify. R=cbruni@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Id01f936f96cf231dcfc599b4f2662124bc1a7744 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2945832Reviewed-by:
Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Clemens Backes authored
This adds a .mailmap entry to remap clemensh@chromium.org to clemensb@chromium.org, with Clemens' new name. R=mathias@chromium.org Change-Id: If234c59cf9089e71a1baf56115d5ee900f8af275 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919626Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75017}
-
Ulan Degenbaev authored
Change-Id: I4a30e0f01e35eb0824f5abeec62d55d62970b59f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910781Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Wenyu Zhao authored
The initial CL is suspected to break the --predictable CI. But looks like the CI is still crashing and also flaky after the revert. So reland it again. This is a reland of 59d58d72 Original change's description: > [csa] Remove InnerAllocate and replace with non-folded allocations > > This CL removes all uses of InnerAllocate (except memento allocations) > and replace with non-folded allocations. The change is based on the > fact that 1. Those InnerAllocates are not guarded by --allocation-folding > flag. 2. Hopefully the MemoryOptimizer can handle the folding and no > performance regression will happen. > > Two special versions of InnerAllocate is still kept: > * One for memento allocations (renamed to InnerAllocateMemento). > * One for AllocateUninitializedJSArrayWithElements (renamed to InnerAllocateElements). > > Change-Id: Ie77da6b2fba31b048241f7b7d927065305a01c27 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2873767 > Commit-Queue: Wenyu Zhao <wenyu.zhao@anu.edu.au> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74899} Change-Id: I540c3a6b6e3f7c70c048f8ad1e5f702287fb086b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2946667 Commit-Queue: Wenyu Zhao <wenyu.zhao@anu.edu.au> Reviewed-by:
-
Patrick Thier authored
Add flag --trace-baseline-batch-compilation to enable tracing for baseline batch compilation. Bug: v8:11790 Change-Id: I2b05017181b95bf3bccb70e2092250211dafb86c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2945174Reviewed-by:
-
Clemens Backes authored
Predictable does not contradict --wasm-tier-up any more, hence unskip the tests. R=ahaas@chromium.org Bug: v8:11319, v8:11848 Change-Id: Iaefcf6c80e65d27c527aa1a45b054ace1d85fe39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2945171 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#75013}
-
Michael Lippautz authored
Heaps in V8 start with a large limit that is shrunk upon young generation GCs, based on some liveness estimate. This provides best throughput during startup while at the same time finding a reasonable first limit. For C++ (embedder memory) there is no estimate which is why it was piggy-backing on V8. This breaks in scenarios where no JS memory is allocated. In this fix we start a memory reducer after embedder memory has hit the activation threshold if no GC happened so far. As soon as a single Scavenger has happened, we leave it up to the JS estimate to figure out a limit. Memory reducing GCs will then find a regular limit based on the initial live size. Drive-by: Give embedders the same activiation threshold of 8MB as JS. Bug: chromium:1217076 Change-Id: I8469696002ac2af8d75d6b47def062d2608387a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944935Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I4d1badcc31accfc1a2efcd0d12118e7aa436e610 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940894 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: v8:11420 Change-Id: Ic2b977c41dd71426838e1039b66dc7936cc4ff98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933658Reviewed-by:
-
Clemens Backes authored
This is a reland of 79d63a5e. Some fixes landed already, and two tests need to be skipped now (one with a tracking bug). Original change's description: > [wasm] Remove all implications from --predictable > > In predictable mode, we want to execute the same code as otherwise, > modulo timing. Hence remove any implications which change behaviour > (like tier-up or asynchronous compilation). > Note that --predictable is a debugging flag, so the configurations does > not need to "make sense" in production. > > R=ahaas@chromium.org > > Bug: v8:11848 > Change-Id: If74fbacadeb087d977922c41f33fd18738b50ded > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940898 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74973} Bug: v8:11848 Change-Id: I3564e4351d6545bb9643d1ae44722eb2606b8961 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944936Reviewed-by:
-
Camillo Bruni authored
- Scale svg flamechart directly instead of rerendering - Convert markers to SVG as well - Fix scroll position after zooming - Support tooltips for flamechart Change-Id: I01c966d2705989cf45a91c64aa4302a8de035414 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944894 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#75008}
-
Clemens Backes authored
The predictable platform only executed background tasks if at least one foreground task was executed. Async compilation in Wasm only spawns a background task though, so that one could be missed. This CL fixes the loop to also execute background tasks if no foreground task was executed. R=ahaas@chromium.org Bug: v8:11848 Change-Id: Ia0b32427c24a79d5710c784b98528bf431471528 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944833Reviewed-by:
-
Manos Koukoutos authored
Changes: - Add struct.new_with_rtt as a new WasmInitExpr. Parse it in consume_init_expr(). Add it to InstanceBuilder::EvaluateInitExpression(). - Change WasmInitExpr::operand_ to vector operands_. - In consume_init_expr(), use parsed over hard-coded opcode length. - Improve WasmStruct::WasmStructPrint slightly. - Add Factory::NewWasmStruct(). - Add WasmValue::CopyToWithSystemEndianness. - In wasm-module-builder.js, generalize emit_init_expr for expressions with operands. Add missing init. expression types. - Add tests. Bug: v8:7748 Change-Id: Ica12378d202730aff1b57c7d4240aa00ef124f8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940893 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
This reverts commit febfbb21. Reason for revert: Introduced new bugs: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20-%20debug/34472/overview Original change's description: > [sparkplug] Adjust compare and jump function in sparkplug > > Mips and risc-v do not have the flag register and can not decide > whether to jump through flags in JumpIf(); > > Therefor, we merge the comparison with the jump; > > Bug: v8:11803 > > Change-Id: If53752da93b97e8ff65affdfe99e5de8e1a1493f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2921034 > Auto-Submit: Liu yu <liuyu@loongson.cn> > Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75001} Bug: v8:11803 Change-Id: Ic982564ccdef9a07bf3a5fb4745a11cfa178cc0e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2946818 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#75005}
-
Daniel Bevenius authored
This commit adds a TryGetCurrent() method to the v8::Isolate class. The motivation for adding this method this is that in Node.js we've run into situations where we need to check if there is a current Isolate and we are using GetCurrent() for this. The issue is that for a debug build of Node.js, the debug check in GetCurrent() will cause a failure. The suggestion in this changeset is to allow getting the current Isolate, or null if one does not exist, without any checks. Change-Id: I01676e4bcdbe86da0496f5df1982d14eb1c9ebf8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2910630Reviewed-by:
-
Liu Yu authored
Some supplements on mips for 8ab75a56 Change-Id: Id0928e59b6a265f34a4ee986fa80e6b9dee0198c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2946812 Auto-Submit: Liu yu <liuyu@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#75003}
-
Clemens Backes authored
Jobs were still being posted on the underlying default platform, which caused concurrent execution. By directly returning a {NewDefaultJobHandle} with a pointer to the {PredictablePlatform}, we force execution of all posted tasks via that platform. R=ahaas@chromium.org, cbruni@chromium.org Bug: v8:11848 Change-Id: Ie10519583341b427776ca428f85641e96f821367 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944808Reviewed-by: -
Liu Yu authored
Mips and risc-v do not have the flag register and can not decide whether to jump through flags in JumpIf(); Therefor, we merge the comparison with the jump; Bug: v8:11803 Change-Id: If53752da93b97e8ff65affdfe99e5de8e1a1493f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2921034 Auto-Submit: Liu yu <liuyu@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
Michael Achenbach authored
The flag had no effect and was removed from fuzzilli instructions here: https://github.com/googleprojectzero/fuzzilli/commit/f31bfb7b5a3364e4cbcf7661f621fb5347521560 No-Try: true Change-Id: If28e79fdf469a4cb665a83793c9fef8c6c2a8232 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944431 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#75000}
-
