- 22 Jun, 2016 23 commits
-
-
rmcilroy authored
Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg Review-Url: https://codereview.chromium.org/2089673002 Cr-Commit-Position: refs/heads/master@{#37181}
-
verwaest authored
The CL avoids superfluous conversions / reboxing and handlescopes. BUG= Review-Url: https://codereview.chromium.org/2089703004 Cr-Commit-Position: refs/heads/master@{#37180}
-
jochen authored
This way embedders don't have to manually convert them to strings BUG=chromium:619166 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2085223002 Cr-Commit-Position: refs/heads/master@{#37179}
-
yangguo authored
R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2083303002 Cr-Commit-Position: refs/heads/master@{#37178}
-
danno authored
Review-Url: https://codereview.chromium.org/2066313002 Cr-Commit-Position: refs/heads/master@{#37177}
-
yangguo authored
- Moves the most often used 32 items to the top. This shaves off 10kB from the startup snapshot size. - Sorts the rest by usage and type. R=mlippautz@chromium.org Review-Url: https://codereview.chromium.org/2088023003 Cr-Commit-Position: refs/heads/master@{#37176}
-
ahaas authored
R=mlippautz@chromium.org Review-Url: https://codereview.chromium.org/2080223005 Cr-Commit-Position: refs/heads/master@{#37175}
-
verwaest authored
This was necessary since certain named handlers didn't check the name beforehand, and could miss to LoadIC_Miss with a name convertible to an index. This is currently not supported anymore, so we can drop this path. We should make sure we miss to the right label instead. BUG= Review-Url: https://codereview.chromium.org/2083283002 Cr-Commit-Position: refs/heads/master@{#37174}
-
jgruber authored
edi is expected to contain the JS function. Ensure that it is not overwritten. BUG=chromium:621431,chromium:621550,chromium:621217 R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2085043004 Cr-Commit-Position: refs/heads/master@{#37173}
-
yangguo authored
R=mlippautz@chromium.org Review-Url: https://codereview.chromium.org/2087163002 Cr-Commit-Position: refs/heads/master@{#37172}
-
mlippautz authored
Failing to do the right check in AdvancePage results in a crash in a CHECK later in EnsureCurrentCapacity. BUG=chromium:620750,chromium:622115 LOG=N R=jochen@chromium.org Review-Url: https://codereview.chromium.org/2090013002 Cr-Commit-Position: refs/heads/master@{#37171}
-
yangguo authored
R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2081703002 Cr-Commit-Position: refs/heads/master@{#37170}
-
yangguo authored
R=jgruber@chromium.org BUG=v8:4703 Review-Url: https://codereview.chromium.org/2088703002 Cr-Commit-Position: refs/heads/master@{#37169}
-
bmeurer authored
This adds a dedicated test to make sure we don't try constant folding on checks (in this case CheckTaggedPointer), which would generate invalid code as we removing checks that guard the constant without knowing whether it's safe to do so. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2087153002 Cr-Commit-Position: refs/heads/master@{#37168}
-
bmeurer authored
Let the SimplifiedOperatorReducer perform some strength reduction for certain CheckTaggedSigned and CheckTaggedPointer inputs (reusing the existing logic for ObjectIsSmi). R=jarin@chromium.org BUG=v8:5141 Review-Url: https://codereview.chromium.org/2080703006 Cr-Commit-Position: refs/heads/master@{#37167}
-
jarin authored
Review-Url: https://codereview.chromium.org/2084943002 Cr-Commit-Position: refs/heads/master@{#37166}
-
bmeurer authored
BUG=v8:3266, v8:3468, v8:3493, v8:5086, v8:5108 R=rtoy@chromium.org Review-Url: https://codereview.chromium.org/2086663004 Cr-Commit-Position: refs/heads/master@{#37165}
-
bmeurer authored
We cannot change x - y < 0 to x < y, because it would only be safe if x - y cannot overflow, which we don't know in general. R=jarin@chromium.org BUG=v8:5129 Review-Url: https://codereview.chromium.org/2090493002 Cr-Commit-Position: refs/heads/master@{#37164}
-
bmeurer authored
Revert of [Crankshaft] Always check for stubs marked to not require an eager frame. (patchset #2 id:20001 of https://codereview.chromium.org/2089673002/ ) Reason for revert: Breaks with nosnap: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/7474/steps/Check/logs/regress-2612 Original issue's description: > [Crankshaft] Always check for stubs marked to not require an eager frame. > > Previously only stubs built in the snapshot were checked for having an > eager frame. This caused a regression to creap in on ia32 for > RegExpConstructResultStub. Change test to always check. > > Committed: https://crrev.com/f6facbb2106ffc2918dd249166233a7fa95dc449 > Cr-Commit-Position: refs/heads/master@{#37162} TBR=rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2087963004 Cr-Commit-Position: refs/heads/master@{#37163}
-
rmcilroy authored
Previously only stubs built in the snapshot were checked for having an eager frame. This caused a regression to creap in on ia32 for RegExpConstructResultStub. Change test to always check. Review-Url: https://codereview.chromium.org/2089673002 Cr-Commit-Position: refs/heads/master@{#37162}
-
v8-autoroll authored
Rolling v8/build to f56976d676dfd5597229b21a83a53a58704582bf Rolling v8/buildtools to 56eaae134648135663c4aa1ed82278572b5f35ef Rolling v8/tools/mb to 5268873c8c1eebbf1a3aaed7e63f99b600fab65e TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2087933004 Cr-Commit-Position: refs/heads/master@{#37161}
-
bjaideep authored
PPC/s390: [builtins] NonNumberToNumber and StringToNumber now use CallRuntime instead of TailCallRuntime Port b5c69cbf Original commit message: With the tail call, pointers to the JS heap could be pushed on a js-to-wasm frame. On the js-to-wasm frame, however, this pointer would not be updated by the GC. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=617084 LOG=N Review-Url: https://codereview.chromium.org/2085183002 Cr-Commit-Position: refs/heads/master@{#37160}
-
ritesht authored
Add a flag to gate experimental support for dynamic code loading and JITing (at runtime in a wasm module). Enhancing functionality of the indirect function table to support JITing and dynamic linking by allowing additional space to be filled with an "undefined" function signature. BUG=v8:5044 LOG=N TEST=None R=mtrofin@chromium.org,bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2049513003 Cr-Commit-Position: refs/heads/master@{#37159}
-
- 21 Jun, 2016 17 commits
-
-
dpranke authored
The GN configs for different optimization levels are confusing and should probably be reworked, but for now we add a special config specifically so that we can compile with -O3 when appropriate. R=brettw@chromium.org, machenbach@chromium.org BUG=616031, 618678, 621335 Review-Url: https://codereview.chromium.org/2076403002 Cr-Commit-Position: refs/heads/master@{#37158}
-
bjaideep authored
Port f47b9e98 Original commit message: This adds a new BUILTIN frame type, which supports variable number of arguments for builtins implemented in hand-written native code (we will extend this mechanism to TurboFan builtins at some point). Convert the Math.max and Math.min builtins to construct a BUILTIN frame if required. This does not yet work for C++ builtins, but that'll be the next step. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4815 LOG=N Review-Url: https://codereview.chromium.org/2087433003 Cr-Commit-Position: refs/heads/master@{#37157}
-
jwolfe authored
Reland of https://codereview.chromium.org/2048703002/ Code like `let a; eval("var a;");` should throw a SyntaxError, not a TypeError (this caused a test262 failure.). However, the code `eval("function NaN() {}");` should actually throw a TypeError. This patch changes most cases of redeclaration errors from TypeError to SyntaxError. See the test mjsunit/regress/redeclaration-error-types for a thorough analysis with spec references. The relevant sections of the spec are ES#sec-globaldeclarationinstantiation and ES#sec-evaldeclarationinstantiation BUG=v8:4955 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel R=adamk Review-Url: https://codereview.chromium.org/2086063002 Cr-Commit-Position: refs/heads/master@{#37156}
-
rossberg authored
- Use ES6 classes and other goodies. - Make some names match design/spec. - Remove obsolete generation of END section. R=bradnelson@chromium.org BUG= Review-Url: https://codereview.chromium.org/2081973003 Cr-Commit-Position: refs/heads/master@{#37155}
-
caitpotter88 authored
Previously, an async arrow function would be parsed if any valid ConditionalExpression began with the identifier "async", and its following token was on the same line. So for example, `async.bar foo => 1` was parsed as a valid async arrow function. This patch corrects this behaviour by asserting that the following token is a valid arrow parameters start. BUG=v8:4483 R=littledan@chromium.org, henrique.ferreiro@gmail.com Review-Url: https://codereview.chromium.org/2089733002 Cr-Commit-Position: refs/heads/master@{#37154}
-
verwaest authored
BUG=chromium:595492 Review-Url: https://codereview.chromium.org/2084923003 Cr-Commit-Position: refs/heads/master@{#37153}
-
jochen authored
BUG=chromium:619166 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2082633002 Cr-Commit-Position: refs/heads/master@{#37152}
-
balazs.kilvady authored
MIPS: Fix 'MIPS: Followup [turbofan] Introduce new operators Float32SubPreserveNan and Float64SubPreserveNan.' Port eff959bb Original commit message: Float32SubMinusZero and Float64SubMinusZero tests are failing because MIPS does not preserve NaN payload according to Wasm spec. Implemented macro-assembler methods that check for NaN operands, and return the qNaN value with preserved payload and sign bits. TEST=cctest/test-run-wasm/Run_WasmFloat32SubMinusZero, cctest/test-run-wasm/Run_WasmFloat64SubMinusZero BUG= Review-Url: https://codereview.chromium.org/2081993002 Cr-Commit-Position: refs/heads/master@{#37151}
-
nikolaos authored
R=adamk@chromium.org BUG=chromium:621111 LOG=N Review-Url: https://codereview.chromium.org/2086513002 Cr-Commit-Position: refs/heads/master@{#37150}
-
caitpotter88 authored
BUG=v8:4483 R=yangguo@chromium.org, littledan@chromium.org Review-Url: https://codereview.chromium.org/2082023002 Cr-Commit-Position: refs/heads/master@{#37149}
-
bmeurer authored
Add control dependencies to Projection and Int32Add/SubWithOverflow operators, to prevent the scheduler from moving the Projection nodes into the wrong place. This way the instruction selection can combine the Int32Add/SubWithOverflow operations with the DeoptimizeIf and/or DeoptimizeUnless nodes. This needs new operators CheckedInt32Add and CheckedInt32Sub so that we can delay the actual lowering until the effect/control linearizer. This also makes CheckIf operator obsolete, so we can drop it. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2082993002 Cr-Commit-Position: refs/heads/master@{#37148}
-
rmcilroy authored
Adds back simple dead code elimination to the bytecode pipeline. BUG=v8:4280,chromium:616064 Review-Url: https://codereview.chromium.org/2038083002 Cr-Commit-Position: refs/heads/master@{#37147}
-
bgeron authored
Fixes bug 5128 in product V8. R=danno@chromium.org BUG= Review-Url: https://codereview.chromium.org/2087813002 Cr-Commit-Position: refs/heads/master@{#37146}
-
rmcilroy authored
Make intrinsic ids a contiguous set of ids so that the switch statement can build a table switch rather than doing a large if/else tree. BUG=v8:4822 LOG=N Committed: https://crrev.com/36abd28a8d9932eb55d7c2bf3ad5e7cfe3eb99ea Review-Url: https://codereview.chromium.org/2084623002 Cr-Original-Commit-Position: refs/heads/master@{#37135} Cr-Commit-Position: refs/heads/master@{#37145}
-
neis authored
This CL merely sets the --ignition-generators flag to true. This flag is currently only meaningful in combination with --ignition. BUG= Review-Url: https://codereview.chromium.org/2065963002 Cr-Commit-Position: refs/heads/master@{#37144}
-
rossberg authored
Implements: - WebAssembly object, - WebAssembly.Module constructor, - WebAssembly.Instance constructor, - WebAssembly.compile async method, - and Module and Instance instance objects. Also, changes ErrorThrower to support capturing errors in a promise reject. Since we cannot yet compile without fixing the Wasm memory, and cannot validate a module without compiling, the Module constructor and compile method don't do anything yet but checking that their argument is a suitable BufferSource. Instead of a compiled module, the hidden state of a Module object currently is just that buffer. BUG= Review-Url: https://codereview.chromium.org/2084573002 Cr-Commit-Position: refs/heads/master@{#37143}
-
bmeurer authored
If all uses of a CheckTaggedHole[convert-hole-to-undefined] node truncate to word32, we can replace the hole check with a Smi check and return the result as word32. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2079233006 Cr-Commit-Position: refs/heads/master@{#37142}
-