1. 26 Sep, 2018 1 commit
    • Frank Tang's avatar
      [Intl] Remove incorrect CHECK · 93cbb579
      Frank Tang authored
      The CHECK was introduced in d7ae63e6.
      
      The first time the property got read by ToDateTimeOptions
      and the test will cause the needsDefault in ToDateTimeOptions
      be false. Then in step 22 of InitializeDateTimeFormat,
      it will get all undefined and cause the
      skeleton to be empty string. If we only pass in empty options, the
      defaults will be filled by ToDateTimeOptions and won't cause any
      CHECK failure.
      
      
      Bug: chromium:888299
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: I3ee14434f0708eaaea78cc8857591152d1bdef8a
      Reviewed-on: https://chromium-review.googlesource.com/1241316
      Commit-Queue: Frank Tang <ftang@chromium.org>
      Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56226}
      93cbb579
  2. 10 Jan, 2017 1 commit
  3. 25 Nov, 2016 1 commit
  4. 25 Jul, 2016 1 commit
  5. 20 May, 2016 1 commit
  6. 16 Feb, 2016 1 commit
  7. 05 Feb, 2016 1 commit
  8. 02 Feb, 2016 1 commit
  9. 29 Jan, 2016 1 commit
    • littledan's avatar
      Fix Unicode string normalization with null bytes · f3e41d96
      littledan authored
      Previously, String.prototype.normalize constructed its ICU input
      string as a null-terminated string. This creates a bug for strings
      which contain a null byte, which is allowed in ECMAScript. This
      patch constructs the ICU string based on its length so that the
      entire string is normalized.
      
      R=jshin@chromium.org
      BUG=v8:4654
      LOG=Y
      
      Review URL: https://codereview.chromium.org/1645223003
      
      Cr-Commit-Position: refs/heads/master@{#33614}
      f3e41d96
  10. 04 Jan, 2016 1 commit