- 27 Sep, 2018 13 commits
-
-
Clemens Hammacher authored
This code is rarely used, but it makes invalid assumptions. The reversations in {owned_code_space_} might not actually be sorted, so we cannot assume that whenever there is an overlap this will be at the end of the to-be-committed range. Minor drive-by improvements: Use iterator, remove redundant DCHECK. R=mstarzinger@chromium.org Change-Id: I56bca4298c89e97395de71f9d9be404a7b2bf621 Reviewed-on: https://chromium-review.googlesource.com/1245770Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56263}
-
Jaroslav Sevcik authored
Instead attribute them properly as Bultin or BytecodeHandler. Bug: v8:6240 Change-Id: I773a533b318afe52d63152edf5b16463801db8e9 Reviewed-on: https://chromium-review.googlesource.com/1249202Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56262}
-
Stephan Herhut authored
This adds a stress test for the I64 variants of the AtomicCompareExchange opcodes. Bug: v8:6532 Change-Id: Iaba4f31f944a71393e5c3222d364d214ff482b9e Reviewed-on: https://chromium-review.googlesource.com/1235913 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#56261}
-
Georg Neis authored
- Add a new broker mode kRetired, in which the heap can again be accessed. - Change the way modes work. We now always start in kDisabled. If FLAG_concurrent_compiler_frontend is on, we eventually move to kSerializing, then to kSerialized, then to kRetired. - Add an ObjectDataKind to ObjectData that indicates whether the data is just a dummy (i.e. created while broker was in kDisabled mode). This also happens to fix a bug found by clusterfuzz. Bug: v8:7790, chromium:889722 Change-Id: I38833fe7ad26d2d3efb15ba560576defb82f673a Reviewed-on: https://chromium-review.googlesource.com/1245425 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#56260}
-
Michael Achenbach authored
NOTRY=true Bug: v8:8198 Change-Id: I04fd0344f3ce9951c246876fbe1c58fa4306d16c Reviewed-on: https://chromium-review.googlesource.com/1248981Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56259}
-
Clemens Hammacher authored
Make {AllocateForCode} return an actual buffer, and move the OOM check into that method. This allows us to generate more precise OOM messages. R=mstarzinger@chromium.org Change-Id: Ie9ed81248fe8068c92eec29a4911ffef43032de2 Reviewed-on: https://chromium-review.googlesource.com/1245769 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Tobias Tebbi authored
This fixes a bug that the variables used to implement labels with parameters in CSA leak into the user-accessible scope. Example: macro Foo() labels Bar(Smi) { Bar0 = 5; } Bug: v8:7793 Change-Id: I33bf5a207c7e9e7337fa79fc7591c05901b2fa5b Reviewed-on: https://chromium-review.googlesource.com/1246183Reviewed-by:Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56257}
-
Clemens Hammacher authored
There is a data race if several background threads check for a tracing flag concurrently. Both will call {GetCategoryGroupEnabledInternal}. The first one not find the category in the {g_category_group_enabled} array, and hence will add it and call {UpdateCategoryGroupEnabledFlag} to initialize the flag. The second thread then finds the entry in the array and reads it without any synchronization, which is a data race. Since we do not really care about this race, we just use a {Relaxed_Load} to read the field. TSan is fine with that. R=yangguo@chromium.org CC=ofrobots@google.com Bug: v8:8221 Change-Id: Ie09141e3d845956d3c487a463f00b7d6cd413513 Reviewed-on: https://chromium-review.googlesource.com/1245424Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56256}
-
Maya Lekova authored
NOTRY=true Bug: v8:8220 Change-Id: I4f6dc81321adc5efceaf64be04fc23627e90b0fe Reviewed-on: https://chromium-review.googlesource.com/1245772 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56255}
-
Deepti Gandluri authored
Change-Id: I1cf8d697b5a4408fb75332dc39be12c0a2ee0e5a Bug: v8:8202, v8:6532 Reviewed-on: https://chromium-review.googlesource.com/1240907 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Marja Hölttä authored
BUG=v8:5402,v8:8015 Change-Id: I19440f77601317d99d912f5d7248a5275c980993 Reviewed-on: https://chromium-review.googlesource.com/1245761Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#56253}
-
Alexei Filippov authored
This reverts commit 181bbd5c. Reason for revert: Still break Win tests https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20debug/25096 Original change's description: > Reland "[heap profiler] Refactor: Replace indices with HeapEntry*" > > This is a reland of 69a502ce > > TBR=ulan@chromium.org > > Original change's description: > > [heap profiler] Refactor: Replace indices with HeapEntry* > > > > Change-Id: I0c176f66711d45e2f59d527f3133a1afbf825ec3 > > Reviewed-on: https://chromium-review.googlesource.com/1229613 > > Commit-Queue: Alexei Filippov <alph@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#56245} > > Change-Id: I416da19eb38a1a55f5e2f5897062bc1ca454ac34 > Reviewed-on: https://chromium-review.googlesource.com/1246802 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56250} TBR=ulan@chromium.org,alph@chromium.org,mlippautz@chromium.org Change-Id: I0d027d192a9354eb6157405566420e6aa38738c1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1248131Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#56252}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6f889c3..343caac Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/846ae9b..3cf15a9 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c4a7356..f221bac Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/9b435fc..ce131de Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/9ad74fa..86c7e6d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iaf0d368c44cd99d570d47782c2121d625fb9a551 Reviewed-on: https://chromium-review.googlesource.com/1248122Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56251}
-
- 26 Sep, 2018 25 commits
-
-
Alexei Filippov authored
This is a reland of 69a502ce TBR=ulan@chromium.org Original change's description: > [heap profiler] Refactor: Replace indices with HeapEntry* > > Change-Id: I0c176f66711d45e2f59d527f3133a1afbf825ec3 > Reviewed-on: https://chromium-review.googlesource.com/1229613 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56245} Change-Id: I416da19eb38a1a55f5e2f5897062bc1ca454ac34 Reviewed-on: https://chromium-review.googlesource.com/1246802 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Frank Tang authored
Add tests for 'quarter' unit in Intl.RelativeTimeFormat#format Bug: v8:7869 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I03077d5d89e1b9e459af0c31b5bf7378d9c4a1f0 Reviewed-on: https://chromium-review.googlesource.com/1244758 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56249}
-
Alexei Filippov authored
This reverts commit 69a502ce. Reason for revert: Broke the build https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20gcc%204.8/22123 Original change's description: > [heap profiler] Refactor: Replace indices with HeapEntry* > > Change-Id: I0c176f66711d45e2f59d527f3133a1afbf825ec3 > Reviewed-on: https://chromium-review.googlesource.com/1229613 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56245} TBR=ulan@chromium.org,alph@chromium.org,mlippautz@chromium.org Change-Id: Ib4495f17a653a95f8d5af634da74905c63048f8e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1246235Reviewed-by:
-
Alexei Filippov authored
This reverts commit 0352ea97. Reason for revert: A dependent patch broke the build https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20gcc%204.8/22123 Original change's description: > [heap profiler] Refactor: remove SnapshotFiller proxy > > Long time ago there were two passes over heap. One was counting > objects and edge and another was filling them. Since then we have > just a single pass, but the filler object is still there. > > Remove it for the sake of layering simplicity. > > Change-Id: Ic873eb5ca616b9dcae17fe388197dde8f539026f > Reviewed-on: https://chromium-review.googlesource.com/1244380 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56246} TBR=ulan@chromium.org,alph@chromium.org,mlippautz@chromium.org Change-Id: If71ddcc0008d138054074fc4cca3f38e032763e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1246234Reviewed-by:
-
Alexei Filippov authored
Long time ago there were two passes over heap. One was counting objects and edge and another was filling them. Since then we have just a single pass, but the filler object is still there. Remove it for the sake of layering simplicity. Change-Id: Ic873eb5ca616b9dcae17fe388197dde8f539026f Reviewed-on: https://chromium-review.googlesource.com/1244380 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#56246}
-
Alexei Filippov authored
Change-Id: I0c176f66711d45e2f59d527f3133a1afbf825ec3 Reviewed-on: https://chromium-review.googlesource.com/1229613 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Maya Lekova authored
That change is attempting to surface the root cause of a recent flake, see the related bug. Bug: v8:8228 Change-Id: Iebed5b8f46db3fd47154031856dc7ea173cf3d7f Reviewed-on: https://chromium-review.googlesource.com/1245771Reviewed-by:
-
Toon Verwaest authored
Before I gave the preparser its own zone this was the case. I somewhat accidentally dropped it when I used set_zone instead; causing large regressions for certain types of pages. Bug: chromium:889086 Change-Id: Ib3cf1f926b5c65506c66a97981c4544dccb372aa Reviewed-on: https://chromium-review.googlesource.com/1245767Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:8230 Change-Id: Ibf93300cd54c6d5053ebed0cb897b4068f2bc160 Reviewed-on: https://chromium-review.googlesource.com/1245768 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56242}
-
Peter Marshall authored
Deprecate GetCodeRange(void** start, size_t* length_in_bytes) in favor of a new signature MemoryRange GetCodeRange() which is consistent with that of GetEmbeddedCodeRange. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic5e244981422a2c75485c851ca768e54914cc539 Reviewed-on: https://chromium-review.googlesource.com/1245741Reviewed-by:
-
Clemens Hammacher authored
R=ahaas@chromium.org Bug: v8:8015 Change-Id: Ic449b76ab3957bb989bbb1fc9cc1fb4782db7acf Reviewed-on: https://chromium-review.googlesource.com/1240119Reviewed-by:
-
Clemens Hammacher authored
This method only has a single user, and can be implemented in a few lines, so just inline it. R=ahaas@chromium.org Bug: v8:8015 Change-Id: I26247d97ebb939274fa72cc5441e8c2e0c6bc869 Reviewed-on: https://chromium-review.googlesource.com/1245743Reviewed-by:
-
Clemens Hammacher authored
The idea of movable data structures is to pass them by value. This is also preferred by the style guide. R=ahaas@chromium.org CC=sattlerf@google.com Bug: v8:8015 Change-Id: Ica016425d624f4497e374b25b363c1f2eb49b4c0 Reviewed-on: https://chromium-review.googlesource.com/1245762Reviewed-by:
-
Hannes Payer authored
Surviving large objects are directly promoted to the old generation. Bug: chromium:852420 Change-Id: I460649714544d4338e01085f487d4b70065ecfb5 Reviewed-on: https://chromium-review.googlesource.com/1238173 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: chromium:888923 Change-Id: Ifb22cd9b34f53de3cf6e47cd92f3c0abeb10ac79 Reviewed-on: https://chromium-review.googlesource.com/1245763Reviewed-by:
-
Toon Verwaest authored
Bug: chromium:889086 Change-Id: Ie5a6a9e27260545469ea62d35b9571c0524f0f92 Reviewed-on: https://chromium-review.googlesource.com/1245427Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56235}
-
Igor Sheludko authored
In particular: MapForFixedTypedArray() and EmptyFixedTypedArrayForMap(). And make ReadOnlyRoots object independent of the Heap. Bug: v8:8015 Change-Id: Ifd17294661fac21c8e7545145280c8a2dedfe8c3 Reviewed-on: https://chromium-review.googlesource.com/1243131Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56234}
-
Igor Sheludko authored
Bug: v8:8015 Change-Id: I2f407c5ffaed96b90b9ead452a98a19ef1700b75 Reviewed-on: https://chromium-review.googlesource.com/1240336 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit eccf1867. Reason for revert: Speculative revert because it seems to introduce a pretty stable flake on gc stress tests, see https://bugs.chromium.org/p/v8/issues/detail?id=8229 Original change's description: > [interpreter] Separate bytecodes for one-shot property loads and stores > > Create LdaNamedPropertyNoFeedback and StaNamedPropertyNoFeedback > for one-shot property loads and stores. This CL replaces the runtime > calls with new bytecodes for named property load stores in one-shot code. > the runtime calls needed extra set of consecutive registers and > additional move instructions. This increased the size of > bytecode-array and possibly extended the life time of objects. > By replacing them with NoFeedback bytecodes we avoid these issues. > > Bug: v8:8072 > Change-Id: I20a38a5ce9940026171d870d354787fe0b7c5a6f > Reviewed-on: https://chromium-review.googlesource.com/1196725 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Cr-Commit-Position: refs/heads/master@{#56211} TBR=rmcilroy@chromium.org,yangguo@chromium.org,jarin@chromium.org,neis@chromium.org,cbruni@chromium.org,chandanreddy@google.com Change-Id: I445db58e6d4c275b434fabad5fad775bf259033f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8072 Reviewed-on: https://chromium-review.googlesource.com/1245421Reviewed-by:
-
Ivica Bogosavljevic authored
Change-Id: I88db66ef1bea03dee365679487814563250c4bba Reviewed-on: https://chromium-review.googlesource.com/1243127Reviewed-by:
-
Marja Hölttä authored
BUG=v8:5402,v8:8015 Change-Id: I2fce46c944e3057cb05aa53c3030916334ffbc3e Reviewed-on: https://chromium-review.googlesource.com/1243044Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4325c99..6f889c3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c51eb62..846ae9b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/64b6133..c4a7356 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I0a47e67e23a980b6fd8b95c97172f86d4c303bd0 Reviewed-on: https://chromium-review.googlesource.com/1244957 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Jakob Kummerow authored
Atomics.{load,store,add,sub,and,or,xor,exchange,compareExchange} are updated to support BigInt and BigInt64Array/BigUint64Array inputs. Atomics.{wait,wake,isLockFree} are left unchanged for now. Bug: v8:8100 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I8862d7e18c58ae08784535e9c010ba94f067a0ee Reviewed-on: https://chromium-review.googlesource.com/1237294 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:8066 Change-Id: I931de0472941fca8f68739a05fa38dee308d59f4 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1212467Reviewed-by:
-
Frank Tang authored
The CHECK was introduced in d7ae63e6. The first time the property got read by ToDateTimeOptions and the test will cause the needsDefault in ToDateTimeOptions be false. Then in step 22 of InitializeDateTimeFormat, it will get all undefined and cause the skeleton to be empty string. If we only pass in empty options, the defaults will be filled by ToDateTimeOptions and won't cause any CHECK failure. Bug: chromium:888299 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I3ee14434f0708eaaea78cc8857591152d1bdef8a Reviewed-on: https://chromium-review.googlesource.com/1241316 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 25 Sep, 2018 2 commits
-
-
Vasili Skurydzin authored
src/compiler/ppc/instruction-selector-ppc.cc: ensure that input register does not alias any temporary registers in VisitWord64ReverseBytes method. Change-Id: I18ddfc5cbe37ba7551ca25efa59d4973f77ffb02 Reviewed-on: https://chromium-review.googlesource.com/1244617Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#56225}
-
Yang Guo authored
This is a reland of bcb8d49b TBR=petermarshall@chromium.org Original change's description: > [snapshot] add checksum to startup snapshot > > We already had checksumming for code cache data. We now extend > checksumming to the startup snapshot to catch data corruption early. > > The performance impact for deserialization is a regression of 1-2%, > which should be acceptable. > > Sample output for the included test with --profile-deserialization: > > [Verifying snapshot checksum took 0.023 ms] > [Deserializing isolate (134348 bytes) took 1.891 ms] > [Verifying snapshot checksum took 0.024 ms] > [Deserializing isolate (134348 bytes) took 1.654 ms] > [Deserializing context #0 (47208 bytes) took 0.331 ms] > Deserialization will reserve: > 208168 bytes per isolate > 123368 bytes per context #0 > Snapshot blob consists of: > 134492 bytes in 6 chunks for startup > 115272 bytes for builtins > 47152 bytes in 31 chunks for context #0 > [Verifying snapshot checksum took 0.048 ms] > [Verifying snapshot checksum took 0.043 ms] > > R=peria@chromium.org, petermarshall@chromium.org > > Bug: chromium:881417 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: Ibc57520d459c86be8972f731aa35045b5e3751d7 > Reviewed-on: https://chromium-review.googlesource.com/1241874 > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56217} Bug: chromium:881417 Change-Id: I037f378fc2d45c3e0fa670bf538df68cbba5c53c Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1243191Reviewed-by:
-
