Commits · 1a4a904bef5d3bd5c91ab5f6f9c20e85550aacd3 · Linshizhi / V8

30 May, 2013 5 commits

Replace DeoptimizeOnUndefined with whitelisting AllowUndefinedAsNan · 1a4a904b

verwaest@chromium.org authored May 30, 2013

R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15952007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14894 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1a4a904b

MIPS: Convert ToBooleanStub to a HydrogenStub. Currently just using the... · 6c21d125

palfia@homejinni.com authored May 30, 2013

MIPS: Convert ToBooleanStub to a HydrogenStub. Currently just using the existing HBranch instruction, which is still fully implemented in Lithium. Will refactor HBranch in a next CL.

Port r14886 (068e9135)

BUG=

Review URL: https://codereview.chromium.org/15664008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14893 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6c21d125

MIPS: Fix AccessArgumentsAt on ARM. Use register for index. · 4e5de4ea

palfia@homejinni.com authored May 30, 2013

Port r14885 (63dd99b)

BUG=

Review URL: https://codereview.chromium.org/16215002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14892 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4e5de4ea

MIPS: Update ASSERT on arm to support SmiOrTagged in ClampToUint8 · d16aa0bc

palfia@homejinni.com authored May 30, 2013

Port r14881 (0b784159)

BUG=

Review URL: https://codereview.chromium.org/15769005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14891 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d16aa0bc

MIPS: Don't explicitly pass requested representations to constants; implement ConstantS · ec32721a

palfia@homejinni.com authored May 30, 2013

Port r14874 (e93cc94e)

BUG=

Review URL: https://codereview.chromium.org/15731008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14890 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ec32721a

29 May, 2013 24 commits

Prevent segfault if file cannot be opened when --ll_prof is used. · 4ee5e29b

plind44@gmail.com authored May 29, 2013

TEST=

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/16107002

Patch from Dusan Milosavljevic <Dusan.Milosavljevic@rt-rk.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14889 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4ee5e29b

Re-land: Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice · 09c489ea

adamk@chromium.org authored May 29, 2013

Original issue: https://codereview.chromium.org/15331002/

Broke mozilla/js1_5/Array/regress-451483.js, which ends up attempting to call %IsObserved() on a non-object.

IsObserved now checks for JSReceiver and returns false rather than crashing.

R=adamk@chromium.org, rossberg@chromium.org

Review URL: https://codereview.chromium.org/15777007

Patch from Rafael Weinstein <rafaelw@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14888 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

09c489ea

Handlify map allocation in Genesis::InstallInternalArray. · e8e2491c

mstarzinger@chromium.org authored May 29, 2013

R=dcarney@chromium.org
TEST=mozilla/js1_5/Regress/regress-367561-01

Review URL: https://codereview.chromium.org/15690018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14887 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e8e2491c

Convert ToBooleanStub to a HydrogenStub. Currently just using the existing... · 88755fb2

olivf@chromium.org authored May 29, 2013

Convert ToBooleanStub to a HydrogenStub. Currently just using the existing HBranch instruction, which is still fully implemented in Lithium. Will refactor HBranch in a next CL.

[
CL breaks mips, since the deoptimizer in Deoptimizer::DoTranslateCommand(...) does not convert smis passed to the stub via a0.
]

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/15302004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14886 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

88755fb2

Fix AccessArgumentsAt on ARM. Use register for index. · 9828a49b

verwaest@chromium.org authored May 29, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15690009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14885 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9828a49b

Improve range analysis for modulo operations. · 7bfe1436

svenpanne@chromium.org authored May 29, 2013

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/15952004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14884 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7bfe1436

Add support for //# sourceURL similar to deprecated //@ sourceURL one. · 09959efe

yurys@chromium.org authored May 29, 2013

BUG=v8:2702
R=yangguo@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/15859010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14883 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

09959efe

Make sure IfBuilder::Return clears the current block. · 39e9a903

mstarzinger@chromium.org authored May 29, 2013

This is a follow-up to an earlier bugfix. It doesn't yet trigger any
known bugs but is a safety precaution since IfBuilder usage increases.

R=jkummerow@chromium.org
BUG=chromium:243868

Review URL: https://codereview.chromium.org/15832005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14882 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

39e9a903

Update ASSERT on arm to support SmiOrTagged in ClampToUint8 · 2e21ff67

verwaest@chromium.org authored May 29, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15832004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14881 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2e21ff67

Fix two CPU profiler tests on ARM and MIPS simulators · 665c6449

yurys@chromium.org authored May 29, 2013

Use Simulator::get_pc instead of Simulator::get_register(pc) as the latter
will return value adjusted by Instruction::kPCReadOffset.

BUG=v8:2628
R=loislo@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/16154004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14880 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

665c6449

Make more GCs in idle notification handler. · fed3dad2

ulan@chromium.org authored May 29, 2013

When counting GCs in idle round, count only GC that were directly triggered by the idle notification handler.

R=hpayer@chromium.org
BUG=241815

Review URL: https://chromiumcodereview.appspot.com/15737007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14879 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fed3dad2

Ignore test262 data files downloaded by test harness. · 8b1bee05

mstarzinger@chromium.org authored May 29, 2013

R=jkummerow@chromium.org
Review by mail to v8-dev@googlegroups.com list.


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14878 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8b1bee05

Fix counting of scanned bytes in incremental marking step for large object. · 1b80e82f

ulan@chromium.org authored May 29, 2013

R=mstarzinger@chromium.org
BUG=241815

Review URL: https://chromiumcodereview.appspot.com/15745004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14877 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1b80e82f

Fix handle zapping interaction with NoHandleAllocation. · bc9bc0de

mstarzinger@chromium.org authored May 29, 2013

This makes sure that closed handle scopes are properly zapped even if an
enclosing NoHandleAllocation shrunk the limit. It also unifies the code
that performs scope closing for internal and external handle scopes.

R=svenpanne@chromium.org
TEST=cctest/test-api/NestedLockersNoTryCatch

Review URL: https://codereview.chromium.org/16004006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14876 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bc9bc0de

remove remaining V8_ALLOW_ACCESS_TO* defines from test classes · ccae2a75

dcarney@chromium.org authored May 29, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/16032010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14875 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ccae2a75

Don't explicitly pass requested representations to constants; implement ConstantS · 7d32e745

verwaest@chromium.org authored May 29, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15932011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14874 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7d32e745

Don't explicitly pass the Smi-representation to IfCompare. · 9b6aa956

verwaest@chromium.org authored May 29, 2013

BUG=
R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15891006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14873 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9b6aa956

Delete old GC related APIs. · f16ebc61

dcarney@chromium.org authored May 29, 2013

Blink doesn't use them any more, and they have no other known users either.

BUG=
R=dcarney@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/16124004

Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14872 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f16ebc61

Transforming PersistentHandleVisitor to not need to copy Persistent handles. · 515aec20

dcarney@chromium.org authored May 29, 2013

This gets rid of more places where Persistent handles are copied
(see crbug.com/236290 ).

Transition plan: after this CL, Blink will be modified to work both with and
without the #define, then the #define will be removed from V8.

The corresponding Blink side changes are in https://codereview.chromium.org/15670010/ .

BUG=
R=dcarney@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/15974006

Patch from Marja Hölttä <marja@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14871 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

515aec20

remove most remaining V8_ALLOW_ACCESS_TO* defines · fec64cd6

dcarney@chromium.org authored May 29, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/15994003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14870 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fec64cd6

fix return out of handlescope in NestedLockers · f8039eff

dcarney@chromium.org authored May 29, 2013

R=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/16076004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14869 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f8039eff

de-isolate remaining persistent calls · 7b82ad9b

dcarney@chromium.org authored May 29, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/16153003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7b82ad9b

Re-enable allocation-site-info test case. · 26e7936e

mstarzinger@chromium.org authored May 29, 2013

R=svenpanne@chromium.org
TEST=mjsunit/allocation-site-info

Review URL: https://codereview.chromium.org/16192002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14867 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

26e7936e

Disabled broken test · 116fe61f

svenpanne@chromium.org authored May 29, 2013

TBR=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/15951006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14866 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

116fe61f

28 May, 2013 11 commits

MIPS: Update the gap resolver to support Smi constants. · 0a6ad373

palfia@homejinni.com authored May 28, 2013

Port r14850 (787f0941)

BUG=

Review URL: https://codereview.chromium.org/16146005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14865 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0a6ad373

MIPS: Added old data space allocation infrastructure for pretenuring. · c5d0215e

palfia@homejinni.com authored May 28, 2013

Port r14843 (2d8faca3)

BUG=

Review URL: https://codereview.chromium.org/16155006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14864 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c5d0215e

MIPS: Support Smi in CompareIDAndBranch · 041257e5

palfia@homejinni.com authored May 28, 2013

Port r14842 (1c8d7430)

BUG=

Review URL: https://codereview.chromium.org/15917012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14863 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

041257e5

Disable --optimize-constructed-arrays due to crashes · cbdf760e

jkummerow@chromium.org authored May 28, 2013

BUG=chromium:244461
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/15766005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14860 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cbdf760e

Prepare push to trunk. Now working on version 3.19.7. · 27587d09

jkummerow@chromium.org authored May 28, 2013

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/16096003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14857 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

27587d09

Disable extra checks in Release mode. · b762c9d5

jkummerow@chromium.org authored May 28, 2013

They caused test failures and performance regressions.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/16158002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14856 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b762c9d5

Allow a relativ path to the NaCl SDK when building. · eb65ec06

machenbach@chromium.org authored May 28, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/16092004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14855 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eb65ec06

Fix IfBuilder::Deopt to clear the current block. · 3b114cdd

mstarzinger@chromium.org authored May 28, 2013

R=jkummerow@chromium.org
BUG=chromium:243868
TEST=mjsunit/regress/regress-crbug-243868

Review URL: https://codereview.chromium.org/16155003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14854 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3b114cdd

Enable extra checks for release builds as well · 6ebdc6df

jkummerow@chromium.org authored May 28, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/14899005

Patch from Jochen Eisinger <jochen@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14853 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6ebdc6df

Only allow non-double if the observed representations are int32. · 8276673a

verwaest@chromium.org authored May 28, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15988005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14852 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8276673a

Revert "Implement ObservedArrayPop, ObservedArrayShift, ObservedArrayUnshift & ObservedArraySplice" · ecb6bd27

rossberg@chromium.org authored May 28, 2013

This reverts commit r14846.

Broke Mozilla test (see http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/3608/steps/Mozilla/logs/stdio), e.g.:

=== mozilla/js1_5/Array/regress-451483 ===
--- stdout ---
BUGNUMBER: 451483
STATUS: [].splice.call(0) == []
/mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/data/js1_5/Array/regress-451483.js:57: illegal access
  var result = [].splice.call(0);
                         ^
Command: /mnt/data/b/build/slave/v8-linux-shared/build/v8/out/Release/d8 --test --nobreak-on-abort --nodead-code-elimination --nofold-constants --expose-gc /mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/mozilla-shell-emulation.js /mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/data/shell.js /mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/data/js1_5/shell.js /mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/data/js1_5/Array/shell.js /mnt/data/b/build/slave/v8-linux-shared/build/v8/test/mozilla/data/js1_5/Array/regress-451483.js

TBR=rafaelw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/16150003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14851 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ecb6bd27