- 07 Mar, 2016 22 commits
-
-
cbruni authored
Revert of [key-accumulator] Starting to reimplement the key-accumulator (patchset #14 id:260001 of https://codereview.chromium.org/1707743002/ ) Reason for revert: gcmole failure https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/8598 Original issue's description: > [key-accumulator] Starting to reimplement the key-accumulator > > Introducing the KeyAccumulator accidentally removed some crucial fast-paths. > This CL starts rewriting the KeyAccumulator, step-by-step introducing the > special cases again. > > BUG=chromium:545503, v8:4758 > LOG=y > > Committed: https://crrev.com/9c61327ecb2ee41f34232632e0cac93202bae6b7 > Cr-Commit-Position: refs/heads/master@{#34532} TBR=verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:545503, v8:4758 Review URL: https://codereview.chromium.org/1773593003 Cr-Commit-Position: refs/heads/master@{#34537}
-
verwaest authored
[runtime] JSObject::GetKeys never returns the EnumCache, so we don't need to copy in GetPropertyNames BUG=148757 LOG=n Review URL: https://codereview.chromium.org/1766293002 Cr-Commit-Position: refs/heads/master@{#34536}
-
ivica.bogosavljevic authored
Fixed a few errors in implementation of FastNewObjectStub::Generate for MIPS64 that cause a hadnfull of tests to fail. TEST=cctest/test-heap-profiler/TrackBumpPointerAllocations BUG= Review URL: https://codereview.chromium.org/1773533002 Cr-Commit-Position: refs/heads/master@{#34535}
-
ahaas authored
Instead of using CheckFloatEq and CheckDoubleEq directly, I introduced a macro which first stores the expected result in a volatile variable. Here are some comments of previous CLs: The reason is same as the CL #31808 (issue 1430943002, X87: Change the test case for X87 float operations), please refer: https://codereview.chromium.org/1430943002/. Here is the key comments from CL #31808 Some new test cases use CheckFloatEq(...) and CheckDoubleEq(...) function for result check. When GCC compiling the CheckFloatEq() and CheckDoubleEq() function, those inlined functions has different behavior comparing with GCC ia32 build and x87 build. The major difference is sse float register still has single precision rounding semantic. While X87 register has no such rounding precsion semantic when directly use register value. The V8 turbofan JITTed has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the same precision for RunCallInt64ToFloat32/RunCallInt64ToFloat64. Such as: volatile double expect = static_cast<float>(*i). R=titzer@chromium.org, weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1773513002 Cr-Commit-Position: refs/heads/master@{#34534}
-
ishell authored
This is a prerequisite for teaching deoptimizer to drop possible arguments adapter frame below current input frame which is needed to support tail call inlining. Review URL: https://codereview.chromium.org/1761303002 Cr-Commit-Position: refs/heads/master@{#34533}
-
cbruni authored
Introducing the KeyAccumulator accidentally removed some crucial fast-paths. This CL starts rewriting the KeyAccumulator, step-by-step introducing the special cases again. BUG=chromium:545503, v8:4758 LOG=y Review URL: https://codereview.chromium.org/1707743002 Cr-Commit-Position: refs/heads/master@{#34532}
-
yangguo authored
R=rossberg@chromium.org BUG=v8:4807 LOG=N Review URL: https://codereview.chromium.org/1768973002 Cr-Commit-Position: refs/heads/master@{#34531}
-
titzer authored
R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1766323002 Cr-Commit-Position: refs/heads/master@{#34530}
-
yangguo authored
NOTRY=true TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1773573002 Cr-Commit-Position: refs/heads/master@{#34529}
-
yangguo authored
Character ranges starting at 1 are not correctly negated. R=jkummerow@chromium.org BUG=chromium:592343 LOG=Y Review URL: https://codereview.chromium.org/1768093002 Cr-Commit-Position: refs/heads/master@{#34528}
-
mythria authored
TestNotEqualsStrict is converted to a TestEqualsStrict and logical not by the parser. Also, CompareIC does not have an implementation for TestNotEqualsStrict. Hence, removing this bytecode. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1768593002 Cr-Commit-Position: refs/heads/master@{#34527}
-
mstarzinger authored
The enum in question is (and should) no longer be used outside of the compiler API and hence is being moved back into the Compiler class. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1762323002 Cr-Commit-Position: refs/heads/master@{#34526}
-
Ben L. Titzer authored
TBR=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/1769873002 . Cr-Commit-Position: refs/heads/master@{#34525}
-
Ben L. Titzer authored
TBR=machenbach@chromium.org BUG= Review URL: https://codereview.chromium.org/1772593002 . Cr-Commit-Position: refs/heads/master@{#34524}
-
machenbach authored
Reland of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (patchset #1 id:1 of https://codereview.chromium.org/1768963002/ ) Reason for revert: Fix landed in head. Original issue's description: > Revert of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (patchset #1 id:1 of https://codereview.chromium.org/1774463002/ ) > > Reason for revert: > [Sheriff] Problem is not fixed: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/8799 > > Original issue's description: > > [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. > > > > This is a reland of https://codereview.chromium.org/1762203002/ > > > > R=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org > > BUG= > > > > Committed: https://crrev.com/aa5770805060a347c6b650634c736ba34ab61728 > > Cr-Commit-Position: refs/heads/master@{#34519} > > TBR=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org,titzer@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= TBR=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1769863002 Cr-Commit-Position: refs/heads/master@{#34523}
-
machenbach authored
Revert of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (patchset #1 id:1 of https://codereview.chromium.org/1774463002/ ) Reason for revert: [Sheriff] Problem is not fixed: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/8799 Original issue's description: > [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. > > This is a reland of https://codereview.chromium.org/1762203002/ > > R=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org > BUG= > > Committed: https://crrev.com/aa5770805060a347c6b650634c736ba34ab61728 > Cr-Commit-Position: refs/heads/master@{#34519} TBR=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1768963002 Cr-Commit-Position: refs/heads/master@{#34522}
-
Ben L. Titzer authored
Cr-Commit-Position: refs/heads/master@{#34521}
-
hablich authored
Revert of Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage (patchset #1 id:1 of https://codereview.chromium.org/1762313002/ ) Reason for revert: Breaks roll https://codereview.chromium.org/1768073002/ : https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/191035 Original issue's description: > Use v8::kGCCallbackFlagCollectAllAvailableGarbage in Heap::CollectAllAvailableGarbage > > Now that the embedder side supports v8::kGCCallbackFlagCollectAllAvailableGarbage, > this CL removes the old v8::kGCCallbackFlagForced from Heap::CollectAllAvailableGarbage. > > BUG=591463 > LOG=Y > > Committed: https://crrev.com/2436674c97f9e0bbc46a4bd75317e6470b4e720d > Cr-Commit-Position: refs/heads/master@{#34517} TBR=jochen@chromium.org,haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591463 Review URL: https://codereview.chromium.org/1771753002 Cr-Commit-Position: refs/heads/master@{#34520}
-
titzer authored
This is a reland of https://codereview.chromium.org/1762203002/ R=ahaas@chromium.org,binji@chromium.org,seththompson@chromium.org BUG= Review URL: https://codereview.chromium.org/1774463002 Cr-Commit-Position: refs/heads/master@{#34519}
-
jarin authored
Review URL: https://codereview.chromium.org/1772563002 Cr-Commit-Position: refs/heads/master@{#34518}
-
haraken authored
Now that the embedder side supports v8::kGCCallbackFlagCollectAllAvailableGarbage, this CL removes the old v8::kGCCallbackFlagForced from Heap::CollectAllAvailableGarbage. BUG=591463 LOG=Y Review URL: https://codereview.chromium.org/1762313002 Cr-Commit-Position: refs/heads/master@{#34517}
-
zhengxing.li authored
port 5912e0f0(r34485) original commit message: Add StringLessThanStub, StringLessThanOrEqualStub, StringGreaterThanStub and StringGreaterThanOrEqualStub, based on the CodeStubAssembler, and hook them up with TurboFan (and Ignition). The stubs are currently essentially comparable with the StringCompareStub, which is now obsolete. We can later extend these stubs to cover more interesting cases (i.e. two byte sequential string comparisons, etc.). BUG= Review URL: https://codereview.chromium.org/1768013002 Cr-Commit-Position: refs/heads/master@{#34516}
-
- 06 Mar, 2016 1 commit
-
-
neis authored
Now there is just one kind, corresponding to what was called "initial" before. Replacement for "suspend": when the parser sees a yield in JS code, it will turn it into a Yield node but wrap its argument in an iterator result object. Replacement for "final": the parser simply inserts a return statement instead. R=littledan@chromium.org, mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1751613004 Cr-Commit-Position: refs/heads/master@{#34515}
-
- 05 Mar, 2016 3 commits
-
-
adamk authored
Revert of [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. (patchset #2 id:20001 of https://codereview.chromium.org/1762203002/ ) Reason for revert: New test test-wasm-module-builder fails on Linux - shared bot: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/8793 Original issue's description: > [wasm] Add a JavaScript utility to make it easier to build WASM modules from JavaScript. > > R=binji@chromium.org,seththompson@chromium.org > BUG= > > Committed: https://crrev.com/d130c6bdc6a424b068614592a0b79a34750af0fc > Cr-Commit-Position: refs/heads/master@{#34513} TBR=binji@chromium.org,seththompson@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1771553002 Cr-Commit-Position: refs/heads/master@{#34514}
-
titzer authored
R=binji@chromium.org,seththompson@chromium.org BUG= Review URL: https://codereview.chromium.org/1762203002 Cr-Commit-Position: refs/heads/master@{#34513}
-
jfb authored
Dropped the change from my previous CL which bisecting Windows failure. R= titzer@chromium.org Review URL: https://codereview.chromium.org/1760243002 Cr-Commit-Position: refs/heads/master@{#34512}
-
- 04 Mar, 2016 14 commits
-
-
titzer authored
R=rossberg@chromium.org,binji@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1764723002 Cr-Commit-Position: refs/heads/master@{#34511}
-
mtrofin authored
BUG= Review URL: https://codereview.chromium.org/1758033002 Cr-Commit-Position: refs/heads/master@{#34510}
-
mtrofin authored
It benefits certain algorithms in register allocation to assume the input is SSA - understanding that ResolvePhis in the regalloc pipeline lowers phis, thus blurring the SSA invariant. BUG= Review URL: https://codereview.chromium.org/1760323002 Cr-Commit-Position: refs/heads/master@{#34509}
-
mbrandy authored
Port 5912e0f0 Original commit message: Add StringLessThanStub, StringLessThanOrEqualStub, StringGreaterThanStub and StringGreaterThanOrEqualStub, based on the CodeStubAssembler, and hook them up with TurboFan (and Ignition). The stubs are currently essentially comparable with the StringCompareStub, which is now obsolete. We can later extend these stubs to cover more interesting cases (i.e. two byte sequential string comparisons, etc.). R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1761403002 Cr-Commit-Position: refs/heads/master@{#34508}
-
mtrofin authored
It seems we produce both the usual add as well as the add with overflow, when we should only generate the overflow variant. This invalidates SSA assumptions in 2 tests (cctest/test-run-machops/RunInt32AddWithOverflowImm and cctest/test-run-machops/RunInt64AddWithOverflowImm). BUG= Review URL: https://codereview.chromium.org/1757213003 Cr-Commit-Position: refs/heads/master@{#34507}
-
binji authored
Reland of https://codereview.chromium.org/1765673002 R=titzer@chromium.org R=bradnelson@chromium.org LOG=n BUG= Review URL: https://codereview.chromium.org/1761173003 Cr-Commit-Position: refs/heads/master@{#34506}
-
mbrandy authored
For platforms that use function descriptors (currently AIX and PPC64BE), log an external callback's entrypoint address rather than its function descriptor address. R=jkummerow@chromium.org, michael_dawson@ca.ibm.com TEST=cctest/test-cpu-profiler/JsNativeJsSample BUG= Review URL: https://codereview.chromium.org/1752173003 Cr-Commit-Position: refs/heads/master@{#34505}
-
dgozman authored
This scope is used to control microtasks execution when MicrotasksPolicy::kScoped is engaged. Attempt #2. First one was reverted due to chromium breakage: SetAutorunMicrotasks(false) was broken. BUG=chromium:585949 LOG=Y TEST=ScopedMicrotasks Review URL: https://codereview.chromium.org/1741893003 Cr-Commit-Position: refs/heads/master@{#34504}
-
mstarzinger authored
This adds more comments to the V8 compiler API explaining the entry methods within that API. It also establishes a separate method for OSR compilation since {Compiler::GetOptimizedCode} is only used for OSR by now. R=danno@chromium.org Review URL: https://codereview.chromium.org/1769523002 Cr-Commit-Position: refs/heads/master@{#34503}
-
machenbach authored
Revert of Reland "[api] Don't go to javascript to construct API functions" (patchset #1 id:1 of https://codereview.chromium.org/1756973002/ ) Reason for revert: [Sheriff] Breaks blink tests. Please fix upstream first. https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5125 Original issue's description: > Reland "[api] Don't go to javascript to construct API functions" > > BUG= > R=verwaest@chromium.org > > Committed: https://crrev.com/d5d4f0b80f585878130bffb40ff8e960646823d8 > Cr-Commit-Position: refs/heads/master@{#34496} TBR=verwaest@chromium.org,bmeurer@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1767663002 Cr-Commit-Position: refs/heads/master@{#34502}
-
jyan authored
R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1762743002 Cr-Commit-Position: refs/heads/master@{#34501}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1765633004 Cr-Commit-Position: refs/heads/master@{#34500}
-
fmeawad authored
The Tracing split CL https://codereview.chromium.org/1707563002 mostly moved the location of the TRACE call, but it added 2 very high frequency calls related to tracking V8.External. In most benchmark and devices the added overhead is negligible except on N6 where it gets amplified. This CL removes those 2 calls until more efficient tracing or a different technique is used. BUG=588137 LOG=N Review URL: https://codereview.chromium.org/1765673003 Cr-Commit-Position: refs/heads/master@{#34499}
-
neis authored
BUG=chromium:591699 LOG=n R=rossberg Review URL: https://codereview.chromium.org/1764953002 Cr-Commit-Position: refs/heads/master@{#34498}
-