1. 22 Nov, 2018 38 commits
  2. 21 Nov, 2018 2 commits
    • Ross McIlroy's avatar
      [AsmJs] Avoid allocation of WasmModuleObject until instantiation. · ccd8073c
      Ross McIlroy authored
      Moves allocation of the WasmModuleObject for asm.js code out of SyncCompileTranslatedAsmJS
      since that is called when we are compiling the native context independent SharedFunctionInfo
      and the WasmModuleObject requires a native context. Instead save the members required to
      create the object in the AsmWasmData and create it during module instantiation. Note:
      since the Wasm module is an implementation detail for asm_wasm code and isn't exposed,
      this doeesn't have semantic change for asm.js code.
      
      As part of this change, the AsmWasmData is changed from a FixedArray to a dedicated
      struct. Some logic is also moved from module-compiler to wasm-engine to make the
      seperation between Wasm SyncCompile and AsmJS SyncCompile more clear.
      
      BUG=chromium:900535,v8:8395
      
      Change-Id: Ia48469c095b0688f210aa86e7430c9ab4ea4b26b
      Reviewed-on: https://chromium-review.googlesource.com/c/1345509
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57704}
      ccd8073c
    • Erik Luo's avatar
      [inspector] console.table should not crash on empty preview · 54f92d52
      Erik Luo authored
      Types such as "function" have a ValueMirror that does not override
      "buildObjectPreview()". This CL updates clients to check that the
      preview was actually built after call it.
      
      Bug: chromium:907400
      Change-Id: Id569c98363d47b259a40790b596efedb3d14abc2
      Reviewed-on: https://chromium-review.googlesource.com/c/1347067Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
      Commit-Queue: Erik Luo <luoe@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57703}
      54f92d52