- 20 Feb, 2018 12 commits
-
-
Yang Guo authored
Until now lookbehind assertions have been quantifiable in non-unicode regexps. This seems to be an oversight in the spec. R=jgruber@chromium.org Bug: v8:7462 Change-Id: Iad0db441089c7510dd2c42a861db92c05545ce1e Reviewed-on: https://chromium-review.googlesource.com/926102 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#51392}
-
Yang Guo authored
R=bmeurer@chromium.org Bug: v8:7421 Change-Id: Iacdd8d294c02b7feb72e3a0bb397930e91197ae7 Reviewed-on: https://chromium-review.googlesource.com/926124 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51391}
-
Benedikt Meurer authored
This makes the inlining of the default resolve/reject closures generated by the Promise constructor effective. To be really useful we still need to have the Promise constructor inlined (work-in-progress) and eventually track SharedFunctionInfo feedback in the CALL_IC. Bug: v8:2206, v8:7253 Change-Id: I08fa8ca72754f459ae36027a55377ef57d411cdc Reviewed-on: https://chromium-review.googlesource.com/926103 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#51390}
-
Peter Marshall authored
Inline the promise constructor when we have one argument and target matches new_target. This is not complete, and is sitting behind an experimental flag for now. We need to fix deoptimization by providing proper frame states. Create a unittest class for JSCallReducer - just assert whether there was a change or not, rather than specify the exact graph that should be produced. Bug: v8:7253 Change-Id: Ib6886a8feb2799f47cd647853cabcf12a189bc25 Reviewed-on: https://chromium-review.googlesource.com/919282 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Stephan Herhut authored
Adds support for generating logging/profiling event when wasm code gets compiled on the native heap. As code objects on the native heap are not ordinary heap objects, the existing abstractions for reporting cannot be used. Instead, add specialized versions for WasmCode objects. Change-Id: I808618d70142073b3c1b06edef6931f59bed8cf5 Reviewed-on: https://chromium-review.googlesource.com/913308 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#51388}
-
Benedikt Meurer authored
This CL introduces new operators JSFulfillPromise and JSPromiseResolve, corresponding to the specification operations with the same name, and uses that to lower calls to Promise.resolve() builtin to JSPromiseResolve. We also optimize JSPromiseResolve and JSResolvePromise further based on information found about the value/resolution in the graph. This applies to both Promise.resolve() builtin calls and implicit resolve operations in async functions and async generators. On a very simple microbenchmark like console.time('resolve'); for (let i = 0; i < 1e8; ++i) Promise.resolve({i}); console.timeEnd('resolve'); this CL reduces the execution time from around 3049ms to around 947ms, which is a pretty significant 3x improvement. On the wikipedia benchmark we observe an improvement around 2% with this CL. Bug: v8:7253 Change-Id: Ic69086cdc1b724f35dbe83305795539c562ab817 Reviewed-on: https://chromium-review.googlesource.com/913488Reviewed-by:Georg Neis <neis@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#51387}
-
Deepti Gandluri authored
Change-Id: Icfacb59e7c90ee696fd7242f4441cfb2965f490b Reviewed-on: https://chromium-review.googlesource.com/924626Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#51386}
-
Clemens Hammacher authored
Remove code duplication by having one method for generating the code for binary operations, templatized by the actual instruction(s) to emit for the operation. R=titzer@chromium.org Bug: v8:6600 Change-Id: I6303475682416727e6a6c9c4ec33ca1cde112092 Reviewed-on: https://chromium-review.googlesource.com/924862Reviewed-by:
-
Sigurd Schneider authored
This ensures that breaking on inlined builtins works, even when compiling concurrently. This CL also introduces the member Isolate::AbortConcurrentOptimization. R=sigurds@chromium.org Bug: v8:178 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ie6cbb48ebde18036888af2dd715862e7a14ddf9d Reviewed-on: https://chromium-review.googlesource.com/912468 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#51384}
-
Mostyn Bramley-Moore authored
Followup after https://chromium-review.googlesource.com/c/v8/v8/+/919063 Bug: chromium:811842 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8e8a4a6d9192d39502514c5a19539965b74b1681 Reviewed-on: https://chromium-review.googlesource.com/925603Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#51383}
-
Benedikt Meurer authored
There's no need to have the AsyncFunctionAwait/AsyncGeneratorAwait operations as separate closures that are called via JavaScript calling convention, but instead we can just have them as intrinsics (with the goal to eventually turn them into IC stubs). Drive-by-fix: Tail call to the ResumeGenerator builtin when resuming an async function. The earlier restrictions no only apply with the new machinery. Bug: v8:7253 Change-Id: I0c4d04dae15b4211158fc07151adafda69d4faec Reviewed-on: https://chromium-review.googlesource.com/924703Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e2c6aae..10345cd Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4aa92ef..8273e47 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iabdb565357af2ab1a156b013068230a58377b69e Reviewed-on: https://chromium-review.googlesource.com/925805 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#51381}
-
- 19 Feb, 2018 28 commits
-
-
Clemens Hammacher authored
The "FreezeWasmLazyCompilation" runtime function can only be invoked if --wasm-lazy-compilation is passed. Hence the "lazy-compilation.js" test must be skipped. The other tests are not affected by this, thus un-skip them. R=machenbach@chromium.org Bug: v8:7400 Change-Id: Id521938ae651b4a67510e42aa69e17b5e0b14a0a Reviewed-on: https://chromium-review.googlesource.com/923967 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#51380}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ia7c18afb10b4198b690b3bc788b8969595d6b0de Reviewed-on: https://chromium-review.googlesource.com/925303 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Change-Id: Idbee9b7b8077a9fd2ffa4a2a010ae7d44b98e31e Reviewed-on: https://chromium-review.googlesource.com/924198 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Peter Marshall authored
Factor out IterableToList into a helper stub to save space. There are two callers now, TypedArrayFrom and ConstructByIterable, and it is ~2.5kb so we save space by doing this. Increase test coverage to cover more of the branching in CSA. This is doesn't follow the control flow in the spec exactly - see the big code comment for an explanation. Change-Id: Ief39e93c4202cb7bf0e28a39dc6aa81b8b9c59d2 Reviewed-on: https://chromium-review.googlesource.com/908755 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
sreten.kovacevic authored
Implement i32 binops, unops and shiftops on MIPS architecture. Bug: v8:6600 Change-Id: Ibd17f840e6754c9eac2fb0bc61c3461e42734703 Reviewed-on: https://chromium-review.googlesource.com/919161 Commit-Queue: Sreten Kovacevic <sreten.kovacevic@mips.com> Reviewed-by:
-
Clemens Hammacher authored
The result of an f64 binop was marked as f32 on Liftoffs value stack. This lead to errors and is fixed in this CL. I plan to clean up all binop implementions in a follow-up CL. R=titzer@chromium.org Bug: chromium:812005, v8:6600 Change-Id: I5bcd5c2e7d2b6170ef60f5e83cf2876b3475c38a Reviewed-on: https://chromium-review.googlesource.com/924025Reviewed-by:
-
Tobias Tebbi authored
This introduces masking of loads with speculation bit during code generation. At the moment, this is done only under the --branch-load-poisoning flag, and this CL enlarges the set of supported platforms from {x64} to {x64, arm}. Overview of changes: - new register configuration configuration with one register reserved for the speculation poison/mask (kSpeculationPoisonRegister). - in codegen, we introduce an update to the poison register at the starts of all successors of branches (and deopts) that are marked as safety branches (deopts). - in memory optimizer, we lower all field and element loads to PoisonedLoads. - poisoned loads are then masked in codegen with the poison register. * only integer loads are masked at the moment. Bug: chromium:798964 Change-Id: I37f5531fd18a96038ea8b059641e3dfc852c2d34 Reviewed-on: https://chromium-review.googlesource.com/913354 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: -
Caitlin Potter authored
Previously, eval caching was only disabled if the root eval body code contained a tagged template. Per discussion on https://github.com/tc39/ecma262/pull/890, this is incorrect. This change tracks if eval caching is allowed during parsing, and uses this information to decide to insert new entries into the cache, or not. This change also removes the TemplateObject feedback kind, as it's no longer needed (behaves the same as Literal feedback). BUG=v8:3230, v8:2891 R=littledan@chromium.org, yangguo@chromium.org, bmeurer@chromium.org, rmcilroy@chromium.org Change-Id: Ib75abe9159baf4d8ad10f8de99d2152714bd0094 Reviewed-on: https://chromium-review.googlesource.com/916945 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Reland reason : not the culprit. This will let us identify in traces whether unwinding after receiving the preemption event is slower than desired and should be optimized. Adding it to pausing while working on removing it in https://chromium-review.googlesource.com/c/v8/v8/+/922103 will allow gathering traces that highlight the issue. R=ulan@chromium.org Bug: chromium:812178 Change-Id: I0dc0f6754980157674968ba4a868f12c779e69bc Reviewed-on: https://chromium-review.googlesource.com/923989Reviewed-by:
-
Gabriel Charette authored
This is a reland of f4b41099. Not expected to be the culprit of the 4 CL revert. Original change's description: > Introduce ConcurrentMarking::StopRequest API. > > This was extracted from https://chromium-review.googlesource.com/c/v8/v8/+/924073/10 > after it became clear that using COMPLETE_TASKS/PREEMPT_TASKS where > it should make sense to doesn't work in practice for now. > > Experimental CLs which led to the above conclusion: > - https://chromium-review.googlesource.com/c/v8/v8/+/924865 > (COMPLETE or CANCEL -- still broken) > - https://chromium-review.googlesource.com/c/v8/v8/+/924866 > (CANCEL only, as before, works) > - https://chromium-review.googlesource.com/c/v8/v8/+/924028 > (CANCEL and PREEMPT -- broken as well) > > Introducing this unittested API allows to reduce the size > of the CLs causing hard-to-diagnose bots-only failures > and fix them individually follow-ups @ > > 1) https://chromium-review.googlesource.com/c/v8/v8/+/924029 > 2) https://chromium-review.googlesource.com/c/v8/v8/+/924031 > 3) https://chromium-review.googlesource.com/c/v8/v8/+/924030 > > Bug: chromium:812178 > Change-Id: Icdac456e9f7874b0c4b321ccdb8898297dad7d73 > Reviewed-on: https://chromium-review.googlesource.com/924867 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51353} Bug: chromium:812178 Change-Id: Iaa32f9cc6b2fa7004c7fae1f79aa4b00f5f8f34c Reviewed-on: https://chromium-review.googlesource.com/924006Reviewed-by:
-
Clemens Hammacher authored
There is a debug check to check that an embedded code object is patched correctly. This check only makes sense if the code object was indeed pushed to the stack, otherwise we are checking the type marker. This CL fixes this check and adds a line of documentation. R=mstarzinger@chromium.org Change-Id: I5bc1454232cdbf2e9fef6eb41f7c7a20f31a5250 Reviewed-on: https://chromium-review.googlesource.com/924154 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:7456 Change-Id: I5b7c151d375267a6a8a24c611b8a13fe38619656 Reviewed-on: https://chromium-review.googlesource.com/924036Reviewed-by:
-
Clemens Hammacher authored
This implements the br_table instruction in LiftoffCompiler by emitting a binary search tree. R=titzer@chromium.org Bug: v8:6600 Change-Id: I89c11501dd3a41556d2fab68af1afbe8c4855d36 Reviewed-on: https://chromium-review.googlesource.com/921641 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Stephan Herhut authored
Set the VMA address for jitted code to the address of the code. This should be the correct value, as the code got loaded to that address at runtime. Change-Id: I6ce9181d940dd4568d93a92e98d206f3c6546ebc Reviewed-on: https://chromium-review.googlesource.com/915923Reviewed-by:
-
sreten.kovacevic authored
Since these instructions will be used in liftoff as well as they are used in code generator, they are transfered to macro assembler. Change-Id: I48e60ccc7586252374bc66b7b72bbe23c2d0c0a6 Reviewed-on: https://chromium-review.googlesource.com/924194Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#51366}
-
Clemens Hammacher authored
This reverts commit f4b41099. Reason for revert: Several GC failures, e.g. https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/23236, https://build.chromium.org/p/client.v8/builders/V8%20Mac/builds/18390 Original change's description: > Introduce ConcurrentMarking::StopRequest API. > > This was extracted from https://chromium-review.googlesource.com/c/v8/v8/+/924073/10 > after it became clear that using COMPLETE_TASKS/PREEMPT_TASKS where > it should make sense to doesn't work in practice for now. > > Experimental CLs which led to the above conclusion: > - https://chromium-review.googlesource.com/c/v8/v8/+/924865 > (COMPLETE or CANCEL -- still broken) > - https://chromium-review.googlesource.com/c/v8/v8/+/924866 > (CANCEL only, as before, works) > - https://chromium-review.googlesource.com/c/v8/v8/+/924028 > (CANCEL and PREEMPT -- broken as well) > > Introducing this unittested API allows to reduce the size > of the CLs causing hard-to-diagnose bots-only failures > and fix them individually follow-ups @ > > 1) https://chromium-review.googlesource.com/c/v8/v8/+/924029 > 2) https://chromium-review.googlesource.com/c/v8/v8/+/924031 > 3) https://chromium-review.googlesource.com/c/v8/v8/+/924030 > > Bug: chromium:812178 > Change-Id: Icdac456e9f7874b0c4b321ccdb8898297dad7d73 > Reviewed-on: https://chromium-review.googlesource.com/924867 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51353} TBR=gab@chromium.org,ulan@chromium.org,mlippautz@chromium.org Change-Id: Ia001cc81c6a7bc030b54d3aa9b9bcecc833300e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:812178 Reviewed-on: https://chromium-review.googlesource.com/925302Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 4b49f844. Reason for revert: Several GC failures, e.g. https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/23236, https://build.chromium.org/p/client.v8/builders/V8%20Mac/builds/18390 Original change's description: > Add a trace event when pausing/preempting concurrent marking. > > This will let us identify in traces whether unwinding after receiving > the preemption event is slower than desired and should be optimized. > > Adding it to pausing while working on removing it in > https://chromium-review.googlesource.com/c/v8/v8/+/922103 > will allow gathering traces that highlight the issue. > > R=mlippautz@chromium.org > > Bug: chromium:812178 > Change-Id: I0555c6825e0792769c9ae2d748d7cc35df4f6fed > Reviewed-on: https://chromium-review.googlesource.com/924122 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51354} TBR=gab@chromium.org,mlippautz@chromium.org Change-Id: I37a82e488de51d5ae4d7ed795b82ea9649c4a5f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:812178 Reviewed-on: https://chromium-review.googlesource.com/924426Reviewed-by:
-
Clemens Hammacher authored
This reverts commit e9750cb8. Reason for revert: Several GC failures, e.g. https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/23236, https://build.chromium.org/p/client.v8/builders/V8%20Mac/builds/18390 Original change's description: > Preempt ConcurrentMarking tasks instead of merely pausing in PauseScope. > > Follow-up to https://chromium-review.googlesource.com/c/v8/v8/+/924867 > > This is the core goal of the initial CL @ > https://chromium-review.googlesource.com/c/v8/v8/+/922103 > which was since split into multiple to diagnose a bots-only failure. > > Bug: chromium:812178 > Change-Id: I4c4e0b517737e020862917bd89fa6ce38244e597 > Reviewed-on: https://chromium-review.googlesource.com/924031 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51356} TBR=gab@chromium.org,ulan@chromium.org,mlippautz@chromium.org Change-Id: Ic095e32708e58acbe5955bf29e65af34c59d321e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:812178 Reviewed-on: https://chromium-review.googlesource.com/925301Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 8b53b9d9. Reason for revert: Several GC failures, e.g. https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/23236, https://build.chromium.org/p/client.v8/builders/V8%20Mac/builds/18390 Original change's description: > Preempt ConcurrentMarking tasks ASAP when cancelling marking. > > Follow-up to https://chromium-review.googlesource.com/c/v8/v8/+/924867 > > Bug: chromium:812178 > Change-Id: I2abe28c6e953df42cffdcbd7ea35df9d29849905 > Reviewed-on: https://chromium-review.googlesource.com/924030 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#51357} TBR=gab@chromium.org,ulan@chromium.org,mlippautz@chromium.org Change-Id: Ic4e226fdd02d8259244cef46e9923c95e6606cc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:812178 Reviewed-on: https://chromium-review.googlesource.com/924425Reviewed-by:
-
Benedikt Meurer authored
This extends the previously introduced logic for implementing await without having to allocate the throwaway promise and the additional closures and context, to also cover await and yield inside of async generators. Bug: v8:7253 Change-Id: I011583a7714bbd148c54e5f204e2076630008db0 Reviewed-on: https://chromium-review.googlesource.com/924003 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:811842 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I72163abf0b20b123fb541fe0a1b168e036ef044e Reviewed-on: https://chromium-review.googlesource.com/919063 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#51360}
-
Peter Marshall authored
Change-Id: Id616646bbeebe91e3e575d40799f01611a57643f Reviewed-on: https://chromium-review.googlesource.com/924281Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#51359}
-
Ulan Degenbaev authored
This adds PersistentBase::AnnotateStrongRetainer(const char*) function. The annotation is used by the heap snapshot generator to show the edges from the (Global handles) root to the global handles. Bug: chromium:811842 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I1a9e3e53a53aeaf2b590709fab8dd4ecf7e8f252 Reviewed-on: https://chromium-review.googlesource.com/916788 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Follow-up to https://chromium-review.googlesource.com/c/v8/v8/+/924867 Bug: chromium:812178 Change-Id: I2abe28c6e953df42cffdcbd7ea35df9d29849905 Reviewed-on: https://chromium-review.googlesource.com/924030 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Follow-up to https://chromium-review.googlesource.com/c/v8/v8/+/924867 This is the core goal of the initial CL @ https://chromium-review.googlesource.com/c/v8/v8/+/922103 which was since split into multiple to diagnose a bots-only failure. Bug: chromium:812178 Change-Id: I4c4e0b517737e020862917bd89fa6ce38244e597 Reviewed-on: https://chromium-review.googlesource.com/924031 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#51356}
-
Predrag Rudic authored
Change-Id: I101cd4eea87f17a1454c3e2b39c421e304509e61 Reviewed-on: https://chromium-review.googlesource.com/919085 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This will let us identify in traces whether unwinding after receiving the preemption event is slower than desired and should be optimized. Adding it to pausing while working on removing it in https://chromium-review.googlesource.com/c/v8/v8/+/922103 will allow gathering traces that highlight the issue. R=mlippautz@chromium.org Bug: chromium:812178 Change-Id: I0555c6825e0792769c9ae2d748d7cc35df4f6fed Reviewed-on: https://chromium-review.googlesource.com/924122 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This was extracted from https://chromium-review.googlesource.com/c/v8/v8/+/924073/10 after it became clear that using COMPLETE_TASKS/PREEMPT_TASKS where it should make sense to doesn't work in practice for now. Experimental CLs which led to the above conclusion: - https://chromium-review.googlesource.com/c/v8/v8/+/924865 (COMPLETE or CANCEL -- still broken) - https://chromium-review.googlesource.com/c/v8/v8/+/924866 (CANCEL only, as before, works) - https://chromium-review.googlesource.com/c/v8/v8/+/924028 (CANCEL and PREEMPT -- broken as well) Introducing this unittested API allows to reduce the size of the CLs causing hard-to-diagnose bots-only failures and fix them individually follow-ups @ 1) https://chromium-review.googlesource.com/c/v8/v8/+/924029 2) https://chromium-review.googlesource.com/c/v8/v8/+/924031 3) https://chromium-review.googlesource.com/c/v8/v8/+/924030 Bug: chromium:812178 Change-Id: Icdac456e9f7874b0c4b321ccdb8898297dad7d73 Reviewed-on: https://chromium-review.googlesource.com/924867 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
