- 10 Dec, 2015 1 commit
-
-
mlippautz authored
R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1510213002 Cr-Commit-Position: refs/heads/master@{#32739}
-
- 13 Nov, 2015 1 commit
-
-
ishell authored
This CL introduces the following visitors: 1) RecordMigratedSlotVisitor which simplifies MarkCompactCollector::MigrateObject(). 2) IteratePointersToFromSpaceVisitor which simplifies Heap::IteratePointersToFromSpace(). 3) FindPointersToNewSpaceVisitor which simplifies StoreBuffer::IteratePointersToNewSpace(). These changes make the object's body descriptors the one and only place that knows how to traverse the object. Review URL: https://codereview.chromium.org/1441453002 Cr-Commit-Position: refs/heads/master@{#31992}
-
- 30 Sep, 2015 1 commit
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
- 26 Aug, 2015 1 commit
-
-
hpayer authored
BUG=chromium:524425 LOG=n Review URL: https://codereview.chromium.org/1313313002 Cr-Commit-Position: refs/heads/master@{#30383}
-
- 25 Aug, 2015 1 commit
-
-
mstarzinger authored
R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1317553002 Cr-Commit-Position: refs/heads/master@{#30355}
-
- 21 Aug, 2015 1 commit
-
-
mstarzinger authored
R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1309733002 Cr-Commit-Position: refs/heads/master@{#30304}
-
- 16 Mar, 2015 2 commits
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1009323002 Cr-Commit-Position: refs/heads/master@{#27214}
-
ishell authored
Revert of Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. (patchset #3 id:40001 of https://codereview.chromium.org/988363002/) Reason for revert: Increased rate of Chrome crashes. Requires further investigation. Original issue's description: > Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. > > The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297, chromium:465273 > LOG=Y > > Committed: https://crrev.com/6d0677d845c47ab9fa297de61d0e3d8e5480a02a > Cr-Commit-Position: refs/heads/master@{#27141} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297, chromium:465273 Review URL: https://codereview.chromium.org/1004623003 Cr-Commit-Position: refs/heads/master@{#27207}
-
- 11 Mar, 2015 1 commit
-
-
ishell authored
The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). This CL also adds useful machinery that helps triggering incremental write barriers. BUG=chromium:454297, chromium:465273 LOG=Y Review URL: https://codereview.chromium.org/988363002 Cr-Commit-Position: refs/heads/master@{#27141}
-
- 10 Mar, 2015 1 commit
-
-
hpayer authored
We can do that now since we have the invariant that the store buffer always has valid slots after marking. BUG= Review URL: https://codereview.chromium.org/991853002 Cr-Commit-Position: refs/heads/master@{#27105}
-
- 09 Mar, 2015 2 commits
-
-
hpayer authored
The store buffer can contain stale store buffer entries, i.e., slot in dead objects pointing to new space objects. These slots are treaded as live slots which cause problems with non-pointer fields and makes concurrent sweeping complicated. Removing these pointers from the store buffer before it is used makes life easier. BUG= Review URL: https://codereview.chromium.org/985453003 Cr-Commit-Position: refs/heads/master@{#27068}
-
ishell@chromium.org authored
Revert of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. (patchset #4 id:230001 of https://codereview.chromium.org/957273002/) Reason for revert: It caused a lot of Canary crashes. Original issue's description: > Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. > > The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297 > LOG=Y > > Committed: https://crrev.com/9633ebabd405c264d33f603f8798c31f59418dcd > Cr-Commit-Position: refs/heads/master@{#27054} TBR=verwaest@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297 Review URL: https://codereview.chromium.org/991793002 Cr-Commit-Position: refs/heads/master@{#27063}
-
- 06 Mar, 2015 1 commit
-
-
ishell authored
The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). This CL also adds useful machinery that helps triggering incremental write barriers. BUG=chromium:454297 LOG=Y Review URL: https://codereview.chromium.org/957273002 Cr-Commit-Position: refs/heads/master@{#27054}
-
- 25 Feb, 2015 1 commit
-
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/946973008 Cr-Commit-Position: refs/heads/master@{#26844}
-
- 11 Aug, 2014 1 commit
-
-
hpayer@chromium.org authored
BUG= R=jochen@chromium.org Review URL: https://codereview.chromium.org/463523002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23046 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jul, 2014 1 commit
-
-
hpayer@chromium.org authored
BUG= R=jarin@chromium.org Review URL: https://codereview.chromium.org/387483002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22319 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Jul, 2014 1 commit
-
-
hpayer@chromium.org authored
BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/372193002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22267 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2014 1 commit
-
-
verwaest@chromium.org authored
Deserializing the partial snapshot may prematurely stop using a map page, adding a free-space filler at the end. Scan-on-scavenge of map-space did not expect anything but maps, and would interpret the uninitialized memory as pointers. Using the heap iterator we can skip over free space and only visit maps. BUG=390732 LOG=y R=hpayer@chromium.org Review URL: https://codereview.chromium.org/364063007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22208 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
Also split v8-core independent methods from checks.h to base/logging.h and merge v8checks with the rest of checks. The CPU::FlushICache method is moved to CpuFeatures::FlushICache RoundUp and related methods are moved to base/macros.h Remove all layering violations from src/libplatform BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/358363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 May, 2014 3 commits
-
-
jochen@chromium.org authored
> BUG=none > R=mstarzinger@chromium.org > LOG=n > > Review URL: https://codereview.chromium.org/293363006 BUG=none TBR=mstarzinger@chromium.org LOG=n Review URL: https://codereview.chromium.org/295373003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21490 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
Because of tree redness. TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/306443002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21483 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
BUG=none R=mstarzinger@chromium.org LOG=n Review URL: https://codereview.chromium.org/293363006 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21482 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 May, 2014 1 commit
-
-
jarin@chromium.org authored
Remove a race between sweepers and the free space skipping code (while iterating new space pointers). There has been a race between a sweeper setting the next pointer on free list node and the main thread skipping free space during update of new space pointers in the heap. This change removes the free space skipping code. R=hpayer@chromium.org BUG=370551 LOG=N Review URL: https://codereview.chromium.org/285733003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21306 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Jul, 2013 1 commit
-
-
hpayer@chromium.org authored
BUG= R=titzer@chromium.org Review URL: https://codereview.chromium.org/18998004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15616 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Jun, 2013 1 commit
-
-
hpayer@chromium.org authored
BUG= R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/16690006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15085 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Apr, 2013 1 commit
-
-
danno@chromium.org authored
std::sort is a template, so it can be inlined more aggressively. Also, it's O(n log n), while libc's qsort is O(n^2) BUG=2639 Review URL: https://codereview.chromium.org/14315005 Patch from Jochen Eisinger <jochen@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14406 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Nov, 2012 1 commit
-
-
danno@chromium.org authored
Review URL: https://codereview.chromium.org/11414207 Patch from Adam Klein <adamk@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13096 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Oct, 2012 1 commit
-
-
mvstanton@chromium.org authored
R=mstarzinger@chromium.org BUG=v8:2120 Review URL: https://codereview.chromium.org/11118018 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12713 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Jan, 2012 1 commit
-
-
erik.corry@gmail.com authored
Review URL: http://codereview.chromium.org/9139051 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10399 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Jan, 2012 1 commit
-
-
vegorov@chromium.org authored
R=erik.corry@gmail.com Review URL: http://codereview.chromium.org/8964025 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10334 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Dec, 2011 1 commit
-
-
erik.corry@gmail.com authored
memory use (2Mbyte on x64). Review URL: http://codereview.chromium.org/8776032 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10143 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Nov, 2011 1 commit
-
-
mstarzinger@chromium.org authored
This makes the store buffer size depend on the pointer size so that store buffers can hold the same number of entries on all architectures. The number of pages marked scan-on-scavenge should decrease on x64 and performance of splay should drastically improve on x64. R=erik.corry@gmail.com Review URL: http://codereview.chromium.org/8498013 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9922 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Sep, 2011 1 commit
-
-
vegorov@chromium.org authored
Review URL: http://codereview.chromium.org/7945009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9328 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-