- 23 Oct, 2019 26 commits
-
-
Igor Sheludko authored
The size/length limits are still at kSmiMaxValue. Bug: v8:4153 Change-Id: I6ffda50a3b9f235b97a3718e86df7deadce9f6f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874346 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64514}
-
Santiago Aboy Solanes authored
Added the opcodes kWord32Equal and kChangeTaggedToCompressed to DecompressionOptimizer. Currently TaggedEqual node generates ChangeTaggedToCompressed nodes before the Word32Equal inputs. This means we need to also propagate kOnly32BitsObserved from kChangeTaggedToCompressed. Bug: v8:7703 Change-Id: I61fee07269696c60e065e1bbfee3a65c1b1537fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871911Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64513}
-
Michael Starzinger authored
This changes the way {SaveFPRegsMode} is stored in a {CallDescriptor}. The value is now encoded in the flags field, similar to all other boolean properties. It removes the last mutable field from the call descriptor, making the struct fully immutable. R=neis@chromium.org Change-Id: I6bca118c7ce0c5bc77e7aa2fcc6541439bd27b3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868616 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64512}
-
Clemens Backes authored
These accessors do not make any use of the interpreter, hence we can define them on the WasmInstanceObject alone. This will allow to reuse them for other (non-interpreted) frames. R=mstarzinger@chromium.org Bug: v8:9676 Change-Id: Iff8b665a4c25581b934c25b66a13cebe044cb02c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1875097Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64511}
-
Michael Achenbach authored
Bug: v8:9899 Change-Id: I7509b376b33ab7a36106ed3af322ec4058fcdcfe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1876048Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64510}
-
Leszek Swirski authored
Add a new PagedSpace called OffThreadSpace. This space will be used for off-thread allocation -- it never marks or sweeps, and always expands into fresh pages. Once allocation completes, this space's pages can be merged into the old space. The space is similar to the CompactionSpace, and merging for both is identical, so we intrduce a new LocalSpace base class that both extend. They differ in interaction with the sweeper and in how new pages are acquired. This patch adds the new space and uses it in a few unittests. Future work will use it in the main source code. Bug: chromium:1011762 Change-Id: Ia008cc95c6e1ef1d1e7ae305fa80fbfc1ff4be2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873690 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#64509}
-
Jakob Gruber authored
Previously, embedders had to fetch the 'exec' property off the RegExp prototype in order to call exec (and such calls involve two transitions between C++ and JS). This CL exposes a convenient RegExp::Exec method through the API. Bug: v8:9695 Change-Id: I57a9174626143d26f2ea34676b8e55fef64932cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864940 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#64508}
-
Michael Starzinger authored
R=neis@chromium.org,miladfar@ca.ibm.com BUG=v8:9872 Change-Id: Ia8b0da9a6026f7933503ecd9e735d7fc3fdff364 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869190Reviewed-by:
-
Igor Sheludko authored
The new ToIndex() must eventually replace ToSmiIndex(). The CL fixes the following abstract operations: GetViewValue(view, requestIndex, isLittleEndian, type) SetViewValue(view, requestIndex, isLittleEndian, type, value) and the following builtins: DataView.prototype.getXXX DataView.prototype.setXXX where XXX are all typed elements. Bug: v8:4153 Change-Id: Ic2f33e91b59426deb0efa28bb4c15253e80a299c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874345 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Mu Tao authored
Port f22837db R=xwafish@gmail.com Change-Id: Iece021bb832618cac0d111639b388d94f7da7028 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868773 Commit-Queue: Mu Tao <pamilty@gmail.com> Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Clemens Backes authored
R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: Ib08647b5d6c4238732eed5a2ed1f1d0eea010076 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1875099Reviewed-by:
-
Michael Starzinger authored
The {InstructionCode} is only used to store plain (non-negative) values of the {ArchOpcode} enum, or additionally encodes {BitField} values. The underlying base type 'U' of a {BitField} is uint32_t. To avoid all the numerous implicit conversions between int32_t and uint32_t, this is changing the {InstructionCode} so that uint32_t is used exclusively. R=neis@chromium.org BUG=v8:9872 Change-Id: If64107ad9298011e219b4827735eafb51465beb0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869193Reviewed-by: -
Jakob Gruber authored
This operator implicitly reads the stack pointer register and is thus not pure. This CL removes it from the list of pure operators and inserts it into the effect chain at its use sites. Drive-by: Alpha-sort the list in CanAllocate. Bug: v8:9534 Change-Id: Icf96fb3e308600dbacec3dbfb7386a4f0d0bdc39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1875098 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Bug: v8:9695 Change-Id: I401a18c84a9ec1af7e14f44004a0788cbfd4a34b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864657Reviewed-by:
-
Igor Sheludko authored
The CL refactors the following builtins: String.prototype.startsWith String.prototype.endsWith to use ClampToIndexRange(x, len) instead of NumberMin(NumberMax(x, 0), len). Bug: v8:8996 Change-Id: I20ab42088168e517840385cc2db435361004d9c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873702 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Mu Tao authored
Port 26afd8f3 Change-Id: I4033e6bb50166d59679dddd8ba0480b4bc4b821d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874969 Commit-Queue: Mu Tao <pamilty@gmail.com> Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
-
Clemens Backes authored
The same change on the {CopyChars} function gave an unexpected 10-20% speedup on microbenchmarks across platforms (ia32, x64, Atom_x64). This CL explores whether a similar change generally speeds up {MemCopy} and {MemMove} (only on x64 for now). If this is the case, we might be able to carefully extend the same pattern to other platforms and remove custom assembly implementations without too much regression. R=leszeks@chromium.org Bug: v8:9810 Change-Id: Ib9674807b67cd2a463680b97a91ae1b41c3be65b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871607Reviewed-by:Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64498}
-
Mu Tao authored
Port 434f9681 Change-Id: I9e9cb8b9ca56d5af3b5ffffa5908501c9214752d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874968 Commit-Queue: Mu Tao <pamilty@gmail.com> Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
-
Jakob Gruber authored
These counters track how often the slow path of these two builtins is hit. Exec is very permissive, its fast-path check doesn't look at the regexp prototype at all. Replace is strict; any change on the prototype will trigger the slow path. Chromium CL: https://crrev.com/c/1875250 Bug: v8:5577 Change-Id: I9807f43829981445b75b5c5d29800cbdac9bc26a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873698Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64496}
-
Z Nguyen-Huu authored
RegExpPrototypeExecBody, RegExpPrototypeExecBodyWithoutResultFast Bug: v8:8976 Change-Id: I79f4d3e27baf5ff7aec9538fa463d810dbb75e4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866957 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Simon Zünd authored
This CL integrates the "v8_nosnapshot" source set into the "mksnapshot" binary. The "mksnapshot" binary is the last use-site after unconditionally enabling snapshot and embedded builtins. Bug: v8:8519 Change-Id: I8e737e10a3f7729e18ac71733b811bf399ebf330 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873685Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#64494}
-
Gus Caplan authored
Bug: v8:9891 Change-Id: I5a9600b44c2363cc9681976e4ed2b86eccf35830 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869581 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Mu Tao authored
Port a0b95232 R=xwafish@gmail.com Change-Id: I15c385a676e574f36d8c25c6f6294ac344b0af43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868557Reviewed-by:
-
Mu Tao authored
Port afbbfcbe R=xwafish@gmail.com Change-Id: Iab3a9f32d8bccddcdca8d9a874869e62ae961948 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868558 Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
-
Mu Tao authored
Port 0089006f Original Commit Message: .. similar to how it is applied in the interpreter. We reserve a stack slot for the backtrack count, increment it on each backtrack, and fail if the limit is hit. Change-Id: I51879e6cafb3c77d635fc6e84e7e2c5ce3a088e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873445 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/996a3e8..e9c43f1 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0388283..9f6271e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/53f9e09..db1e79c Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/5005010..b51014b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c5d85f1..aa07e59 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I52086f4e4c1226e0555dd912b89473e1448cddd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874828Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64489}
-
- 22 Oct, 2019 14 commits
-
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: Idee4daded322731648fe51e75f3b9e8be2dcd0d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872929Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#64488}
-
Ng Zhi An authored
This is a reland of 08b26f53 Fixed the original crash, by removing a disasm for psllq and psrlq that is now handled by the macro list. Original change's description: > Clean up macros > > Move some instruction definitions into sse-instr, which is used to > generate some disasm tests, so we can remove some cases there. > > Bug: v8:9810 > Change-Id: I0615ec823396da08bc5d234cf1dabca6afd3f052 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866965 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64441} Bug: v8:9810 Change-Id: I69335a889f5f72b76a79e4e9860835232e6e38a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872298Reviewed-by:
-
Mu Tao authored
Port 3cad6bf5 Original Commit Message: This is a reland of c7c47c68. This makes TSAN happy in addition to: Previously I presumed that the context read from a frame in the profiler was a valid context. Turns out that on non-intel we're not guaranteed that the frame is properly set up. In the case we looked at, the profiler took a sample right before writing the frame marker indicating a builtin frame, causing the "context" pointer from that frame to be a bytecode array. Since we'll read random garbage on the stack as a possible context pointer, I made the code reading the native context from it a little more defensive. Bug: v8:9860 Tbr: ulan@chromium.org, neis@chromium.org, ishell@chromium.org Original change's description: > [runtime] Move Context::native_context to the map > > Remove the native context slot from contexts by making context maps > native-context-specific. Now we require 2 loads to go from a context to the > native context, but we have 1 field fewer to store when creating contexts. > > Change-Id: I3c0d7c50c94060c4129db684f46a567de6f30e8d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859629 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64296} R=xwafish@gmail.com Change-Id: I6496a8c5be8cbabf48cddc2d59111410f31eb75f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868774 Auto-Submit: Mu Tao <pamilty@gmail.com> Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#64486}
-
Milad Farazmand authored
Port 434f9681 R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I2b374de4d50022e88b240dbad5eddcab8cfe9547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874085Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Adam Klein authored
Remove inactive contributors (cira and mnita) and add ftang and jshin. Change-Id: Ibd1e4f11553b78e1cd938a7ce8958fe5341829d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872540Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#64484}
-
Gus Caplan authored
Change-Id: Iee27a99a9627d73e10c4c85c31d07a5204808259 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864574 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Andreas Haas authored
Otherwise the value cannot be used in gtests in EXPECT_GT expressions. The reason is that EXPECT_GT takes values by reference and not by value, so the declaration in v8.h is not enough. R=clemensb@chromium.org Bug: v8:9810 Change-Id: I6f85024d483701fcc65d1ccfc5254dbdbcce16c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871606Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64482}
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: Ib78d7506fa8c8b755a8e1feccc5d948834ddc3a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873106Reviewed-by:
-
Gus Caplan authored
Change-Id: I97ccbb29f9d4d92bb2ac20402ff8240632533989 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864572 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The new predicate indicates whether the backing store was created for an ArrayBuffer or a SharedArrayBuffer. It is useful for some embedders. Bug: v8:9380 Change-Id: I804063bb8c4c17815defd6538ce6a1b32f6a4531 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873689 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64479}
-
Liviu Rau authored
Bug: v8:9503 Change-Id: I6434685459a6b5a935a3a3598a3827959590b9e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864652Reviewed-by:
-
Victor Gomes authored
Original change's description: > [runtime] Remove extension slots from context objects > > Context objects have an extension slot, which contains further > additional data that depends on the type of the context. > > This CL removes the extension slot from contexts that don't need > them, hence reducing memory. > > The following contexts will still have an extension slot: native, > module, await, block and with contexts. See objects/contexts.h for > what the slot is used for. > The following contexts will not have an extension slot anymore (they > were not used before): script, catch and builtin contexts. > Eval and function contexts only have the extension slot if they > contain a sloppy eval. > > Bug: v8:9744 > Change-Id: I8ca56c22fa02437bbac392ea72174ebfca80e030 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863191 > Commit-Queue: Victor Gomes <victorgomes@google.com> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Auto-Submit: Victor Gomes <victorgomes@google.com> > Cr-Commit-Position: refs/heads/master@{#64372} TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org Bug: v8:9744 Change-Id: I8700ed2fa62c89e86c39bb16ac3167f38ea8d63f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873695 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Hans Wennborg authored
I was just driving by and noticed these unnecessary includes. Bug: none Change-Id: I071ce08ef8a52cdeda997047ff7d9a5f47c5ba10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872394 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:4153 Change-Id: Icd346fae1dea9e56527b8669ace1aa6cfd46e87a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872393 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
