- 08 May, 2019 19 commits
-
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I4ef23446609e0b276877aedaccbd738497f2853f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601145Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61327}
-
Toon Verwaest authored
MakeExternal can change byteness of strings without updating wrappers; hence we cannot trust byteness of wrappers. Unwrap the string before checking encoding. Bug: chromium:960680 Change-Id: I95d2bca906141c0d8b3de8fdac44b9fdb2ef2c43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601140Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#61326}
-
Santiago Aboy Solanes authored
We are changing all heap Tagged loads and stores to used the Compressed representation. From this point forward, MachineType::TypeCompressedTaggedXXX has to be used instead of MachineType::TaggedXXX. This function was added in the middle of my CLs and therefore was not included in my wasm CL. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: If3973d436ae04520b36d0f442b7886a58ac901ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601137Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61325}
-
Clemens Hammacher authored
This reverts commit cc71d5ca. Reason for revert: gc-stress failures, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/22357 Original change's description: > [wasm][gc] Use SetPermissions to discard pages > > On 32bit windows, DiscardSystemPages fails sometimes (see bug). We don't > have a reproducer, so this is a purely speculative fix. > {SetPermissions} has some platform-specific logic to also discard the > pages. Specifially, on windows it uses {VirtualFree} instead of > {DiscardVirtualMemory}. > {SetPermissions} is also semantically stronger, since it forbids any > further access to the pages. > > R=mstarzinger@chromium.org > > Bug: v8:8217, chromium:960707 > Change-Id: I8b3325264c86aff8d6e7c6b01c22ae410e87faf4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601134 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61321} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: Ib2d534a6906ea5d390d08943ea71e1f8799278e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8217, chromium:960707 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601147Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61324}
-
Maciej Goszczycki authored
Seems like the CodeBuilder CL actually caused this. This is a reland of 964edc25 Original change's description: > [heap] Set read-only space's and its pages' heap_ to null. > > Various small changes are required to enable this. > > HeapObject::GetReadOnlyRoots no longer uses the Space's heap when > possible (see comment in ReadOnlyHeap::GetReadOnlyRoots definition). > This requires that ReadOnlyRoots be construct-able using a raw pointer > to the read-only space's roots array. > > Global read-only heap state is now cleared by tests where appropriate > and extra DCHECKs in ReadOnlyHeap::SetUp should make catching future > issues easier. > > String padding is now always cleared just before read-only space is > sealed when not deserializing. > > Change-Id: I7d1db1c11567be5df06ff7066f3a699125f8b372 > Bug: v8:7464 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535830 > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61188} Bug: v8:7464 Change-Id: If75bbd16c2e2af5b80cd60811dfd7866f8be8309 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599186 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#61323}
-
Mythri A authored
Bug: v8:9207 Change-Id: Ie137e8c2395e835d532394495d892ad9b2cfc90d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601133 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Auto-Submit: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#61322}
-
Clemens Hammacher authored
On 32bit windows, DiscardSystemPages fails sometimes (see bug). We don't have a reproducer, so this is a purely speculative fix. {SetPermissions} has some platform-specific logic to also discard the pages. Specifially, on windows it uses {VirtualFree} instead of {DiscardVirtualMemory}. {SetPermissions} is also semantically stronger, since it forbids any further access to the pages. R=mstarzinger@chromium.org Bug: v8:8217, chromium:960707 Change-Id: I8b3325264c86aff8d6e7c6b01c22ae410e87faf4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601134Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61321}
-
Peter Marshall authored
Perfetto will actually call this from the main thread in various cases so we need to implement it. Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Bug: v8:8339 Change-Id: I509fa277fb0f7e98e9dea4d991a2d313e0a249da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599183Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61320}
-
Santiago Aboy Solanes authored
This reverts commit 3c510438. Reason for revert: Breaks pointer compression bots (https://ci.chromium.org/p/v8/builders/try.triggered/v8_linux64_pointer_compression_rel_ng_triggered/b8914100067516580000) Original change's description: > [ptr-compr][turbofan] Calling the non-compressed Tagged loads and stores > > This CL changes the instruction selector so that we use the normal load > and store, instead of the one that (de)compresses. > > Also removed "return;"s and "break;"s that were unnecessary. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng > Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng > Bug: v8:8977, v8:7703 > Change-Id: I4f2a82bfc4d300dd56300f394f59c3f9da242ba8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593296 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61304} TBR=mvstanton@chromium.org,jarin@chromium.org,solanes@chromium.org Change-Id: I022895f648b7f9a24944d1c647ba76773cee3669 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8977, v8:7703 Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601136 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61319}
-
Joyee Cheung authored
Bug: v8:8578 Change-Id: If6b62b7d0ca2be03ab46c58d33aa2353ddd44986 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584251 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#61318}
-
Peter Marshall authored
The default protobuf compiler main builds generators for the CLI tool for all the supported languages. This CL adds a custom main() which only requires the CPP generator. The protobuf compiler is a build-time dependency so this won't shrink binary size but will speed up compile a little bit and means we don't have to list all of the files for the other supported languages in the build.gn file. That should hopefully make protobuf rolls a bit easier given that we are maintaining GN build files for protobuf. Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Bug: v8:8339 Change-Id: Iac432dfe53b7ac9cfa819be1b2945d5948ffff38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599448 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61317}
-
Peter Marshall authored
This is needed for Perfetto which sometimes chooses to bypass the task queue if the task queue uses a given thread to run tasks. Bug: v8:8339 Change-Id: Iecec5e7883d174e4b63495ecdadfb96105e4505c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588471 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#61316}
-
Simon Zünd authored
This is a reland of 2d45ecf0 The reland properly initializes struct fields in unittests. To prevent this in the future, TorqueCompilerOptions uses brace initialization. Original change's description: > [torque] Introduce force_assert_statements compiler option > > "assert(...)" statements are usually only visited and generated in > debug builds. To provide Language Server support for statements inside > asserts, the force_assert_statements option allows to manually > override this behavior and visit assert statements in release builds. > > R=sigurds@chromium.org > > Bug: v8:7793 > Change-Id: I38f48e35f2b0a1a98abb74b7babb1edd2d7dba24 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599180 > Auto-Submit: Simon Zünd <szuend@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61295} Bug: v8:7793 Change-Id: I96ef863c8c85ae87a00cbe858655d4a2c9368b41 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599599 Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61315}
-
Andreas Haas authored
Incorrect sub-typing caused some spec tests to fail. The rules in the spec are here: https://webassembly.github.io/reference-types/core/exec/modules.html#globals R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: Ic0924b98a39395e351fec901c47a9debfe56be9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598763 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61314}
-
Yu Yin authored
Above test passes on simulator but may take up about 3 minutes. Test passes normally on native mips. ppc & arm both skip it on simulator. Change-Id: Ifd51a29ab653fa80e541fb2a7a8b0ae680a4454d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598913Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#61313}
-
Michael Achenbach authored
TBR=mslekova@chromium.org NOTRY=true Bug: v8:9145 Change-Id: I4672c61f6fc40878c2997826ac6492c37edbfc64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599597Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61312}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I8f51731a789b242cdd489f6321bc1ba909aa5d66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599548Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61311}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/27799cd..ec592be [spec] Constrain name section ordering (#1012) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/ec592be [spec] Typo in type table (#1013) (Galaxtone) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/08fe3e3 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I2610be6a50dd18800dc5096dbd0f9188d2f9879e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600972Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61310}
-
Yu Yin authored
port https://crrev.com/c/1588430 to mips. Change-Id: Ic1474294a8be5191cc8d10ba65cdc5eb28ac1362 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596045Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#61309}
-
- 07 May, 2019 21 commits
-
-
Alexei Filippov authored
Change-Id: Iaf4ad9a097e7201d072341525e6364e1d4f689b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599774Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#61308}
-
Z Duong Nguyen-Huu authored
This is the follow-up for frozen, sealed packed elements kind. Design docs: bit.ly/fast-frozen-sealed-elements-in-v8 This change is only support the transition from holey elements to holey sealed elements (via object.seal) or to holey frozen elements (via object.freeze). Added tests for non-extensible, sealed, frozen holey elements in https://chromium-review.googlesource.com/c/v8/v8/+/1574503 and https://chromium-review.googlesource.com/c/v8/v8/+/1582481 Bug: v8:6831 Change-Id: Ia4373648f79f2ebebb390982a503145844a0c123 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574777 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#61307}
-
Milad Farazmand authored
Port 0a0d70eb R=sigurds@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Id4a864b95368c392de8b363076114cd36c463397 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598549Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#61306}
-
Balaram Makam authored
When one of two compared strings is empty, or when both are the same object, we can skip the calls to Flatten and into ICU. Performance results on hikey620(cortex-a53) device: Speedometer2.0 - no impact. Jetstream2.0 - only impacts CDJS subtest: name old score new score delta CDJS 2.33 ± 3% 2.38 ± 1% +2.35% (p=0.009 n=6+5) Change-Id: Ibe490f86188caab1d7712b52c610658e1e2b819c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584221 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61305}
-
Santiago Aboy Solanes authored
This CL changes the instruction selector so that we use the normal load and store, instead of the one that (de)compresses. Also removed "return;"s and "break;"s that were unnecessary. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I4f2a82bfc4d300dd56300f394f59c3f9da242ba8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593296 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#61304}
-
Mythri A authored
In PrepareFunctionForOptimization, for functions that are already optimized we didn't hold on to the bytecode array strongly. If these functions get deoptimized before we call OptimizeFunctionOnNextCall, then they need to be re-optimized again. So we should hold the bytecode arrays for optimized functions as well. OptimizeFunctionOnNextCall removes it from the table if the function is still optimized. Bug: v8:8801 Change-Id: I7f3d94d9842223d85843c9ddb109c8bc9f414891 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599388 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#61303}
-
Clemens Hammacher authored
The test is timing out a lot recently, blocking the LKGR. The underlying issue still needs to be found and fixed. If the test passes, it is fast. TBR=titzer@chromium.org No-Try: true Bug: v8:9221 Change-Id: Ie2cbfa310a5088ed736cfd930eefe993e68af9b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599550Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61302}
-
Igor Sheludko authored
... to minimize pollution of v8::internal namespace. This CL also removes usages of WriteBarrierKind from CodeAssembler interface. Bug: v8:9183 Change-Id: I7e87c0a98cfd08b3740a022cf12d3aab415da67a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599176 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61301}
-
Santiago Aboy Solanes authored
This is the last string of CLs! We eliminated all Tagged loads and stores. That's why I also cleaned up that TODO in machine-type.h Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: Icb23b396d0cbb6ee914637e34e26b52435f0000c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593085 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#61300}
-
Toon Verwaest authored
That's the only place where it's used, with a known StringTableKey type. This also makes MakeThin available on String. Change-Id: If1aca892045dadae91c902e783822280ae01f485 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598764 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61299}
-
Clemens Hammacher authored
In the {WasmEngine::RemoveIsolate} method, we might remove the last outstanding isolate for the current GC. In that case, finish the GC at that point. R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I7d710756d29265e0552fcc318435133f7db03dda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598706Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61298}
-
Maggie Chen authored
This is for the finch experiment CL 1592792 V8HugeMaxOldGenerationSize (--js-flags="huge_max_old_generation_size"). The purpose of this finch is to support web apps that require more heap space for their data sets. The current max_old_space_size is 2 GB. This CL increases the size to 4 GB for 64-bit systems with a physical memory size bigger than 16 GB. This CL does not change MaxGrowingFactor. HeapController::kMaxSize is still set to 2GB so the GC schedule remains the same. All tests from "tools\dev\gm.py x64.release.check" passes in my local machine with FLAG_increase_max_old_space_size forced to true. Bug:958974 Change-Id: I9d916d75c0b16342040dd1336e28e423e5bcc474 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1592129 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61297}
-
Clemens Hammacher authored
This reverts commit 2d45ecf0. Reason for revert: Fails on arm64 msan: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/26567 Original change's description: > [torque] Introduce force_assert_statements compiler option > > "assert(...)" statements are usually only visited and generated in > debug builds. To provide Language Server support for statements inside > asserts, the force_assert_statements option allows to manually > override this behavior and visit assert statements in release builds. > > R=sigurds@chromium.org > > Bug: v8:7793 > Change-Id: I38f48e35f2b0a1a98abb74b7babb1edd2d7dba24 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599180 > Auto-Submit: Simon Zünd <szuend@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61295} TBR=sigurds@chromium.org,szuend@chromium.org Change-Id: Ib0f72a756ff1f6c9838d3d7f837a326b1dab3278 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7793 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599549Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61296}
-
Simon Zünd authored
"assert(...)" statements are usually only visited and generated in debug builds. To provide Language Server support for statements inside asserts, the force_assert_statements option allows to manually override this behavior and visit assert statements in release builds. R=sigurds@chromium.org Bug: v8:7793 Change-Id: I38f48e35f2b0a1a98abb74b7babb1edd2d7dba24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599180 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61295}
-
Simon Zünd authored
DocumentSymbol responses provide all symbols (macros, classes, etc.) in a given document. The LSP standard evolved over time and supports two different kind of responses here: - A simpler one, that is a plain list of all the symbols - A more detailed one, allowing a hierarchy of symbols. For example a class symbol has a list of field/method symbols attached. This is used by editors to build hierarchical outline views. For now, the simpler response is chosen as its also used for workspace wide symbol searches. This CL adds the necessary boilerplate so the actual implementation CL is easier to review. R=tebbi@chromium.org Bug: v8:8880 Change-Id: I6c86fc839b1f4e0309f6403a5f9afd5c162c0e89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598757 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#61294}
-
Santiago Aboy Solanes authored
The Change nodes have to be explicitly introduced in effect control linearizer since it runs after the pass that adds the Change nodes automatically. This is a CL in a string of CLs that aims to eliminate all Tagged loads and stores. We are getting close to that goal. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I07521edad0d6d28a549572b56edd91aa5ddb7146 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591774 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#61293}
-
Toon Verwaest authored
Change-Id: I079befeac55aae9ef9ff7743f69fdd3977adcb18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598760 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#61292}
-
Benedikt Meurer authored
This switches --modify-field-representation-inplace to true again, after the issue with the elements kinds transitions is fixed. Cq-Include-Trybots: luci.chromium.try:linux-rel,win7-rel Doc: http://bit.ly/v8-in-place-field-representation-changes Bug: v8:8749, v8:8865, v8:9114, chromium:959645, chromium:952682 Change-Id: Ieb9a40d6ff44dd5f327e18ed7e7a169951c58416 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598705 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#61291}
-
Sigurd Schneider authored
This allows generic specializations to appear before the generic itself. Bug: v8:7793 Change-Id: I127fb49380a14cdf2a63854117d25fc865a95352 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599178Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61290}
-
Toon Verwaest authored
This is a step towards reducing the number of StringTableKeys to the absolute minimum so we can better optimize how they work. This always flattens ConsStrings into a buffer to avoid expensive comparison with cons string (as well as hash computation). Change-Id: I6dcf0bdd2a722f490dad02b7f887083e1ac46000 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598707Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#61289}
-
Santiago Aboy Solanes authored
This is a CL in a string that aims to replace the Tagged loads and stores nodes that are still being created. Also took the liberty of cleaning up part of wasm-compiler. There were some cases where we could have been using the existing macros, but weren't. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: Ic6ce2f9dc9f2ad440c91c98b1f449d3c76f42fd2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591773Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61288}
-