- 01 Apr, 2019 17 commits
-
-
Mythri A authored
It is not safe to access flags from concurrent marking visitor. We access FLAG_flush_bytecode and FLAG_stress_flush_bytecode when visiting SharedFunctionInfo and JSFunction to decide if we need to collect bytecode. This cl adds a bytecode_flushing_mode which will be initialized when creating the visitor. This way we can avoid accessing flags. Bug: v8:9045 Change-Id: I84bf09ec2dd1543abad54bd87f8bf953830b89e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541108Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#60553}
-
Mythri A authored
We added %PrepareForOptimization, that holds the bytecode array strongly until the function is optimized, to test using assertOptimized. This function expects that the function is optimized before preparing the next function for optimization. In some tests, we may not explicitly optimize a function because it got inlined into other functions or if it was already optimized. This cl relaxes this condition and holds onto multiple bytecode arrays. Bug: v8:8801, v8:8395 Change-Id: Iebccc4a798aa3f35be9ee295eb3c4917da659c22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541055Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#60552}
-
Jaroslav Sevcik authored
Drive-by: make sure that Allocate node consistently take intptr input as size (as opposed to sometimes intptr, sometimes int32). Bug: v8:8984 Change-Id: Ida56b9788cd11b470cc866f1b7df71f03ef0075f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541037Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60551}
-
Georg Neis authored
- We didn't take stability dependencies on the inferred maps in case of kUnreliableReceiverMaps. - We didn't take stability dependencies on the prototype chains. Bug: v8:9041 Change-Id: I85418dbed219f51e7fb46c59a0cb9cbb9b499bc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541107 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Georg Neis authored
It was missing a control output. Bug: chromium:946889 Change-Id: I85f203fc6e27a60f0b86e0e2999dd798a5416dfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547655 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: I67e052b3a15ef88c21d056ca824d32da68cbbcfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541049 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#60548}
-
Sigurd Schneider authored
This is a reland of 5fbc5015 Original change's description: > [mjsunit] Add test that calls functions on prototypes with no arguments > > Change-Id: I0ede9f309b89cfa878a325e3f68327b1682d4ced > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538123 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60541} TBR=jarin@chromium.org Change-Id: I409e3dab72057bcba6c729f3b181fc29e8c861ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547654Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60547}
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in base code to 'using' declarations. R=mlippautz@chromium.org Bug: v8:8834 Change-Id: Ic5c3d7fa2e50938c6f43e9ff304dc2289fed1133 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547650Reviewed-by:
-
Michael Lippautz authored
Without the proper check V8 would not delegate to the embedder (Blink) for processing wrappable objects. Bug: chromium:946941 Change-Id: I5aa3ca85e5113ab8d28a61eca6a5e0593c62f6a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547649 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 5fbc5015. Reason for revert: Fails on noi18n: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20noi18n%20-%20debug/26006 Original change's description: > [mjsunit] Add test that calls functions on prototypes with no arguments > > Change-Id: I0ede9f309b89cfa878a325e3f68327b1682d4ced > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538123 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60541} TBR=jarin@chromium.org,sigurds@chromium.org Change-Id: I4b9c747e6d73dd3ff01af81c3d1e6143dcab6ecd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547652Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60544}
-
Georg Neis authored
... from Object to HeapObject, as they are never Smis. Change-Id: I4cbe12985091ed1b1e94dab2803a977ae3e25224 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541104 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60543}
-
Benedikt Meurer authored
The CheckNonEmptyString lowering was the wrong way around and would deoptimize if it doesn't see the empty string. This leads to the creation of invalid ConsStrings and also to unnecessary deopt loops with proper code. Bug: chromium:947949, v8:8834, v8:8931, v8:8939, v8:8951 Change-Id: Ib2cc4e92cc9ec7e0284d94f74d14f67f8c878dec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545908Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I0ede9f309b89cfa878a325e3f68327b1682d4ced Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538123 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: If32de05a48bddf5f746b2a3ea810ee350f6a7dda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541051 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60540}
-
Sigurd Schneider authored
Change-Id: I71a97bf686e9d821b607504c4211b21a4fe8234b Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545906 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60539}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/1443de9..8059cd6 Update instructions.rst (#995) (Søren Sjørup) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/8059cd6 [interpreter] Check argument types on invoke (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/5ea9d89 [test] Add test when start function traps (#994) (Ben Smith) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/559a10d TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Id73ec7683a566f5d206426fcfbbc75f726cbe244 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547414Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60538}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/524030d..a72af28 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/adc6ac4..82dbc02 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie4d1344c408d094000b7a2c4f61ba6bcdbf20085 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547413Reviewed-by:
-
- 31 Mar, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/99a60dd..524030d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7b483abcaed40e74e54bc950a03c31d12e54e04f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547125Reviewed-by:
-
- 30 Mar, 2019 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/4406612..1443de9 [interpreter] Fix in JS conversion (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/1443de9 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I6bd1f78bacb7b805730246fc6e3ce6bbad8ab6ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1546929Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/c7664bb..c69a8ff Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a525b65..99a60dd Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/eda23ac..459baaf Rolling v8/buildtools/linux64:gn/gn/linux-amd64: https://chrome-infra-packages.appspot.com/gn/gn/linux-amd64/+log/git_rev..git_rev Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/aab7e31..5b63b1f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/803c869..8d3ba46 Rolling v8/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto/+log/40cc341..21a33af TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7c82fed3eac96ae2a5f09de2642b624f681d2878 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545088Reviewed-by:
-
- 29 Mar, 2019 19 commits
-
-
Milad Farazmand authored
Porting: 138d2dfc Original comment: This allows immediates to be encoded directly into instructions, rather than mov-ing constants to registers first. This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once this approach has been approved. Change-Id: I8442642126555f47a47d511f0ca9d4c00ed82da1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1546050 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60533}
-
Alexei Filippov authored
That saves some bytes on the frontend side and some cycles when generating and parsing protocol JSON for stacks. BUG=chromium:946411 Change-Id: I36b3a48b5d8246a05b877bc21f36c08803a1c304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1542800 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60532}
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in src/objects to 'using' declarations. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: Iec455b40e9256ee3aae867a42c0e949a338d417c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545893Reviewed-by:
-
Deepti Gandluri authored
Change-Id: Iad000c91323b9eef799b1e17f25bd3e9d345ab2d Bug: v8:8635 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543850Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60530}
-
Michael Achenbach authored
TBR=sigurds@chromium.org NOTRY=true Change-Id: I367705e892aea333cee4f8410b866972b7885dfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545907Reviewed-by:
-
Michael Starzinger authored
This removes a special case for eager initialization of function tables used by asm.js modules. For such modules the table in question can never be exported. It is used to implement asm.js function tables (for details see section 6.3 - ValidateFunctionTable in the asm.js spec). Since such tables are never exported, it should be beneficial to lazily allocate the export entries. R=ahaas@chromium.org Change-Id: I5099d548fe1d2432584d1a09b756c136866d4a0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539578Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60528}
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in compiler code to 'using' declarations. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: I3baf3ecbfe2c853cb17bb479ebbf140382193b5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545896 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:8977 Change-Id: I3eed7db62e4b6fc8f8e51c5aca29c8b78439a400 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545891Reviewed-by:
-
Michael Starzinger authored
This fixes initialization of reference type global variables (i.e. anyref and except_ref) based on an index of another global. It extends the existing support to exception types, fixes the logic, and also fixes a missing write barrier. R=ahaas@chromium.org TEST=mjsunit/wasm/exceptions-global BUG=v8:8091 Change-Id: Ia91f1ea03be24fadf3023a5acdd073badb8dcd93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539581 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: v8:9061 Change-Id: Ib8064fc45caa362a63ffd826325c8eabf49e5608 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545898Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in heap code to 'using' declarations. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: I8a9f6e1eebdd0adca4373c866e95ebab0a1e992d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545892Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in parsing code to 'using' declarations. R=leszeks@chromium.org Bug: v8:8834 Change-Id: I0c95f83ee6897d294bd002b7a4a6277962397e90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545897Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60522}
-
Joey Gouly authored
This is a reland of e3be96d6 The failure was due to not sign extendint the immediate for 64-bit adds on 32-bit platforms. Original change's description: > [liftoff] Introduce emit_{i64,i32}_add with immediate > > This allows immediates to be encoded directly into instructions, rather than > mov-ing constants to registers first. > > This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once > this approach has been approved. > > Bug: v8:9038 > > Change-Id: I0c7306c2da0dae26f1c6e2465a9565adbf0bda84 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524482 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60506} Bug: v8:9038 Change-Id: I7dd1112827d037d900fd36cce71206388642605b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543730Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in ic code to 'using' declarations. R=ishell@chromium.org Bug: v8:8834 Change-Id: I70c74d3f20a6c15693157de5fc40bb769ef0599d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545895 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#60520}
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in wasm code to 'using' declarations. R=ahaas@chromium.org Bug: v8:8834 Change-Id: Ibdce88a5cc31e0785cbc1b34088bd39aa3ec84b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545890Reviewed-by:
-
Santiago Aboy Solanes authored
In x64 we can use the macro ASSEMBLE_MOVX. In Arm64, we force the use of registers. B Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng,v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977 Change-Id: I98c6a12d28acca43a38a77dc3ee7af126edb64fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545889 Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
In reducers, we should avoid reductions of the form ReduceWithValue(node, replacement) return Replace(node) because such reduction does not kill the original node, so it may become subject to resurrection from some side table (in the bug referenced below it was load elimination's side table). Instead, we should use ReduceWithValue(node, replacement) return Replace(replacement) Bug: chromium:945644 Change-Id: Id210efe0d214a53241392d30b7f0eee8e7515e2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545229Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/adf96bc..a525b65 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/466efc7..eda23ac Rolling v8/buildtools/linux64:gn/gn/linux-amd64: https://chrome-infra-packages.appspot.com/gn/gn/linux-amd64/+log/git_rev..git_rev Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6d6a48a..aab7e31 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/51c0f38..803c869 Rolling v8/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto/+log/b66b4e0..40cc341 Rolling v8/third_party/protobuf: https://chromium.googlesource.com/external/github.com/google/protobuf/+log/bdeb215..b68a347 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/39afd62..adc6ac4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia3bc8391b9cc96488e21bbd5482ac2c983578f99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545091Reviewed-by:
-
Frank Tang authored
For intl_datetime_style DesignDoc: https://goo.gl/v7n7zV Test: test/intl/date-format/constructor-date-time-style.js test/intl/date-format/constructor-date-time-style-order.js test/intl/date-format/property-override-date-time-style.js test/intl/date-format/constructor-date-style-order.js test/intl/date-format/property-override-date-style.js test/intl/date-format/constructor-time-style-order.js test/intl/date-format/property-override-time-style.js For intl_bigint Test: test/intl/bigint/tolocalestring.js https://www.chromestatus.com/feature/5742274625404928 chromium src/v8/test/intl/date-format/constructor-no-style-order.js Bug: v8:8699,v8:8702 Change-Id: Ide331e3571d5f6c230fe29b24bf6cced351cba49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541449Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60515}
-
- 28 Mar, 2019 1 commit
-
-
Maciej Goszczycki authored
Change-Id: I6c1a2edcee54993cd73e211de8271ea6b6c42ad7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543732 Auto-Submit: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
-
