- 08 Jun, 2016 1 commit
-
-
bmeurer authored
Revert of [heap] Fix chunk map removal for large objects. (patchset #1 id:1 of https://codereview.chromium.org/2042123003/ ) Reason for revert: Fails on noi18n debug build (https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20noi18n%20-%20debug/builds/8040/steps/Check/logs/unbox-double-arrays), please take a look. Original issue's description: > [heap] Fix chunk map removal for large objects. > > BUG= > > Committed: https://crrev.com/65dac7f8ead2eb09d417ecaaae0164699edfd510 > Cr-Commit-Position: refs/heads/master@{#36802} TBR=mlippautz@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2046283002 Cr-Commit-Position: refs/heads/master@{#36803}
-
- 07 Jun, 2016 36 commits
-
-
hpayer authored
BUG= Review-Url: https://codereview.chromium.org/2042123003 Cr-Commit-Position: refs/heads/master@{#36802}
-
jyan authored
Port 8d90210a R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG=v8:4483 LOG=N Review-Url: https://codereview.chromium.org/2047673003 Cr-Commit-Position: refs/heads/master@{#36801}
-
ishell authored
Committed: https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2 Review-Url: https://codereview.chromium.org/2033943005 Cr-Original-Commit-Position: refs/heads/master@{#36760} Cr-Commit-Position: refs/heads/master@{#36800}
-
machenbach authored
Revert of [heap] Clear out of live range remembered set slots in large objects. (patchset #2 id:20001 of https://codereview.chromium.org/2043713006/ ) Reason for revert: Fails arm sim: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20-%20sim/builds/1012 Original issue's description: > [heap] Clear out of live range remembered set slots in large objects. > > BUG=chromium:617882 > LOG=n > > Committed: https://crrev.com/38ad63ff15d7e379423be4c57ae94ae2c9ffb4af > Cr-Commit-Position: refs/heads/master@{#36795} TBR=ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:617882 Review-Url: https://codereview.chromium.org/2042403002 Cr-Commit-Position: refs/heads/master@{#36799}
-
mlippautz authored
backing store. Details of tracking: - Scavenge: New space pages are processes in bulk on the main thread - MC: Unswept pages are processed in bulk in parallel. All other pages are processed by the sweeper concurrently. BUG=chromium:611688 LOG=N TEST=cctest/test-array-buffer-tracker/* CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel Review-Url: https://codereview.chromium.org/2036643002 Cr-Commit-Position: refs/heads/master@{#36798}
-
ishell authored
TBR=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2043103002 Cr-Commit-Position: refs/heads/master@{#36797}
-
bryleun authored
R=joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,jyan@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2043843002 Cr-Commit-Position: refs/heads/master@{#36796}
-
hpayer authored
BUG=chromium:617882 LOG=n Review-Url: https://codereview.chromium.org/2043713006 Cr-Commit-Position: refs/heads/master@{#36795}
-
ishell authored
PrimaryStubCache and SecondaryStubCache: resurrected outdated tests (and enabled stub cache counters in the new LoadIC). TryProbeStubCache: decreased number of code objects created. Review-Url: https://codereview.chromium.org/2040193002 Cr-Commit-Position: refs/heads/master@{#36794}
-
hpayer authored
BUG=chromium:617883 LOG=n Review-Url: https://codereview.chromium.org/2046953002 Cr-Commit-Position: refs/heads/master@{#36793}
-
ishell authored
Dictionary::Add() must not be called for existing keys. Review-Url: https://codereview.chromium.org/2044003004 Cr-Commit-Position: refs/heads/master@{#36792}
-
bbudge authored
Uses float registers s0-s31 for moves and swaps when rep is kFloat32. Changes bitcast to use float registers. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2039843003 Cr-Commit-Position: refs/heads/master@{#36791}
-
cbruni authored
In most cases we return a Smi and undefined for the other cases. Hence there is no need to handlify the result unecessary. Additionally pass in the isolate for the hash-symbol lookup. BUG= Review-Url: https://codereview.chromium.org/2044843002 Cr-Commit-Position: refs/heads/master@{#36790}
-
machenbach authored
This declares v8_enable_slow_dchecks and v8_optimized_debug as gn args. It adds support for dcheck_always_on and debugging with v8_optimized_debug = false. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2024833002 Cr-Commit-Position: refs/heads/master@{#36789}
-
ofrobots authored
BUG=v8:5015 R=jarin@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2041243002 Cr-Commit-Position: refs/heads/master@{#36788}
-
cbruni authored
Using the isolate to check for IsUndefined and IsTheHole is roughly at least 20% faster in the worst-case and up to a factor 2x in the best case. BUG= Review-Url: https://codereview.chromium.org/2031533002 Cr-Commit-Position: refs/heads/master@{#36787}
-
mvstanton authored
It may be that we have a feedback vector, but no literals. In this case we can store into the OptimizedCodeMap directly instead of using a WeakCell, because all data in the feedback vector is already held weakly. The use of a WeakCell in the OptimizedCodeMap is only required when there are literals which may hold maps strongly. This is to address a performance regression caused by the creation of a large number of WeakCells. BUG=chromium:615831 Review-Url: https://codereview.chromium.org/2031123003 Cr-Commit-Position: refs/heads/master@{#36786}
-
yangguo authored
R=jkummerow@chromium.org BUG=chromium:595626 Review-Url: https://codereview.chromium.org/2037363002 Cr-Commit-Position: refs/heads/master@{#36785}
-
balazs.kilvady authored
Port 941524f8 TEST=mjsunit/harmony/async-debug-* BUG= Review-Url: https://codereview.chromium.org/2045923002 Cr-Commit-Position: refs/heads/master@{#36784}
-
machenbach authored
Revert of [builtins] Properly optimize TypedArray/DataView accessors. (patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ ) Reason for revert: Blink: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7296 Original issue's description: > [builtins] Properly optimize TypedArray/DataView accessors. > > The following getters were moved to the TypedArray/DataView prototype > chain with ES2015, and hence need different treatment now: > > - DataView.prototype.buffer > - DataView.prototype.byteLength > - DataView.prototype.byteOffset > - TypedArray.prototype.buffer > - TypedArray.prototype.byteLength > - TypedArray.prototype.byteOffset > - TypedArray.prototype.length > > Instead of having special magic on the LoadIC in the IC system and the > optimizing compilers, as we used to do before (and which we got rid of > already), we just treat those as normal accessors and make them > recognizable via the BuiltinFunctionId mechanism. This allows us to > remove some of the additional magic from the IC subsystem, and just > extend the BuiltinFunctionId mechanism in Crankshaft slightly to cover > these cases too (TurboFan doesn't yet support accessors, but that will > be fixed soonish anyways). > > This addresses most of the 15-20% regression we saw on the Octane > GameBoy emulator benchmark. > > BUG=chromium:579905,chromium:593634,v8:4085,v8:5073 > R=yangguo@chromium.org > > Committed: https://crrev.com/1ef737026565ea2becc84f30cfd432e581d50c6b > Cr-Commit-Position: refs/heads/master@{#36782} TBR=yangguo@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:579905,chromium:593634,v8:4085,v8:5073 Review-Url: https://codereview.chromium.org/2039093005 Cr-Commit-Position: refs/heads/master@{#36783}
-
bmeurer authored
The following getters were moved to the TypedArray/DataView prototype chain with ES2015, and hence need different treatment now: - DataView.prototype.buffer - DataView.prototype.byteLength - DataView.prototype.byteOffset - TypedArray.prototype.buffer - TypedArray.prototype.byteLength - TypedArray.prototype.byteOffset - TypedArray.prototype.length Instead of having special magic on the LoadIC in the IC system and the optimizing compilers, as we used to do before (and which we got rid of already), we just treat those as normal accessors and make them recognizable via the BuiltinFunctionId mechanism. This allows us to remove some of the additional magic from the IC subsystem, and just extend the BuiltinFunctionId mechanism in Crankshaft slightly to cover these cases too (TurboFan doesn't yet support accessors, but that will be fixed soonish anyways). This addresses most of the 15-20% regression we saw on the Octane GameBoy emulator benchmark. BUG=chromium:579905,chromium:593634,v8:4085,v8:5073 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2042013003 Cr-Commit-Position: refs/heads/master@{#36782}
-
mstarzinger authored
This avoids the inclusion of inline headers (i.e. vm-state-inl.h in this case) in a normal header. There are three more such violations left in the code-base after this change. R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2039913002 Cr-Commit-Position: refs/heads/master@{#36781}
-
ishell authored
BUG=chromium:617524, v8:5009 LOG=Y Review-Url: https://codereview.chromium.org/2044003003 Cr-Commit-Position: refs/heads/master@{#36780}
-
titzer authored
R=ahaas@chromium.org,bradnelson@chromium.org BUG=chromium:617884 Review-Url: https://codereview.chromium.org/2044833002 Cr-Commit-Position: refs/heads/master@{#36779}
-
yangguo authored
R=littledan@chromium.org BUG= Review-Url: https://codereview.chromium.org/2044803003 Cr-Commit-Position: refs/heads/master@{#36778}
-
machenbach authored
BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2046683003 Cr-Commit-Position: refs/heads/master@{#36777}
-
cbruni authored
Without the boundary prototypes we have to keep track of all shadowing properties throughout the complete prototype chain. This contradicts the finding that most objects have a rather large number of non-enumerable properties on the prototype chain. BUG=v8:705, v8:4905, v8:4706 Review-Url: https://codereview.chromium.org/2038043002 Cr-Commit-Position: refs/heads/master@{#36776}
-
yangguo authored
This is a fix intended to be merged. Ideally messages.js should be rewritten. R=bmeurer@chromium.org BUG=chromium:617527 Review-Url: https://codereview.chromium.org/2044823002 Cr-Commit-Position: refs/heads/master@{#36775}
-
machenbach authored
BUG=chromium:474921 TBR=vogelheim@chromium.org, jochen@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2041303002 Cr-Commit-Position: refs/heads/master@{#36774}
-
machenbach authored
BUG=chromium:617873 NOTRY=true TBR=jochen@chromium.org, vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2046563004 Cr-Commit-Position: refs/heads/master@{#36773}
-
yangguo authored
These files somehow got added due to some rebase issues I had locally. R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2042203002 Cr-Commit-Position: refs/heads/master@{#36772}
-
machenbach authored
Bots broke after https://codereview.chromium.org/2040913002/ BUG=chromium:599327 NOTRY=true NOPRESUBMIT=true TBR=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2044013002 Cr-Commit-Position: refs/heads/master@{#36771}
-
yangguo authored
NOTRY=true TBR=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2044593003 Cr-Commit-Position: refs/heads/master@{#36770}
-
Yang Guo authored
R=bmeurer@chromium.org BUG=v8:5071 Review URL: https://codereview.chromium.org/2045863002 . Cr-Commit-Position: refs/heads/master@{#36769}
-
bmeurer authored
There's no point in trying to extract the type hints from the fullcodegen CompareICs, BinaryOpICs and ToBooleanICs if the feedback is not consumed (which is guarded by the flag). R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2048543002 Cr-Commit-Position: refs/heads/master@{#36768}
-
v8-autoroll authored
Rolling v8/build to 274d94c4280f7a4bd0e5747ac4a6ac5d1aedad32 Rolling v8/third_party/android_tools to 5b5f2f60b78198eaef25d442ac60f823142a8a6e TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2046883002 Cr-Commit-Position: refs/heads/master@{#36767}
-
- 06 Jun, 2016 3 commits
-
-
gsathya authored
Revert of Promises: Make PromiseSet operation monomorphic (patchset #1 id:1 of https://codereview.chromium.org/2025073002/ ) Reason for revert: As a side effect of calling PromiseSet from FulfillPromise, clears the deferred symbol and the resolve/reject callback symbols. Although this isn't strictly necessary, not doing this seems to result in a leak as seen in -- https://bugs.chromium.org/p/chromium/issues/detail?id=617137#c10 Original issue's description: > Promises: Make PromiseSet operation monomorphic > > The PromiseSet operation is called with two types of promises > 1) A newly created promise object with no properties > 2) Promise object with callbacks and other properties > > PromiseSet is called with the first type of promise (with no > properties) from multiple call sites. PromiseSet is called with the > second type of promise object only from FulfillPromise. Furthermore, > this call only sets the value and status of the promise, the rest of > the values are reset to UNDEFINED (which isn't necessary). > > This patch inlines the calls to set the value and status of the > promise in FulfillPromise, instead of calling out to PromiseSet. > > This patch also reduces the number of symbol lookups, as we only set > the value and status of the promise, and don't change the callback or > deferred symbols. > > This patch results in a performance improvement of 2.8% over 5 runs in > the bluebird benchmark. > > BUG=v8:5046 > > Committed: https://crrev.com/df4f8a2b9ee9e474e674301718d19b63650a0ba5 > Cr-Commit-Position: refs/heads/master@{#36688} TBR=littledan@chromium.org,adamk@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5046 Review-Url: https://codereview.chromium.org/2047553002 Cr-Commit-Position: refs/heads/master@{#36766}
-
gsathya authored
When |ResolvePromise| is resolved with a promise that is already fulfilled or resolved, we can short circuit the promise resolution procedure by directly looking up the result from the promise. We save creating two closures, enqueuing in the promise queue, and running through PromiseThen. This patch uses IsPromise to check if the |resolution| object is a native promise and also checks if |resolution.then| hasn't been monkey patched. This patch adds some redundant code from PromiseThen like setting the promiseHasHandlerSymbol and calling PromiseRevokeReject call, which would've been taken care of by PromiseThen in the old code path. This patch results in a 13.8% improvement(over 5 runs) in the bluebird benchmarks. BUG=v8:5046 Review-Url: https://codereview.chromium.org/2028253004 Cr-Commit-Position: refs/heads/master@{#36765}
-
adamk authored
Revert of [stubs] Enable TurboFan LoadIC dispatcher stub. (patchset #1 id:1 of https://codereview.chromium.org/2033943005/ ) Reason for revert: Fails cctest consistently on Linux nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/7185 https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/7186 https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/7187 Original issue's description: > [stubs] Enable TurboFan LoadIC dispatcher stub. > > Committed: https://crrev.com/46a9322e88de037598cfd1090285375d97b11db2 > Cr-Commit-Position: refs/heads/master@{#36760} TBR=verwaest@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2042873002 Cr-Commit-Position: refs/heads/master@{#36764}
-