- 22 Apr, 2015 2 commits
-
-
machenbach authored
Revert of Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #1 id:1 of https://codereview.chromium.org/1103473003/) Reason for revert: This was probably an infrastructure problem caused by the mac ninja/goma switch. Original issue's description: > Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #7 id:140001 of https://codereview.chromium.org/1011823003/) > > Reason for revert: > [Sheriff] breaks mac gc stress: > http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1029 > > Original issue's description: > > [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) > > > > BUG=v8:3965, v8:3966 > > R=arv@chromium.org > > LOG=N > > > > Committed: https://crrev.com/b09c048f693d280052ac63c7d6b3baf27b3bf271 > > Cr-Commit-Position: refs/heads/master@{#27985} > > TBR=arv@chromium.org,caitpotter88@gmail.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3965, v8:3966 TBR=arv@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3965, v8:3966 Review URL: https://codereview.chromium.org/1098243002 Cr-Commit-Position: refs/heads/master@{#27999}
-
machenbach authored
Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #7 id:140001 of https://codereview.chromium.org/1011823003/) Reason for revert: [Sheriff] breaks mac gc stress: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1029 Original issue's description: > [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) > > BUG=v8:3965, v8:3966 > R=arv@chromium.org > LOG=N > > Committed: https://crrev.com/b09c048f693d280052ac63c7d6b3baf27b3bf271 > Cr-Commit-Position: refs/heads/master@{#27985} TBR=arv@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3965, v8:3966 Review URL: https://codereview.chromium.org/1103473003 Cr-Commit-Position: refs/heads/master@{#27990}
-
- 21 Apr, 2015 1 commit
-
-
caitpotter88 authored
BUG=v8:3965, v8:3966 R=arv@chromium.org LOG=N Review URL: https://codereview.chromium.org/1011823003 Cr-Commit-Position: refs/heads/master@{#27985}
-
- 10 Dec, 2014 1 commit
-
-
adamk authored
They both now run fast (due to utilizing transitions instead of always creating new maps) and sealed or non-extensible objects can stay in fast mode after transitioning. This almost entirely reuses the code for transitioning objects frozen by Object.freeze(), with the added benefit of freeing up a bit on the map (we no longer keep track of frozen-ness, as that bit wasn't used for anything interesting). BUG=v8:3662,chromium:115960 LOG=y Review URL: https://codereview.chromium.org/776143005 Cr-Commit-Position: refs/heads/master@{#25759}
-
- 11 Nov, 2014 1 commit
-
-
jkummerow@chromium.org authored
This relands commit ea74f0f8. The revert was due to failures in cctest/test-heap/ReleaseOverReservedPages, caused by apparent changes to memory layout and fragmentation of the first page. Eliminating a situation in messages.js where this CL has had an effect on map transitions seems to solve the issue. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/714883003 Cr-Commit-Position: refs/heads/master@{#25266} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25266 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Nov, 2014 2 commits
-
-
arv@chromium.org authored
This reverts commit e1f23eab4255d63344011dfb885b8e8962cb60e2. Broke cctest/test-heap/ReleaseOverReservedPages on a bunch of builders http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/928/steps/Check/logs/ReleaseOverReservedPa.. BUG=None LOG=N TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/709123002 Cr-Commit-Position: refs/heads/master@{#25224} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25224 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
(1) When we have just normalized and re-fastified a map, we don't need to copy it again to set the is_prototype bit. (2) When defining accessors causes a non-prototype object to go slow, don't force re-fastification. BUG=v8:3267 LOG=n R=verwaest@chromium.org Review URL: https://codereview.chromium.org/706243002 Cr-Commit-Position: refs/heads/master@{#25221} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25221 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Apr, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org TEST=mjsunit,test262,webkit Review URL: https://codereview.chromium.org/233083003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20717 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Nov, 2013 1 commit
-
-
mvstanton@chromium.org authored
Array builtins need to be prevented from changing frozen objects, and changing structure on sealed objects. BUG=299979 LOG=Y R=verwaest@chromium.org Review URL: https://codereview.chromium.org/80623002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18164 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 May, 2013 1 commit
-
-
verwaest@chromium.org authored
The bug in the existing code was that it modified the |attributes| local variable on its way through the loop in CopyUpToAddAttributes. But that affected any properties updated after an accessor property. The code now sets up a mask each time and applies that instead of mutating |attributes|. R=verwaest@chromium.org Review URL: https://chromiumcodereview.appspot.com/16051002 Patch from Adam Klein <adamk@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14818 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 May, 2013 1 commit
-
-
verwaest@chromium.org authored
This patch both speeds up the freeze operation itself, but also allows properties to remain in fast mode. Objects with non-empty elements backing stores still end up with slow elements. Relanding r14758 and r14759 with fix for Test262: only mark properties and elements READ_ONLY if they are not JS setter/getters. Tightened up tests to assert frozen-ness, and added targeted tests for the new code (covering accessors). BUG=v8:1858, 115960 R=verwaest@chromium.org Review URL: https://chromiumcodereview.appspot.com/15691007 Patch from Adam Klein <adamk@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14762 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 May, 2013 3 commits
-
-
adamk@chromium.org authored
and "Fix Object.freeze on dictionary-backed arrays to properly freeze elements" This reverts r14758 and r14759 due to introducing failures in Test262 TBR=verwaest@chromium.org Review URL: https://codereview.chromium.org/15681004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
adamk@chromium.org authored
Follow-up to r14758: slightly rearranges JSObject::Freeze() to avoid duplicating code while still retaining proper dictionary elements storage behavior. Also fix a lint error. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/15737018 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14759 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
adamk@chromium.org authored
This patch both speeds up the freeze operation itself, but also allows properties to remain in fast mode. Objects with non-empty elements backing stores still end up with slow elements. BUG=v8:1858, 115960 R=verwaest@chromium.org Review URL: https://codereview.chromium.org/14888005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14758 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 May, 2011 1 commit
-
-
ager@chromium.org authored
Our testing infrastructure uses exceptions to indicate errors. assertUnreachable therefore throws an exception to indicate that it was reached. Therefore, it cannot be used to check that an exception was thrown using the pattern: try { shouldThrow(); assertUnreachable(); } catch(e) { } Such a test will always pass because assertUnreachable will throw an exception if shouldThrow does not. R=ricow@chromium.org Review URL: http://codereview.chromium.org/7053035 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8117 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Mar, 2011 1 commit
-
-
ricow@chromium.org authored
This change makes us compatible with Safari on not throwing when trying to add a property to a non-extensible object. Review URL: http://codereview.chromium.org/6712059 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7379 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Aug, 2010 1 commit
-
-
sgjesse@chromium.org authored
BUG=http://code.google.com/p/v8/issues/detail?id=809 TEST=Seal/freeze an object and check if Object.seal and Object.freeze returns the given object. Burcu Dogan <burcujdogan@gmail.com> Review URL: http://codereview.chromium.org/3056049 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5176 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jul, 2010 1 commit
-
-
ricow@chromium.org authored
Since out internal representation of a property descriptor does not have configurable and writable attributes Object.isFrozen returns true whenever an object is not extensible. This change makes use of the right method calls on our internal representation (isWritable() and isConfigurable()). Tests added directly to the mjsunit test. Review URL: http://codereview.chromium.org/2904015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5068 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Jul, 2010 1 commit
-
-
ricow@chromium.org authored
This change adds ES5 15.2.3.9 Object.freeze and 15.2.3.12 Object.isFrozen Review URL: http://codereview.chromium.org/2944016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5055 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-