- 11 Mar, 2021 3 commits
-
-
Igor Sheludko authored
... instead of Code. This is useful because usually the callers are interested in having just a builtin ID but not the Code object. This CL also makes Builtins::kNoBuiltinId a part of the Builtins::Name enum. Bug: v8:11527 Change-Id: I501e3e52dccc73cc7800f271939e0bf9fd00a975 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749635Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#73331}
-
Georg Neis authored
OptimizedFrame::Summarize is used by debugger features etc to inspect the frame of an optimized function (and the virtual frames of functions that got inlined). It could end up materializing a JSArray with the same backing store as one that would later get left-trimmed, resulting in a dangling elements pointer. This CL fixes that by creating a fresh copy of the elements store instead. Bug: chromium:1182647 Change-Id: Iaf329464520a927b0ba33166cad2524d3752c450 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748593Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#73330}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/389d3f3..cb067b2 Rolling v8/third_party/aemu-linux-x64: oXIWsntGxFugYHN4Qb0Ve-IRPq4Rq1FxFYNiuEKnP0kC..ee1oRcPCyneRYNLsuBvxMYnBajvkvvdJY5BYvoaX0vUC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4f82770..7a3a736 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/57af8c3..c2c576e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/fc54e6b..e65f1a7 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I921f4b3aa14f88bae4a1a96a58c40db7796d1ae6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2751388Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73329}
-
- 10 Mar, 2021 20 commits
-
-
Junliang Yan authored
Change-Id: Iaf00bdfba9d42d1e472e048bffee2cde628d164a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749576Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#73328}
-
Junliang Yan authored
Change-Id: I953d1f9e1789cb6f754b1206edcac752e4f22801 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749575Reviewed-by:
-
Milad Fa authored
Change-Id: I86fbdc9ca2c1bf66092e52bc85a5b9dfbc696bfb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2749574Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73326}
-
Leszek Swirski authored
Robustify %CompileBaseline against fuzzing, and allowlist it in the fuzzer. Bug: v8:11420 Change-Id: I44947014c8c9362d80ea98636dbbaa5d07d6a177 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739643 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73325}
-
Clemens Backes authored
This will make it easier to generate builtin calls that require the context to be passed in that register, because this can be represented as a {LiftoffRegister} then. Drive-by: Fix a typo (x8 -> x28). R=thibaudm@chromium.org Bug: v8:11453 Change-Id: I7dcf7a0390dbde9713334d3da28ce6d79413a9f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748585Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73324}
-
Jakob Kummerow authored
Building arm64 binaries on arm64 hosts works as long as you set the correct options in args.gn. This patch teaches gm.py to do that. Building 32-bit arm binaries on arm64 hosts requires an extra definition in snapshot_toolchain.gni (as well as some system setup to support running 32-bit binaries). Change-Id: I66c1f8f51932e2f5425033ef09181c31ea5d633e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743889 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Milad Fa authored
Change-Id: I66712edab0d1242516add2fc6fc183168ef1fa11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748994Reviewed-by:
-
Benedikt Meurer authored
This is the V8 side change for https://crrev.com/c/2744048, which an explicit "stack" property into the (renamed) "Expression" scope to align the behavior and appearance of that scope with the other scopes. Fixed: chromium:1159310 Bug: chromium:1071432, chromium:1159307 Change-Id: Ic070c50b674d8c1cff4a93538f708cc431c3f2cb Screenshot: https://imgur.com/a/ryFiOGA.png Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748591 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/master@{#73321}
-
Thibaud Michaud authored
If the try block cannot throw, we don't expect an exception on the stack when we exit the block. R=clemensb@chromium.org Bug: v8:11537 Change-Id: I5f2ea6df2d14205b3ad2cd61a5132bc0b3db6cc8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748583Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#73320}
-
Frank Emrich authored
This fixes a handle leaking out of V8HeapExplorer::ExtractPropertyReferences when enabling v8_dict_mode_prototypes, which breaks the test-heap-profiler/NoHandleLeaks cctest. Bug: v8:11388 Change-Id: I911f60e3701277540ae5a63fa59f3ac2f52879ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748580Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Omer Katz authored
Reporting marked bytes after atomic sweeping means we might be missing allocations in case finalizers are allocating during sweeping. Instead report marked bytes and marking time directly to LocalEmbedderHeapTracer as soon as marking is done. Bug: chromium:1056170 Change-Id: Ie770f077d2eec10dea182a503a7cd514d3b66baf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748579 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73318}
-
Clemens Backes authored
Loops will always execute a stack check in the header, so having the instance cached in a register is handy. Instead of clearing it before entering a loop, ensure that backward jumps to the loop header move the instance into the right register. R=thibaudm@chromium.org Bug: v8:11336 Change-Id: I16cb13457438b7a1603182d56a3d2ea99d670911 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743892Reviewed-by:
-
Santiago Aboy Solanes authored
Fix to make the macro actually use the relaxed accessors instead of the atomic ones. Bug: v8:7790, v8:11539 Change-Id: Ic74ee4084a76176feac138716e10b88a3a5e1a1d Fixed: v8:11539 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748088 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Clemens Backes authored
Some ValueKinds were defined based on the size of a system pointer or the size of a tagged value. In order to be able to reuse those definitions in both LiftoffAssembler and LiftoffCompiler, define them as public constants on LiftoffAssembler. Also, avoid the "ValueType" suffix, since they are not ValueTypes, but ValueKinds. R=jkummerow@chromium.org Change-Id: I38f9c9b6c4e6592d31ee58466b786bf24a55f19c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743890Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73315}
-
Georg Neis authored
Bug: v8:7790 Change-Id: I1e7448c6583a36b2311474e14f4611935e2aa79f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748076Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#73314}
-
Clemens Backes authored
In contrast to wasm modules, asm.js modules have an empty source URL. Thus loosen a DCHECK and handle the nullptr source_url correctly. Also add regression tests that check that we don't crash. Those can later be extended to check that the profile looks as expected; for now they only check that we terminate. R=bmeurer@chromium.org Bug: chromium:1185919 Change-Id: I6b879f540a2c3647920ad2970efcf7c94712d8c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745895Reviewed-by:
-
Michael Achenbach authored
Bug: chromium:1154223 Change-Id: Ie1786a499f87f86bc6f91a92a0dfb1a02889ef46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2748083Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/077f859..389d3f3 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/a5cc843..368c7dd Rolling v8/third_party/aemu-linux-x64: dBlHF6-1NU-vr6DU068Y8_WQHCWdk_yovRmg225wIr0C..oXIWsntGxFugYHN4Qb0Ve-IRPq4Rq1FxFYNiuEKnP0kC Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/75c9832..57af8c3 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/e6379c8..d879aac Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/630ab8a..fc54e6b TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I23f92a7e958b90228f898df85e3efa87c9429a73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2746751Reviewed-by:
-
Milad Fa authored
Change-Id: If9380a99318618199ced8f079d13ddee28cde770 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745896Reviewed-by:
-
Ng Zhi An authored
This is done with a script that does something like: files=$(ag 'v\d\d?x\d\d?[._]?all_?true' -l) sed -i 's/V\(8x16\|16x8\|32x4\|64x2\)\([._]\?\)\([aA]ll_\?[tT]rue\)/I\1\2\3/g' $(files) sed -i 's/v\(8x16\|16x8\|32x4\|64x2\)\([._]\?\)\([aA]ll_\?[tT]rue\)/i\1\2\3/g' $(files) And manual fixups in test-run-wasm-simd.cc and wasm-opcodes-inl.h. Bug: v8:10946 Change-Id: Ib5dad388dd6dd9cd0fb575ad961dffc189a2e6ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2740488Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73309}
-
- 09 Mar, 2021 17 commits
-
-
Ng Zhi An authored
They were using a fixed offset of pc+2, but since the instructions can be multiple bytes long (leb128 encoded), it should be using *len. Drive-by fix to add missing instructions to wasm-module-builder.js. Bug: chromium:1185323,chromium:1185492 Change-Id: I12f396cc2969ecc284aba35b94b1bc5640f12277 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745977 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I89dd887a75a475f998d950e86f35c7fe2af5d67f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743887Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73307}
-
Michael Lippautz authored
The test ensures that in-construction objects that have been found through a write barrier are properly processed (marked + trace) when finalizing the collection conservatively with a different stack. This is a test for https://crrev.com/c/2744074 Bug: chromium:1056170 Change-Id: I8099bca1fb9025a315a8f0a3530aac822d1c45d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745334Reviewed-by:
-
Dominik Inführ authored
It could happen that a background thread expands the heap by one page, but by the time the thread tries to allocate on it the space is already used by other background threads. If this happens three times in a row, V8 would crash with an OOM error. This CL prevents such situations by always allocating the object immediately at area_start(). Bug: v8:10315 Change-Id: I6390c84e742bf4105e70e930c21557ff1f4d952d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743881Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/f6034ebe..311265 Bug: v8:7834 Change-Id: Ib5b92ff8a2b32a2f9c4140c5f70c514e52ab191c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2744442 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#73304}
-
Clemens Backes authored
The wasm instance will initially be in kWasmInstanceRegister, and for each call we also need to put it in that register. Hence, when getting a new register to cache the instance, prefer that register, if it is available. R=thibaudm@chromium.org Bug: v8:11336 Change-Id: Ie7026c4c7c5e4b825b9ab310839f0273bd3ce7f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743885 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
... and after creating the debug side table entry. The safepoint and the debug side table entry should be generated right after the call, so that they are associated with the return address of the previous call. R=clemensb@chromium.org Bug: v8:11453 Change-Id: I71395851c5a7f4e2c873907454245c9d04f972f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739629 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Seth Brenith authored
The generated Torque files class-verifiers.cc and class-debug-readers.cc currently include files which are part of v8_initializers, despite being used in unrelated build targets. This change removes the unnecessary inclusions. There is still a lot of code included via all-objects-inl.h, but that's because these files require full class definitions for every object type. Bug: v8:11528 Change-Id: Ib26496f2a30ef576f1101636e0aca2cafbfd1f37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743087 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73301}
-
Maya Lekova authored
This CL removes the caching of the stack slot used for the fallback mechanism in V8, as the current implementation is incorrect and needs to be reworked. Bug: chromium:1185753 Change-Id: I9f77bc42bfd649e0dbcd294b000b48c928cf99d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743886 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Lazy native accessors require special handling to rewrite the accessor into a data property, so transition to a slow handler for this case. Bug: v8:11485 Change-Id: I01636c6e624562619a216fea5e836ae85c7da93f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743882Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#73299}
-
Clemens Backes authored
This ensures that after the function-entry stack check, the instance will still be available in a register. The cost is having to reload it from the stack in the OOL code for the stack check, even though it is not clear if that register will still be used. This does not affect code size significantly (~0.25% reduction), but can improve performance a little bit if there are memory accesses or other instructions that require the instance right at the beginning of the function. R=thibaudm@chromium.org Bug: v8:11336 Change-Id: Ib72db172813d55120f527b31014b69a734934ff3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2743878Reviewed-by:
-
Michael Achenbach authored
Bug: chromium:1154223 Change-Id: I9545db5ce76f973f8402cefe588d994d1519135b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745137Reviewed-by:
Liviu Rau <liviurau@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#73297}
-
Santiago Aboy Solanes authored
Reading the descriptor array from a map has been safe for a while. Bug: v8:7790 Change-Id: Ib06e12727b7da26c09822db45530addc11e2cf00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739637Reviewed-by:
-
Thibaud Michaud authored
Push the caught exception on the value stack, so that we can access it from an inner catch block and rethrow it. R=clemensb@chromium.org Bug: v8:11453 Change-Id: Ibc5e653a07c3e4436e252c001b53bc2d3402abc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2739974Reviewed-by:
-
Jakob Kummerow authored
With the value stack refactoring in 1b5c7e15 / r73193, the combination of helper functions called by PeekArgs() ended up checking the stack height repeatedly. This CL avoids that by introducing a ValidateArgType() helper that does not check stack height. Bonus: achieve a small speedup by special-casing two of the most common opcodes in the decoder's main dispatcher. Fixed: chromium:1185082 Change-Id: I6d51aca844ef9377d203147f74ff8137e12a23e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745341 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
pthier authored
This is a reland of a8b61ef5 The main reason for the revert was not related to this CL and was fixed with https://crrev.com/c/2739646 In addition debug output in d8.test.verifySourcePositions was removed due to TSAN complaints. Original change's description: > [sparkplug] Change bytecode offset mapping and introduce iterator. > > Previously, we recorded pairs of (bytecode offset, sparkplug pc) to > create a mapping of bytecode offset <-> sparkplug pc. > These pairs were only recorded after builtin/runtime calls. > In preparation for deoptimizing to Sparkplug, we need a more precise > mapping. > With this CL, we record positions for every bytecode. Instead of storing > a pair of (bytecode offset, sparkplug pc), we store only the pc, > calculating the bytecode offset from the index in the mapping table. > For easier use an iterator to access the mapping is introduced. > > Drive-by: Reduce sampling interval in cpu-profiler cctest to get rid of flaky failures. > > Bug: v8:11420, v8:11429 > Change-Id: I36a9171f43a574eb67880cbca6cf9ff7ab291e60 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720189 > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Auto-Submit: Patrick Thier <pthier@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73186} > > Change-Id: I9ab4cb60da002ef130f8a21ad10ba69e2826a7b6 Change-Id: I9ab4cb60da002ef130f8a21ad10ba69e2826a7b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745335Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#73293}
-
Leszek Swirski authored
Do --always-sparkplug compilations in a separate function, and allow that function to return false if a sparkplug compilation fails. Similarly, don't assert that --always-sparkplug requires a function to have baseline code, in case a previous sparkplug compilation failed. Fixed: chromium:1185735, chromium:1185739 Change-Id: I363fcf271395afa2ec47228fff7a28a76c157f0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2744735 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
