- 27 May, 2020 3 commits
-
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I4ae500548e7ab09f5bd037563af5c057751197bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215049Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#67996}
-
Iain Ireland authored
To ensure that regexp syntax errors are reported as early errors, SpiderMonkey calls ParseRegExp at parse time to validate that the regexp parses properly. This does not require the allocation of named capture information. We have a project underway to completely eliminate the allocation of GC things at parse time, which will require us to suppress the allocation of named capture information (or else jump through hoops to implement FixedArray as a non-GC thing). We can work around this in our shim layer -- for example, by setting a flag on the Factory shim that causes us to allocate dummy objects -- but it's much simpler to add an option to ParseRegExp. (Note: V8 currently does not treat regexp syntax errors as early errors. See https://bugs.chromium.org/p/v8/issues/detail?id=896.) Bug: v8:10406 Change-Id: Ib5f0613a54509146e00f90cf61bda4bf03b03859 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207813 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67995}
-
Manos Koukoutos authored
Motivation: In the wasm-gc proposal, structs and arrays are allowed to store elements of packed types i8 and i16. Changes: - Add i8 and i16 to ValueType. - Fix all case switches to handle the new cases. - Add a couple helper methods to ValueType and improve the implementation/usage of a couple more. Bug: v8:7748 Change-Id: I527cfe5acf5d877fc38e4212174ba9f9de5c40ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215046Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
- 26 May, 2020 34 commits
-
-
Ng Zhi An authored
This removes the post-mvp flag for bitmask, since it was accepted into the proposal, see https://github.com/WebAssembly/simd/pull/201. Bug: v8:10308 Change-Id: I4ced43a6484660125d773bc9de46bdea9f72b13b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2216532Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67993}
-
Milad Farazmand authored
Change-Id: Ife10d7c8634cbd6b542dc522a49124f790f51921 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2216434Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67992}
-
Seth Brenith authored
We can do a good job of optimizing Torque expressions that load and check multiple bitfields from a bitfield struct, but only if those expressions are written using the binary `&` operator as opposed to the logical `&&`. This change adds a lint rule to detect some simple cases where we should clearly prefer `&` to `&&`. Bug: v8:7793 Change-Id: Id996a7971cff8f7f83198075a172170d9c7d42e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207666 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
-
Ng Zhi An authored
Making them private was a way to hide the constructor, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: Iddc00b86e5481b90c20d9c68f1261f853ac8d5dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2210778Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67990}
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: I904fa4fada2860938a32be9f0a84af091adc76ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211193Reviewed-by:
-
Ng Zhi An authored
Making them private was a way to hide the constructor, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: I9268f42b9367cc1af4d58e71e2033c254ed4cbf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2210777Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: I872782060c22812c93eadf4f77ba75c058283b8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2210779 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9909 Change-Id: Ic3a13131e07487512161eec1bec0cdc33a0a3f63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207664Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67986}
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: I78fdfb904ea94d9ae034b41cd43be8689a0096ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211188 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Daniel Clifford authored
There was a legacy place in map code that wasn't fully ported to use the strong, new SloppyArgumentsElements type because of code that used hard-coded constants. Bug: chromium:1086470 Change-Id: Ieba152e4bd92c89125f831949c2efb4f4219f95c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215059Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: Ia2bf5c1ec84dd4473d0e013ec3d22548b38a0578 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211190Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67983}
-
Ng Zhi An authored
Making them private was a way to hide them, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: Ieffa05951aeefc0225f8fb84e756eb67353e57a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211184Reviewed-by:
-
Seth Brenith authored
VisitWord32EqualImpl was checking for inputs of type kCompressedHeapConstant, but it can also sometimes have inputs of type kHeapConstant. In either case, we can check for whether to do a load from the roots array. This improves Octane score by about 3% (or about 1.5% if --no-opt is specified). Bug: v8:8948 Change-Id: Iab6c0b1dacd96c74e4cfb54c772aa92e5baf00ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213081 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67981}
-
Ng Zhi An authored
Making them private was a way to hide them, we can explicitly delete them, which give a better compilation error message as well. Also see: https://stackoverflow.com/q/55205874 Bug: v8:10488 Change-Id: I3f2b6881ae2252809c84fbd32ce0687e8328506e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211182Reviewed-by:
-
Ng Zhi An authored
Recommended by clang-tidy's modernize-use-nullptr. Bug: v8:10488 Change-Id: I7cf26f7bda69b9b1a6bdabe274399b494f6d49ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211155Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: I66efe295b8a3372bc2e99516447f70d258520090 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211185Reviewed-by:
-
Anton Bikineev authored
This reverts commit a35d0e8c. The original CL is likely not a culprit for the infra failures. Bug: chromium:1056170 Change-Id: I8fa85db8a737fb01328021782f0c43626fa52b0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215826Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#67977}
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: I5eac73a2b437e5e2d4005f79b7807ae7a9ed78e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2214829Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67976}
-
Milad Farazmand authored
Change-Id: I5a93231b16c8291c87fce57062837dce886bc2f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2216231Reviewed-by:
-
Santiago Aboy Solanes authored
Several tests were using them and we can dedup code. Change-Id: I4ef5ae5772856d1f36e965b6b62ff5895b4e04fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215173Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#67974}
-
Maya Lekova authored
Bug: v8:9975 Change-Id: I51cbc83adecfa52959c991ed3c6f26cf4929c297 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215175Reviewed-by:
-
Seth Brenith authored
This reverts commit 4e5fabae. Reason for revert: performance regressions chromium:1085305, chromium:1084978 Original change's description: > [torque][cleanup] Use more precise field types in a few classes > > This change updates some Torque-defined classes to include more precise > field types where possible. It also updates those classes to use > @generateCppClass. One field was removed because it's unused > (PrototypeInfo::validity_cell), and two fields in StackFrameInfo > actually became less precise because they're based on Script::name, > which is an embedder-provided untyped Local<Value>. (Automatically > generated accessors pointed out this bug easily.) > > This change also includes a couple of minor fixes in Torque. > > Change-Id: Ib2bc6c7165bb3612b6d344c0686a94165a568277 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2199640 > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67907} TBR=ulan@chromium.org,tebbi@chromium.org,verwaest@chromium.org,seth.brenith@microsoft.com Change-Id: I720821d8dc84ea0d79eb137f1c2507f75df9a107 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211322Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67972}
-
Victor Gomes authored
This CL is a step towards reversing JS stack arguments for TurboFan. It does the following: 1. Add StackOrder to CallInterfaceDescriptor 2. Reverse arguments in TF backend for JS calls. 3. Cleanup TFJ builtins interface descriptors, since calls for these builtins already reverse the arguments, we don't need to reverse the interface descriptor anymore. Change-Id: Ie840b1757bf023aa381a7fa01cbe66e7cf90778f Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213440Reviewed-by:
-
Maya Lekova authored
This reverts commit 9a0e6bd5. Reason for revert: Speculative revert for https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20builder/47777 Original change's description: > cppgc: Port concurrent sweeper > > This moves concurrent and incremental sweeping from Blink. This also > adds TestPlatform that makes it easier to test concurrent and > incremental sweeping. > > Drive-by: fix unmarking of large pages. > > Bug: chromium:1056170 > Change-Id: Ifd50ff67b9df17ff117a5f4d4eb5a2937d3023be > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207132 > Commit-Queue: Anton Bikineev <bikineev@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67969} TBR=ulan@chromium.org,mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org Change-Id: I5530f11f7b8560116324bb156ba98e426c0feb35 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215057Reviewed-by:
-
Anton Bikineev authored
This moves concurrent and incremental sweeping from Blink. This also adds TestPlatform that makes it easier to test concurrent and incremental sweeping. Drive-by: fix unmarking of large pages. Bug: chromium:1056170 Change-Id: Ifd50ff67b9df17ff117a5f4d4eb5a2937d3023be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207132 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Dominik Inführ authored
With --stress-incremental-marking we want to start concurrent marking faster by also sweeping pages on incremental marking steps. Bug: v8:10315 Change-Id: Ie3fa04acc5e59a4b81c3351f4b522c78368bb1a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2210247 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Objects allocated on the background thread during incremental marking, need to be allocated black. This prevents concurrent marking to observe uninitialized objects. Bug: v8:10315 Change-Id: Ia4b05a2a72e4142c79b31a01cbf162a6599a18c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196347 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Clemens Backes authored
The Isolate is only used to access the wasm engine, and the accounting allocating. The latter is also linked directly from the wasm engine, and the engine is linked from the native module, to which the DebugInfoImpl already has access. Hence, this CL removes the redundant Isolate pointers, and just accesses the engine and the allocator via the NativeModule. R=thibaudm@chromium.org Change-Id: Ib51cee2d166443a34e22fa02e8ad1549328aaa7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2214827Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67966}
-
Clemens Backes authored
Triggering recompilation can reduce the number of outstanding recompilation functions. If it gets reduced to zero, we also need to trigger other callbacks waiting for recompilation to finish. This situation can happen if all recompiled code was already installed in the native module, but the compilation state was not updated yet via {OnFinishedUnits}. R=thibaudm@chromium.org Bug: v8:10557, chromium:1084369, v8:10359 Change-Id: Ib80ff110776cf284632303b0b23e4c6e63426411 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2214828Reviewed-by: -
Clemens Backes authored
The interpreter is still used for testing, but frame inspection is not wired any more. Hence this CL removes it. R=thibaudm@chromium.org Bug: v8:10389 Change-Id: If93928dd3996a19c1251a93d843034574d4c43ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215165Reviewed-by:
-
Jakob Gruber authored
... and CallParameters::arity(). The construct arity contains the actual argument count, plus 2 for the target (the first input) and new target (the last input). This CL adds a named constant and a helper method for accessing arity without extra args. In the future we may want to remove the extra args from arity() altogether. Call arity is similar but includes the target and receiver. Bug: v8:10542,v8:8888 Change-Id: I850fa314f88c2bee9d4dcd87eac9295b2bf88281 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208850 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#67963}
-
Jakob Gruber authored
If --turbo-nci is enabled, use unary op builtins with feedback collection during generic lowering. Bug: v8:8888 Change-Id: Ie32cfe1558a7fbada2ac69a99ef969097558bc89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209067 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Kim-Anh Tran authored
This adds the wasm instance to the module scope. The instance contains the exported entities that can now be inspected. Bug: chromium:1043034 Change-Id: I9236ac9c126f3bc4b1e056990fe34956bbe8ed6b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213433 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#67961}
-
Manos Koukoutos authored
After all struct/array definitions are parsed, we need to check if all reference type indices are legal. We need to do it at the end because types can be mutually recursive. Bug: v8:7748 Change-Id: I5e6b5185e7d0c5e8d905b6833a2b9026ab630c01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2214821 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
- 25 May, 2020 3 commits
-
-
Shu-yu Guo authored
Bug: v8:10552 Change-Id: I1160ff0f9d2c91bb3c2ad3e0d5e1f36953538420 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211402Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#67959}
-
Clemens Backes authored
The interpreter is not used for debugging any more. Hence any breakpoint support and related functionality is dead code. This CL removes - the {SetBreakpoint} and {GetBreakpoint} methods, - the {break_pc_} field which holds the current pause position, - the {break_flags_} field which is used to break at function entry and after calls, - functions to modify {break_flags_}, - the dead {kInternalBreakpoint} and {kInvalidPc} constants (plus respective macros and enums), - the {orig_start} and {orig_end} fields (code is not being modified any more, so we just use {start} and {end} now), - the {PrepareStepIn} method, - the unimplemented {SetTracing} method, and - two tests that test breakpoints in the interpreter. R=thibaudm@chromium.org Bug: v8:10389 Change-Id: I52103c37516446e40d3dfa365d6b480a7c623577 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2215163 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
If multiple isolates share the same module, and the debugger gets enabled, then we trigger tier down in each isolate separately. To avoid generating too much code, we only recompile functions that are not already in the right tier. This CL is only the first step towards an actual fix. Since we only check already installed code (and ignore compilations that are already scheduled), we might still compile the same functions multiple times. A second CL will make sure that only one recompilation is running at the same time. R=thibaudm@chromium.org Bug: chromium:1084369, v8:10359 Change-Id: Ic4f9afac1add0fe8ad9e5d68f22d3d41ba2e52be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2213438Reviewed-by:
-
