Commits · 161b2f689a09cab75a7ff624277bab27bb1866c7 · Linshizhi / V8

12 Feb, 2014 28 commits

Reland: "Use stability to only conditionally flush information from the CheckMaps table." · 161b2f68

verwaest@chromium.org authored Feb 12, 2014

BUG=
R=ishell@chromium.org

Original CL: https://codereview.chromium.org/153823003

Review URL: https://codereview.chromium.org/153653007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19342 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

161b2f68

Don't propagate information through phis in loop headers. · 7b7e3658

verwaest@chromium.org authored Feb 12, 2014

To properly do this, we'd have to iterate over CompareMaps (and their bodies) handling phis, until we have learned enough to decide which paths can be taken. For now, just disable learning from phis in loop headers.

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/147023005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19341 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7b7e3658

[a64]: Disable failing sparse-array-reverse on a64 debug builds. · 26e80099

rmcilroy@chromium.org authored Feb 12, 2014

BUG=v8:3158
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/160633002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19340 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

26e80099

KeyedLoadIC::GenerateGeneric() fix for MIPS. · 7e3218b5

ishell@chromium.org authored Feb 12, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/160353003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19339 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7e3218b5

Fix test-heap/OptimizedPretenuringAllocationFolding wrt concurrent recompilation delay. · 6c4133a3

yangguo@chromium.org authored Feb 12, 2014

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/148063008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19338 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6c4133a3

Stack trace string should use dynamic script sourceURL if present. · 887bd285

alph@chromium.org authored Feb 12, 2014

BUG=v8:2342
R=dcarney@chromium.org, yurys@chromium.org, yurys
LOG=N

Review URL: https://codereview.chromium.org/143283015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19333 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

887bd285

Make prev and next pointer in pages list AtomicWords and access them using... · 81347246

hpayer@chromium.org authored Feb 12, 2014

Make prev and next pointer in pages list AtomicWords and access them using acquire/release semantics.

BUG=
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/150413009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19332 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

81347246

Revert "Use stability to only conditionally flush information from the CheckMaps table." · 75432b76

verwaest@chromium.org authored Feb 12, 2014

R=ishell@chromium.org

BUG=

Review URL: https://codereview.chromium.org/137863005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19331 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

75432b76

Use stability to only conditionally flush information from the CheckMaps table. · 2b7d3357

verwaest@chromium.org authored Feb 12, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/153823003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19330 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2b7d3357

Port of r19288 to a64: Fix for smi stores optimization. · 1512e9e6

ishell@chromium.org authored Feb 12, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/159513004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19329 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1512e9e6

Avoid doing explicit cast in simulator-a64::get_sp(). · e5033969

rmcilroy@chromium.org authored Feb 12, 2014

R=rodolph.perfetta@arm.com

Review URL: https://codereview.chromium.org/153823012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19328 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e5033969

Add to OWNERS for arm and a64 · 7152389a

rmcilroy@chromium.org authored Feb 12, 2014

R=danno@chromium.org

Review URL: https://codereview.chromium.org/138953017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19327 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7152389a

Fix for (One|Two)ByteSeqStringSetChar evaluation order/deopt. · af29e31a

jarin@chromium.org authored Feb 12, 2014

This makes the evaluation order consistent between full codegen
and Hydrogen (so that deopt does not screw up stack).

R=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/159983008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19326 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af29e31a

Clean up some A64 specific code in common code that was introduced by A64 merge · 6ef556bd

rmcilroy@chromium.org authored Feb 12, 2014

 - Remove arch specific check macros
 - Remove duplicate code in code-stubs.h
 - Remove flag check in bootstrap.cc which was introduced for A64 bringup
 - Remove A64 specific test message expectations

R=rodolph.perfetta@arm.com, ulan@chromium.org

Review URL: https://codereview.chromium.org/134333011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19325 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6ef556bd

[a64] Omit redundant smi checks in write barriers. · b4214a12

bmeurer@chromium.org authored Feb 12, 2014

R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/156603007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19324 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b4214a12

Omit redundant smi checks in write barriers. · 85856fea

bmeurer@chromium.org authored Feb 12, 2014

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/155843006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19323 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

85856fea

Improve computation of effects for load elimination. · 9ef9c4cd

bmeurer@chromium.org authored Feb 12, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/152953004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19322 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9ef9c4cd

A64: Skip tests failing on gc stress bots · b0fcc801

jochen@chromium.org authored Feb 12, 2014

BUG=none
TBR=ulan@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/160353002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19321 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b0fcc801

Improved variable-related assembler comments in fullcode. · ad536f2a

svenpanne@chromium.org authored Feb 12, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/157033012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19320 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ad536f2a

Refactor scope and function state tracking in (Pre)Parser. · 10ae9eb2

marja@chromium.org authored Feb 12, 2014

Notes:
- PreParser::Scope was a weird combination of Parser::FunctionState and
  Scope. Split it into two (PreParser::FunctionState and PreParser::Scope). This
  is necessary for unifying the Parser and the PreParser.
- Scopes take care of language mode and tracking "with".
- FunctionStates take care of counting material literal indexes, properties
  etc. and tracking generators.
- PreParser::Scope::InsideWith was a hack to make a FunctionState-like object
  take care of tracking "with". It's now the responsibility fo PreParser::Scope
  and Scope.
- PreParser::ScopeType is unnecessarly, there is already a ScopeType enum in
v8globals.h.
- Renamed scope stack variables so that they're consistent in Parser and PreParser.
- Parser::FunctionState and Parser::BlockState had an unnecessary dependency to
  the Parser; they only need a couple of things from Parser. Broke the
  dependency.

R=ulan@chromium.org
BUG=v8:3126
LOG=N

Review URL: https://codereview.chromium.org/148293011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19319 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

10ae9eb2

A64: Skip more known failures · 96a18866

jochen@chromium.org authored Feb 12, 2014

TBR=ulan@chromium.org
BUG=none
LOG=n

Review URL: https://codereview.chromium.org/160073007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19318 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

96a18866

Move parenthesized_function_ to ParserBase. · cec4fb02

marja@chromium.org authored Feb 12, 2014

This change is trivial (was probably overlooked when ParserBase was created).

R=yangguo@chromium.org
BUG=v8:3126
LOG=N

Review URL: https://codereview.chromium.org/150943008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19317 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cec4fb02

A64: Remove two TODOs that will not be done. · 652ba510

alexandre.rames@arm.com authored Feb 12, 2014

- For the LDP/STP TODO: The arguments need dereferencing, so using LDP/STP would
  require some additional checks.
- For the constant pools TODO: Unless we need to, there is no benefit from
  trying to generate constant pools more often, as it would likely only pollute
  the I-cache.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/151363004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19316 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

652ba510

Add ARM contributors to AUTHORS. · 558de62f

jacob.bramley@arm.com authored Feb 12, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/134083011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19315 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

558de62f

A64: Skip cctests failing in debug mode · c2c9228c

jochen@chromium.org authored Feb 12, 2014

TBR=ulan@chromium.org
BUG=none
LOG=n

Review URL: https://codereview.chromium.org/160303003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19314 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c2c9228c

Merge experimental/a64 to bleeding_edge. · e95bc7ee

ulan@chromium.org authored Feb 12, 2014

BUG=v8:3113
LOG=Y
R=jochen@chromium.org, rmcilroy@chromium.org, rodolph.perfetta@arm.com

Review URL: https://codereview.chromium.org/148293020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19311 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e95bc7ee

Disable test-api/PreCompileInvalidPreparseDataError for NaCl. · a4ea7000

marja@chromium.org authored Feb 12, 2014

More information: https://code.google.com/p/v8/issues/detail?id=3150

R=machenbach@chromium.org

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19306 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a4ea7000

Prepare push to trunk. Now working on version 3.24.38. · 3606220e

machenbach@chromium.org authored Feb 12, 2014

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/156853008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19303 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3606220e

11 Feb, 2014 12 commits

More check elimination improvements including partial learning on false... · b446674c

ishell@chromium.org authored Feb 11, 2014

More check elimination improvements including partial learning on false branches of CompareMap and better handling of unreachable blocks.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/159963002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19300 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b446674c

Mark faster when executing write barriers. · 36ba6f01

hpayer@chromium.org authored Feb 11, 2014

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/159833002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19290 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

36ba6f01

Fix environment of the optimized version of the _SetValueOf intrinsic. · 21bf99e5

jarin@chromium.org authored Feb 11, 2014

R=jkummerow@chromium.org
BUG=

Review URL: https://codereview.chromium.org/158723006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19289 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

21bf99e5

Fix for a smi stores optimization on x64 with a test case. · 994f0f6d

ishell@chromium.org authored Feb 11, 2014

BUG=338425
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/152923006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19288 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

994f0f6d

Remove extended_extra_ic_state and extend extra_ic_state instead. · 78f568d6

verwaest@chromium.org authored Feb 11, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/159013003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19287 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

78f568d6

Clean up accessors in the Isolate. · 466df42a

yangguo@chromium.org authored Feb 11, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/137213009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19285 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

466df42a

Add more test cases for api function inlining · ce789e88

dcarney@chromium.org authored Feb 11, 2014

R=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/154283003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19278 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ce789e88

Cleanup: ContextualMode doesn't need to be passed to ICs. · 1d88f090

mvstanton@chromium.org authored Feb 11, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/154113010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19277 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1d88f090

Move ParseRegexpLiteral to ParserBase. · f59ac1cb

marja@chromium.org authored Feb 11, 2014

R=ulan@chromium.org
BUG=v8:3126
LOG=N

Review URL: https://codereview.chromium.org/156423005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19273 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f59ac1cb

Harmony: fix spec violation in Math.cosh. · 08707024

yangguo@chromium.org authored Feb 11, 2014

R=jarin@chromium.org
BUG=v8:3141
LOG=N

Review URL: https://codereview.chromium.org/159353003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19272 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

08707024

Disable concurrent osr for test-mark-compact/BootUpMemoryUse. · ab2aaac1

yangguo@chromium.org authored Feb 11, 2014

If --concurrent-osr is on, it will imply --concurrent-recompilation, even
though it's expected to be disabled.

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/143183006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19271 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ab2aaac1

Move allocation site pretenuring decision making to GC epilog. · 117d0dc4

hpayer@chromium.org authored Feb 11, 2014

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/149913005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19270 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

117d0dc4