- 11 Feb, 2019 29 commits
-
-
Caitlin Potter authored
Currently, PRIVATE_NAME / PrivateIdentifier is not valid in ObjectLiterals or other places expecting the PropertyName production. A SyntaxError here prevents an access violation later on when attempting to dereference a null property key BUG=v8:8808 R=gsathya@chromium.org, littledan@chromium.org Change-Id: Idde9c669cb48c1595b83115351a8fe0caed40eef Reviewed-on: https://chromium-review.googlesource.com/c/1461161Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#59515}
-
Alexei Filippov authored
The line number is associated with each sample along with pointer to the ProfileNode and timeDelta. Once collected line numbers are streamed as an array of integers in "ProfileChunk" trace events. If all the line numbers are zero, the array may be omitted. Otherwise the array length matches length of samples and timeDeltas arrays. BUG=chromium:925089 Change-Id: I1ef5cd1b208b03bb127f4d17b1efa74c01959542 Reviewed-on: https://chromium-review.googlesource.com/c/1459739Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#59514}
-
Z Duong Nguyen-Huu authored
This will happen incrementally. Bug: v8:8553 Change-Id: If92eacf85044bfcbc30d5551b817725c1fe1a937 Reviewed-on: https://chromium-review.googlesource.com/c/1457436Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#59513}
-
Toon Verwaest authored
It's automatically detected in VariableDeclarationParsingScope::Declare. Change-Id: I2cf406ebd2dcd66eefb3d709289e0a8d162d0251 Reviewed-on: https://chromium-review.googlesource.com/c/1463783Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59512}
-
Ulan Degenbaev authored
Bug: chromium:852420 Change-Id: I9c86353734055ef08ab5b2d3c55bf5dd0a870335 Reviewed-on: https://chromium-review.googlesource.com/c/1463520 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#59511}
-
Dan Elphick authored
Removes deprecated platform::CreateDefaultPlatform, Object::GetPropertNames/GetOwnPropertyNames/HasRealNamedProperty/ HasRealIndexedProperty/HasRealNamedCallbackProperty, Function::New/Call and Isolate::SetWasmCompileStreamingCallback. Change-Id: I00c73576bbfbdc6bbe72bad9ac9d7a338a5bf068 Reviewed-on: https://chromium-review.googlesource.com/c/1460952Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#59510}
-
Michael Lippautz authored
Change-Id: I9544759a42f66dc384d354204be64081c5cc39fe Reviewed-on: https://chromium-review.googlesource.com/c/1461996 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#59509}
-
Jaroslav Sevcik authored
Given a map, its HasNonInstancePrototype bit in bit_field can differ from the same bit in that map's root map. If that is the case just return false from the equivalence check. (Currently, we just assert that bit_field is the same for a map and its root map.) Bug: chromium:930486 Change-Id: Ic0eb83f80725fb1224e0f97927127e1cb8ad92e6 Reviewed-on: https://chromium-review.googlesource.com/c/1462004Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59508}
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: I8fa2659814f1d9585d0e2313540e8c11997eec6b Reviewed-on: https://chromium-review.googlesource.com/c/1459636 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#59507}
-
Andrew Comminos authored
Fixes a segfault that occurs when v8::CpuProfilers are restarted caused by the reuse of a stale CodeEventObserver. Bug: chromium:929928 Change-Id: I5d5f7eaf5cd903910130cdb0cfec8c3fd6608edd Reviewed-on: https://chromium-review.googlesource.com/c/1459740Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Mythri authored
The spec specifies that a non-true return values from the trap functions should be treated as error in the strict mode. With the new lazy feedback effort inferring the language mode is expensive and causes regression on these tests. Since the test doesn't actually need to test this, fixing them to return true would help test the performance of calling the trap without the unnecessary overhead of inferring the language mode. Bug: chromium:925289 Change-Id: Ib650c3210ee260296257ae3b56174099a5492675 Reviewed-on: https://chromium-review.googlesource.com/c/1462959 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#59505}
-
Ulan Degenbaev authored
The test says that it is testing dictionary mode, but it is only creating fast mode arrays. Bug: chromium:852420 Change-Id: I99ccc997aaa87ecf49bddf02e46b7e543f535374 Reviewed-on: https://chromium-review.googlesource.com/c/1462918Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59504}
-
Ulan Degenbaev authored
Bug: chromium:852420 Change-Id: I659e8d2d047387d7b73f11406b29696d74d84ff7 Reviewed-on: https://chromium-review.googlesource.com/c/1462965Reviewed-by:
-
Santiago Aboy Solanes authored
tagged fields. Implemented TurboAssembler::StoreTaggedField for tagged fields's store. Instead of pushes like x64 does, in arm64 do loads due to doing a load-poke combination rather than just a push. See https://chromium-review.googlesource.com/c/v8/v8/+/1382740 for the x64 version. Bug: v8:7703 Change-Id: I79fbba4b03260c0dba5624e990c5af51290b28c6 Reviewed-on: https://chromium-review.googlesource.com/c/1462956 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#59502}
-
Santiago Aboy Solanes authored
This CL introduces TurboAssembler::LoadTaggedPointerField() and TurboAssembler::LoadAnyTaggedField(), which respectively loads a field containing a HeapObject, or any tagged value, and decompresses it if necessary. Bug: v8:7703 Change-Id: I71ace74d7433a3a78d56bdcef6d2ec041df630e4 Reviewed-on: https://chromium-review.googlesource.com/c/1456098 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:852420 Change-Id: I08207462e1177fb7e56d37ce221d8bef21cfb25e Reviewed-on: https://chromium-review.googlesource.com/c/1462964Reviewed-by:
-
Junliang Yan authored
Port 9e060e47 Original Commit Message: When BUILDING_V8_SHARED in release builds __declspec(dllexport) causes generation of implicit constructors in the forwarding class while its deleted in TurboAssemblerBase, which leads to compilation errors like: In file included from gen/v8/v8_base_jumbo_6.cc:41: In file included from .\../../v8/src/interface-descriptors.cc:7: In file included from ../../v8\src/macro-assembler.h:40: ../../v8\src/x64/macro-assembler-x64.h(92,9): error: call to deleted constructor of 'v8::internal::TurboAssemblerBase' : TurboAssemblerBase(std::forward<Args>(args)...) {} ^ ~~~~~~~~~~~~~~~~~~~~~~~~ ../../v8\src/x64/macro-assembler-x64.h(536,25): note: in instantiation of function template specialization 'v8::internal::TurboAssembler::TurboAssembler<v8::internal::TurboAssembler>' requested here class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler { ^ ../../v8\src/turbo-assembler.h(127,34): note: 'TurboAssemblerBase' has been explicitly marked deleted here DISALLOW_IMPLICIT_CONSTRUCTORS(TurboAssemblerBase); ^ 1 error generated. The original changes were made in https://chromium-review.googlesource.com/c/v8/v8/+/1414913 R=hop2deep@gmail.com, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I2a6e555b028583b89402b257e40757f34f3301c1 Reviewed-on: https://chromium-review.googlesource.com/c/1463179Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#59499}
-
Michael Lippautz authored
Bug: chromium:923361 Change-Id: Id4a0f6515f6b17cec2732df561c1e82080dc29c8 Reviewed-on: https://chromium-review.googlesource.com/c/1462963Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#59498}
-
Georg Neis authored
Change-Id: I4c86ede2e1f423d0faf5dde28bb435d5c99f9144 Reviewed-on: https://chromium-review.googlesource.com/c/1462962Reviewed-by:
-
Georg Neis authored
Then the various methods that take receiver maps don't need to worry about deprecated maps. Change-Id: I09c53939275b1af19d54430bfecb23809a4257c2 Reviewed-on: https://chromium-review.googlesource.com/c/1458243Reviewed-by:
-
Georg Neis authored
Change-Id: Ia433525116637fdf3273919af31f2e6eee62bfd0 Reviewed-on: https://chromium-review.googlesource.com/c/1462002Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59495}
-
Georg Neis authored
R=sigurds@chromium.org Change-Id: Iaabe863956bb59755af570cd031ab486f5fe3f20 Reviewed-on: https://chromium-review.googlesource.com/c/1460942Reviewed-by:
-
Clemens Hammacher authored
When executing the interpreter, we should not try to create compiled code. Otherwise we cannot implement and test a feature in the interpreter in isolation. R=ahaas@chromium.org CC=fgm@chromium.org Change-Id: I2074de31650a52b38b2f6e530e20b427d2d1db65 Reviewed-on: https://chromium-review.googlesource.com/c/1462876Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59493}
-
Simon Zünd authored
This CL prepares stack trace capturing for the switch from using plain StackFrameInfos to StackTraceFrames backed by a FrameArray. To reuse the caching mechanism, the relevant code is extracted into a helper, as the CaptureStackTraceHelper class will be removed in a future CL. R=jgruber@chromium.org Bug: v8:8742 Change-Id: I794faac09f414daf7946625606af7d7aa1630cde Reviewed-on: https://chromium-review.googlesource.com/c/1460473 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Georg Neis authored
For unknown reasons, we didn't try to update deprecated maps when taking the shortcut for compatible element kinds. Change-Id: I78f70f1d98acd40cfc6687f0b087182849a0188e Reviewed-on: https://chromium-review.googlesource.com/c/1454722Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Georg Neis authored
This automatically fixes another place in element access where the check was missing. Change-Id: I585079d76c03903f3486ec9e001a51a131259c0b Reviewed-on: https://chromium-review.googlesource.com/c/1460950Reviewed-by:
-
Georg Neis authored
This make things more readable. Change-Id: I1373a4d67de4b4dd8ec9f68b5a672dabc68daf67 Reviewed-on: https://chromium-review.googlesource.com/c/1460951Reviewed-by:
-
Toon Verwaest authored
That way we can properly walk the active ambiguous stack of expressions and stop where it's non-ambiguous. In the bug we would have forced context allocation of "this" in an outer function because an inner function was parsed as part of an arrow function head and "this" was referenced. That caused the ambiguous arrow head scope to be marked, even though the reference came from a non-ambiguous function. Bug: chromium:930580 Change-Id: I0bf0fa569e2d2ca1dc26b0514fe5bdb48ab7ae6f Reviewed-on: https://chromium-review.googlesource.com/c/1462005Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Change-Id: I7005dc4c8282f8de75859f642e4d1808c6a8ef90 Reviewed-on: https://chromium-review.googlesource.com/c/1462000Reviewed-by:
-
- 09 Feb, 2019 9 commits
-
-
Z Duong Nguyen-Huu authored
Bug: v8:6831 Change-Id: I67e4d9f39576a4067dad59b18b3b4bf04bcdcb99 Reviewed-on: https://chromium-review.googlesource.com/c/1461166 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Mike Stanton authored
This is a reland of 7179cdb1 The node integration build failure appears to be constant. Original change's description: > Reland "Introduce a PREMONOMORPHIC state to StoreGlobalIC" > > (Fixed test failure in lite-mode) > > Introduce a PREMONOMORPHIC state to StoreGlobalIC > > It's used rather narrowly for now -- only when we run into an > interceptor during the lookup. After the call to SetProperty, we know > more. That is, the interceptor was only there because it's a new > property, and the call to SetProperty ends up creating it. > > By delaying the initialization of the IC, we recognize the (now) > created property, and can provide good feedback downstream to > TurboFan. > > TBR=ishell@chromium.org > > Bug: v8:8712 > Change-Id: Ieb79dcf1354ee294ad0f479a4a6c41a77f389850 > Reviewed-on: https://chromium-review.googlesource.com/c/1460955 > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59483} TBR=ishell@chromium.org Bug: v8:8712 Change-Id: I31aa4c066ff46cb39187eed392313d2e524f4445 Reviewed-on: https://chromium-review.googlesource.com/c/1461998Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#59485}
-
Michael Stanton authored
This reverts commit 7179cdb1. Reason for revert: Breaks node integration build. Original change's description: > Reland "Introduce a PREMONOMORPHIC state to StoreGlobalIC" > > (Fixed test failure in lite-mode) > > Introduce a PREMONOMORPHIC state to StoreGlobalIC > > It's used rather narrowly for now -- only when we run into an > interceptor during the lookup. After the call to SetProperty, we know > more. That is, the interceptor was only there because it's a new > property, and the call to SetProperty ends up creating it. > > By delaying the initialization of the IC, we recognize the (now) > created property, and can provide good feedback downstream to > TurboFan. > > TBR=ishell@chromium.org > > Bug: v8:8712 > Change-Id: Ieb79dcf1354ee294ad0f479a4a6c41a77f389850 > Reviewed-on: https://chromium-review.googlesource.com/c/1460955 > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59483} TBR=mvstanton@chromium.org,ishell@chromium.org Change-Id: Ifd45908ee66760ef9199d9722b7e558c31f77830 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8712 Reviewed-on: https://chromium-review.googlesource.com/c/1461997Reviewed-by:
-
Mike Stanton authored
(Fixed test failure in lite-mode) Introduce a PREMONOMORPHIC state to StoreGlobalIC It's used rather narrowly for now -- only when we run into an interceptor during the lookup. After the call to SetProperty, we know more. That is, the interceptor was only there because it's a new property, and the call to SetProperty ends up creating it. By delaying the initialization of the IC, we recognize the (now) created property, and can provide good feedback downstream to TurboFan. TBR=ishell@chromium.org Bug: v8:8712 Change-Id: Ieb79dcf1354ee294ad0f479a4a6c41a77f389850 Reviewed-on: https://chromium-review.googlesource.com/c/1460955Reviewed-by:
-
Michael Stanton authored
This reverts commit ec06b5c4. Reason for revert: Breaks "lite" builder. Original change's description: > Introduce a PREMONOMORPHIC state to StoreGlobalIC > > It's used rather narrowly for now -- only when we run into an > interceptor during the lookup. After the call to SetProperty, we know > more. That is, the interceptor was only there because it's a new > property, and the call to SetProperty ends up creating it. > > By delaying the initialization of the IC, we recognize the (now) > created property, and can provide good feedback downstream to > TurboFan. > > Bug: v8:8712 > Change-Id: I4e10ba220c8363b393c6de84ce35fe5ef0e9c427 > Reviewed-on: https://chromium-review.googlesource.com/c/1456090 > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59481} TBR=mvstanton@chromium.org,ishell@google.com,ishell@chromium.org Change-Id: I072a55275d64315924090a68247bb430f5c4f03d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8712 Reviewed-on: https://chromium-review.googlesource.com/c/1460954Reviewed-by:
-
Mike Stanton authored
It's used rather narrowly for now -- only when we run into an interceptor during the lookup. After the call to SetProperty, we know more. That is, the interceptor was only there because it's a new property, and the call to SetProperty ends up creating it. By delaying the initialization of the IC, we recognize the (now) created property, and can provide good feedback downstream to TurboFan. Bug: v8:8712 Change-Id: I4e10ba220c8363b393c6de84ce35fe5ef0e9c427 Reviewed-on: https://chromium-review.googlesource.com/c/1456090 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bailout from map update if there are private symbol transitions on non-extensible maps. Bug: chromium:930045 Change-Id: I02fbea0ec0afde07cded688c06122d8f2bb25921 Reviewed-on: https://chromium-review.googlesource.com/c/1460949Reviewed-by:
-
Johannes Henkel authored
This brings in the CBOR_h / CBOR_cc template. Change-Id: I3d3971a5ba4c98a8b36982449e4d9a2606010f22 Reviewed-on: https://chromium-review.googlesource.com/c/1459738Reviewed-by:
-
Jakob Kummerow authored
HeapObject::SizeFromMap() was too large to get inlined anyway. HeapObject::IsFoo() predicates should be implemented in foo-inl.h, because that's what they depend on. This patch also fixes up includes: dropping unnecessary ones from object-inl.h, and adding them in other places that previously relied on getting them transitively. Bug: v8:8562 Change-Id: Id062bed67257d9dc1899f2d71f44cf69a1368c83 Reviewed-on: https://chromium-review.googlesource.com/c/1450778Reviewed-by:
-
- 08 Feb, 2019 2 commits
-
-
Frank Tang authored
Bug: v8:7684 Change-Id: If74e2b6d1ff7d11f3133ff74847d23b171b05f0a Reviewed-on: https://chromium-review.googlesource.com/c/1459744Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#59477}
-
Frank Tang authored
Fix intl402/Locale/likely-subtags Bug: v8:8236 Change-Id: I0f109d0bedb1fda3f5eaac9cfce935788f54b595 Reviewed-on: https://chromium-review.googlesource.com/c/1459745Reviewed-by:
-
