- 22 Jul, 2022 16 commits
-
-
Nico Hartmann authored
This reverts commit 8cb02753. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20isolates/20736/overview Original change's description: > [wasm] Materialize suspender in JS-to-wasm wrapper > > Instead of creating the Suspender object in JS and passing it to the > stack-switching js-to-wasm wrapper, the wrapper now automatically > creates the Suspender object and forwards it as an extra parameter to > the wasm function. See: > https://github.com/WebAssembly/js-promise-integration/pull/1/files > > R=ahaas@chromium.org > > Bug: v8:12191 > Change-Id: I2badee823f4223a293632f93e7e59f24c49d0820 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779688 > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81890} Bug: v8:12191 Change-Id: Id22ed357e3a59bd1569687eadbc9b007d3da995c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780816 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81891}
-
Thibaud Michaud authored
Instead of creating the Suspender object in JS and passing it to the stack-switching js-to-wasm wrapper, the wrapper now automatically creates the Suspender object and forwards it as an extra parameter to the wasm function. See: https://github.com/WebAssembly/js-promise-integration/pull/1/files R=ahaas@chromium.org Bug: v8:12191 Change-Id: I2badee823f4223a293632f93e7e59f24c49d0820 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779688 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81890}
-
Nico Hartmann authored
This reverts commit 0e554376. Reason for revert: Breaks a number of windows builds Original change's description: > Update google_benchmark > > Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/d4bc509..ef7f75f > > simplified code (#1439) (maochongxin) > https://chromium.googlesource.com/external/github.com/google/benchmark/+/ef7f75f > > use target_compile_definitions (#1440) (Dominic Hamon) > https://chromium.googlesource.com/external/github.com/google/benchmark/+/e27c930 > > Stop generating the export header and just check it in (#1435) (Dominic Hamon) > https://chromium.googlesource.com/external/github.com/google/benchmark/+/7b3ac07 > > Also fix the SOVERSION for benchmark_main (Dominic Hamon) > https://chromium.googlesource.com/external/github.com/google/benchmark/+/d845b7b > > R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org > > Change-Id: Ifbb9be7752856e3f0ab042194108a96a5b6cc083 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782483 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81884} Change-Id: I22eb5e12653f2c8965a87692695cbb06a44da14a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782799 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#81889}
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: I067e9d6a56dd58dbd0f45607f62b5ef36c69ff6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776690Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Matthias Liedtke <mliedtke@google.com> Commit-Queue: Matthias Liedtke <mliedtke@google.com> Cr-Commit-Position: refs/heads/main@{#81888}
-
Jakob Kummerow authored
The DevTools frontend doesn't want the Wasm module's understanding of function body offsets (i.e. including locals), but the ranges of offsets where breakpoints can be set (i.e. only where instructions are). This patch adjusts the reported offsets accordingly. A consequence is that we have to report full (start,end) pairs for each function, instead of being able to dedupe end1==start2 etc. Bug: v8:12917 Change-Id: I0c7d2d96435cdac2c4553647b7bcc8783bc1798b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780526 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/main@{#81887}
-
Divy Srivastava authored
This CL adds Uint8Array as supported arguments for fast API calls. It introduces a kUint8 variant to CTypeInfo for use with TypedArrays only. Bug: v8:13080 Change-Id: Ie65206078a18acabaafa9c95793f400b8e95373d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3767098 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81886}
-
Al Muthanna Athamina authored
Bug: v8:12755 Change-Id: Ib4f98aa28a7f5d590a81128291ceecaec5edc8a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3762569Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#81885}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/d4bc509..ef7f75f simplified code (#1439) (maochongxin) https://chromium.googlesource.com/external/github.com/google/benchmark/+/ef7f75f use target_compile_definitions (#1440) (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/e27c930 Stop generating the export header and just check it in (#1435) (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/7b3ac07 Also fix the SOVERSION for benchmark_main (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/d845b7b R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: Ifbb9be7752856e3f0ab042194108a96a5b6cc083 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782483Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81884}
-
jameslahm authored
... api/api-icu-unittest. Bug: v8:12781 Change-Id: Ibfc420e9d5ff0fce67f710b89a214332c7be65cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3748164Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#81883}
-
Victor Gomes authored
Update LogicalNot to use same Constant::ToBoolean logic. Bug: v8:7700 Change-Id: Id8f6c1b8fa9bb70489122f35bcee4c88bffc9499 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3769691Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#81882}
-
Simon Zünd authored
This CL adds a new method to the `console` that is available when DevTools is open. In TypeScript notation the API is: ``` namespace console { // Creates a new `Task` and associates the current async // stack trace with the created `Task`. scheduleTask(name: string): Task; } interface Task { // Executes an arbitrary payload and forwards the return value // back to the caller. Any async stack trace captured during // 'f' has the site of the corresponding `scheduleTask` as // its parent. run<T>(f: () => T): T; } ``` The API is a saner user-facing API for our async stack trace mechanism: * scheduleAsyncTask corresponds to scheduleTask * startAsyncTask/stopAsyncTask are called implicitly before `f` is executed. * cancelAsyncTask is called implicitly when `Task` is GC'ed The API is behind the flag --experimental-async-stack-tagging-api Bug: chromium:1334585 Change-Id: Ic6054279a108756caed6b4b5f2d1fe4a1bdbaf78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776678Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#81881}
-
Richard Wang authored
Also fix incorrect config for Win32 goma cache silo builder Win64 builders added in https://crrev.com/c/3779918 Bug: b:239780467 Change-Id: Ib65e486e478e2603b936d6a6620e9461a49698be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779917Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Richard Wang <richardwa@google.com> Cr-Commit-Position: refs/heads/main@{#81880}
-
Suraj Sharma authored
All ETW Events are controlled by v8_enable_system_instrumentation. This flag is turned off when perfetto is enabled since traces events flowing through TRACE_EVENT macros can't be intercepted by Recorder. Since, stack walking Events don't use TRACE_EVENT it can be turned back on, when using perfetto. Hence, creating a separate Build Flag for emitting stack walking event until the recorder is ported. Bug: v8:11043 Change-Id: I6cdb81400780e54fddf6d6e2476cad29c60483d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3704465Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Suraj Sharma <surshar@microsoft.com> Cr-Commit-Position: refs/heads/main@{#81879}
-
v8-ci-autoroll-builder authored
Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/88bf407..3e55cfb Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/abcd8ba..b0098bb Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/39e33e6..0ba2fd4 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: If66f6e1d154c11e7cce0ac2996de684e1991f217 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779653 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81878}
-
Milad Fa authored
Change-Id: Idb4f93cb40c6210ce1b8527d2ed0d0d942e15ca1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780523 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#81877}
-
Frank Tang authored
Add a second implementation of BalanceDuration which the nanoseconds could be very large and beyong the precision could be handled by double and passed in by BigInt, and values of other time fields are 0. Bug: v8:11544 Change-Id: Ib794c6c78b81b8338434314fa5033cf1e991d32b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3781117 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81876}
-
- 21 Jul, 2022 18 commits
-
-
Jakob Kummerow authored
Prints information about frequency and aggregate size of instructions. Change-Id: Ia745c0e5e26fbc5e24437302ba171bd05600577d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773779Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81875}
-
Omer Katz authored
Bug: v8:12612 Change-Id: I4d9de4446d343040ae29e25d23a09cf4c740bde0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3743448 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Omer Katz <omerkatz@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81874}
-
Thibaud Michaud authored
Add a test where the GC gets called during parameter conversion, and fix two related issues: - Reorder spilled references so that they are at the top of the stack before the builtin call - Add the missing frame marker on the new stack R=ahaas@chromium.org Bug: v8:12191 Change-Id: I3f68c675123c726543df6942d110fe06bc6c0efb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780530 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#81873}
-
Omer Katz authored
See a description of the different classes and how they integrate in https://docs.google.com/document/d/1wNj_akGSh6RBMC2RvH8HIlSUqkjWrpGkxI_BTZ-zdXE/edit# Bug: v8:12612 Change-Id: I0f2141f4ada5c964e985d109133902172d1ab605 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3641178Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#81872}
-
Camillo authored
The CpuProfile previously emitted a CpuProfileMaxSamplesCallbackTask if there was a sample where V8 could not resolve the stack. This resulted in a premature "samplebufferfull" events for the self-profiling API. Skipping over samples without a resolved stack solves this issue. Bug: chromium:1334366 Change-Id: If7a375dbf533c391307e8e506b37c0e3705f63b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776680Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#81871}
-
Liviu Rau authored
Bug: v8:12785 Change-Id: Icae27e743824a234d51946747402c2c4e2bb9ec2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779686 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81870}
-
V8 Autoroll authored
Change-Id: Ibc132bb36976c8286e641155955f31e7fdf24331 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780298Reviewed-by: Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/main@{#81869}
-
ishell@chromium.org authored
... by removing the unused Code* argument. Bug: v8:11880 Change-Id: Icec0c448e844a371ec1751a30419f79dc11876d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3777717 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#81868}
-
Andreas Haas authored
R=clemens@chromium.org Bug: v8:12926 Change-Id: Ie0744464f0f849e2ee4ec09cfc318bbf1f8b2dc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3757890Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#81867}
-
Clemens Backes authored
The previous declaration was failing on GCC, because the argument types did not match the actual constructor. The second parameter needs to be a reference. R=jkummerow@chromium.org Bug: v8:13069 Change-Id: I151b44e05cd8b45da8f737ab84da063e491f3292 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779683Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81866}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I1cba243972ac9a22ef4a5873d6d6d1e55b99cb55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779678 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81865}
-
Michael Lippautz authored
Introduce `TraceStrongContainer()` to retain containers strongly. This makes the use of `Trace(T*)` obsolete as all other use cases should refer to Member overloads. Bug: v8:13089 Change-Id: Ib0e762bf3298f1818528e45cc842d14a63f2c684 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779680Reviewed-by: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#81864}
-
ishell@chromium.org authored
... in various components. Bug: v8:11880 Change-Id: I1e4411ec38a4b15e505bda35a92987972e89d9d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3777718 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#81863}
-
Manos Koukoutos authored
Some tests and testing infrastructure had to be changed because it relied on nominal types. Drive-by: Support function supertypes in wasm-module-builder.js. Bug: v8:7748 Change-Id: Ife92431d1842ff9de91e296a50421aa48f02c0de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776197Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#81862}
-
Thibaud Michaud authored
See https://github.com/llvm/llvm-project/issues/56560 R=ahaas@chromium.org Bug: chromium:1344641 Change-Id: I1cc475e1bb678029f7418cb440c52a150eba9a8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3778717Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#81861}
-
Lu Yahan authored
Change-Id: I0b7b4daf5b88341ba56076137b8d34bdfcd45c1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773329Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#81860}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7aa2227..be25fb2 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I7fe7c6720f856a8db4eb38df498f292fb8446361 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779225 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81859}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0c6b8d6..abcd8ba Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9585c93..39e33e6 Rolling v8/third_party/fuchsia-sdk/sdk: version:9.20220719.2.1..version:9.20220720.2.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ibe9163f4977034279eb7fb1afa61a9e80ad40a7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779221 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81858}
-
- 20 Jul, 2022 6 commits
-
-
Milad Fa authored
Change-Id: Ia45248a3d8566dbb4f2702a8b1ea6959157dc76b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776949 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#81857}
-
Seth Brenith authored
Background: In order to show custom content in the "Locals" pane in WinDbg, v8windbg replaces the getter function for a built-in debug model property named "Debugger.Models.StackFrame.LocalVariables". This is the property that the debugger fetches when determining what to display in "Locals". The new implementation of that getter, V8LocalVariables::GetValue, can either call the original getter (so that WinDbg displays the usual content for normal C++ frames) or produce a custom result (for builtins and JIT-compiled JS frames). The current problem: In new builds of WinDbg, users of v8windbg no longer see any content in the Locals pane for stack frames that correspond to builtins or JIT-compiled code. This is because of a behavior change in WinDbg: previously, attempting to get Debugger.Models.StackFrame.LocalVariables would eagerly attempt to find the symbols for the frame and return an error code if symbols were not found, but now it returns a lazy object which does not perform symbol lookup until you iterate its properties. V8LocalVariables::GetValue currently starts with an early-exit path based on checking whether the original getter succeeded, so the new lazy implementation causes us to always take that early exit. Proposed fix: Rather than relying on the return value from the original getter, which is not guaranteed to work consistently, we can base our decisions on the instruction pointer. If it points outside any module, or if it points to within a function in the module containing V8 whose name starts with "Builtins_", then we can build a custom result for the Locals pane. Change-Id: I6644071d5d83a25b964d9f4018265532528cc85c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3759228Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#81856}
-
Dominik Inführ authored
In order to make the shared code write barrier thread-safe, we simply lock the page mutex when appending to the typed_slot_set. We can later improve this when performance isn't good enough. Bug: v8:13018 Change-Id: I5e12f83f459f8976c22ec488cfa9b6f16d4a8a8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3763867Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#81855}
-
ishell@chromium.org authored
... in favour of Builtins::name(). Bug: v8:11880 Change-Id: I1e06314aec71ea367cd8096316e8fb9aceb63feb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776686 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#81854}
-
Clemens Backes authored
Enable a clang warning that embedders might enable, and fix issues found by it. R=ahaas@chromium.org, nicohartmann@chromium.org, mlippautz@chromium.org Bug: v8:13069 Change-Id: I935f18872178f4421b441f33ef8ab1d8f030dfc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3760443Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81853}
-
Clemens Backes authored
Instead of one big test which tests multiple functions, split the unit test into multiple smaller tests. Also, use TestWithZone instead of TestWithIsolate, because the isolate is never used. R=jkummerow@chromium.org Bug: v8:12425 Change-Id: I32148e40b5ed2b006cc647d42bdfe564ccc6d0ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3776676 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81852}
-