- 07 Dec, 2018 19 commits
-
-
Yuki Shiino authored
https://crrev.com/c/1343709 fixed GetIncumbentContext to work with ASan, however, GetIncumbentContext didn't work well with MSan because MSan uses a simulator which supports yet another separate stack frame. This patch fixes GetIncumbentContext so that it works well with not only ASan but also MSan simply following the same way as v8::TryCatch does. i::GetCurrentStackPosition() solves the issue of ASan and SafeStack (native but separate stack frame), and i::SimulatorStack solves the issue of MSan (simulator stack frame). Bug: chromium:888867, chromium:866610 Change-Id: Id803cbfd17fb1b1d9b8ee34c4802768f3a2f8e79 Reviewed-on: https://chromium-review.googlesource.com/c/1356691 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58096}
-
Jakob Gruber authored
This reverts commit f849396c. Reason for revert: arm64: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/24229 Original change's description: > [nojit] Remove code stubs > > All stubs have been migrated to builtins. This CL removes most related > code. > > Bug: v8:7777, v8:5784 > Change-Id: I4470cfef34788e6c8e0fd5fd09e40e250d088dad > Reviewed-on: https://chromium-review.googlesource.com/c/1365284 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58093} TBR=jkummerow@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,jarin@chromium.org,jgruber@chromium.org,bmeurer@chromium.org Change-Id: I52c3abd3f4e5872fe26ed7e527a58b118e02b387 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7777, v8:5784 Reviewed-on: https://chromium-review.googlesource.com/c/1367804Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58095}
-
Michael Lippautz authored
Allow a V8 step after doing an embedder step if there's time left. This will speed up marking in certain situations. Bug: chromium:909788, chromium:911053, chromium:843903 Change-Id: Ie15c30d5ce8443caf7217a834a120a19d0bb292b Reviewed-on: https://chromium-review.googlesource.com/c/1367455 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58094}
-
Jakob Gruber authored
All stubs have been migrated to builtins. This CL removes most related code. Bug: v8:7777, v8:5784 Change-Id: I4470cfef34788e6c8e0fd5fd09e40e250d088dad Reviewed-on: https://chromium-review.googlesource.com/c/1365284 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Gerrit seems to concatenate several commit messages on uploading branch creation CLs. Now we pass the commit message of the branch commit to the upload script to prevent this. NOTRY=true Bug: v8:8546 Change-Id: Ia4673261aad2f40bcda4384889a0428039adae74 Reviewed-on: https://chromium-review.googlesource.com/c/1367454Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58092}
-
Igor Sheludko authored
(mostly for roots, handles and stack locations). Thi CL also changes RootVisitor interface to use FullObjectSlots instead of ObjectSlots. Bug: v8:8518 Change-Id: I217c7ae176387a8c64f4754e62339727bdb36018 Reviewed-on: https://chromium-review.googlesource.com/c/1366035Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Should help the case where the single existing transition matches. BUG=v8:8547 Change-Id: Ic459357a10311346499ea054447d6cc42352fc0d Reviewed-on: https://chromium-review.googlesource.com/c/1363133Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#58090}
-
Tamer Tas authored
R=machenbach@chromium.org Change-Id: Ib049f88cbbf72fd33b5a962f074ac98948d6ae1c Reviewed-on: https://chromium-review.googlesource.com/c/1360631Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#58089}
-
Jakob Gruber authored
This migrates the JSEntryStub to three dedicated builtins: JSEntry JSConstructEntry JSRunMicrotasksEntry Drive-by: Tweaks to make the code isolate-independent (e.g. using the correct macro assembler method to load and store external references through the kRootRegister). Drive-by: The context slot on x64/ia32 must be set up after kRootRegister is initialized, so we first reserve the slot and later load its value. Drive-by: Update all remaining comments referencing JSEntryStub. Bug: v8:7777 Change-Id: Ie3ba17ffb3bde6f18ec1d26d778b258719b2d4ef Reviewed-on: https://chromium-review.googlesource.com/c/1365275Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8477, v8:8238 Change-Id: I8170911d27b605a5befe959af16212c870104a2b Reviewed-on: https://chromium-review.googlesource.com/c/1366735Reviewed-by:
-
Igor Sheludko authored
Bug: v8:8477, v8:8238 Change-Id: If776225f8949ba84fa17de333b4f14188c93a93d Reviewed-on: https://chromium-review.googlesource.com/c/1366615Reviewed-by:
-
Takuto Ikuta authored
This is preparation to switch swarming client. Bug: chromium:894045, chromium:907585 Change-Id: I3cd5eec0ed8a81eefbac0061f0ee0eb38f5bfd7c Reviewed-on: https://chromium-review.googlesource.com/c/1365212Reviewed-by:
-
Mathias Bynens authored
Now that `do` expressions have been removed [1], we should remove the corresponding golden file as well. [1]: https://chromium.googlesource.com/v8/v8/+/58988c6c6395788799057ab8a0676d0534c46c14 Change-Id: I4a6908d4d53b2bce1d9f2d616c672b4caf15adac Reviewed-on: https://chromium-review.googlesource.com/c/1365283Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#58084}
-
Michael Achenbach authored
TBR=santa Change-Id: Id624d0e64fcc1c8daf52a032cbb2daf12493e26d Reviewed-on: https://chromium-review.googlesource.com/c/1367445Reviewed-by:
-
Frank Tang authored
The removed tests should be later covered by v8:8556 Bug: v8:5751, v8:8556 Change-Id: Iea5450564ab4f85256f1aa76fb09d7e6704f9bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1355634Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58082}
-
Frank Tang authored
Simplified test for default locale under test/intl Remove GetDefaultLocale from runtime Move Intl::DefaultLocale from intl-object.h to internal function inside intl-object.cc Bug: v8:5751 Change-Id: I885abf30ff33d5213ee99c07ac1e92d3c5065d8b Reviewed-on: https://chromium-review.googlesource.com/c/1358022Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58081}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9fee3d5..9e9ea82 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/04161ec..7d88270 Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/76d26bb..89ae39c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a8f4725..5d7bcad Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9875e18..f94f910 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7825688d990209a62fb5aca120d96b1bf38c5c17 Reviewed-on: https://chromium-review.googlesource.com/c/1367127Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#58080}
-
Sathya Gunasekaran authored
Bug: v8:7834 Change-Id: I2b1444eded3d2917bf67f5077f35daccdbbbb951 Reviewed-on: https://chromium-review.googlesource.com/c/1367125Reviewed-by:
-
Sven Sauleau authored
This is a reland of 0e8f20d2 Original change's description: > [wasm] fix js-api interface > > Make sure WebAssembly's js-api exposes the correct attributes: writable, > enumerable and configurable. > > Bug: v8:8319 > Change-Id: I427533159d7975a42c0c5cb1babdc8a61f8198b5 > Reviewed-on: https://chromium-review.googlesource.com/c/1351002 > Commit-Queue: Adam Klein <adamk@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Ben Smith <binji@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58053} Bug: v8:8319 Change-Id: I2d0af568edab295ad8c01b64e588bbabf89bd251 Reviewed-on: https://chromium-review.googlesource.com/c/1365273Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#58078}
-
- 06 Dec, 2018 20 commits
-
-
Dmitry Gozman authored
This reverts commit d9fbfeb8. Reason for revert: see bug. Bug: 906847 Original change's description: > inspector: return [[StableObjectId]] as internal property > > This property might be useful for fast '===' check. > > R=dgozman@chromium.org,yangguo@chromium.org > > Bug: none > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352 > Reviewed-on: https://chromium-review.googlesource.com/1226411 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56095} TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,jgruber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: I68c700b7b8fd0a015f099460c15665d74e4da183 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1363558Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#58077}
-
Igor Sheludko authored
because attempt to decompress the off-heap map slot will fail. Bug: v8:7703 Change-Id: Iad3884fb95ccb17b2992d190acb5914062a0e8f4 Reviewed-on: https://chromium-review.googlesource.com/c/1365286Reviewed-by:
-
Igor Sheludko authored
to make TSAN happy. Bug: v8:8518 Change-Id: I1c7291cc6035c7e88758d867cb74467c59e95ef1 No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/1365285Reviewed-by:
-
Dan Elphick authored
Since RO_SPACE strings cannot be written to after creation, they cannot be internalized later. This adds checks to normal string construction methods that they are not created with TENURED_READ_ONLY. Also changes the Symbol construction in setup-heap-internal.cc to use internalized strings, which increases the number of internalized RO_SPACE strings from 490 to 514 (915 including OLD_SPACE). Bug: chromium:911416 Change-Id: I222ff883e98f3a2f4ce70d369f22273f5c9edb0b Reviewed-on: https://chromium-review.googlesource.com/c/1365279Reviewed-by:
-
Igor Sheludko authored
which will require different handling for compressed pointers case. Bug: v8:8518 Change-Id: I99cb103bad57b134ecb8d7dd7018cf16ed3d8f25 Reviewed-on: https://chromium-review.googlesource.com/c/1365272Reviewed-by:
-
Ulan Degenbaev authored
The main change is about tracking typed slots locally in each concurrent marking thread. This generalizes the old LiveBytesMap to MemoryChunkData, which now contains the live bytes and the typed slots. With that in place it is straightforward to mark code concurrently. Bug: v8:8459 Change-Id: I103fff0ad39beadea5151a1d8519f5d3c6602e58 Reviewed-on: https://chromium-review.googlesource.com/c/1337747 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#58072}
-
Jaroslav Sevcik authored
There is no fast path for 0-length substrings, which implied runtime calls for some of the trickier types of strings (such as non-flat cons-strings). This made for a big performance gap between String.p.slice and String.p.substring for those inputs. This CL just adds the 0-length shortcut in CSA implementation of SubString. Here is an example where it makes difference: let s = "abcdefghijkalmnopqrst"; let a = ""; console.time("Substring"); for (let i = 0; i < 100000; i++) { s += "0"; a += s.substring(0, 0); } console.timeEnd("Substring"); Before this change: > console.timeEnd: Substring, 640.308000 After this change: > console.timeEnd: Substring, 13.242000 For completeness, here is the time for slice: > console.timeEnd: Slice, 13.142000 This also recovers performance in the jsdom library, as observed in https://github.com/jsdom/jsdom/issues/2350. Bug: v8:6730 Change-Id: I7d2127e4506a86ec2a7ed378293476c3699dc47a Reviewed-on: https://chromium-review.googlesource.com/c/1365282 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: -
Mythri authored
Bug: v8:8394 Change-Id: If9af9f3c79e442f6e384934e005ae5d82b0d358b Reviewed-on: https://chromium-review.googlesource.com/c/1365277Reviewed-by:
-
Jakob Gruber authored
Fixes https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20noembed%20-%20debug/781. Failing since https://crrev.com/c/1360630. Tbr: yangguo@chromium.org Bug: v8:7777 Change-Id: Ia9adfa9340087dfcd74c966c40a54176081f6933 Reviewed-on: https://chromium-review.googlesource.com/c/1365276Reviewed-by:
-
tzik authored
This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint. RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed, and may causes nested Microtasks in a problematic way. E.g. that confuses v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext(). OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it respects the microtask suppressions. As all existing tests don't call RunMicrotasks() in the suppressed situation (like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should not affect to these tests. Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d Reviewed-on: https://chromium-review.googlesource.com/c/1360095Reviewed-by: -
Frank Tang authored
Bug: v8:8525 Change-Id: I42764afbb419825fe6af504a641a78dbb127f30c Reviewed-on: https://chromium-review.googlesource.com/c/1355629 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Currently, if we lower to a pure computation that is unreachable because of some runtime check, we just rename it with DeadValue. This is problematic if the pure computation gets later eliminated - that allows the DeadValue node float above the check that makes it dead. As we conservatively lower DeadValues to debug-break (i.e., crash), we might induce crash where we should not. With this CL, whenever we lower an impossible effectful node (i.e., with Type::None) to a pure node in simplified lowering, we insert an Unreachable node there (pinned to the effect chain) and mark the impossible node dead (and make it depend on the Unreachable node). Bug: chromium:910838 Change-Id: I218991c79b9e283a9dd5beb4d3f0c4664be76cb2 Reviewed-on: https://chromium-review.googlesource.com/c/1365274Reviewed-by:
-
Jakob Gruber authored
In preparation for converting JSEntry into a builtin. The root register used to be initialized by an embedded external reference, which is not isolate-independent. Pass in its value explicitly instead. Tbr: clemensh@chromium.org Bug: v8:7777 Change-Id: If9d20cb193af175bd1cf58e5826bdf6f397869ad Reviewed-on: https://chromium-review.googlesource.com/c/1363139Reviewed-by:
-
Jakob Gruber authored
A spec change to simplify IsRegExp has been proposed: https://github.com/tc39/ecma262/pull/1318 This CL adds use counters for cases in which the spec change would alter behavior: 1. o[@@match] is trueish but o is not a JSRegExp 2. o[@@match] is falseish (but not undefined) and o is a JSRegExp This is the V8 side of required changes. The Chromium-side CL: https://crrev.com/c/1360730 Drive-by: TNodeify IsRegExp. Tbr: yangguo@chromium.org Bug: v8:8522 Change-Id: I3766e02977f256a80d0e59472d3bafa9c692af9e Reviewed-on: https://chromium-review.googlesource.com/c/1360630Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58064}
-
Jakob Gruber authored
This addresses follow-up comments to https://crrev.com/c/1354887/. Use DCHECKs instead of CHECKs and make the branch order consistent across architectures. Bug: v8:7777 Change-Id: I5c3f8f5ac97b55fa80662bc211aff7833ff12bfa Reviewed-on: https://chromium-review.googlesource.com/c/1362912 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Achenbach authored
TBR=santa Change-Id: If6722b455219d5113ddbfe1a97e9178e7fad63c9 Reviewed-on: https://chromium-review.googlesource.com/c/1365271Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 0e8f20d2. Reason for revert: Breaks layout tests, blocks roll: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-blink-rel/3047 Original change's description: > [wasm] fix js-api interface > > Make sure WebAssembly's js-api exposes the correct attributes: writable, > enumerable and configurable. > > Bug: v8:8319 > Change-Id: I427533159d7975a42c0c5cb1babdc8a61f8198b5 > Reviewed-on: https://chromium-review.googlesource.com/c/1351002 > Commit-Queue: Adam Klein <adamk@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Ben Smith <binji@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58053} TBR=binji@chromium.org,adamk@chromium.org,gdeepti@chromium.org,ssauleau@igalia.com Change-Id: I16fa44a0e79020850613751ae45a68d67602166d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8319 Reviewed-on: https://chromium-review.googlesource.com/c/1365270Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58061}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9c85c83..9fee3d5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/58f2981..a8f4725 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f28ef98..9875e18 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0dea619..f6641a3 Rolling v8/tools/luci-go:infra/tools/luci/isolate/${platform}: https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}/+log/git_rev..git_rev TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I944970e96d4db2531431643cf54d3369ea977b49 Reviewed-on: https://chromium-review.googlesource.com/c/1364711 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Deepti Gandluri authored
Change-Id: Id221faecc9873cb0dbbd89777e055884158dbfb3 Reviewed-on: https://chromium-review.googlesource.com/c/1364370Reviewed-by:
-
Sathya Gunasekaran authored
The prefix size is read from the Derived class. The hash code of the object will be stored in this prefix. Change-Id: I15646701c9bab99b8aed39ea9ad8ae03f6d605ed Bug: v8:6443, v8:7569 Reviewed-on: https://chromium-review.googlesource.com/c/1337586 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
- 05 Dec, 2018 1 commit
-
-
Igor Sheludko authored
Bug: v8:8518 Change-Id: I39db0adbd84627491bcb653b90de724eb988d383 Reviewed-on: https://chromium-review.googlesource.com/c/1363145 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
