1. 02 Jul, 2016 1 commit
  2. 29 Jun, 2016 1 commit
  3. 24 Jun, 2016 2 commits
  4. 11 Mar, 2016 1 commit
  5. 19 Feb, 2016 1 commit
  6. 26 Jan, 2016 1 commit
    • littledan's avatar
      Fix length of DataView and TypedArray get/set functions · 3f37c446
      littledan authored
      Functions like DataView.prototype.getUint8 should have length 1,
      and DataView.prototype.setUint8 should have length 2, as their
      endianness arguments are optional. Additionally,
      TypedArray.prototype.set.length should be 2. This follows the ES2015
      specification, and a new test262 test tests for it. This patch
      fixes the functions' lengths.
      
      R=adamk
      
      Review URL: https://codereview.chromium.org/1636953003
      
      Cr-Commit-Position: refs/heads/master@{#33531}
      3f37c446
  7. 30 Dec, 2015 1 commit
    • littledan's avatar
      Reland of Use ES2015-style TypedArray prototype chain (patchset #1 id:1 of... · e549c7a3
      littledan authored
      Reland of Use ES2015-style TypedArray prototype chain (patchset #1 id:1 of https://codereview.chromium.org/1554523002/ )
      
      Reason for revert:
      Should be fixed again with this Blink change to add NeedsManualRebaseline
      
      Original issue's description:
      > Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ )
      >
      > Reason for revert:
      > [Sheriff] Changes layout tests. Please fix upstream first if intended.
      >
      > https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689
      >
      > Original issue's description:
      > > Use ES2015-style TypedArray prototype chain
      > >
      > > This patch switches TypedArrays to use the prototype chain described
      > > in the ES2015 specification, which adds a %TypedArray% superclass above
      > > all individual TypedArray types. Most methods are defined on the
      > > superclass rather than the subclasses.
      > >
      > > In order to prevent a performance regression, a few methods are
      > > marked as inline. Inlining might prevent code which was previously
      > > monomorphic from becoming polymorphic, and it was specifically
      > > applied in places where methods became more polymorphic than before.
      > > Tests with realistic workloads would be nice to do before this
      > > ships in stable.
      > >
      > > This patch does not bring TypedArrays up to full spec compliance. In
      > > particular, @@species is not yet supported.
      > >
      > > R=cbruni
      > > BUG=v8:4085
      > > LOG=Y
      > >
      > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7
      > > Cr-Commit-Position: refs/heads/master@{#33050}
      >
      > TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org
      > NOPRESUBMIT=true
      > NOTREECHECKS=true
      > NOTRY=true
      > BUG=v8:4085
      >
      > Committed: https://crrev.com/28b55ffd1e32e09aaf42b8bbb407944d4808e07c
      > Cr-Commit-Position: refs/heads/master@{#33053}
      
      TBR=caitpotter88@gmail.com,cbruni@chromium.org,machenbach@chromium.org
      BUG=v8:4085
      LOG=Y
      
      CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
      
      Review URL: https://codereview.chromium.org/1558663002
      
      Cr-Commit-Position: refs/heads/master@{#33067}
      e549c7a3
  8. 29 Dec, 2015 1 commit
    • machenbach's avatar
      Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of... · 28b55ffd
      machenbach authored
      Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ )
      
      Reason for revert:
      [Sheriff] Changes layout tests. Please fix upstream first if intended.
      
      https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689
      
      Original issue's description:
      > Use ES2015-style TypedArray prototype chain
      >
      > This patch switches TypedArrays to use the prototype chain described
      > in the ES2015 specification, which adds a %TypedArray% superclass above
      > all individual TypedArray types. Most methods are defined on the
      > superclass rather than the subclasses.
      >
      > In order to prevent a performance regression, a few methods are
      > marked as inline. Inlining might prevent code which was previously
      > monomorphic from becoming polymorphic, and it was specifically
      > applied in places where methods became more polymorphic than before.
      > Tests with realistic workloads would be nice to do before this
      > ships in stable.
      >
      > This patch does not bring TypedArrays up to full spec compliance. In
      > particular, @@species is not yet supported.
      >
      > R=cbruni
      > BUG=v8:4085
      > LOG=Y
      >
      > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7
      > Cr-Commit-Position: refs/heads/master@{#33050}
      
      TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:4085
      
      Review URL: https://codereview.chromium.org/1554523002
      
      Cr-Commit-Position: refs/heads/master@{#33053}
      28b55ffd
  9. 28 Dec, 2015 1 commit
    • littledan's avatar
      Use ES2015-style TypedArray prototype chain · 07c91dcc
      littledan authored
      This patch switches TypedArrays to use the prototype chain described
      in the ES2015 specification, which adds a %TypedArray% superclass above
      all individual TypedArray types. Most methods are defined on the
      superclass rather than the subclasses.
      
      In order to prevent a performance regression, a few methods are
      marked as inline. Inlining might prevent code which was previously
      monomorphic from becoming polymorphic, and it was specifically
      applied in places where methods became more polymorphic than before.
      Tests with realistic workloads would be nice to do before this
      ships in stable.
      
      This patch does not bring TypedArrays up to full spec compliance. In
      particular, @@species is not yet supported.
      
      R=cbruni
      BUG=v8:4085
      LOG=Y
      
      Review URL: https://codereview.chromium.org/1541233002
      
      Cr-Commit-Position: refs/heads/master@{#33050}
      07c91dcc
  10. 04 Dec, 2015 1 commit
  11. 03 Dec, 2015 1 commit
  12. 19 Oct, 2015 1 commit
  13. 17 Jul, 2015 1 commit
    • littledan's avatar
      Additional TypedArray tests · 8068b91d
      littledan authored
      - Test that TypedArray properties cannot be set in strict mode
        Properties like %TypedArray%.prototype.length have a getter and no
        setter. This test verifies that property, which was apparently not
        true in the past or had no test ensuring throwing in this case.
      - Test that TypedArray integer indexed properties (array elements)
        are not configurable
      
      Both of these have passed for some time, but there are open bugs against
      them and apparently no tests verifying that they are fixed.
      
      BUG=v8:3048, v8:3799
      LOG=N
      R=adamk
      
      Review URL: https://codereview.chromium.org/1232843005
      
      Cr-Commit-Position: refs/heads/master@{#29717}
      8068b91d
  14. 01 Jul, 2015 1 commit
  15. 17 Jun, 2015 1 commit
  16. 16 Jun, 2015 1 commit
    • littledan's avatar
      Add %TypedArray% to proto chain · a1059015
      littledan authored
      According to the ES6 spec, the main methods and getters shouldn't
      be properties of the individual TypedArray objects and prototypes
      but instead on %TypedArray% and %TypedArray%.prototype. This
      difference is observable through introspection. This patch moves
      some methods and getters to the proper place, with the exception
      of %TypedArray%.prototype.subarray and harmony methods. These will
      be moved in follow-on patches.
      
      BUG=v8:4085
      LOG=Y
      R=adamk
      
      Review URL: https://codereview.chromium.org/1186733002
      
      Cr-Commit-Position: refs/heads/master@{#29057}
      a1059015
  17. 15 Jun, 2015 1 commit
    • littledan's avatar
      Allow TypedArrays to be initialized with iterables · 40420f67
      littledan authored
      In ES6, the TypedArray constructor can be called either with an
      array-like object or an iterable. The code previously handled
      only array-like objects. This patch switches to supporting
      iterables while throwing in an optimization to make Arrays
      get allocated the old way, without an extra copy.
      
      BUG=v8:4090
      LOG=Y
      R=adamk
      
      Review URL: https://codereview.chromium.org/1181903003
      
      Cr-Commit-Position: refs/heads/master@{#29031}
      40420f67
  18. 30 Mar, 2015 1 commit
  19. 10 Mar, 2015 1 commit
  20. 24 Oct, 2014 1 commit
  21. 21 Oct, 2014 2 commits
  22. 17 Oct, 2014 3 commits
  23. 13 Oct, 2014 1 commit
  24. 28 Mar, 2014 3 commits
  25. 10 Oct, 2013 1 commit
  26. 17 Jul, 2013 1 commit
  27. 16 Jul, 2013 1 commit
  28. 15 Jul, 2013 1 commit
  29. 09 Jul, 2013 1 commit
  30. 27 Jun, 2013 1 commit
  31. 24 Jun, 2013 1 commit
  32. 21 Jun, 2013 1 commit
  33. 07 May, 2013 1 commit
  34. 03 May, 2013 1 commit