- 06 Sep, 2022 21 commits
-
-
Shu-yu Guo authored
This reverts commit ae329407. Reason for revert: Correct fix landed in https://chromium-review.googlesource.com/c/v8/v8/+/3869196 Do not backmerge this revert! Original change's description: > [compiler] fix typing of [[DateValue]] > > Bug: chromium:1356308 > Change-Id: I00be3495031b203b71cf924745dd2bad878ab3c2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3868955 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Auto-Submit: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82918} Bug: chromium:1356308 Change-Id: Iaf4581ead10613a105844b6d703d25d1e7d37d14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3872555 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#83008}
-
Michael Lippautz authored
Follow up from https://crrev.com/c/3858226 - Remove include when not necessary. - Choose platform/memory.h when appropriate. Change-Id: Ic24ef89aefb754acccef896e6b59a7ba744ac2df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862504Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#83007}
-
Michael Achenbach authored
This adds Python logging to several code locations that previously used to just print. The locations aren't yet complete. The changed code locations should help for investigating hanging test runs. The default level is WARNING for running tests locally, and INFO when called from bots that pass the --swarming parameter. Bug: v8:13113 Change-Id: If3a336703e7c346a5c718f2359b1a80e37e1ca6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3876183 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Alexander Schulze <alexschulze@chromium.org> Cr-Commit-Position: refs/heads/main@{#83006}
-
Dominik Inführ authored
This CL defines empty methods when building without VERIFY_HEAP. This removes the need for some preprocessor statements around heap verification. Bug: v8:11708 Change-Id: I354fd2793ab5d8ca4ab7de0822c832e2a868d832 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3872267Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#83005}
-
Shu-yu Guo authored
ValueDeserializer should be lenient and not assume correct usage when deserializing shared objects. This CL makes ValueDeserializer throw if a shared object conveyor id or shared object id are not found. Bug: v8:12547, chromium:1359227 Change-Id: I429a37dfadd95e42edca5d4870eb5188cb013bc7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3872549Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Patrick Thier authored
- Add v-flag and corresponding prototype getters. - Update RegExp builtins fuzzer to handle two-byte flags. - Update test262 status. Bug: v8:11935 Change-Id: If649ebfacf1f933f3ae5c770c2240470a8b460ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3868952Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Linke <jgruber@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#83003}
-
Manos Koukoutos authored
Rename {TypeCheckJSObject} to {JSToWasmObject}. Change it to return a MaybeHandle containing the typechecked object transformed to its wasm representation. Use the new function to simplify {WasmWrapperGraphBuilder::FromJS}. Bug: v8:7748 Change-Id: I036f3a1c197041d0b12e7338adca2bc10e66038b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3874931 Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/heads/main@{#83002}
-
Victor Gomes authored
Temporary fix, ideally we should tell the register allocator to not alias the input with the output. Bug: v8:7700, v8:13109 Change-Id: I822e8e957689213499ea34620fcdeb5f532f2f5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3876382 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Bug: v8:7700 Change-Id: I08cea127fcb8a2d1adf1667d0953888e035e3e46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3876242 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#83000}
-
Leszek Swirski authored
idiv throws a hardware divide exception if it overflows, so add some manual overflow checks before it (mostly copied from TurboFan). Bug: v8:7700 Change-Id: Ic3764ecb03d627e482d75b80e712d5ce4a16e9df Fixed: chromium:1359864 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3876182Reviewed-by:
-
Leszek Swirski authored
... because it's now read concurrently by Maglev. Bug: v8:7700 Change-Id: Iab20ee398269bab403f9d463665c967dcf48e9aa Fixed: chromium:1360255, v8:13266 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3875903Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Milad Fa authored
Change-Id: I61227d13bd6d9efb037ea62179c02e0571d61fa8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3870654Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82997}
-
Clemens Backes authored
Avoid the deprecated FLAG_* syntax, access flag values via the {v8_flags} struct instead. R=ishell@chromium.org Bug: v8:12887 Change-Id: I457fd781f13c37ffdaa19e29c8f998ee3eaa55a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3875085Reviewed-by: -
Clemens Backes authored
If collecting PGO information, keep all modules alive until the process dies. This allows to run multiple tests / benchmarks and combining the profile information for all of them. Otherwise the NativeModule might be garbage-collected between runs, and previous information would be lost. R=manoskouk@chromium.org Bug: v8:13209 Change-Id: I96e3cda1a123c7a1f3fbc7f5369d2366acee80e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3875082Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#82995}
-
Samuel Groß authored
The check for non-canonical address access must come before the check for nullptr access as the faultaddr will be 0x0 in the former case. Bug: v8:12878 Change-Id: I6f141d08862879ec9ccb13c081aa6c75a3707530 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3875904 Auto-Submit: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Victor Gomes authored
Allows to debug print a node, similar to CSA. Bug: v8:7700 Change-Id: I602f8f8ed8c6df6b0782dd55b477252ee31dca26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3874932Reviewed-by:
-
Manos Koukoutos authored
- i31s should not be packed in {WasmWrapperGraphBuilder::ToJS}. - anyref should be able to hold any JS value (except null if non nullable). - Restructure TypeCheckJSObject. Bug: v8:7748 Change-Id: I51ab6b84e89a70e565ce56de7a41f8693aa28e5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3871073Reviewed-by: -
Danylo Boiko authored
Fixed a bug with Smis in the bytecode constant pool when running with --trace-turbo Bug: chromium:1356895 Change-Id: Idc8990c250c2c85f4755e45115d4c4bac167bfe3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3870413Reviewed-by:
-
Clemens Backes authored
Avoid the deprecated FLAG_* syntax, access flag values via the {v8_flags} struct instead. R=jgruber@chromium.org Bug: v8:12887 Change-Id: Id293b260c1d84c2f9bd7f5c3c826f374ac6a68b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3875086 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
Avoid the deprecated FLAG_* syntax, access flag values via the {v8_flags} struct instead. R=jgruber@chromium.org Bug: v8:12887 Change-Id: Ide7272de6a59e8324f19d4f52053737b56a380d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3875083 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a412eb2..24bb610 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/18d22db..46ab4c3 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/369cbf3..85a3363 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/48afced..6285577 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/81e0cc1..9f4113d R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: If51fa917599a962c36cbb1cacfaa3c182911540a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3870602 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82988}
-
- 05 Sep, 2022 19 commits
-
-
Michael Lippautz authored
- ObjectAllocator::Terminate() description was out of date. - Compactor::CancelIfShouldNotCompact() return value was unused. Change-Id: Ie47e70eaecaba1300ad638e155a9dd273202aca5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3875084Reviewed-by:
-
Feng Yu authored
Bug: v8:12781 Change-Id: Ib2d7fe959f06cb750ccf419796002efb7e569623 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865062Reviewed-by:
-
Leszek Swirski authored
Dynamic maybe-context/maybe-global lookup can fast-path in the case where there are no context extensions in the parent contexts. Add a trampoline builtin for maglev which performs this fast path. This is similar to Sparkplug, which calls a similar builtin (except one which loads context and FBV from Sparkplug frame slots), and unlike TurboFan, which creates local control flow to inline this operation fully. Maglev avoids creating local control flow, so the builtin approach seems more fitting. Bug: v8:7700 Change-Id: I2f63694d9c1f907f91b8b7b8982adc9f9ba106ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3871210Reviewed-by:
-
Victor Gomes authored
Contexts are not included into bytecode loop assignment analysis. We follow TF and create a LoopPhi unconditionally. Bug: v8:7700 Fixed: chromium:1359662 Change-Id: I1a589a4bae2bbbf14bf637f0c1e0439e66216aae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3871209 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit f388f96f. Reason for revert: Crashes in canary (https://crbug.com/1360024) Original change's description: > Enable background merging of deserialized scripts > > This can save memory in cases where multiple frames in a process use the > same script, with sufficient time between loads that the script's > top-level SharedFunctionInfo is no longer present in the compilation > cache. Merging is relatively fast; it generally takes about one tenth as > long as deserialization. > > Bug: v8:12808 > Change-Id: I7366a51f1d2ca6a9f551cdf2bdbe0441450cf1bb > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3868088 > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82920} Bug: v8:12808 Change-Id: If160173afaab351d995ddcf4b60d6efe656cf70b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3871208 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82983}
-
Clemens Backes authored
Avoid the deprecated FLAG_* syntax, access flag values via the {v8_flags} struct instead. R=tebbi@chromium.org Bug: v8:12887 Change-Id: Ia636a23e8d9fceb9bc17d830b8395bac46984285 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3871202Reviewed-by: -
Clemens Backes authored
Avoid the deprecated FLAG_* syntax, access flag values via the {v8_flags} struct instead. R=nicohartmann@chromium.org Bug: v8:12887 Change-Id: Icc9016552c53489afd821ff6d360c025e48fee18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3871201 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
Avoid the deprecated FLAG_* syntax, access flag values via the {v8_flags} struct instead. R=leszeks@chromium.org Bug: v8:12887 Change-Id: I17a168a4810f13087be34a58358c684f1516da99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3870489 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
This adds two flags to dump "type feedback" (call targets and frequencies) to a local file, or load it from there. This is meant for experimentation only. Some implications are removed, as (speculative) inlining now does not require Liftoff any more, but can also use information from PGO. R=jkummerow@chromium.org Bug: v8:13209 Change-Id: I2d34233ce4077db61f5c237b1941136ac61d3b73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3870470Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#82979}
-
Leon Bettscheider authored
This CL implements ConcurrentMarking::RunMinor which uses YoungGenerationConcurrentMarkingVisitor (go/YGCMV). This CL also implements Teardown and FinishConcurrentMarking, and schedules minor concurrent marking in IncrementalMarking::StartMarkingMinor. Additionally, this CL opts out of ConcurrentMarking::PauseScope in Heap::MinorMarkCompact if concurrent MinorMC is active because concurrent marking will be finalized in FinishConcurrentMarking subsequentially. Bug: v8:13012 Change-Id: I78fe18416e564565c6421243ff40dec7561fb20a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3850292 Commit-Queue: Leon Bettscheider <bettscheider@google.com> Reviewed-by:
-
Igor Sheludko authored
Bug: chromium:1359936 Change-Id: If5b09647dbb341b056a782ae6d1733351c8061bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3870487 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#82977}
-
Leon Bettscheider authored
This CL removes global handle marking barriers for MinorMC because global handles should only be marked by MajorMC. Bug: v8:13012 Change-Id: I23737f128c01eee75b2b1a19f47c4bcf6d043976 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3872270Reviewed-by:
-
Camillo authored
- Disable interspersed args for a cleaner CLI - Auto upload pprof results for authenticated googlers Change-Id: I3bfa602980ed659c8671910ea77dddedabc84e12 No-Try: True No-CQ: True Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3871200Reviewed-by:
-
Michael Lippautz authored
The test broke in https://crrev.com/c/3865148 Bug: chromium:1352649 Change-Id: I9857fd359d73a4c1f7d202feba27a3dcf56e23c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3872275 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Nikolaos Papaspyrou authored
The stack of an isolate's main thread is kept in the isolate's heap. This CL sets the stack's start address when the isolate's heap is set up; it can also be set explicitly from the embedder. The CL also fixes threaded cctests, where an isolate is shared by many "main" threads. Bug: v8:13257 Change-Id: Ie30bbbe4130882d94f23de946cbada748f32e22d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3870923Reviewed-by:
-
Leszek Swirski authored
LdaLookupGlobal/ContextSlot loop over parent contexts to check for context extensions. If there aren't any, they can do a fast context/global load, otherwise they have to call a runtime slow path. The bytecode graph builder didn't build a slow path in the case where no context extensions are possible, by depth == 0 or static scope info information that there are no possible context extensions. However, this information is already known to the interpreter, so that should already elide the lookup in these cases. So, get rid of the slow path being optional in TurboFan, and consider such cases bytecode generation bugs. Change-Id: Ib69f90e51b0f783306824fed56911d039f7e134e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3872277 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Workaround crbug.com/13261 by converting the maglev CodeT into a Code. Bug: v8:7700 Bug: v8:13261 Change-Id: I5ef692dea9d7c4eee2c1ca6476f572fc415f5ed0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3872274 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Matthias Liedtke authored
This reverts commit d00c0405. Reason for revert: Failing CI tests on Mac arm64 Original change's description: > [strings] Support shared external strings > > With this CL shared strings can be externalized and external strings can > be shared. > The StringForwardingTable is used to delay the real transition to the > next full GC. On the API side strings marked for externalization will > look like externalized strings. > > Bug: v8:12957 > Change-Id: I53b6509129bc5679c06bdf99421bdb41ea5d9082 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3849643 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82966} Bug: v8:12957 Change-Id: I13155fcc788d217db56cbfd1c9e4457a81a9dbd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3870486 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/heads/main@{#82970}
-
Clemens Backes authored
Avoid the deprecated FLAG_* syntax, access flag values via the {v8_flags} struct instead. R=mlippautz@chromium.org Bug: v8:12887 Change-Id: Id12f9d8270dd9fed651e1b3596c06e45aae9d6d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3846151Reviewed-by:
-
