- 09 Aug, 2021 1 commit
-
-
legendecas authored
Excluded keys should not be performed with GetOwnPropertyDescriptor on source object in CopyDataProperties. The key values fetch in CopyDataProperties might be arbitrary kind. It may be smi, string, and symbol. Yet the proxy keys collected by KeyAccumulator are not expected types for numeric keys. Those keys should be converted to expected types. Also updates a typo in comments of BytecodeGenerator::BuildDestructuringObjectAssignment. The elements in rest_runtime_callargs should be [value, ...excluded_properties]. Refs: https://tc39.es/ecma262/#sec-copydataproperties Bug: v8:11532 Change-Id: If71bfedf8272ce8405e8566a016fae66b3007dd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060275Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#76171}
-
- 25 Oct, 2017 1 commit
-
-
Adam Klein authored
This flag has been on by default since Chrome 61. Bug: v8:5549 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I81c34d1d3a7dbd219acce2cdf0cf4917eb484002 Reviewed-on: https://chromium-review.googlesource.com/738312Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48945}
-
- 14 Jul, 2017 1 commit
-
-
Sathya Gunasekaran authored
Only allow BindingIdentifier in BindingRestPattern and ValidReferenceExpression in AssignmentRestPattern. Also updated to a better, actionable error message. Bug: v8:6500, v8:6513 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Ifaba2f85c20bc20e263267e8c76d50a27075b87d Reviewed-on: https://chromium-review.googlesource.com/550559 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#46653}
-
- 21 Jan, 2017 1 commit
-
-
gsathya authored
Convert strings to numbers if possible in the runtime call and store in excluded property list. BUG=v8:5549 Review-Url: https://codereview.chromium.org/2639333004 Cr-Commit-Position: refs/heads/master@{#42581}
-
- 18 Jan, 2017 1 commit
-
-
gsathya authored
This rewrites the rest property into a runtime call which sets up the correct properties in the newly created object. - Changes flag to --harmony-object-rest-spread - Changes pattern rewriter to desugar rest property - Adds new runtime function CopyDataPropertiesWithExcludedProperties BUG=v8:5549 Review-Url: https://codereview.chromium.org/2620943002 Cr-Commit-Position: refs/heads/master@{#42430}
-