- 30 Nov, 2018 20 commits
-
-
Ross McIlroy authored
Introduces a IsCompiledScope object which can be used to check whether a function is compiled, and ensure it remains compiled for the lifetime of the scope without being uncompiled by bytecode flushing. The Compile functions are modified to take a scope so that calling code can ensure the function remains compiled for the lifetime they require. Also, don't allocate a feedback vector for asm-wasm code as this is never used, and will be reallocated if the asm-wasm code fails to instantiate the module and we fallback to regular JavaScript. Also restructure Compiler::PostInstantiation() to allocate the feedback vector once, and do the optimized code check before optimizing for always opt. BUG=v8:8395 Change-Id: I3f1a71143fcae3d1a0c01eefe91ebb4b8594221a Reviewed-on: https://chromium-review.googlesource.com/c/1352295Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57971}
-
Camillo Bruni authored
- Message listener callbacks - Bootstrapper and deserialization - ObjectVerify - Invoke and InvokeApiFunction Drive-by-fix: sort RCS counters list. Change-Id: I9acec3a3b94cb126c23575aae749c60b5257549d Reviewed-on: https://chromium-review.googlesource.com/c/1356509Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#57970}
-
Jakob Gruber authored
Bug: v8:8503, v8:7777 Change-Id: Iadf515cf4735d1046c7c14f44c02d5d5f95df87a Reviewed-on: https://chromium-review.googlesource.com/c/1356512Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57969}
-
Clemens Hammacher authored
Do not implement one-armed ifs by emulating an empty else branch. In Liftoff, we can generate better code and save compile time by handling this specially. If the merge point at the end of the if is not reached by the if-branch, we do not need to generate any merge code. R=titzer@chromium.org Bug: v8:6600, v8:8423 Change-Id: Ie8ea69dd7491f225605a8e1b986d275d869aa90b Reviewed-on: https://chromium-review.googlesource.com/c/1356508 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57968}
-
Tobias Tebbi authored
Change-Id: I9c927567e43e269a9b8ed81edfc8786a879e9573 Reviewed-on: https://chromium-review.googlesource.com/c/1350120Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57967}
-
Sigurd Schneider authored
Change-Id: Id73e9e4862d3b7751b6867183a43cfa7a0cdef52 Bug: v8:8344 Reviewed-on: https://chromium-review.googlesource.com/c/1355145 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Peter Marshall authored
Bug: chromium:906043 Change-Id: I3a397447be186eff7e6b2ab25341718b6c0d205d Reviewed-on: https://chromium-review.googlesource.com/c/1356507 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Maya Lekova authored
Remove the test-api/InitializeDefaultIsolateOnSecondaryThread_ResourceConstraints test which was setting max-old-space-size limit without acutally using it. This caused repetitive failures, resulting in the test being effectively disabled. Bug: v8:8521 R=ulan@chromium.org, yangguo@chromium.org Change-Id: Iad39cc95df86963d256816bf56d0bc5f62f7d5c9 Reviewed-on: https://chromium-review.googlesource.com/c/1356506Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Yang Guo authored
Termination exceptions tear down V8 to the bottom-most V8 call. If there is a v8::TryCatch scope around that call, it returns true for HasTerminated() and HasCaught(). However, Isolate::IsExecutionTerminating() returns false and we can call into V8 from still inside the v8::TryCatch scope. Changes that this patch introduces: - You need to leave the v8::TryCatch scope around the bottom-most call to reset the termination state, in order to resume. - Explicitly check for termination exception and reporting it through the DevTools protocol after Runtime.evaluate and Debugger.evaluateOnCallFrame. Bug: v8:8455 Change-Id: I1f36f7a365985469813c2619bf16f18ee69aa4b8 Reviewed-on: https://chromium-review.googlesource.com/c/1337582Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57963}
-
Michael Starzinger authored
The placement of the exceptipon section is by now restricted to be in between the Global and the Import section. This changes our validation to check this stricter requirement now. R=clemensh@chromium.org TEST=unittests/WasmModuleVerifyTest BUG=v8:8091 Change-Id: Ib3ea625fd4df93bffda47ced09e6969159f7ac70 Reviewed-on: https://chromium-review.googlesource.com/c/1356504Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57962}
-
Predrag Rudic authored
64-bit implementations of ExtractBits and InsertBits were using 32-bit instructions. Masking when representation of instruction is 64 is now correct. Also added optimization for 32-bit InsertBits. Change-Id: I3d5117835daa67708e544d01d1d9058dcc0cc64e Reviewed-on: https://chromium-review.googlesource.com/c/1355141Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57961}
-
Clemens Hammacher authored
Building on linux x64 with "is_component_build = true" currently fails with linker errors (undefined references). This CL fixes that. R=ahaas@chromium.org TBR=mseaborn@chromium.org,mark@chromium.org Bug: v8:8532 Change-Id: I6b32c00bd974a22268ad1f161ce06a9ebe47c805 Reviewed-on: https://chromium-review.googlesource.com/c/1356505Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57960}
-
Camillo Bruni authored
Make sure that the testAddFn is always optimized. Bug: v8:8220 Change-Id: I38543dc4cf99df6a379c9474ce275af2c9ef015d Reviewed-on: https://chromium-review.googlesource.com/c/1355401 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#57959}
-
Clemens Hammacher authored
Minor refactoring. R=titzer@chromium.org Bug: v8:8238 Change-Id: Ibf3388cf8fc4a8d618e2e0da53209e29e753058d Reviewed-on: https://chromium-review.googlesource.com/c/1356501Reviewed-by:
-
Toon Verwaest authored
Move from ParseAndClassifyIdentifier to places where we either know that what we're parsing are parameters, or where they could become (async) arrow formals. Change-Id: Ic69bb586ed29ba9ac7b4dbef5d11a2e1954e7332 Reviewed-on: https://chromium-review.googlesource.com/c/1356503Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57957}
-
Peter Marshall authored
This reverts commit 4e3a17d0. Reason for revert: Web compact issues, see crbug.com/910252 Original change's description: > [runtime] Reduce spread/apply call max arguments > > Bug: chromium:906043 > Change-Id: I308b29af0644c318d73926b27e65a94913c760c7 > Reviewed-on: https://chromium-review.googlesource.com/c/1346115 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57731} TBR=jarin@chromium.org,jgruber@chromium.org,petermarshall@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:906043 Change-Id: I240c1b55c10fd3e108e3c49f93ce1d9ca9c61780 Reviewed-on: https://chromium-review.googlesource.com/c/1356502Reviewed-by:
-
Tao Pan authored
In the case of using start and size to manage range, the range is start ~ start + size - 1, start + size is out of the range. The template function IsInRange(T value, U lower_limit, U higher_limit) judge whether value is in the range lower_limit ~ higher_limit. IsInRange(pc, start, start + isolate->embedded_blob_size()) misjudge the case pc == start + isolate->embedded_blob_size() Signed-off-by:
Tao Pan <tao.pan@intel.com> Change-Id: Iad172454bacb27a1328bbdda5863d28c9853a6db Bug: v8:8530 Change-Id: Iad172454bacb27a1328bbdda5863d28c9853a6db Reviewed-on: https://chromium-review.googlesource.com/c/1355633Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b7e2add..e066ef7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/eee0f6a..63d69d7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/44d4b29..dd53081 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/8a671fe..5422fce Rolling v8/tools/luci-go:infra/tools/luci/isolate/${platform}: https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}/+log/git_rev..git_rev TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I4c5055d0a46a6ab5b0f4f30a70520d172ca77bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1355632Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57954}
-
Aseem Garg authored
This is a reland of 9436e8a8 This CL simplifies the wasm/futex.js test so that it doesn't push the limits of d8. Original change's description: > [wasm] Add I64AtomicWait implementation > > Bug=v8:8075 > R=adamk@chromium.org,binji@chromium.org > > Change-Id: I11ef5daccd043123b23e60c93ee0df79cabe9ccd > Reviewed-on: https://chromium-review.googlesource.com/c/1342948 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Ben Smith <binji@chromium.org> > Commit-Queue: Aseem Garg <aseemgarg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57917} Change-Id: Ifd26f1ecdb9fe24a1896162bb4d4285f9188a9ba Reviewed-on: https://chromium-review.googlesource.com/c/1351304 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57953}
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: I6ad84a663926fffc9e1acc590c13780c39461274 Reviewed-on: https://chromium-review.googlesource.com/c/1351248 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
- 29 Nov, 2018 20 commits
-
-
Ben Smith authored
The bulk-memory proposal adds a new DataCount section that declares the number of data segments that are expected to be seen in the Data section. This is similar to the way the number of functions is split between the Function and Code sections. The DataCount section occurs before the Code section, so we can do single-pass validation of the new `memory.init` and `memory.drop` instructions, which have data segment indices as immediates. Bug: v8:7747 Change-Id: Ibc5a7ee9336dbc5d0fd667572c42cb065c048e00 Reviewed-on: https://chromium-review.googlesource.com/c/1352792 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
-
Camillo Bruni authored
This should reduce the likelyhood of getting indistinguishable map log events with --trace-maps. Bug: v8:8524 Change-Id: I5dad7a026ec9384960177298afadc1f9fa710eda Reviewed-on: https://chromium-review.googlesource.com/c/1354890Reviewed-by:
-
Ben Smith authored
Make sure to check that the number of declared functions (specified in the function section) matches the number of function bodies, even if the code section is omitted. Note that it is valid to have a function section with zero declared functions and an omitted code section, and vice versa. Bug: v8:8514 Change-Id: I4effa5abe2ed6d71146a665d2df6a2f48b5a84be Reviewed-on: https://chromium-review.googlesource.com/c/1351306 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
This CL moves a number of memory-related methods out of utils into its own header, since utils.h is included in many places that do not need these methods. R=clemensh@chromium.org,mstarzinger@chromium.org Change-Id: I5155baf329844784286413408c05c7108b789020 Reviewed-on: https://chromium-review.googlesource.com/c/1354889 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#57948}
-
Andreas Haas authored
The problem were missing V8_EXPORT_PRIVATE and V8_EXPORT. The unittests test if the trap handler only handles those traps it is supposed to handle: * Only handle traps when the thread-in-wasm flag is set. * Only handle traps of the right type, i.e. memory access violations. * Only handle traps at recorded instructions. The tests also test the consistency of the thread-in-wasm flag. I made one change in the trap handler where that consistency could be violated. All tests are executed with the default trap handler provided by V8, and with the trap handler callback installed in a test signal/exception handler. Patchset 1 is the original CL. R=mstarzinger@chromium.org Change-Id: I172d94f24cdba4c3a1f7f344825b059dbb59da79 Reviewed-on: https://chromium-review.googlesource.com/c/1351024Reviewed-by:
-
Michael Lippautz authored
Fix two bugs: - Initial configuration of limit allowed to go below the size of already allocated objects. - Context disposal without dependend context reset the heap state to not configured without actually increasing the limit again. Bug: chromium:843903 Change-Id: Ibdcf69b0b92b800f8919d5cc98186334945d811f Reviewed-on: https://chromium-review.googlesource.com/c/1355143Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:8091 Change-Id: Ib0e0b50d1fe24b0e528a3dd9849829799b33f1bc Reviewed-on: https://chromium-review.googlesource.com/c/1355139Reviewed-by:
-
Clemens Hammacher authored
This adds error functions that receive offsets instead of pc, since the streaming compiler stores different sections in different buffers, so computing pointer differences between different sections does not work. We keep the pc-based methods for now to reduce code-churn and complexity at the different call sites. R=ahaas@chromium.org CC=binji@chromium.org Bug: v8:8238 Change-Id: I1aa68740bdda93c3341431aa7a81ac01ecfb71bb Reviewed-on: https://chromium-review.googlesource.com/c/1354463Reviewed-by:
-
Michael Starzinger authored
This introduces a dedicated instance type for exception tags. The main motivation is to reduce their footprint and getting rid of a temporary workaround that used the {JSObject} type for this purpose. R=clemensh@chromium.org BUG=v8:8091 Change-Id: Id5678bce513f2ac086c7380bd803011b11d5050e Reviewed-on: https://chromium-review.googlesource.com/c/1354464Reviewed-by: -
Vasili Skurydzin authored
Change-Id: If22939274db5db07a4f947ef5ef209d96078da36 Reviewed-on: https://chromium-review.googlesource.com/c/1351766Reviewed-by:
-
Sigurd Schneider authored
This adds a new target :generated_cc_files which generates all generated .cc files and is quick to build (~5sec on my machine). TBR=yangguo@chromium.org Change-Id: I51485635671b55302b06f1ea300e86ef1745931e Bug: v8:8526 Reviewed-on: https://chromium-review.googlesource.com/c/1354881 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57941}
-
Toon Verwaest authored
Changes [ x **= 2 ] = [] from [ x **= 2 ] = [] ^^^ SyntaxError: Unexpected token **= to: [ x **= 2 ] = [] ^^^^^^^ SyntaxError: Invalid destructuring assignment target Change-Id: I07170d12c151a94a7f99d37dce17197a3aa6f503 Reviewed-on: https://chromium-review.googlesource.com/c/1355140Reviewed-by: -
George Wort authored
This reverts commit 291a6029. Reason for revert: Unnecessary following f32 support for Liftoff on arm32. Original change's description: > [liftoff][arm] Fix overlapping of F32 and F64 registers in Liftoff > > Add a check to bailout in the case when F32 parameters are used for Arm. > > Bug: v8:6600, chromium:904026, chromium:904606 > Change-Id: I7f70c0806994a89dca31ef7e0b68f91d68484936 > Reviewed-on: https://chromium-review.googlesource.com/c/1346492 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57741} TBR=titzer@chromium.org,clemensh@chromium.org,george.wort@arm.com Change-Id: I98ba43017f521c83b96bbb15e9dc803954dc1eec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600, chromium:904026, chromium:904606 Reviewed-on: https://chromium-review.googlesource.com/c/1354467Reviewed-by:
-
Toon Verwaest authored
|scope_snapshot_| might not have been cleared if there was a parser error between setting the snapshot and consuming it. Explicitly clear it at the end of parsing for that case. Otherwise Scope::Snapshot's destructor will possibly write into the already freed zone. Bug: chromium:909976 Change-Id: I8469d11f04e7f71528be5cba5663c652cd7eacb2 Reviewed-on: https://chromium-review.googlesource.com/c/1354880 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57938}
-
Michael Hablich authored
TBR=machenbach@chromium.org Change-Id: Id131f9624b6cd8e72f45e0506644d9e9765fa6f2 Reviewed-on: https://chromium-review.googlesource.com/c/1354888Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#57937}
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I869ee5d6b705da0dab3c78dfd01eff9aca469d01 Reviewed-on: https://chromium-review.googlesource.com/c/1354886 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Peter Marshall authored
This is a reland of d5f4a33e Landing with test disabled for now. Original change's description: > [cpu-profiler] Fix stack iterability for fast C calls with no exit frame > > Before fast C calls, store the current FP and PC on the isolate. When > iterating frames in SafeStackFrameIterator, check if these fields are > set and start iterating at the calling frame's FP instead of the current > FP, which will be in C++ code. We need to do this because c_entry_fp is > not set on the Isolate for Fast-C-Calls because we don't build an exit > frame. > > This change makes stack samples that occur within 'Fast-C-Calls' > iterable, meaning we can properly attribute ticks within the JS caller. > > Fast-C-Calls can't call back into JS code, so we can only ever have one > such call on the stack at a time, allowing us to store the FP on the > isolate rather than the stack. > > TBR=v8-mips-ports@googlegroups.com > > Bug: v8:8464, v8:7202 > Change-Id: I7bf39eba779dad34754d5759d741c421b362a406 > Reviewed-on: https://chromium-review.googlesource.com/c/1340241 > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Martyn Capewell <martyn.capewell@arm.com> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57896} TBR=v8-mips-ports@googlegroups.com TBR=jgruber@chromium.org Bug: v8:8464, v8:7202 Change-Id: I260d5ab3bc12c9c4529fb52a297a1040dcaa8ebf Reviewed-on: https://chromium-review.googlesource.com/c/1354466 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This refactors Map operations to update the instance descriptors and the number of own descriptors via the SetInstanceDescriptors bottleneck. This will allow us to add a special marking barrier for these updates. Bug: v8:8486 Change-Id: Ie9c746d4bcdd6166d38402622734693fa59faf21 Reviewed-on: https://chromium-review.googlesource.com/c/1354883Reviewed-by:
-
Igor Sheludko authored
This CL unifies performance-critical slot processing code that was manually specifaized for ObjectSlot. Now one templated implementation can be used for processing both ObjectSlot and MaybeObjectSlot. Bug: v8:8518 Change-Id: Ia4346a817911f8042459ce579741fe2308ef5e4d Reviewed-on: https://chromium-review.googlesource.com/c/1354459 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#57933}
-
George Wort authored
This supports the use of f32 values for the arm32 port of Liftoff. Bug: v8:6600 Change-Id: I1fa2782f5a8bc6687a17d2df6e4ec8036b23452c Reviewed-on: https://chromium-review.googlesource.com/c/1354040 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
