- 12 Apr, 2016 27 commits
-
-
binji authored
* New atomic code stubs for x64, ia32, arm, arm64 * Add convenience functions JumpIfNotValidSmiValue, JumpIfUintNotValidSmiValue to macro-assembler-ia32 (API based on x64 macro assembler) * Remove runtime implementation of Atomics.load, the code stub should always be called instead * Add new test to mjsunit atomics test; check that Smi values of different sizes are supported when possible, else fall back to HeapNumbers These changes were needed to add another codestub: * Bump kStubMajorKeyBits from 7 to 8 * Reduce ScriptContextFieldStub::kSlotIndexBits from 13 to 12 BUG=v8:4614 LOG=y Review URL: https://codereview.chromium.org/1617503003 Cr-Commit-Position: refs/heads/master@{#35427}
-
jyan authored
port 52148c41 Original Commit Message: Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. R=gdeepti@google.com, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com, mbrandy@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1884573003 Cr-Commit-Position: refs/heads/master@{#35426}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1883533006 Cr-Commit-Position: refs/heads/master@{#35425}
-
mbrandy authored
Port eb5fe0df Original commit message: Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. R=gdeepti@google.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1878233002 Cr-Commit-Position: refs/heads/master@{#35424}
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 Reverted again in: https://codereview.chromium.org/1877823003 Reverts due to non-CQ bots: - First: v8_win_dbg, v8_win64_dbg, v8_mac_dbg - Second: gc mole (added to v8_linux_rel_ng for this patch) R= jochen@chromium.org TBR= ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1872203005 Cr-Commit-Position: refs/heads/master@{#35423}
-
jyan authored
Port 79ff6507 R=verwaest@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1877353002 Cr-Commit-Position: refs/heads/master@{#35422}
-
mythria authored
When %OptimizeOSR is used with ignition flag, the runtime function tries to compile for OSR on interpreted functions. This cl modifies Runtime_OptimizeOsr function to return false for interpreted frames. BUG=v8:4280,chromium:599002 LOG=N Review URL: https://codereview.chromium.org/1880073002 Cr-Commit-Position: refs/heads/master@{#35421}
-
marija.antic authored
Fix for drotr and drotr32 instructions in MIPS64 simulator. BUG= Review URL: https://codereview.chromium.org/1880953002 Cr-Commit-Position: refs/heads/master@{#35420}
-
mstarzinger authored
This uses the common predicate SharedFunctionInfo::IsApiFunction to determine flushability. Just a minor cleanup, no change in semantics. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1878183002 Cr-Commit-Position: refs/heads/master@{#35419}
-
bmeurer authored
Previously TurboFan always went to the runtime to allocate in old space, which is pretty slow compare to a stub call. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1877323002 Cr-Commit-Position: refs/heads/master@{#35418}
-
jyan authored
port 2e329666 Original Commit Message: ... instead of doing stack magic. This is a cleanup in preparation for the new generators implementation. R=bmeurer@chromium.org, neis@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1882553003 Cr-Commit-Position: refs/heads/master@{#35417}
-
mbrandy authored
Port 2e329666 Original commit message: ... instead of doing stack magic. This is a cleanup in preparation for the new generators implementation. R=neis@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1874323002 Cr-Commit-Position: refs/heads/master@{#35416}
-
thakis authored
Makes browser_tests --gtest_filter=CrSettingsBrowserTest.CrSettingsTest complete in a little over 8 seconds instead of timing out after 45s on my box. Without this patch, the test is much slower in gn builds than in gyp builds. v8/ part, goes with https://codereview.chromium.org/1880693003 BUG=chromium:586511 LOG=n Review URL: https://codereview.chromium.org/1882453002 Cr-Commit-Position: refs/heads/master@{#35415}
-
mlippautz authored
R=ulan@chromium.org BUG=chromium:581412 LOG=N Review URL: https://codereview.chromium.org/1882033002 Cr-Commit-Position: refs/heads/master@{#35414}
-
ulan authored
This ensures that GC tracer scope is nested in a trace event. BUG= Review URL: https://codereview.chromium.org/1881993002 Cr-Commit-Position: refs/heads/master@{#35413}
-
hlopko authored
When the embedder sets the heap tracer, V8, during marking, will collect all reachable wrappers, and then ask embedder to trace its heap. The embedder is expected to call PersistentBase::RegisterExternalReference with all wrappers reachable from the given ones. This fixed point iteration happens in MarkCompact::ProcessEphemeralMarking. For more efficient object visiting during marking, we need a special JS_API_OBJECT_TYPE (in tandem with already existing JS_SPECIAL_API_OBJECT_TYPE) and corresponding visitor (JSApiObjectVisitor). BUG=chromium:468240 LOG=no Review URL: https://codereview.chromium.org/1844413002 Cr-Commit-Position: refs/heads/master@{#35412}
-
bmeurer authored
Make these builtins fast by default w/o relying on the %_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal with well in TurboFan (and ignition). CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg,v8_linux_blink_rel R=epertoso@chromium.org Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb Cr-Commit-Position: refs/heads/master@{#35350} Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c Cr-Commit-Position: refs/heads/master@{#35402} Review URL: https://codereview.chromium.org/1868963002 Cr-Commit-Position: refs/heads/master@{#35411}
-
machenbach authored
Revert of [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. (patchset #3 id:40001 of https://codereview.chromium.org/1868963002/ ) Reason for revert: Please rebaseline: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/5992 Original issue's description: > [builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan. > > Make these builtins fast by default w/o relying on the > %_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal > with well in TurboFan (and ignition). > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg > R=epertoso@chromium.org > > Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb > Cr-Commit-Position: refs/heads/master@{#35350} > > Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c > Cr-Commit-Position: refs/heads/master@{#35402} TBR=epertoso@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1877263002 Cr-Commit-Position: refs/heads/master@{#35410}
-
jochen authored
This is a convenience API that an embedder can use to do final checks on the return value. Note that this creates a new handle and thus defeats the performance optimization done for ReturnValue - an embedder should only use this in non-performance critical code paths. BUG= R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1875263003 Cr-Commit-Position: refs/heads/master@{#35409}
-
machenbach authored
BUG=535160 TBR=sergiyb@chromium.org, kjellander@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1884473002 Cr-Commit-Position: refs/heads/master@{#35408}
-
gdeepti authored
Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org Committed: https://crrev.com/eb5fe0df64ec0add423b2a1f6fb62d5a33dce2a5 Cr-Commit-Position: refs/heads/master@{#35182} Committed: https://crrev.com/297932a302ce0b73c3618ef9e4eba9d9d241f2b3 Cr-Commit-Position: refs/heads/master@{#35400} Review URL: https://codereview.chromium.org/1759383003 Cr-Commit-Position: refs/heads/master@{#35407}
-
oth authored
Fixes updating golden files following instanceof change. BUG=v8:4280 LOG=N R=rmcilroy@chromium.org,ssanfilippo@chromium.org Review URL: https://codereview.chromium.org/1858593002 Cr-Commit-Position: refs/heads/master@{#35406}
-
mbrandy authored
Port 79ff6507 R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1874983004 Cr-Commit-Position: refs/heads/master@{#35405}
-
hablich authored
Revert of Visit the Optimized Code Map on first call rather than closure creation. (patchset #7 id:120001 of https://codereview.chromium.org/1670143002/ ) Reason for revert: Blocks roll. See https://codereview.chromium.org/1877003002/ for detailed messages. You should be able to repro this with Linux ASAN. Original issue's description: > Visit the Optimized Code Map on first call rather than closure creation. > > This is useful for escape analysis, and helps upcoming changes to > type feedback gathering. > > BUG= > > Committed: https://crrev.com/9336f4cc6d25d39a128176679a70dbd13a6d946e > Cr-Commit-Position: refs/heads/master@{#35395} TBR=mstarzinger@chromium.org,bmeurer@chromium.org,mvstanton@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1878063004 Cr-Commit-Position: refs/heads/master@{#35404}
-
ahaas authored
The parameter is not used at the moment, so I removed it. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1876833003 Cr-Commit-Position: refs/heads/master@{#35403}
-
bmeurer authored
Make these builtins fast by default w/o relying on the %_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal with well in TurboFan (and ignition). CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg R=epertoso@chromium.org Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb Cr-Commit-Position: refs/heads/master@{#35350} Review URL: https://codereview.chromium.org/1868963002 Cr-Commit-Position: refs/heads/master@{#35402}
-
machenbach authored
Revert of [compiler] Add relocatable pointer constants for wasm memory references. (patchset #15 id:320001 of https://codereview.chromium.org/1759383003/ ) Reason for revert: [Sheriff] Breaks msan: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/7842 Original issue's description: > [compiler] Add relocatable pointer constants for wasm memory references. > > Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. > > R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org > > Committed: https://crrev.com/eb5fe0df64ec0add423b2a1f6fb62d5a33dce2a5 > Cr-Commit-Position: refs/heads/master@{#35182} > > Committed: https://crrev.com/297932a302ce0b73c3618ef9e4eba9d9d241f2b3 > Cr-Commit-Position: refs/heads/master@{#35400} TBR=bradnelson@chromium.org,titzer@chromium.org,bmeurer@chromium.org,bradnelson@google.com,gdeepti@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1881913002 Cr-Commit-Position: refs/heads/master@{#35401}
-
- 11 Apr, 2016 13 commits
-
-
gdeepti authored
Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates. R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org Committed: https://crrev.com/eb5fe0df64ec0add423b2a1f6fb62d5a33dce2a5 Cr-Commit-Position: refs/heads/master@{#35182} Review URL: https://codereview.chromium.org/1759383003 Cr-Commit-Position: refs/heads/master@{#35400}
-
jarin authored
Review URL: https://codereview.chromium.org/1856643002 Cr-Commit-Position: refs/heads/master@{#35399}
-
hablich authored
Reland of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1876103002/ ) Reason for revert: Did not fail on another roll including this CL .. Original issue's description: > Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ ) > > Reason for revert: > Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001 > > Original issue's description: > > [compiler] Make feedback vector cope with flag changes. > > > > This fixes corner cases where the layout of feedback vectors baked into > > the snapshot is different from the expected layout, depending on some > > runtime flags. We make sure the feedback vector is regenereated for > > functions that are not compiled. Flag changes of this kind are only > > allowed when code is not serialized. > > > > An alternative solution would be to not serialize the feedback vector > > for such cases in the first place. That solution however would have a > > higher overhead, as it would required the serializer to be able to > > recognize feedback vectors while generating a snapshot. > > > > R=mvstanton@chromium.org > > TEST=mjsunit/regress/regress-crbug-600995 > > BUG=chromium:600995 > > LOG=n > > > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c > > Cr-Commit-Position: refs/heads/master@{#35339} > > TBR=mvstanton@chromium.org,mstarzinger@chromium.org > > BUG=chromium:600995 > LOG=N > NOTRY=true > > Committed: https://crrev.com/78049e9c4837f053575d6c71e53ae12fec99f1aa > Cr-Commit-Position: refs/heads/master@{#35392} TBR=mvstanton@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:600995 Review URL: https://codereview.chromium.org/1876973002 Cr-Commit-Position: refs/heads/master@{#35398}
-
jkummerow authored
This logic mirrors what KeyedLoadICs are doing already. BUG=chromium:602184 LOG=n Review URL: https://codereview.chromium.org/1876793003 Cr-Commit-Position: refs/heads/master@{#35397}
-
https://codereview.chromium.org/1877453002/machenbach authored
Reason for revert: Breaks gc mole: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/9421 Original issue's description: > Fix printf formats > > The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: > > - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. > - Uses it appropriately. > - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). > - Fixes a bunch of incorrect formats. > > Original CL: https://codereview.chromium.org/1869433004 > Reverted in: https://codereview.chromium.org/1867383002 > > R= jochen@chromium.org > TBR= bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org > > Committed: https://crrev.com/bf505329288e1b75bab0e6800371a9aac40fa5cc > Cr-Commit-Position: refs/heads/master@{#35394} TBR=jochen@chromium.org,ahaas@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,jfb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1877823003 Cr-Commit-Position: refs/heads/master@{#35396}
-
mvstanton authored
This is useful for escape analysis, and helps upcoming changes to type feedback gathering. BUG= Review URL: https://codereview.chromium.org/1670143002 Cr-Commit-Position: refs/heads/master@{#35395}
-
jfb authored
The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL: - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h. - Uses it appropriately. - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done). - Fixes a bunch of incorrect formats. Original CL: https://codereview.chromium.org/1869433004 Reverted in: https://codereview.chromium.org/1867383002 R= jochen@chromium.org TBR= bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org Review URL: https://codereview.chromium.org/1877453002 Cr-Commit-Position: refs/heads/master@{#35394}
-
verwaest authored
Otherwise they can't be found in the megamorphic cache, leading to repeated misses. BUG=chromium:596825 LOG=n Review URL: https://codereview.chromium.org/1874303002 Cr-Commit-Position: refs/heads/master@{#35393}
-
hablich authored
Revert of [compiler] Make feedback vector cope with flag changes. (patchset #1 id:1 of https://codereview.chromium.org/1869693003/ ) Reason for revert: Blocks current roll: https://codereview.chromium.org/1876713002/ according to bisect: https://codereview.chromium.org/1872353002/#ps80001 Original issue's description: > [compiler] Make feedback vector cope with flag changes. > > This fixes corner cases where the layout of feedback vectors baked into > the snapshot is different from the expected layout, depending on some > runtime flags. We make sure the feedback vector is regenereated for > functions that are not compiled. Flag changes of this kind are only > allowed when code is not serialized. > > An alternative solution would be to not serialize the feedback vector > for such cases in the first place. That solution however would have a > higher overhead, as it would required the serializer to be able to > recognize feedback vectors while generating a snapshot. > > R=mvstanton@chromium.org > TEST=mjsunit/regress/regress-crbug-600995 > BUG=chromium:600995 > LOG=n > > Committed: https://crrev.com/460bff5fb6af2bd79e610f89afdf6da9dba3cf0c > Cr-Commit-Position: refs/heads/master@{#35339} TBR=mvstanton@chromium.org,mstarzinger@chromium.org BUG=chromium:600995 LOG=N NOTRY=true Review URL: https://codereview.chromium.org/1876103002 Cr-Commit-Position: refs/heads/master@{#35392}
-
mstarzinger authored
This moves the computation of the {expected_nof_properties} for a shared function to where the object is actually being allocated. This is done after parsing when the literal has been populated already. The expected number of properties is not mutated after parsing. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/1873173002 Cr-Commit-Position: refs/heads/master@{#35391}
-
machenbach authored
BUG=535160 TBR=sergiyb@chromium.org, kjellander@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1872423002 Cr-Commit-Position: refs/heads/master@{#35390}
-
epertoso authored
Adds a ModulusStub for the modulo operator and lets TurboFan and Ignition make use of it. Review URL: https://codereview.chromium.org/1876793002 Cr-Commit-Position: refs/heads/master@{#35389}
-
mstarzinger authored
This makes sure that --hydrogen-filter only filters for Crankshaft, not for TurboFan compilations. For TurboFan there is --turbo-filter as a separate flag already. There no longer is a single flag to filter both compilers at the same time, one can still specify both flags however. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1871343003 Cr-Commit-Position: refs/heads/master@{#35388}
-