1. 01 Jun, 2021 1 commit
  2. 19 Jun, 2020 1 commit
  3. 08 Oct, 2019 1 commit
  4. 14 Mar, 2019 1 commit
    • Clemens Hammacher's avatar
      [wasm] Make error messages deterministic · eb1d2d70
      Clemens Hammacher authored
      Compilation only stores whether an error has been found, but not the
      exact error or it's location. This is generated by running a validation
      pass once all wire bytes have been received.
      This unifies error messages by removing one more location where we
      generate compilation error messages, and makes it deterministic because
      a) we always report the error in the first failing function, and
      b) if names are present, the error message will always contain the
         function name.
      
      R=titzer@chromium.org
      
      Bug: chromium:926311, v8:8814
      Change-Id: I79551b8bb73dcee503484de343a3ada60a6add4f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1521112
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#60242}
      eb1d2d70
  5. 07 Feb, 2019 1 commit
    • Clemens Hammacher's avatar
      [wasm] Check that sync and async errors match · 7a8cd551
      Clemens Hammacher authored
      This makes the existing error message tests also test the error
      produced by asynchronous compilation and instantiation.
      It also slightly tweaks the error message to contain the name of the
      API function invoked instead of "WebAssembly Instantiation".
      
      R=titzer@chromium.org
      
      Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
      Bug: chromium:926311
      Change-Id: If4ab963cee8267d43b289169d21b31637c471d6d
      Reviewed-on: https://chromium-review.googlesource.com/c/1456085
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59442}
      7a8cd551
  6. 30 Jan, 2019 1 commit
  7. 12 Sep, 2018 1 commit
  8. 26 Jun, 2017 2 commits