- 16 Jul, 2018 13 commits
-
-
Michael Lippautz authored
Bug: chromium:863362 Change-Id: I88896d7477d893f1b7fae08f6dfd5709748a6edd Reviewed-on: https://chromium-review.googlesource.com/1138080Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54461}
-
Yang Guo authored
R=bmeurer@chromium.org, ulan@chromium.org Bug: chromium:680662 Change-Id: I5e1486ad2a42db2998d5485a0c4e711378678e6c Reviewed-on: https://chromium-review.googlesource.com/1136034Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54460}
-
Sigurd Schneider authored
This reverts commit b7f0951f. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/21517 Original change's description: > [wasm] Add a separate CodeTracer to the WasmEngine. > > This makes sure the TurboFan pipeline is independent of the Isolate by > getting the CodeTracer from the WasmEngine for WebAssembly compilations. > > R=clemensh@chromium.org > > Change-Id: I343af1a2bfaeff77e2f41ef0c53fbfe165e2e202 > Reviewed-on: https://chromium-review.googlesource.com/1134997 > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54455} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: I5f69f12ab29dcb92e7b7f53632eb73a3abc1f6af No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1138113Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54459}
-
Clemens Hammacher authored
This helps debugging wasm crashes. {WasmCompiledFrame::Print} should also print the position inside the current function, additional to the absolute position in the wasm module. The source positions encoded in wasm code are also function-relative, so with the additional output it's easier to match them. R=ahaas@chromium.org Change-Id: I40f99e75e3ba25fdfd24943ea96e49868b91844f Reviewed-on: https://chromium-review.googlesource.com/1138053Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54458}
-
Peter Marshall authored
We convert this {ptr, size} pair to an ArrayBuffer::Allocation when we need to free it anyway, so we can get rid of this intermediate step to make things simpler. Change-Id: I6e82949ec02acb5794f4d668afb2313ebdcb9d52 Reviewed-on: https://chromium-review.googlesource.com/1136309 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54457}
-
Michael Starzinger authored
R=clemensh@chromium.org TEST=mjsunit/wasm/worker-module Change-Id: I56c274c67354d534f86312ee8fe7b7761da8ca44 Reviewed-on: https://chromium-review.googlesource.com/1138074Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54456}
-
Michael Starzinger authored
This makes sure the TurboFan pipeline is independent of the Isolate by getting the CodeTracer from the WasmEngine for WebAssembly compilations. R=clemensh@chromium.org Change-Id: I343af1a2bfaeff77e2f41ef0c53fbfe165e2e202 Reviewed-on: https://chromium-review.googlesource.com/1134997 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This CL adds inlining for the Number constructor if new.target is not present. The lowering is BigInt compatible, i.e. it converts BigInts to numbers. Bug: v8:7904 Change-Id: If03b9f872d82e50b6ded7709069181c33dc44e82 Reviewed-on: https://chromium-review.googlesource.com/1118557 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54454}
-
Simon Zünd authored
This CL renames Constant to ExternConstant (this already happend in the grammar). It also enforces the rule that such extern constants require "constexpr" types. Drive-by-change: Replaced non constexpr extern constants with module constants. R=tebbi@chromium.org Bug: v8:7793 Change-Id: Icb3f75071b15b1fcabbe447941e05dd5a09d4b23 Reviewed-on: https://chromium-review.googlesource.com/1136434Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#54453}
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: I96fa8f6c2dbc9fb3da0be9a8b8d730cc1d1e3415 Reviewed-on: https://chromium-review.googlesource.com/1131456 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Iab7210eaddb14c9ca8638cbc8d69206bbaf15462 Reviewed-on: https://chromium-review.googlesource.com/1134785Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54451}
-
Marja Hölttä authored
BUG=chromium:852765 Change-Id: Iaba84f6e52b08b3aee4c1529701239c049dceb9a Reviewed-on: https://chromium-review.googlesource.com/1128875Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54450}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2f38df6..8d3925b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iabf2679443822f70c058df0f23a5b90171b658bd Reviewed-on: https://chromium-review.googlesource.com/1137926 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54449}
-
- 15 Jul, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/579c986..2f38df6 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I0ffc30c9d1a4ee518fa9073e17c614902d70e6ad Reviewed-on: https://chromium-review.googlesource.com/1137850Reviewed-by:
-
- 14 Jul, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7b4d0db..c0771e9 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8495de1..be45355 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/882c91e..579c986 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/272de12..8227701 Rolling v8/tools/luci-go: https://chromium.googlesource.com/chromium/src/tools/luci-go/+log/7edc822..abcd908 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I8b67be916591e6e98bb0ead58aca3c87a08b941d Reviewed-on: https://chromium-review.googlesource.com/1137736 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 13 Jul, 2018 25 commits
-
-
Bill Budge authored
- Reorganizes shuffle tests into tabular form. - Adds a test that composes random numbers of random shuffles to make new shuffles. - Adds a test that generates functions to compute a complex expression consisting of shuffles, and compares interpreter results to compiled code results. - Fixes a problem with temp register exhaustion on ARM 32-bit. - Matches identity shuffles (returning first or second operand unchanged) and uses EmitIdentity() for these. Bug: v8:6020 Change-Id: Ie41c14fee52a7406b1d32e731e050096400e12f5 Reviewed-on: https://chromium-review.googlesource.com/1119567 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
R=bradnelson@chromium.org, titzer@chromium.org CC=ahaas@chromium.org No-Try: true Change-Id: I0843b33f04861b8c829fac27231a39452db9f7a6 Reviewed-on: https://chromium-review.googlesource.com/1136443Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#54445}
-
Ulan Degenbaev authored
They are replaced by - Memory.Experimental.Renderer2.V8 - Memory.Experimental.Renderer2.V8.AllocatedObjects Bug: chromium:852415 Change-Id: I64285e5067304319acadc0d64a05aa553d8ae6e0 Reviewed-on: https://chromium-review.googlesource.com/1101197 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54444}
-
Hannes Payer authored
Bug: chromium:842083 Change-Id: I7f3d7cb64c1263e081d1f9bd36939aaf1a0e3da8 Reviewed-on: https://chromium-review.googlesource.com/1135322 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Bill Budge authored
This reverts commit f0a9a6a5. Reason for revert: Breaks V8 Android GN (dbg) https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Android%20GN%20%28dbg%29/12328 Original change's description: > Update GN configs for v8_perf target to allow running perf tests in swarming > > This will allow us to migrate our deprecated configs to android_docker. > > R=machenbach@chromium.org > > Bug: chromium:838864 > Change-Id: I5f7db648520847aa2077e9fc2a5970e63daa9a50 > Reviewed-on: https://chromium-review.googlesource.com/1131944 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54441} TBR=machenbach@chromium.org,sergiyb@chromium.org Change-Id: I81ecd49ed69f2161931fce3836ba66462a101a25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:838864 Reviewed-on: https://chromium-review.googlesource.com/1136716Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#54442}
-
Sergiy Byelozyorov authored
This will allow us to migrate our deprecated configs to android_docker. R=machenbach@chromium.org Bug: chromium:838864 Change-Id: I5f7db648520847aa2077e9fc2a5970e63daa9a50 Reviewed-on: https://chromium-review.googlesource.com/1131944Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54441}
-
Georg Neis authored
Also remove an unnecessary AllowHandleDereference scope. Bug: chromium:863155, v8:7790 Change-Id: I37a6efb0595d09ccf0a1e653620060a16fc96247 Reviewed-on: https://chromium-review.googlesource.com/1136444 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#54440}
-
Dan Elphick authored
All auto-generated with some fix-ups including marking the following classes as NeverReadOnlySpaceObject so their GetIsolate/GetHeap methods are safe to use: Code, CodeDataContainer, AbstractCode, DeoptimizationData, CompilationCacheTable, NormalizedMapCache, Script, SharedFunctionInfo TBR=yangguo@chromium.org Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I6cb5dcca88a0bc99b5afe80f553e06a661b5da3c Reviewed-on: https://chromium-review.googlesource.com/1135306 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54439}
-
Clemens Hammacher authored
No need to define a function just to default-initialize all fields. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I059f310d22435a364dff8b7cfcb68c6314412c9a Reviewed-on: https://chromium-review.googlesource.com/1136306 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Dan Elphick authored
Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I195d65ec77a838878db340599fc8a5de1c3e1324 Reviewed-on: https://chromium-review.googlesource.com/1135541Reviewed-by:
-
Michael Starzinger authored
The code under test is handling of multi-return values in TurboFan and hence actually independent of WebAssembly. The only reason to generate WasmCode is in order to use the WebAseembly linkages. This changes the generated code to have {STUB} kind instead of {WASM_FUNCTION} kind to avoid having stack checks in the generated code which would require a proper WasmInstanceObject to be allocated. R=ahaas@chromium.org BUG=chromium:862508 Change-Id: I4feb7bff1a42bbf59cfc5f249f2e0585ce7011ad Reviewed-on: https://chromium-review.googlesource.com/1136438Reviewed-by: -
Michael Starzinger authored
This removes support to track the memory footprint of fully executed but not yet finalized compilation units. It was used to throttle creation of new tasks when the latent memory pressure of this unfinished jobs rose above a certain threshold. Now that units no longer incur a significant latent memory pressure, this is no longer needed. R=clemensh@chromium.org BUG=v8:7921 Change-Id: I3f4a563ebcb85b7aeac50f469a8a495eecf8aa3d Reviewed-on: https://chromium-review.googlesource.com/1136291Reviewed-by:
-
Clemens Hammacher authored
This adds trace events for Liftoff compilation, Turbofan compilation, instantiation and running the start function. These are basic operations that help to understand the startup behaviour of WebAssembly modules. R=ahaas@chromium.org Change-Id: I0c0544cfd2d03de1783fa1d3a5897d3b8ef09e05 Reviewed-on: https://chromium-review.googlesource.com/1134768 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Abort after reaching MAX_NOF_RETRIES since there is only a very low chance that the page will keep on working after that. Change-Id: Ia9e5f3cf69ae2b5ad40a60f86a46800541404862 Bug: v8:7941 Reviewed-on: https://chromium-review.googlesource.com/1134771Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54433}
-
Michael Starzinger authored
This removes an occurrence where the "%Foo" native syntax appears as part of a string. Such strings are picked up by the fuzzer and recombined in unsupported ways, producing false-positive crash reports. Simply avoid having those strings in the fuzzing corpus. R=clemensh@chromium.org TEST=mjsunit/regress/wasm/regress-808848 BUG=chromium:844842 Change-Id: I017c1552578f0d26033e58b11353e87e27a69ebf Reviewed-on: https://chromium-review.googlesource.com/1136300Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:7921 Change-Id: I5d6417c7b661066cecaf2eb7125d7399f3d9cf21 Reviewed-on: https://chromium-review.googlesource.com/1135141 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds constants that can be defined in the module scope: const kConstexprConst: constexpr int31 = 5; const kIntptrConst: intptr = 4; const kSmiConst: Smi = 3; They are implemented by generating "mini-macros" that return the expression on the right-hand side of the assignment. Bug: v8:7793 Change-Id: I0a476cb3111707fad56bf15e9547b377c7adab37 Reviewed-on: https://chromium-review.googlesource.com/1114745 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Ivica Bogosavljevic authored
Change-Id: Iecbc7b5b4f8cbea99cb83982d0b5f0db78dfa89e Reviewed-on: https://chromium-review.googlesource.com/1128964 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Miran Karić <miran.karic@mips.com> Cr-Commit-Position: refs/heads/master@{#54429}
-
Michael Lippautz authored
This reverts commit 7bff339e. Reason for revert: Breaks autoroll, see bug. Bug: v8:7944 Original change's description: > Reland "[heap] Added External Strings to external memory accounting." > > This is a reland of 5863c0b6 > > Original change's description: > > [heap] Added External Strings to external memory accounting. > > > > Bug: chromium:845409 > > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 > > Reviewed-on: https://chromium-review.googlesource.com/1118164 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54110} > > Bug: chromium:845409 > Change-Id: Ied341ec6268000343d2a577b22f2a483460b01f5 > Reviewed-on: https://chromium-review.googlesource.com/1121736 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54410} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,petermarshall@chromium.org,rfbpb@google.com Change-Id: Ie55586e84f44a2d83c7f97110d60abb86f0730c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1136312Reviewed-by:
-
Michael Lippautz authored
This reverts commit 6b4ba741. Reason for revert: Blocks roll, see bug. Bug: v8:7944 Original change's description: > Fix update external string call in morph string test. > > Bug: chromium:845409 > Change-Id: Ic9b1fa0f669c8b9a82ed91d3f348dd070fc9267f > Reviewed-on: https://chromium-review.googlesource.com/1135247 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54419} TBR=mlippautz@chromium.org,rfbpb@google.com Change-Id: I42121de37913bbe858b9a7c6a9dabf86090c493b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1136311Reviewed-by:
-
Clemens Hammacher authored
In https://crrev.com/c/1044187 we messed up the macro definition, so the four f64 operations with c fallback were actually never emitted (we bailed out instead). This went unnoticed, as it does not produce an error. This CL reenables these four instructions. R=ahaas@chromium.org CC=predrag.rudic@mips.com Bug: v8:6600, v8:7933 Change-Id: I394a0348237676c12df741fc3f302c4576619ffc Reviewed-on: https://chromium-review.googlesource.com/1135532Reviewed-by:
-
Michael Starzinger authored
This moves the entire code generation phase (including code emission into the native module) into the background task. The code manager is fully thread safe by now and there are no Isolate-bound steps anymore. The only step remaining on the foreground task is publishing the fully finished code to other threads via {NativeModule::PublishCode}. R=clemensh@chromium.org BUG=v8:7921 Change-Id: Ia64c6ce945aabd071b26e61ef8d397fb7727a038 Reviewed-on: https://chromium-review.googlesource.com/1135004 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Clemens Hammacher authored
This is a reland of 5b744bfb. Node is fixed by this pull request: https://github.com/v8/node/pull/75 Original change's description: > Fix and extend lldbinit > > 1) Define all commands in one file. > 2) Add logic to make 'jco' print current pc by default. > 3) Add a comment to explain how to load the lldb_commands.py file. > 4) Minor refactorings. > > R=ahaas@chromium.org > No-Try: true > > Bug: v8:7754 > Change-Id: I553f2ce4cefedad05466c692a8665a570372b76a > Reviewed-on: https://chromium-review.googlesource.com/1127892 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54329} Bug: v8:7754 Change-Id: I8645ae07176fe6983a581dd175ed6f2b2b15d4ea Reviewed-on: https://chromium-review.googlesource.com/1135026Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6ff84ae..7b4d0db Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/39de3d2..8495de1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/32e3d1e..882c91e Rolling v8/tools/luci-go: https://chromium.googlesource.com/chromium/src/tools/luci-go/+log/e3d4003..7edc822 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia175b2c08112afe5b882ca2e40ffd9cdf4c0d16b Reviewed-on: https://chromium-review.googlesource.com/1136068 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Johannes Henkel authored
This is in preparation of removing the using statements that are currently in third_party/inspector_protocol/lib/Collections_h.template. Once this is done I can update https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1135832 some more and eventually roll it into v8 (and chromium's third party). R=dgozman Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I75a7b291715f241e3b58fb97ac91a0b0ff0ca70b Reviewed-on: https://chromium-review.googlesource.com/1135968 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#54422}
-
