Commits · 0fb091fc6f5bd1e40d2e4b4c0a8d3d462b6cb062 · Linshizhi / V8

18 Nov, 2013 3 commits

Fix data view accessors to throw execptions on offsets bigger than size_t. · 6749e57f

dslomov@chromium.org authored 11 years ago

R=jkummerow@chromium.org
BUG=v8:3013
LOG=Y

Review URL: https://codereview.chromium.org/74583003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17840 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6749e57f

Revert "Fix data view accessors to throw execptions on offsets bigger than size_t." · cb6e8b33

dslomov@chromium.org authored 11 years ago

This reverts commit r17838 for breaking arm build.

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/75213005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17839 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb6e8b33

Fix data view accessors to throw execptions on offsets bigger than size_t. · dd5c7ec8

dslomov@chromium.org authored 11 years ago

R=jkummerow@chromium.org
BUG=v8:3013
LOG=Y

Review URL: https://codereview.chromium.org/74583003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17838 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dd5c7ec8

24 Jul, 2013 1 commit

Make DataView setters throw when only offset is provided. · a418b36b

dslomov@chromium.org authored 11 years ago

Also fix typo in error message id.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/20030004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15865 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a418b36b

15 Jul, 2013 1 commit

Use corerct conversions for DataView accessors. · 1c2d005b

dslomov@chromium.org authored 11 years ago

We now use DoubleTo(U)Int32 that follows ES specification.

R=titzer@chromium.org,rossberg@chromium.org

Review URL: https://codereview.chromium.org/18703007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15659 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1c2d005b

10 Jul, 2013 1 commit

Change DataView accessors behavior for insufficient args. · 5eb63e48

dslomov@chromium.org authored 11 years ago

ES6 spec for DataView is not fully finished, but Blink, WebKit and
Firefox agree in that for DataView use of getters/setters with no
arguments should result in exceptions, while undefined offset argument
is the same as zero.

R=bmeurer@chromium.org, rossberg@chromium.org

Review URL: https://codereview.chromium.org/18313007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15607 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5eb63e48

24 Jun, 2013 1 commit

Update typed arrays behavior to match ES6 rev 15. Remove TO_POSITIVE_INTEGER... · e6e0ee07

dslomov@chromium.org authored 11 years ago

Update typed arrays behavior to match ES6 rev 15. Remove TO_POSITIVE_INTEGER and throw on negative length arguments.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/17572009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15298 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e6e0ee07

21 Jun, 2013 1 commit

DataView implementation. · 91eb5f8d

dslomov@chromium.org authored 11 years ago

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/17153011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15269 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

91eb5f8d