- 05 May, 2022 1 commit
-
-
jiepan authored
WASM only supports simd128, but modern CPUs support up to 256 bit vector register or more, we will add an experimental feature to do 256 bit re-vectorization in Turbofan pipeline, this patch add simd256 machine representation. Bug: v8:12716 Change-Id: I1e6a3f2afa0a457fca2c261216f4113d0ed5b818 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3534456Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Jie Pan <jie.pan@intel.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80361}
-
- 04 May, 2022 11 commits
-
-
Frank Tang authored
Add AO: ISOMonthDayFromFields Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.monthdayfromfields https://tc39.es/proposal-temporal/#sec-temporal-isomonthdayfromfields Bug: v8:11544 Change-Id: I8a04a8e61af8abdb902de33efbf5635b8e8300aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3408576 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80360}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.month Note- this is only the non-intl version. intl version in https://tc39.es/proposal-temporal/#sup-temporal.calendar.prototype.month will be implemented in later cl. Bug: v8:11544 Change-Id: Ibbbb00faa0bdb4d49784cd9aae69fb779d95f924 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3531554 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Vasili Skurydzin authored
Change-Id: I4003b30ec4f1e29a7c5d55a51cbf82fa3a7487e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585856 Commit-Queue: Vasili Skurydzin <vasili.skurydzin@ibm.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80358}
-
Dominik Inführ authored
This reverts commit 2b79eefe. Reason for revert: Speculative revert because of https://crbug.com/1322305 Original change's description: > Reland^2: [heap] Store size with invalidated object > > This is a reland of commit 23b2d571 > > When updating pointers during a full GC, a page might not be swept > already. In such cases there might be invalid objects and slots > recorded in free memory. Updating tagged slots in free memory is fine > even though not strictly necessary. > > However, the GC also needs to calculate the size of potentially dead > invalid objects in order to be able to check whether a slot is within > that object. But since that object is dead, its map might be dead as > well which makes size calculation impossible on such objects. The CL > changes this to cache the size of invalid objects. A follow-up CL will > also check the marking bit of invalid objects. > > Reason for reverts: > > Revert #2: In-object slack tracking on JSObjects doesn't update the > cached size of invalidated objects. The fix here was to stop > invalidating recorded slots on JSObjects at all and avoid that problem > completely (see https://crrev.com/c/3620274). > > Revert #1: Not all size changes go through NotifyObjectLayoutChange, so > https://crrev.com/c/3607992 introduced NotifyObjectSizeChange as a > bottleneck for object size changes/right-trimming. This method is > now used to update the size of invalidated objects. > > Bug: v8:12578, chromium:1316289 > Change-Id: I0478d04601c0270ddb39419ca6cf98719951eb4d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623542 > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Reviewed-by: Patrick Thier <pthier@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80344} Bug: v8:12578, chromium:1316289 Change-Id: I6dd2dd13583123b9cb7933b15e2113fddc0c0b0b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627511 Owners-Override: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80357}
-
Anton Bikineev authored
Old gcc versions (< gcc-8) have problems with parameter packs in capture-lists wrapped in fold-expressions. Bug: chromium:1029379 Change-Id: I0c0ee7caa2d750f551e93fdfeb2667328bee4acb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627594 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This is temporary until we update our infra to always use --turbofan Change-Id: Ie1ca8ce2cae6744515d9810ae4f57f00c8670e36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625977 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#80355}
-
Leszek Swirski authored
In the future we may want to cache this in a separate slot to turbofan code, but for now cache maglev code in the same optimized code slot on the feedback vector. Bug: v8:7700 Change-Id: Idd40a024cc9beb9b4da06a88a3789d822ddd4ab7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622916Reviewed-by:
Jakob Linke <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1322318 Change-Id: Id3899a493eb1519e2f7498dcad1e607cc2b6a5db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627509Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80353}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c8ec41b..c812b8d Rolling v8/buildtools/linux64: git_revision:48b013c9d9debc0f5fc1dd71a257b3c38c5acb43..git_revision:53ef169800760fdc09f0773bf380fe99eaeab339 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/c7888dd..ce96725 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/d8a4746..393e3ee Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/36c1580..5ecb463 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9ba02ee..d3c4414 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fccf35c..13acea3 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/961141d..9979c19 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Id96be288b2f8076e646031be4f3e2a72f4cca8e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3626171 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80352}
-
Frank Tang authored
1. Retun value w/ newly added movable Maybe<> 2. Change arg passing from pointer to const ref. 3. Change some CHECK to DCHECK Change-Id: Ia4e6c6031d8873c86df7ec178165dd23e75c571b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3606390 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80351}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-totemporaldatetime https://tc39.es/proposal-temporal/#sec-temporal-totemporaldisambiguation Bug: v8:11544 Change-Id: Ibb38f807386c4e213bfd2bb568911a96a17cf1be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623196Reviewed-by:
-
- 03 May, 2022 28 commits
-
-
Shu-yu Guo authored
Bug: chromium:1321078 Change-Id: I426327ffc3d7eebdb562c01a87039a93dfb79a88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3620836 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80349}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.monthcode Note- this is only the non-intl version. intl version in https://tc39.es/proposal-temporal/#sup-temporal.calendar.prototype.monthcode will be implemented in later cl. Bug: v8:11544 Change-Id: I52dfc1bda6d2ed8c0aba735c64d7ae8227844ed1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3531555Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.day Note- this is only the non-intl version. intl version in https://tc39.es/proposal-temporal/#sup-temporal.calendar.prototype.day will be implemented in later cl. Bug: v8:11544 Change-Id: If56182cf65b3b8cc91ed843f0e20edeb6a065954 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3531556Reviewed-by:
-
Frank Tang authored
This reverts commit 0a5fcd8a. Reason for revert: reenable TSAN test after moving best_fit out from stage Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_isolates_rel_ng,v8_linux64_tsan_no_cm_rel_ng,v8_linux64_tsan_rel_ng,v8_numfuzz_tsan_ng;luci.chromium.try:linux_chromium_tsan_rel_ng,linux_chromium_tsan_rel_ng-compilator Original change's description: > [test] Skip flaking test > > Bug: v8:12697 > Change-Id: I124f2f0fd3c98d6a5233a0e2a8236a2b15d791fd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3532261 > Auto-Submit: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79518} Bug: v8:12697 Change-Id: I53d109674ecd938d8be915099c412d174600edfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3624464 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#80346}
-
Shu-yu Guo authored
Relative indexing methods have shipped since M92. Bug: v8:10961 Change-Id: I4346a3bed443c9cc48924e5ef23ec012eeeecab1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622134Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80345}
-
Dominik Inführ authored
This is a reland of commit 23b2d571 When updating pointers during a full GC, a page might not be swept already. In such cases there might be invalid objects and slots recorded in free memory. Updating tagged slots in free memory is fine even though not strictly necessary. However, the GC also needs to calculate the size of potentially dead invalid objects in order to be able to check whether a slot is within that object. But since that object is dead, its map might be dead as well which makes size calculation impossible on such objects. The CL changes this to cache the size of invalid objects. A follow-up CL will also check the marking bit of invalid objects. Reason for reverts: Revert #2: In-object slack tracking on JSObjects doesn't update the cached size of invalidated objects. The fix here was to stop invalidating recorded slots on JSObjects at all and avoid that problem completely (see https://crrev.com/c/3620274). Revert #1: Not all size changes go through NotifyObjectLayoutChange, so https://crrev.com/c/3607992 introduced NotifyObjectSizeChange as a bottleneck for object size changes/right-trimming. This method is now used to update the size of invalidated objects. Bug: v8:12578, chromium:1316289 Change-Id: I0478d04601c0270ddb39419ca6cf98719951eb4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623542Reviewed-by:
-
Leszek Swirski authored
Also manually reformat some files with the clang-format change. Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e10cf1a..c8ec41b Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/c2e4795..113378f Rolling v8/buildtools/linux64: git_revision:7c8e511229f0fc06f6250367d51156bb6f578258..git_revision:48b013c9d9debc0f5fc1dd71a257b3c38c5acb43 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/518fd76..c7888dd Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/705543f..d8a4746 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/88422dc..9ba02ee Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dc8ca44..fccf35c Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/32e65ef..961141d Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3c4a622..75625c6 Rolling v8/tools/luci-go: git_revision:6da0608e4fa8a3c6d1fa4f855485c0038b05bf72..git_revision:2aa3d7e5e8662c5193059a490f07b7d91331933e Rolling v8/tools/luci-go: git_revision:6da0608e4fa8a3c6d1fa4f855485c0038b05bf72..git_revision:2aa3d7e5e8662c5193059a490f07b7d91331933e R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I00a09d42cf91f226c661e97915d5a95fff84b079 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3615245Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80343}
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: Ifd24e32dac905d47af233fa01b93206ee9ebdb8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623739 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80342}
-
Marja Hölttä authored
Bug: v8:11525,v8:12820 Change-Id: I58bde48322c89bf33f3b28080659387a3c14de91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3620277 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Danil Somsikov authored
Distinguish untrusted clients in v8 inspector and disable Profiler, HeapProfiler and Schema CDP domains for them. Bug: chromium:1313437 Change-Id: I7544c64acb4bc368392ba5f6a87ed62176828304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616517Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Danil Somsikov <dsv@chromium.org> Cr-Commit-Position: refs/heads/main@{#80340}
-
Marja Hölttä authored
No-Try: true Bug: v8:12847, v8:11111 Change-Id: Id0c2749970333b82650b33c9cddcb028ac03709c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623541 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80339}
-
Michael Lippautz authored
Before this CL, the heap object name of unnamed objects(those not inheriting from NameProvider) would be solely determined by whether the build-time configuration cppgc_enable_object_names is enabled. This patch adds a way to override that value at runtime. This is useful for preserving default behavior with custom builds but at the same time allow them to still enable the feature. Bug: chromium:1321620 Change-Id: I3aa06db15e58d9ba9773be6797572f17f007e9ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3620279Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80338}
-
Camillo Bruni authored
Previously marked V8_DEPRECATED_SOON that are now V8_DEPRECATED: File Version Date Commit include/v8-initialization.h:208 v9.9 2021-12-15 277fdd1d include/v8-initialization.h:226 v9.9 2021-12-15 277fdd1d include/v8-initialization.h:236 v9.9 2021-12-15 277fdd1d include/v8-initialization.h:250 v9.9 2021-12-15 277fdd1d include/v8-locker.h:130 v10.0 2022-01-20 116ca00f include/v8-message.h:90 v9.8 2021-11-09 2b3df06b Previously marked V8_DEPRECATED that are now removed: File Version Date Commit include/v8-fast-api-calls.h:886 v9.8 2021-11-11 b295d0b0 include/v8-fast-api-calls.h:893 v9.8 2021-11-11 b295d0b0 include/v8-fast-api-calls.h:902 v9.8 2021-11-11 b295d0b0 include/v8-initialization.h:186 v10.0 2022-01-26 36707481 include/v8-isolate.h:639 v10.0 2022-01-26 36707481 include/v8-locker.h:132 v9.8 2021-11-11 b295d0b0 include/v8-object.h:597 v9.9 2022-01-18 0a61fa51 include/v8-object.h:609 v9.8 2021-11-11 b295d0b0 include/v8-script.h:50 v10.0 2022-01-26 36707481 include/v8-script.h:653 v10.0 2022-01-18 9cf4f131 Output generated by ./tools/release/list_deprecated.py Bug: v8:11165, chromium:1166077 Change-Id: Ie0d435f7a10f362ed714bdc30ad899ee9c485cb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571804 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Camillo Bruni authored
To be consistent with the all the other tiers and avoid confusion, we rename --opt to ---turbofan, and --always-opt to --always-turbofan. Change-Id: Ie23dc8282b3fb4cf2fbf73b6c3d5264de5d09718 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3610431Reviewed-by:
-
Anton Bikineev authored
The ubsan failures were fixed by 99e90c55. Bug: chromium:1029379 Change-Id: Iec334388de7faf8a47e6d607501a2f1298a441a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623540Reviewed-by:
-
Leszek Swirski authored
Observe the beauty of nature, as a TODO blossoms into a DONE. Bug: v8:7700 Change-Id: I6981a5530664aa9ba4d120000d688a682c923a23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622914Reviewed-by:
-
Dominik Inführ authored
Slots don't need to be invalidated in the object. The object is trimmed to its supertype, so all possibly recorded slots remain valid. Bug: v8:12578, chromium:1316289 Change-Id: I859b3ec843a2c2c9863cdb3bbc1c3158364aaa5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622917Reviewed-by:
-
Anton Bikineev authored
This fixes: runtime error: upcast of misaligned address 0x000000000001 for type 'cppgc::internal::(anonymous namespace)::SimpleGCed<64>', which requires 8 byte alignment Bug: chromium:1029379 Change-Id: Id03ce022e72fc07a18c171d4cf5e42f50cb684f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622918 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
Mark the labels to the code and data global, which removes the need for having separate pointers to these labels in the .data section. This means that `v8_Default_embedded_blob_code_` and `v8_Default_embedded_blob_data_` can now actually be read-only when RELRO is enabled. The actual contents of `v8_Default_embedded_blob_code_` remain potentially non-readable for platforms where code is marked as execute-only, but these changes do not attempt to read them. Bug: v8:12850 Change-Id: Ic1bc8e68fe44a9ce45380c83b0be5fa94e7da267 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616510 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
-
Al Muthanna Athamina authored
Bug: v8:12842 Change-Id: Ice4ef2f1e62773238a0d9b08b6af36e9bed48ddd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622919 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
jameslahm authored
This CL changes MaybeLocal::ToLocal documentation to assign |out| with nullptr when the MaybeLocal is empty to be consistent with the behavior. Bug: v8:12845 Change-Id: I8145d6604c51b79f137b686b3e9b4f328534e0a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3616432 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
Marja Hölttä authored
Fix: copy-paste error in raw ptr GC update function. Bug: v8:11525 Change-Id: I915ae92191b2add60962395a2d0ad28f57e02fd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622915 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
When lowering signatures, we must preserve the separation of parameters into tagged and untagged sections. Fixed: chromium:1320614 Change-Id: I8119ba23e35f499630c2d2494e99191ca793cb1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3620283Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80327}
-
Patrick Thier authored
For entries in the string forwarding table, mark the internalized string if the original string is marked. The logic is moved from the string forwarding table implementation to the mark compact implementation, using RootVisitor. Bug: v8:12007 Change-Id: I860de75077c864dd4e5f2c47ab647d2eafcc5ced Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3610625Reviewed-by:
-
Camillo Bruni authored
Due to the consistent overhead of snapshot checksum verification we ideally want to avoid it all-together. However there are still enough devices out there that suffer from corrupted snapshots that might cause hard to debug heap corruptions. This CL exposes the calculated (dummy value for now) and the expected snapshot checksum as a crash key, so it can be easily consulted during investigation. Note: The calculated crash key contains 0x0 for now as a dummy value. We will come up with a strategy later-on to limit the overhead of calculating the checksum. Bug: v8:12195 Change-Id: I6da6d74c035cb6f9b0edae212a36e6c41c048a5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3605813Reviewed-by:
-
Samuel Groß authored
While nullptr also mostly seems to work, GetCurrentProcess() is the correct way of specifying the current process for operations like MapViewOfFile3 or VirtualAlloc2. Bug: chromium:1218005 Change-Id: I988140374a708018dca089c29eb699e0536a5285 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3620288Reviewed-by:
-
Benedikt Meurer authored
When formatting console messages (for consumption in Chromium/Blink), we have special logic to unwrap value wrapper objects. But this logic was not very consistent, and especially Number values and NumberObject values were formatted differently. This changes the V8ValueStringBuilder::append() logic to always unwrap any value wrapper first and then use the regular dispatch for the primitive value. Fixed: chromium:1321833 Change-Id: I9996671e1f91da0841e5d5f1687cf647ab72a561 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622913 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Frank Tang authored
In v3 we allow both significant digits and fraction digits to be set in some conditions. Also fix the case in v2 we didn't handle "precision-integer" with currency format. Related spec text: https://tc39.es/proposal-intl-numberformat-v3/out/numberformat/diff.html#sec-intl.numberformat.prototype.resolvedoptions https://tc39.es/proposal-intl-numberformat-v3/out/numberformat/diff.html#sec-setnfdigitoptions Bug: v8:11544 Change-Id: I89c147dcc7803eae7aad2a380e85d1d877e30370 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3615217 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
