- 31 Jul, 2018 23 commits
-
-
Clemens Hammacher authored
R=titzer@chromium.org Bug: v8:7754, v8:7965 Change-Id: I5cb76b4e989fbe6d4d08bafb60dbbb26c3d58e2d Reviewed-on: https://chromium-review.googlesource.com/1156515Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54820}
-
Sathya Gunasekaran authored
... So that this can be re-used in the intl code. Also, add a helper method that loads the iterator if it's not provided. Bug: v8:5751 Change-Id: Ifc1142a486b2cdf1c33a813c5446b206ad9f81ef Reviewed-on: https://chromium-review.googlesource.com/1156390 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54819}
-
Ben L. Titzer authored
As discussed offline, this header is not really useful without its inline definitions. So instead of trying to split it (unnaturally), declare defeat and make it an inline header file. Also remove two unnecessary uses of it, move the JSON stringifier class into its .cc file (because it needs IncrementalStringBuilder inline) and forward declare in prettyprinter.h. R=petermarshall@chromium.org, mstarzinger@chromium.org BUG=v8:7965 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I7ba032ca718a195e156ec3e59f8e858a25423450 Reviewed-on: https://chromium-review.googlesource.com/1156401Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#54818}
-
Georg Neis authored
Use sizeof of the C type instead. Also fix a few #undef's that got reported after my changes. R=jarin@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I30a43b3d93e6df04fb9fb33050b52988edd7fdb1 Reviewed-on: https://chromium-review.googlesource.com/1155108Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This changes recording of compilation stats (i.e. code and reloc info size) for each code object individually after it is finished, instead of for the entire module. It avoids needed to iterate the code table which would race with background tasks performing tier-up. R=clemensh@chromium.org Change-Id: Ic196fccb38b069a07e79fed4633d01dfc2639cd7 Reviewed-on: https://chromium-review.googlesource.com/1156396 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54816}
-
Michael Starzinger authored
R=titzer@chromium.org BUG=v8:7424 Change-Id: I49f0f31e19d9242ac6eb26406a0aecd4d60ad869 Reviewed-on: https://chromium-review.googlesource.com/1148396 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Peter Marshall authored
There are still some cases where entry->instruction_start() is 0, meaning that computing pc_offset makes no sense. We don't care about those cases really; the dcheck in CodeMap::FindEntry will find the interesting cases. Bug: v8:7983, v8:8002 Change-Id: I7369f32da15e858f1c7af88f88cede60751b7eea Reviewed-on: https://chromium-review.googlesource.com/1156398 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#54814}
-
jgruber authored
This changes Call(ExternalReference) to use the correct Mov() overload, which contains logic to load external references indirectly (i.e. in an isolate-independent way). Bug: v8:6666, v8:7985 Change-Id: Ib6f3931308c7d13fd4ef0563b7e1e83db3a760eb Reviewed-on: https://chromium-review.googlesource.com/1152730 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54813}
-
Dan Elphick authored
This new method only compares Strings and so doesn't need a Context. It also can't throw so it returns bool. Can be used in place of the deprecated Equals method and many Equals call currently taking a Context. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I4cfe7747aa140e5a55d9513681ee4704414e1545 Reviewed-on: https://chromium-review.googlesource.com/1151321 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54812}
-
Ben L. Titzer authored
BUG=chromium:863205 R=clemensh@chromium.org Change-Id: I15f3a09e15210a80b155def5761d9aead95d19b7 Reviewed-on: https://chromium-review.googlesource.com/1156386Reviewed-by:
-
Andreas Haas authored
The lifetime of the WasmInterpreter is managed by the GC. However, we did not tell the GC the amount of memory consumed by the interpreter. Therefore it was possible to fill up memory with instances of the interpreter without triggering a GC to free memory. With this CL we pass the size of the stack as an estimate for the size of the interpreter. At least in the fuzzer the stack is the dominating factor for memory consumption. R=clemensh@chromium.org Bug: chromium:863198 Change-Id: Ic5cb0bd364500bcff793a1fd53d2d0113196dfe2 Reviewed-on: https://chromium-review.googlesource.com/1156385Reviewed-by:
-
Peter Marshall authored
For optimized code there are two modes. This is controlled by NeedsSourcePositionsForProfiling(). The problem we currently have is that this mode must be enabled before the code is optimized, otherwise the source position information will be low quality, even once the CPU profiler is turned on. Also add an implication from --future to this new flag, to gather perf & memory data from the bots. Bug: v8:7983 Change-Id: I993fc03df83028529eea365b6d336d9f4c0dcd2b Reviewed-on: https://chromium-review.googlesource.com/1156309Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54809}
-
Michael Starzinger authored
R=ahaas@chromium.org TEST=cctest/test-wasm-shared-engine BUG=v8:7424 Change-Id: Idad7bcfe2734df7395c62ec56fb737e180035c76 Reviewed-on: https://chromium-review.googlesource.com/1152918 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54808}
-
Michael Achenbach authored
This reverts commit 23cb219f. Reason for revert: https://crbug.com/v8/7996 Original change's description: > [build] Add MB config for deprecation warning bot > > TBR=yangguo@chromium.org > NOTRY=true > > Bug: v8:7963 > Change-Id: I1a91047b2a3c7d128f3b01a0970ce53a63c196d6 > Reviewed-on: https://chromium-review.googlesource.com/1145187 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54585} TBR=machenbach@chromium.org,yangguo@chromium.org NOTRY=true Bug: v8:7996 Change-Id: Ib6a0c972cd9bdf864295f70ebeda50f9f23ca314 Reviewed-on: https://chromium-review.googlesource.com/1156404 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54807}
-
Michael Starzinger authored
This avoids serializing and deserializing the sharable part of a module when it is transferred via {TransferrableModule}, which is possible when all Isolates run off the same engine via the --wasm-shared-engine flag. This adds a new --wasm-shared-code flag to enable this feature. R=ahaas@chromium.org BUG=v8:7424 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I099d581d7ccc4d058a4646f545a011745fd84eb4 Reviewed-on: https://chromium-review.googlesource.com/1142144 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Sigurd Schneider authored
ReadFile returned a Vector with ownership transfer, i.e. the client needed to call Dispose to free the memory. This CL changes the interface to return a std::string instead, which manages ownership. As it turns out, there is only one user of ReadString that sometimes calls an API function which expects to take ownership of its Vector argument. Bug: v8:7932 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie624a7a65cf5814fddce7a57bc557e4b9876bc53 Reviewed-on: https://chromium-review.googlesource.com/1155115 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Georg Neis authored
Also define some infrastructure for serialization. Bug: v8:7790 Change-Id: Icaa3d5b877dca41dfd5554683d05667fda115e80 Reviewed-on: https://chromium-review.googlesource.com/1150531 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
They were marked V8_DEPRECATE_SOON for the 6.9 branch, so we deprecate them for the 7.0 branch. R=yangguo@chromium.org Bug: v8:7868 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idc42affd4d1b103e9946e3b77a93720694eb2dfd Reviewed-on: https://chromium-review.googlesource.com/1150024Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: v8:6922 Change-Id: I6341cf5d16276f894c5986c194ff3fff3b71b46a Reviewed-on: https://chromium-review.googlesource.com/1154973Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54802}
-
Michael Achenbach authored
This reverts commit d854d351. Reason for revert: Speculative revert for webkit unit tests: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/25209 Original change's description: > [builtins] Clear RelocInfo for off-heap trampolines > > For technical reasons, we used to serialize off-heap trampolines with a > RelocInfo containing a single OFF_HEAP_TARGET entry. This RelocInfo was > never needed at runtime. It also ended up being somewhat misleading > because printing an embedded code object would show the OFF_HEAP_TARGET > entry (belonging to the trampoline) at the first 'real' instruction. > > With this CL, we explicitly serialize an empty byte array as the reloc > info for each off-heap trampoline, i.e. the snapshot will never contain > such off-heap target reloc infos. > > Bug: v8:6666, v8:7969 > Change-Id: If6fa85a438d093ed5dcea07ce0de1db49a224d28 > Reviewed-on: https://chromium-review.googlesource.com/1146643 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54786} TBR=yangguo@chromium.org,jgruber@chromium.org Change-Id: If5eabd162141149361df90095b89a173fe2cb81e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666, v8:7969 Reviewed-on: https://chromium-review.googlesource.com/1155594Reviewed-by:
-
Michael Achenbach authored
This reverts commit d9f6c685. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/17584 Original change's description: > Reland [CloneObjectIC] overwrite monomorphic/polymorphic feedback if deprecated > > An object with a deprecated Map which has already been cached in > CloneObjectIC feedback is still a valid Map for fast cloning --- but > to be consistent with other ICs, deprecated maps are ignored, and are > expected to be transitioned away from. > > If the source object has a deprecated map, the instance is migrated. > > BUG=v8:7611, chromium:867958, chromium:868586 > R=jkummerow@chromium.org, mvstanton@chromium.org > > Change-Id: I477aec6c8d0ae1e1648a70e85d2fd46146521d1c > Reviewed-on: https://chromium-review.googlesource.com/1154143 > Commit-Queue: Caitlin Potter <caitp@igalia.com> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54799} TBR=jkummerow@chromium.org,mvstanton@chromium.org,caitp@igalia.com Change-Id: Ifcb422c3a692543490710d450590323524a6359a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7611, chromium:867958, chromium:868586 Reviewed-on: https://chromium-review.googlesource.com/1155593Reviewed-by:
-
Caitlin Potter authored
An object with a deprecated Map which has already been cached in CloneObjectIC feedback is still a valid Map for fast cloning --- but to be consistent with other ICs, deprecated maps are ignored, and are expected to be transitioned away from. If the source object has a deprecated map, the instance is migrated. BUG=v8:7611, chromium:867958, chromium:868586 R=jkummerow@chromium.org, mvstanton@chromium.org Change-Id: I477aec6c8d0ae1e1648a70e85d2fd46146521d1c Reviewed-on: https://chromium-review.googlesource.com/1154143 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b668f37..3e09e23 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/0dd5c6f..9a90d9a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e05f902..65f883b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d795ab8..b0e855a Rolling v8/third_party/proguard: https://chromium.googlesource.com/chromium/src/third_party/proguard/+log/eba7a98..63f6c0b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/e26243c..24c4916 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I8f71d9ff29ee05663bd7a17cc40737eb996afdb6 Reviewed-on: https://chromium-review.googlesource.com/1156060 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54798}
-
- 30 Jul, 2018 17 commits
-
-
Frank Tang authored
Bug: v8:7988 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ib06e07b20c4a80baac7667241906142d60ada8e8 Reviewed-on: https://chromium-review.googlesource.com/1152453 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
Bug:v8:6532 Change-Id: Ie983fa561654f86597b8f45c5ce11f993846bfe6 Reviewed-on: https://chromium-review.googlesource.com/1145893 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:7993,v8:7994 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I058a2b8181b933dce9f71dab2b03304a424ae0ea Reviewed-on: https://chromium-review.googlesource.com/1154237 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
-
Frank Tang authored
Bug: v8:7979 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ic30da6f85b49fd34ee58faf253d9e976a460153c Reviewed-on: https://chromium-review.googlesource.com/1150873Reviewed-by:
-
Frank Tang authored
Reflect spec change in https://github.com/tc39/proposal-intl-relative-time/pull/81 Bug: v8:7992 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ic2153f8355b8380d2986b34d46eb6bb6771d4b59 Reviewed-on: https://chromium-review.googlesource.com/1154236Reviewed-by:
-
Vasili Skurydzin authored
Change-Id: I991686d6890909510d2a3e7101230995ff521063 Reviewed-on: https://chromium-review.googlesource.com/1152081Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#54792}
-
Michael Lippautz authored
Tbr: cbruni@chromium.org No-try: true Change-Id: Ica8c64e0956d4ca362646814e675104f94e77fac Reviewed-on: https://chromium-review.googlesource.com/1155585Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54791}
-
Rodrigo Bruno authored
From the promotion code point of view, a ThinString being forwarded to an ExternalString is exactly the same as an actual ExternalString being forwarded to its promoted copy. These changes provide a way to disambiguate both scenarios since they are different for external memory accounting. Bug: chromium:867902 Change-Id: I6fd56ee5e0f8900318466108273ab26e936eb439 Reviewed-on: https://chromium-review.googlesource.com/1152975 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Michael Starzinger authored
R=ahaas@chromium.org TEST=cctest/test-wasm-shared-engine Change-Id: I1f1b643089206805bc88e8898db6bf94093291b5 Reviewed-on: https://chromium-review.googlesource.com/1154916Reviewed-by:
-
Michael Lippautz authored
The following are ready for iwyu: - src/heap/mark-compact.h - src/heap/objects-visiting.h Bug: v8:7490 Change-Id: I4cb9b1146586adcef8c0e0cf187ca363fe6e9a8d Reviewed-on: https://chromium-review.googlesource.com/1154970Reviewed-by:
-
Peter Marshall authored
Fixes: src/parsing/parse-info.h src/parsing/preparsed-scope-data.h src/profiler/heap-profiler.h src/profiler/heap-snapshot-generator.h src/profiler/heap-snapshot-generator-inl.h' src/property.h src/prototype.h src/prototype-inl.h Bug: v8:7754,v8:7490,v8:7965 Change-Id: Iba14292cdfbbaf29d5b989c16d579a1ee0edcc25 Reviewed-on: https://chromium-review.googlesource.com/1154967 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54787}
-
jgruber authored
For technical reasons, we used to serialize off-heap trampolines with a RelocInfo containing a single OFF_HEAP_TARGET entry. This RelocInfo was never needed at runtime. It also ended up being somewhat misleading because printing an embedded code object would show the OFF_HEAP_TARGET entry (belonging to the trampoline) at the first 'real' instruction. With this CL, we explicitly serialize an empty byte array as the reloc info for each off-heap trampoline, i.e. the snapshot will never contain such off-heap target reloc infos. Bug: v8:6666, v8:7969 Change-Id: If6fa85a438d093ed5dcea07ce0de1db49a224d28 Reviewed-on: https://chromium-review.googlesource.com/1146643 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: v8:7490 Change-Id: Id6e50a201732b4ca1fd1f69f8c43298e216ce95b Reviewed-on: https://chromium-review.googlesource.com/1154788Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: Ibf87a807202d8f1e0e7c095bf6b3790b0f0954bf Reviewed-on: https://chromium-review.googlesource.com/1154907Reviewed-by:
-
Florian Sattler authored
AdvanceUntil allows the Utf16CharacterStream to advance until a charater is found that passes the check. Bug: v8:7926 Change-Id: Iae39fb24194aa0ee2f544a55a7847956aa324b64 Reviewed-on: https://chromium-review.googlesource.com/1151303 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54783}
-
Jaroslav Sevcik authored
This CL introduces InstanceTypeChecker namespace with type checkers for types used by the optimizing compiler. The type checkers are global functions. Examples: bool InstanceTypeChecker::IsJSFunction(InstanceType); bool InstanceTypeChecker::IsAllocationSite(InstanceType); The CL also uses these type checkers in the HeapObject::IsXXXX() functions to ensure consistency. Bug: v8:7790 Change-Id: I7eb9e79ca28da02fd489201f532e566d0d13243a Reviewed-on: https://chromium-review.googlesource.com/1154529Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54782}
-
Michael Lippautz authored
Bug: v8:7490 Change-Id: I6bed10a6389d83b1941ba894f06b2d9540e84139 Reviewed-on: https://chromium-review.googlesource.com/1152733Reviewed-by:
-
