- 04 Dec, 2019 3 commits
-
-
Clemens Backes authored
This was probably meant by the TODO removed in https://crrev.com/c/1946354, I just failed to see it because the TODO was placed at the wrong place. The fix triggered a bug in the profiler, which made the wrong assumption that the passed wasm name is null-terminated. This is also fixed in this CL. R=jkummerow@chromium.org, petermarshall@chromium.org Change-Id: Ibf798e7511e61f6b305dd2d05d1aeca43be774a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948704Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65319}
-
Simon Zünd authored
The ScopeIterator only requires accurate information for the whole script during local debug-evaluate, when the accurate scope information is used to build stack local blacklists. Otherwise it is enough to only reparse the closure. This should recover some performance during stepping, especially with large stacks and scripts. Drive-by: Remove unused COLLECT_NON_LOCALS enum option. Bug: chromium:1028093, v8:9938 Change-Id: I6b3a34e9015e564d683e76b88388daabc426e1cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948715 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65318}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a82ba26..e35470d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ca84a42..10bac4e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6d31ed5..9777ab3 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/a841030..4225f68 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I6f02720a886864a85623ad8d6a469da8ff4d88ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1947672Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65317}
-
- 03 Dec, 2019 15 commits
-
-
Milad Farazmand authored
Port 9fcbb5e3 Original Commit Message: Replace unsigned extract lane followed by sign extend as added here https://chromium-review.googlesource.com/c/v8/v8/+/1846711 with a signed extract lane for I8x16 and I16x8. R=george.wort@arm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I09254621c45298a431da44cc1670a90c7a8add0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1949062Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65316}
-
Jiayao Lin authored
Change-Id: I47f11509a4e0022ec0f50fdfd29f7cc3d4d547bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1949054Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: Ic82dbf1497913012138a62f22c53b936114df3e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948708 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#65314}
-
Clemens Backes authored
Currently, we show wasm frames, js frames, and js-to-wasm frames (the latter two are identified as "OPTIMIZED"). This CL makes us also show wasm-to-js frames in CPU profiling. R=petermarshall@chromium.org Bug: chromium:1029470 Change-Id: I2d09f73e7d7e62867554f2a95dc8ad4500a2cde1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948706Reviewed-by:
-
Nico Hartmann authored
Bug: chromium:1029576 Change-Id: If647f764da2682a0f278b9b8060d0665fab1c40c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948711 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65312}
-
Deepti Gandluri authored
Bug: chromium:1001376 Change-Id: I63811e33272715dd5b87a6d58ab2d48d3fc096a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948791Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#65311}
-
Seth Brenith authored
I noticed that the generated code from the Torque macro EnsureArrayLengthWritable included an imul instruction, even though the inputs to that instruction are both constants. This change adds the ability for MachineOperatorReducer to get rid of that operation. Change-Id: Ia2050c888d76f110d1290fd9eab13853c3353a63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1941138 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65310}
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: I8907a207448a6d3a38b5454107100959d485b8e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925614Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65309}
-
Joshua Litt authored
This reverts commit 3114000a. Reason for revert: Clusterfuzz issue should be fixed. Original change's description: > Revert "[replaceAll] Stage String.prototype.replaceAll." > > This reverts commit 825f65d3. > > Reason for revert: Clusterfuzzed > Bug: chromium:1028475 > > Original change's description: > > [replaceAll] Stage String.prototype.replaceAll. > > > > Intent to ship thread: > > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/raep1X9R_SE > > > > Bug: v8:9801 > > Change-Id: I61c559b82b4119084420ffb0a14a27774e37c760 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930608 > > Reviewed-by: Adam Klein <adamk@chromium.org> > > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#65161} > > TBR=adamk@chromium.org,joshualitt@chromium.org > > Change-Id: I7fa44eda475b8f421f74491e60a3131d381eb789 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:9801 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1935024 > Reviewed-by: Joshua Litt <joshualitt@chromium.org> > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65175} TBR=adamk@chromium.org,joshualitt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1028475, v8:9801 Change-Id: Idb5fbd1ec38084222357aeb2d9ff05d703f10eb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946737Reviewed-by:
Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65308}
-
George Wort authored
Replace unsigned extract lane followed by sign extend as added here https://chromium-review.googlesource.com/c/v8/v8/+/1846711 with a signed extract lane for I8x16 and I16x8. Change-Id: I5a701417b772d12f5ef038efbb081716bb27e25a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873700 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65307}
-
Ng Zhi An authored
Whenever we spill, num_used_spill_bytes_ is already updated using RecordSpillSpillSlot, so we don't need to add the number of locals. Bug: v8:9909 Change-Id: Ieecf957e71e0711be744a3f378d8ae11b941fc5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1947349Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65306}
-
Emanuel Ziegler authored
The following changes were introduced with the recent proposal update: - OOB access with 0 length traps - Double drop of segments is allowed - Dropped segments are treated like having size 0 (OOB error) - Active segments are dropped right after initialization R=ahaas@chromium.org Change-Id: I4e9fc4d9212841c7d858585c672143f99287520d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946355Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#65305}
-
Igor Sheludko authored
Bug: chromium:1029658 Change-Id: I4cb201bbf0a05d2673fcb8a5d19e34a969294c5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946335 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Calculate the number of bytes of the stack frame used in PatchPrepareStackFrame using the size of the spill instead of the number of slots. We only need the number of bytes spilled (without adding the number of locals) because whenever we spill, we already track the largest offset, with RecordUsedSpillSlot. GetTotalFrameSlotCount can also be changed to remove the num_locals, in a future patch. Change-Id: I08fe3e81eaebf5f2cf1e11292645663474483447 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1945944 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/00a14de..a82ba26 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0317de9..ca84a42 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5ae4817..6d31ed5 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/ae5343c..d1940b1 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I9bc8f7f48dccef25770eeaa081b36444b79b0913 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948103Reviewed-by:
-
- 02 Dec, 2019 22 commits
-
-
Jakob Kummerow authored
CSA::TryLookupElement must check the upper bound for dictionary-mode indices. The "stable map + accessor" branch of FastGetOwnValuesOrEntries must construct its LookupIterator such that it handles the named/indexed distinction correctly. Bug: chromium:1029338,chromium:1029369 Change-Id: I17e74ed24c260c5cfc20c61616e75db7d347f7a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943164 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65301}
-
Georg Neis authored
These hints are different from the rest (they only ever grow) and there's no need to have them in each environment. Bug: v8:7790 Change-Id: I56ed9671f602bcb6faba4003d84fee8b1d6e0128 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1944156 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
When converting a Smi to a String, we can skip the check for a cached array index on the result in case of a number-to-string cache hit. When trying to convert a String back to an index, the inlined fast path can check for a cached index (in addition to checking for a cached known negative). Locally this yields about 5% on the JSTests/Proxies/GetIndex* tests. Bug: chromium:1028021 Change-Id: I117eae01b1ad9c5d107ad7e598464b96dae9a6b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943160 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Maya Lekova authored
Add serialization of the virtual closures for Function.ptototype.apply and Function.prototype.call. Also add tests for those. Bug: v8:7790 Change-Id: I26374009c09958943ef36eae283a270875234e40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943155 Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit c509bb8c. Reason for revert: Breaks arm64 - sim - MSAN, see https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/30050 Original change's description: > [wasm] Share native modules compiled from the same bytes > > Cache native modules in the wasm engine by their wire bytes. This is to > prepare for sharing {Script} objects between multiple {WasmModuleObject} > created from the same bytes. This also saves unnecessary compilation > time and memory. > > R=clemensb@chromium.org > > Bug: v8:6847 > Change-Id: Iad5f70efbfe3f0f134dcb851edbcec50691677e0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916603 > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65296} TBR=clemensb@chromium.org,thibaudm@chromium.org Change-Id: I908b0f59bce26678d0b5d7fddc986384c40b4709 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6847 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946334Reviewed-by:
-
Thibaud Michaud authored
Cache native modules in the wasm engine by their wire bytes. This is to prepare for sharing {Script} objects between multiple {WasmModuleObject} created from the same bytes. This also saves unnecessary compilation time and memory. R=clemensb@chromium.org Bug: v8:6847 Change-Id: Iad5f70efbfe3f0f134dcb851edbcec50691677e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916603 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: -
Joshua Litt authored
Bug: v8:9838, chromium:1028016 Change-Id: Iae195ac12c8fc01506f04ed5e62fc3c0983c56e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1944280Reviewed-by:
-
Milad Farazmand authored
Change-Id: I01a449f098c7be3f1e071f57542dac6b67fb366d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1944279Reviewed-by:
-
Georg Neis authored
... in order to be in sync with JSNativeContextSpecialization. This probably doesn't allow any more optimizations but avoids confusing misses in the broker trace. Bug: v8:7790 Change-Id: Ia99a5828651468af8450028a351692482c21670c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1944155 Commit-Queue: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Dan Elphick authored
Removes the following functions: Flush AppendChars WriteAsCFile (only from header since impl was already removed) and moves local function AppendChars into anonymous namespace block. Bug: v8:9810 Change-Id: Icc3ca8458eed4711f25514ac71aa0e6b413ed281 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1921797 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Mike Stanton authored
Loop variable analysis doesn't recognize that the initial type of the loop variable phi combined with the increment type may produce a NaN result through the addition of two infinities of differing sign. This leads to unreachable code and a SIGINT crash. The fix is to consider this case before typing the loop variable phi, falling back to more conservative typing if discovered. R=neis@chromium.org Bug: chromium:1028863 Change-Id: Ic4b5189c4c50c5bbe29e46050de630fd0673de9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946352 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Mike West authored
Blink CL: https://chromium-review.googlesource.com/c/chromium/src/+/1944474 Bug: chromium:1029700 Change-Id: I91936942b21d133e06f2583a4e3c70951e5e86f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946348 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
Dan Elphick authored
Each Pipeline phase now declares kRuntimeCallCounterId which is used to record the runtime stats for the duration of the phase. As a result some manually instantiated counters are removed. All counters have the same name as the phase name with the v8.TF prefix replaced with Optimize. To enforce this, the existing phase_name declaration in each phase has been replaced with a macro that also declares the counter id and its mode. Bug: v8:10006 Change-Id: I836582298b60c30eb794f4c45a8bb16efa17a38e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943161Reviewed-by:
-
Clemens Backes authored
Code objects are scheduled for logging during compilation. In {CompileToNativeModule}, we then only need to ensure that these objects are actually logged. {LogWasmCodes} would log them independently, which leads to duplicate logging. R=jkummerow@chromium.org Bug: chromium:1029470 Change-Id: I6a187f4d7adcf7ac057f3a266f66244ef7e7102f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946353Reviewed-by: -
Clemens Backes authored
Instead of logging them as "wasm-unnamed" functions, log them as "wasm-to-js", and append the signature. This moves and generalizes the {AppendSignature} method that was already used to produce the signature string for other wrappers. R=jkummerow@chromium.org Bug: chromium:1029470 Change-Id: Ic911cb19a49dcbc332bf5a4aa195107522ac6945 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946350 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
Import wrappers (wasm-to-js) were missing from profiling, since their code is never logged. This CL fixes this by generally logging all wasm code generated, not just actual wasm functions. Also, instead of logging each individual code object (which requires a lock) within another lock, move the code out of the other lock and log all code objects at once. R=jkummerow@chromium.org Bug: chromium:1029470 Change-Id: Ia250d7f3f183b2c1d8e6af4e58dd65ee27df545b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943163 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Clemens Backes authored
This fixes a few thing regarding code logging for profiling: 1) Append the execution tier, otherwise we get two function of the same name. 2) Replace "wasm-function[%d]" by "<wasm-unnamed>", since the index is appended later anyway. 3) Avoid unneeded JS heap and C++ heap allocations during logging. R=jkummerow@chromium.org Bug: chromium:1029470 Change-Id: Ie7af41f21e4595f8d8c574e4ad18273f89f1cb6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943162 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Convert more uses of index into offsets. We record spill in terms of offsets (bytes) rather than slot index, so the name of the method can be changed, and in GetTotalFrameSlotCount we calculate the number of slots used in terms of number of bytes spilled. Bug: v8:9909 Change-Id: I26484c1b040cd4711cc7998cb29d68955bf8ddb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934528Reviewed-by:
-
Clemens Backes authored
We already don't do the on-heap round-trip any more. R=jkummerow@chromium.org No-Try: true Change-Id: Ib7223699f6907ca695f17616c280f4aa665e7291 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946354 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: chromium:1028208 Change-Id: I439cb5acf4487ab0e4af0dcd065f1ccb78b2e7a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946351Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65282}
-
Jakob Kummerow authored
The flag combination --gc-interval=500 --stress-compaction --stress-flush-bytecode, combined with baking mjsunit.js into the custom snapshot, caused type feedback for "deepEquals" to be forgotten, leading to an unexpected soft deopt. Forcing type feedback collection with %PrepareFunctionForOptimization() fixes that. Change-Id: I954c7ecbe70ca5b803a5fa7cd809c118f7659f21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946347Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:9810 Change-Id: I1dd90312b4ae1ad9461a27898f66d7c802dbae76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1930071 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#65280}
-
