- 04 Dec, 2018 7 commits
-
-
Camillo Bruni authored
Drive-by-fixes: - Rename RestoreData to RestoreDataForScope - Move Scope's private variable declaration to after functions Change-Id: I349b2fc05cd94d6d7a0745b28b4e66b898b5e147 Reviewed-on: https://chromium-review.googlesource.com/c/1358517Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58010}
-
Sigurd Schneider authored
This CL improves typed optimization more: ChangePlainPrimitiveToNumber is only omitted if it is not required. Change-Id: I5d81537a046c5a5a0c730fcd1e17bbdfda887687 Bug: v8:910562 Reviewed-on: https://chromium-review.googlesource.com/c/1357058Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58009}
-
Jaroslav Sevcik authored
It is possible this CL results in various regressions, the idea is to get some data on where constant tracking helps and where it regresses. Bug: v8:8361 Change-Id: I2f291788a8bea03e6eaac9f51564c1da02734d1a Reviewed-on: https://chromium-review.googlesource.com/c/1347474 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#58008}
-
Michael Achenbach authored
TBR=sergiyb@chromium.org NOTRY=true Change-Id: Ia49bf1d4a096e72c6584297ef5db0eaf85938178 Reviewed-on: https://chromium-review.googlesource.com/c/1360573Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58007}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/42a08f0..f686dfc Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6f862e5..4feee58 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/61ea307..d87b096 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I35746d4d32d6456ce7bf9320b64efbc2e3f3933a Reviewed-on: https://chromium-review.googlesource.com/c/1360074Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58006}
-
Jakob Gruber authored
This is the first (and major) step towards converting CallApiCallback and CallApiGetter stubs into builtins. The CallApiCallbackStub was parameterized with the number of arguments passed on the stack. This CL converts the compile-time parameter into an explicit runtime parameter, and removes all uses of the stub parameter. Drive-by: The implementation is now mostly consistent across platforms. Drive-by: Refactor the calling convention to free up two registers (kCallData and kHolder are now passed on the stack). Bug: v8:7777 Change-Id: I212dccc2930de89c264a13755918c9fae7842f1f Reviewed-on: https://chromium-review.googlesource.com/c/1354887 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58005}
-
Marja Hölttä authored
For this to work, I had to move PropertyCell out of objects.h too, since otherwise there would be an inl include cycle which makes the code not compile. BUG=v8:5402,v8:8238 Change-Id: I3233f86b68c1e2fd32d135fcf0bbba8101af8cb2 Reviewed-on: https://chromium-review.googlesource.com/c/1356510Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#58004}
-
- 03 Dec, 2018 15 commits
-
-
Jakob Kummerow authored
and also its pure-static subclass PrototypeUsers, whose porting is a no-op. Bug: v8:3770 Change-Id: I075806f784a0631058692149e71c45e455e90f73 Reviewed-on: https://chromium-review.googlesource.com/c/1355631 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
to the new design. Bug: v8:3770 Change-Id: I8483d47ac77e756395656628a80257e6462de22c Reviewed-on: https://chromium-review.googlesource.com/c/1355630Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58002}
-
Junliang Yan authored
This is to address the first issue reported on v8:8453 Page::kPageSize is 524288 MemoryAllocator::GetCommitPageSize() returns 65536 on ppc ObjectEndOffsetInCodePage() returns 458752 ObjectStartOffsetInCodePage() returns (65536 + 65536) => 131072 Therefore, memory = 327680, which is less than kMaxRegularHeapObjectSize(507136), which causes the DCHECK to fail. Bug: v8:8453 Change-Id: I6048192ded4234a6987371ec4d4b2a8553756c25 Reviewed-on: https://chromium-review.googlesource.com/c/1355422 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58001}
-
Nico Weber authored
Bug: chromium:911183 Change-Id: I99552d09e68a6b99e35daf39e15ddf1ef5781baa Reviewed-on: https://chromium-review.googlesource.com/c/1358701Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58000}
-
Vasili Skurydzin authored
architecture. Bug: v8:8402 Change-Id: I13928b6946b8fa68ccd8d329c8a0856313a10571 Reviewed-on: https://chromium-review.googlesource.com/c/1357159Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57999}
-
Joran Siu authored
CPU features printout needs to use PrintF macro, in order for the output to be in correct native encoding. R=michael_dawson@ca.ibm.com, jyan@ca.ibm.com Change-Id: If1762e452cdfe8c0ca954676acb20c1e60df8d2f Reviewed-on: https://chromium-review.googlesource.com/c/1357160 Commit-Queue: Joran Siu <joransiu@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57998}
-
Igor Sheludko authored
broken by: [cleanup] Fix kPointerSize usages in src/objects/bigint.* Bug: v8:8477, v8:8238 Change-Id: If1961ae42e1969d4ee807ea052a9c4cf4f072d0f Reviewed-on: https://chromium-review.googlesource.com/c/1357046 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57997}
-
George Wort authored
Move lhs into dst when lhs == rhs. Bug: v8:6600, chromium:910223 Change-Id: I5bcb01b57705c52f363a43b2036f0ade0fd451e7 Reviewed-on: https://chromium-review.googlesource.com/c/1357041 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Since all other values are not used any more if we return, we don't need to spill anything (as might happen during {PopToRegister}). Instead, just load the top stack value into the return register(s). R=titzer@chromium.org Bug: v8:6600, v8:8423 Change-Id: Ibfd02d20191459c7b136ab9a48f0cf1a53b3385d Reviewed-on: https://chromium-review.googlesource.com/c/1358391 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57995}
-
Toon Verwaest authored
Rename ParseIdentifierOrStrictReservedWord to simply ParseIdentifier and replace the old ParseIdentifier with ParseNonRestrictedIdentifier for the disallow_restricted_identifier case. It reuses the new ParseIdentifier. Clients that relied on the is_strict_reserved output parameter can simply check the token themselves. Change-Id: I49b096d7ffbfff391483e9c18c9504e5d353e97b Reviewed-on: https://chromium-review.googlesource.com/c/1357057Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57994}
-
Toon Verwaest authored
- Rename methods, - Introduce flags for tokens to lookup IsKeyword and IsPropertyName - Remove "contextual keyword" leftover code. - Inline ParsePropertyName into ParsePropertyNameOrPrivatePropertyName since public is more likely than private. Change-Id: Ib7633ef3c46889ecafc7a6c929029845bb8ef15c Reviewed-on: https://chromium-review.googlesource.com/c/1357052 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Remove IdentifierOrEnum and AwaitOrYield and reduce Callable to exclude enum. Change-Id: Id80c0c5e7a8d4869ab8d841f3b973ea7c0c844cc Reviewed-on: https://chromium-review.googlesource.com/c/1357044 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
If they are part of a keyed store they are pushed later using impl()->PushPropertyName. Change-Id: I9c104d15722dd59556c04fe3d4b0018c37d0f553 Reviewed-on: https://chromium-review.googlesource.com/c/1357055Reviewed-by:
-
Stephan Herhut authored
The register allocator spends significant amounts of time on updating the state of active and inactive live range sets. In many cases, no update is needed. By precomputing when the next update is due during state management, we can avoid unnecessary checks. This cuts the time spent for managing queues in half. Change-Id: I44074266bed2f09171872a829f115e61608b76c8 Reviewed-on: https://chromium-review.googlesource.com/c/1352308Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#57990}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8373abc..42a08f0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia1bc23643a569120a6fb22e912f1b06c8e15679b Reviewed-on: https://chromium-review.googlesource.com/c/1356913Reviewed-by:
-
- 02 Dec, 2018 3 commits
-
-
Frank Tang authored
Also split out some order check tests. Bug: v8:5751 Change-Id: I1765d1809b456c43e21d9a379f720a0ea12e794e Reviewed-on: https://chromium-review.googlesource.com/c/1352283Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57988}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fe88ff7..8373abc TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib2f4e3846ba51a5ed9d07005ad9d3f8fb0604c74 Reviewed-on: https://chromium-review.googlesource.com/c/1356910Reviewed-by:
-
Mathias Bynens authored
The `readonly: true` key-value pair is redundant since it gets ignored anyhow. This patch removes it. Also, `configurable: false` is implied when using `Object.defineProperty` (just like `enumerable: false` and `writable: false`). Therefore, specifying only `configurable` but not `enumerable` and `writable` gave the impression that configurability was somehow the deciding factor for this test. Instead, the only important data property for this test is `writable: false`. This patch lists all four data property attributes explicitly, making it clear that only `writable` has a “special” value. Bug: v8:8175, v8:8238 Change-Id: Icfc6262f246712a64cdfcffff7b648f5681a711e Reviewed-on: https://chromium-review.googlesource.com/c/1357048Reviewed-by:
Caitlin Potter <caitp@igalia.com> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#57986}
-
- 01 Dec, 2018 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e066ef7..fe88ff7 Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/2e948dd..76d26bb Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/63d69d7..6f862e5 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dd53081..61ea307 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5422fce..558f684 Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/157bec8..0e3e1c4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7cfd5de6833e5ad18501f07147c71e61ec392c11 Reviewed-on: https://chromium-review.googlesource.com/c/1356904Reviewed-by:
-
Jakob Kummerow authored
While strictly speaking it is legal (though useless) to dynamically create zero-length arrays with "new T[0]", UBSan does not like it, so this CL avoids doing it. It fixes the error: ../../src/allocation.h:41:34: runtime error: constructor call on address 0x... with insufficient space for an object of type 'unsigned char' Bug: v8:3770 Change-Id: I5017767c59df0d8928f7493f92d2d04519083964 Reviewed-on: https://chromium-review.googlesource.com/c/1356902Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57984}
-
- 30 Nov, 2018 13 commits
-
-
Jakob Kummerow authored
Taking kSystemPointerSize into account when determining the maximum allowed BigInt size accidentally made the limit platform-specific. This patch chooses a platform-independent constant (1<<30) instead. Bug: chromium:909614 Change-Id: I4717969bc56e6dd5f1eed70b7e60e621989d0719 Reviewed-on: https://chromium-review.googlesource.com/c/1355625 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Ross McIlroy authored
This is a reland of 10ea3f8a Original change's description: > [Compiler] Introduce IsCompiledScope which prevents flushing of compiled code > > Introduces a IsCompiledScope object which can be used to check whether a > function is compiled, and ensure it remains compiled for the lifetime > of the scope without being uncompiled by bytecode flushing. The Compile > functions are modified to take a scope so that calling code can ensure > the function remains compiled for the lifetime they require. > > Also, don't allocate a feedback vector for asm-wasm code as this > is never used, and will be reallocated if the asm-wasm code fails to > instantiate the module and we fallback to regular JavaScript. > > Also restructure Compiler::PostInstantiation() to allocate the feedback > vector once, and do the optimized code check before optimizing for > always opt. > > BUG=v8:8395 > > Change-Id: I3f1a71143fcae3d1a0c01eefe91ebb4b8594221a > Reviewed-on: https://chromium-review.googlesource.com/c/1352295 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57971} TBR=jgruber@chromium.org,mstarzinger@chromium.org Bug: v8:8395 Change-Id: I8dc00798a5680997990c879c3380fe4febd47297 Reviewed-on: https://chromium-review.googlesource.com/c/1357045 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57982}
-
Jakob Kummerow authored
to the new design. Bug: v8:3770 Change-Id: I63291cc8eccfa1da20e84c6d3e9f48f253409396 Reviewed-on: https://chromium-review.googlesource.com/c/1355627 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#57981}
-
Ujjwal Sharma authored
Cleanup runtime/runtime-intl.cc by removing dead code, namely Runtime_CanonicalizeLanguageTag and Runtime_GetDefaultICULocale. Bug: v8:8439,v8:5751 Change-Id: Id8712b2f3b2ddffc0e289b904f17ae3b09faffae Reviewed-on: https://chromium-review.googlesource.com/c/1329705 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: I0ffdd0d9da8629977a0b82fbfdac2b4f903e39ad Reviewed-on: https://chromium-review.googlesource.com/c/1355626Reviewed-by:
-
Ross McIlroy authored
The optimized code for TestSetWithCustomIterator holds a weak reference to the map for the entries object. If this is collected by the GC then the optimized code deopts which causes the test to fail. To prevent this, hold onto an entires object to keep it's map alive. Change-Id: I5796e74fc1d7c5061bf8c98f7a82fe582d6be76a Reviewed-on: https://chromium-review.googlesource.com/c/1357043Reviewed-by:
-
Toon Verwaest authored
- Rely more heavily on Token::IsValidIdentifier. - Deal with IsLet() when it's possibly a lexical declaration. - Remove ENUM from the default IsAnyIdentifier range. - Always pre-check whether IsAnyIdentifier before classifying identifiers. Change-Id: I55eae6ff65dc306b466fa29d233c715e85bc3854 Reviewed-on: https://chromium-review.googlesource.com/c/1356514Reviewed-by:
-
George Wort authored
Add the arm architecture to the list of archs that support Liftoff in mjsunit and so run the Liftoff tests for it. Bug: v8:6600 Change-Id: I4896f0727f6ccc3343f5d517e100840f76dd901d Reviewed-on: https://chromium-review.googlesource.com/c/1357040Reviewed-by:
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: I47ea0994b7f1933095995c051fce76c288a25d6a Reviewed-on: https://chromium-review.googlesource.com/c/1356515 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Ross McIlroy authored
This reverts commit 10ea3f8a. Reason for revert: Causing failure on gc_stress bot: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8928421099411850688/+/steps/Bisect_10ea3f8a/0/steps/Retry/0/logs/collections-construct../0 Original change's description: > [Compiler] Introduce IsCompiledScope which prevents flushing of compiled code > > Introduces a IsCompiledScope object which can be used to check whether a > function is compiled, and ensure it remains compiled for the lifetime > of the scope without being uncompiled by bytecode flushing. The Compile > functions are modified to take a scope so that calling code can ensure > the function remains compiled for the lifetime they require. > > Also, don't allocate a feedback vector for asm-wasm code as this > is never used, and will be reallocated if the asm-wasm code fails to > instantiate the module and we fallback to regular JavaScript. > > Also restructure Compiler::PostInstantiation() to allocate the feedback > vector once, and do the optimized code check before optimizing for > always opt. > > BUG=v8:8395 > > Change-Id: I3f1a71143fcae3d1a0c01eefe91ebb4b8594221a > Reviewed-on: https://chromium-review.googlesource.com/c/1352295 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57971} TBR=rmcilroy@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org Change-Id: I1449a02a0aceb9757440757628e586df33972a40 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8395 Reviewed-on: https://chromium-review.googlesource.com/c/1357042Reviewed-by:
-
Clemens Hammacher authored
This has significant impact on validation time (11% regression, see linked bug). These annotations bring us back to the old performance (according to local measurements it even makes us better than before). R=mstarzinger@chromium.org Bug: chromium:910432 Change-Id: I8e701f9577d53115b3db22be2a09487414c965df Reviewed-on: https://chromium-review.googlesource.com/c/1356511Reviewed-by:
-
Hannes Payer authored
Bug: chromium:852420 Change-Id: Ie1f656cafe78c517ff53676d8cb7200d0bf1d7cc Reviewed-on: https://chromium-review.googlesource.com/c/1356518Reviewed-by:
-
Ross McIlroy authored
Introduces a IsCompiledScope object which can be used to check whether a function is compiled, and ensure it remains compiled for the lifetime of the scope without being uncompiled by bytecode flushing. The Compile functions are modified to take a scope so that calling code can ensure the function remains compiled for the lifetime they require. Also, don't allocate a feedback vector for asm-wasm code as this is never used, and will be reallocated if the asm-wasm code fails to instantiate the module and we fallback to regular JavaScript. Also restructure Compiler::PostInstantiation() to allocate the feedback vector once, and do the optimized code check before optimizing for always opt. BUG=v8:8395 Change-Id: I3f1a71143fcae3d1a0c01eefe91ebb4b8594221a Reviewed-on: https://chromium-review.googlesource.com/c/1352295Reviewed-by:
-
