- 22 Jun, 2018 1 commit
-
-
Sigurd Schneider authored
This CL adds the BUILTIN kind specific flag is_off_heap_trampoline to Code objects. Code objects hence know whether they are off-heap trampolines, and can decide whether they need to return the off-heap instruction start or not without looking at the builtin index and/or considering the existence of an embedded blob. Bug: v8:6666 Change-Id: I0fbc540a2624ed5fa8256b807299e2fe4b907dda Reviewed-on: https://chromium-review.googlesource.com/1109691 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53956}
-
- 23 Apr, 2018 1 commit
-
-
jgruber authored
When attributing ticks to a function, we first check if the current pc matches a section within the dynamic library. If we find a match here, then we don't continue looking within dynamically generated range information, e.g. for JS functions and builtins. This logic breaks when embedded builtins come into play. They live within the libv8.so shared library, and are found when looking up statics. But what we really want is to look up the dynamically generated code-range, which contains more precise information. In this CL, this case is detected by matching the found symbol name. If it's the embedded blob, then we continue to dynamic lookup. Bug: v8:6666 Change-Id: I7cea2cd4898f5a08381a071bdbc2f862b9c80880 Reviewed-on: https://chromium-review.googlesource.com/1023422 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52723}
-
- 04 Mar, 2017 1 commit
-
-
jarin authored
Improvements: - top-down call tree. - interactive restriction to time interval. Review-Url: https://codereview.chromium.org/2696903002 Cr-Commit-Position: refs/heads/master@{#43599}
-
- 28 Apr, 2016 1 commit
-
-
lpy authored
Currently we already have tools to extract C++ symbols of d8, and output the statistics result. This patch creates two scripts, one is to use exsisting tools to extract C++ symbols and dump to output, the other collects all symbols and merges them into v8 log. The format of C++ symbols in v8 log is: cpp,start_address,size,symbol_name BUG=v8:4906 LOG=n Review-Url: https://codereview.chromium.org/1884493003 Cr-Commit-Position: refs/heads/master@{#35841}
-
- 17 Oct, 2014 1 commit
-
-
jkummerow@chromium.org authored
R=loislo@chromium.org, yangguo@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/638633002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24700 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Sep, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
Events are still generated for tick processor on performance testing server to work, as soon as scripts will be updated, it will be safe to remove code delete events emitting code. R=erik.corry@gmail.com BUG=v8:1466 TEST=existing tests in test-profile-generator,test-cpu-profiler and mjsunit/tools Review URL: http://codereview.chromium.org/7864017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9275 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Sep, 2011 2 commits
-
-
mikhail.naganov@gmail.com authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9231 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mikhail.naganov@gmail.com authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9229 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Jul, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
The only usage of it was in logging tests, I've switched them for using a file. I've left out support for "--logfile=*" for now, as Chromium uses it. Will be removed after the next V8 roll. R=sgjesse@chromium.org BUG=859 TEST=mjsunit/log-* Review URL: http://codereview.chromium.org/7310025 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8629 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Feb, 2011 1 commit
-
-
mikhail.naganov@gmail.com authored
As they are no more used in DevTools profiler, there is no need to prefix them with "devtools.profiler" namespace. Review URL: http://codereview.chromium.org/6456025 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6712 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Jan, 2010 1 commit
-
-
mikhail.naganov@gmail.com authored
The problem appeared due to a fact that stubs doesn't create a stack frame, reusing the stack frame of the caller function. When building stack traces, the current function is retrieved from PC, and its callees are retrieved by traversing the stack backwards. Thus, for stubs, the stub itself was discovered via PC, and then stub's caller's caller was retrieved from stack. To fix this problem, a pointer to JSFunction object is now captured from the topmost stack frame, and is saved into stack trace log record. Then a simple heuristics is applied whether a referred function should be added to decoded stack, or not, to avoid reporting the same function twice (from PC and from the pointer.) BUG=553 TEST=added to mjsunit/tools/tickprocessor Review URL: http://codereview.chromium.org/546089 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3673 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Nov, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
Logging getters and setters from DOM API is extremely useful for web developers as setting (and getting!) several properties can cause page relayouts which take significant time. Review URL: http://codereview.chromium.org/434074 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3363 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jul, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
'nm' is now called with an option to report function code sizes. Static code entries are restricted to the sizes reported, and the remaining unnamed code is attributed to a library as a whole. This makes reports more accurate, as some functions are tiny, but has chunks of unnamed code behind them. This change doesn't affect reporting on Windows, as in .map files function code sizes aren't specified. Review URL: http://codereview.chromium.org/149513 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Jun, 2009 1 commit
-
-
erik.corry@gmail.com authored
handling addresses. Review URL: http://codereview.chromium.org/125187 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2193 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 May, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
This reduces memory usage of tickprocessor. Thanks to William Hesse for pointing out this issue. Also speed up static symbols loading. Review URL: http://codereview.chromium.org/113101 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1902 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Apr, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
This is an effort to reuse profiler data processing code both in TickProcessor and Dev Tools Profiler. The old Python implementation will be removed. The new TickProcessor works almost identical to the previous one. However, it has some differences: 1. Not very useful "Call profile" section is replaced with a new WebKit-like "Bottom up (heavy) profile" which shows the most expensive functions together with their callers. I used it personally in order to find and remove bottlenecks in the tickprocessor script itself, and found it quite helpful. 2. Code entries with duplicate names (they occur for RegExes, stubs and sometimes for anonymous Function objects) are now distinguished by adding an occurence number inside curly brackets. 3. (Address -> code entry) mapping is more precise in boundary cases. 4. Windows version no more requires specifying .map file location. 5. Works faster. Review URL: http://codereview.chromium.org/99054 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Apr, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
Review URL: http://codereview.chromium.org/77014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1739 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Apr, 2009 1 commit
-
-
mikhail.naganov@gmail.com authored
Found a pair of bugs concerned with border cases in the original implementation. Review URL: http://codereview.chromium.org/67191 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1726 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-