- 22 Oct, 2019 40 commits
-
-
Ng Zhi An authored
This is a reland of 08b26f53 Fixed the original crash, by removing a disasm for psllq and psrlq that is now handled by the macro list. Original change's description: > Clean up macros > > Move some instruction definitions into sse-instr, which is used to > generate some disasm tests, so we can remove some cases there. > > Bug: v8:9810 > Change-Id: I0615ec823396da08bc5d234cf1dabca6afd3f052 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866965 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64441} Bug: v8:9810 Change-Id: I69335a889f5f72b76a79e4e9860835232e6e38a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872298Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#64487}
-
Mu Tao authored
Port 3cad6bf5 Original Commit Message: This is a reland of c7c47c68. This makes TSAN happy in addition to: Previously I presumed that the context read from a frame in the profiler was a valid context. Turns out that on non-intel we're not guaranteed that the frame is properly set up. In the case we looked at, the profiler took a sample right before writing the frame marker indicating a builtin frame, causing the "context" pointer from that frame to be a bytecode array. Since we'll read random garbage on the stack as a possible context pointer, I made the code reading the native context from it a little more defensive. Bug: v8:9860 Tbr: ulan@chromium.org, neis@chromium.org, ishell@chromium.org Original change's description: > [runtime] Move Context::native_context to the map > > Remove the native context slot from contexts by making context maps > native-context-specific. Now we require 2 loads to go from a context to the > native context, but we have 1 field fewer to store when creating contexts. > > Change-Id: I3c0d7c50c94060c4129db684f46a567de6f30e8d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859629 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64296} R=xwafish@gmail.com Change-Id: I6496a8c5be8cbabf48cddc2d59111410f31eb75f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868774 Auto-Submit: Mu Tao <pamilty@gmail.com> Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#64486}
-
Milad Farazmand authored
Port 434f9681 R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I2b374de4d50022e88b240dbad5eddcab8cfe9547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874085Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64485}
-
Adam Klein authored
Remove inactive contributors (cira and mnita) and add ftang and jshin. Change-Id: Ibd1e4f11553b78e1cd938a7ce8958fe5341829d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872540Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#64484}
-
Gus Caplan authored
Change-Id: Iee27a99a9627d73e10c4c85c31d07a5204808259 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864574 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#64483}
-
Andreas Haas authored
Otherwise the value cannot be used in gtests in EXPECT_GT expressions. The reason is that EXPECT_GT takes values by reference and not by value, so the declaration in v8.h is not enough. R=clemensb@chromium.org Bug: v8:9810 Change-Id: I6f85024d483701fcc65d1ccfc5254dbdbcce16c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871606Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64482}
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: Ib78d7506fa8c8b755a8e1feccc5d948834ddc3a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873106Reviewed-by:
-
Gus Caplan authored
Change-Id: I97ccbb29f9d4d92bb2ac20402ff8240632533989 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864572 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The new predicate indicates whether the backing store was created for an ArrayBuffer or a SharedArrayBuffer. It is useful for some embedders. Bug: v8:9380 Change-Id: I804063bb8c4c17815defd6538ce6a1b32f6a4531 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873689 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64479}
-
Liviu Rau authored
Bug: v8:9503 Change-Id: I6434685459a6b5a935a3a3598a3827959590b9e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864652Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#64478}
-
Victor Gomes authored
Original change's description: > [runtime] Remove extension slots from context objects > > Context objects have an extension slot, which contains further > additional data that depends on the type of the context. > > This CL removes the extension slot from contexts that don't need > them, hence reducing memory. > > The following contexts will still have an extension slot: native, > module, await, block and with contexts. See objects/contexts.h for > what the slot is used for. > The following contexts will not have an extension slot anymore (they > were not used before): script, catch and builtin contexts. > Eval and function contexts only have the extension slot if they > contain a sloppy eval. > > Bug: v8:9744 > Change-Id: I8ca56c22fa02437bbac392ea72174ebfca80e030 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863191 > Commit-Queue: Victor Gomes <victorgomes@google.com> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Auto-Submit: Victor Gomes <victorgomes@google.com> > Cr-Commit-Position: refs/heads/master@{#64372} TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org Bug: v8:9744 Change-Id: I8700ed2fa62c89e86c39bb16ac3167f38ea8d63f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873695 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#64477}
-
Hans Wennborg authored
I was just driving by and noticed these unnecessary includes. Bug: none Change-Id: I071ce08ef8a52cdeda997047ff7d9a5f47c5ba10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872394 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:4153 Change-Id: Icd346fae1dea9e56527b8669ace1aa6cfd46e87a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872393 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64475}
-
Joshua Litt authored
Currently, RegExpResult builds match indices lazily using data stored in hidden internal fields on the result object itself. Unfortunately, if an internal field is deleted, it can cause these hidden fields to migrate to a dictionary, making indexed lookup unsafe. This CL forces slow but safe lookup for these fields when lazily building indices. Bug: v8:9548, chromium:1013133 Change-Id: Ide87d9ca6a73644ced3de8e35ecac26330d365e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871756Reviewed-by:
-
Milad Farazmand authored
Port 0089006f Original Commit Message: .. similar to how it is applied in the interpreter. We reserve a stack slot for the backtrack count, increment it on each backtrack, and fail if the limit is hit. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ic0c0f8569b2c2596976136d96971e7fa39f9e145 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872430Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64473}
-
Thibaud Michaud authored
R=mstarzinger@chromium.org Bug: v8:6672 Change-Id: Id8a53f6f74fa05150469c35ceba9470e75363637 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847156Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
We should be encountering this due to TaggedEquality. DecompressionElimination used to take care of this, but it will not be present in the new system. Bug: v8:7703 Change-Id: I9fe00ee116ed1514cb4c465a8d19df6e785ef913 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868623Reviewed-by:
-
Simon Zünd authored
This CL adds a boolean flag to Runtime.evaluate that allows REPL mode to be enabled. REPL mode hasn't landed in V8 yet, and the internal API for it is still in flux. R=yangguo@chromium.org Bug: chromium:1004193 Change-Id: I281285e225d3fd2dd4175f3dd967d6562459a203 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866510Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Bug: chromium:1016450 Change-Id: I4801b5ffb0ebea92067aa5de37e11a4e75dcd3c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873692Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#64469}
-
Nico Hartmann authored
BigInt performance benchmarks are restructured in JSTest1.json in such a way that it is easier to run meaningful subsets of BigInt test cases. Bug: v8:9213 Change-Id: Ibf94bfb0f14cf8afa890927d97f920659e8b28d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872390 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Jakob Gruber authored
The new regexp_backtracks / V8.RegExpBacktracks counter tracks the number of backtracks performed per regexp execution. The results can help us prioritize related work. Note that we only count backtracks in the interpreter. Jitted code is ignored. With our current regexp tiering strategy, that means we count backtracks only in the first execution of each regexp. Chromium CL: https://crrev.com/c/1871601 Bug: v8:9892 Change-Id: I19146d6e9bc2355f210a050e93dd7e856ab066f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873696 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Georg Neis authored
Instead of logging when SFI inlineability is computed, log when that result is actually used. Moreover, log something in some cases where we logged nothing so far (e.g. when we can't inline due to missing feedback vector). Change-Id: Id93119f4ead17aa9e721eb4fcc20774c54178665 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873693Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64466}
-
Thibaud Michaud authored
Block inputs are removed from the stack. Set expected stack height accordingly. R=ahaas@chromium.org Bug: v8:9867 Change-Id: I7e3fd2985c0e77e83d5551cac613788f3cf0a370 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872404 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Simon Zünd authored
Embedded builtins are now unconditionally enabled, which removes the need to differentiate between enabled/disabled embedded builtins. This Cl removes the 'embedded_builtins' variant and related *.status entries. R=machenbach@chromium.org Bug: v8:8519 Change-Id: I55d0dd54735b7cc437832af6fa2836fd6c14a317 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864936 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... and refactor String.prototype.substring. This is done to simplify cleaning up callers of ConvertToRelativeIndex() in a follow-up CL. This CL also introduces Smi-overflow friendly helper function ClampToIndexRange(index: JSAny, min: uintptr, max: uintptr): uintptr which can be used in other String builtins as a better alternative to NumberMin(NumberMax(value, min), max) pattern. Bug: v8:8996, v8:4153 Change-Id: Ie1bb5ab305ebf851c033d109ffe9e6afb9418274 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872392 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
If a new jump table is created and lazy compilation is enabled, we need to initialize the new jump table with jumps to the lazy compile table. R=ahaas@chromium.org Bug: chromium:1016515 Change-Id: I5749470d4a08af903a6a4da13dbe5454ee6db309 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873687Reviewed-by:
-
Jakob Gruber authored
This CL removes the V8_EMBEDDED_BUILTINS define, FLAG_embedded_builtins, and all code for supporting non-embedded-builtin builds. Bug: v8:6666,v8:8519 Change-Id: I2ad7bd6614c7cd404b83d3d2bf5ff91d7b55ff2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866569 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
These are useful for the cases when an embedder works with backing stores without creating JS ArrayBuffer objects. Bug: v8:9380 Change-Id: I452bd911e7b20fb38568f18f9d15ea1a7ffb5a57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1825339 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
This is a reland of f5611402 We had to revert due to branch cut. The A/B experiment wasn't done yet. Original change's description: > [ptr-compr][arm64] Temporarily enable pointer compression on arm64 > > ... and make sure that the arm64 ptr-compr bots proceed testing V8 without > pointer compression in order to keep testing the other config. > > Commented out the 'extra' variant since it was crashing. Opened a bug > regarding that: https://bugs.chromium.org/p/v8/issues/detail?id=9568 > > Similar to x64's https://chromium-review.googlesource.com/c/v8/v8/+/1607654 > > Bug: v8:7703 > Change-Id: Ifd46b029bab34524f9f536dcdbd1574f2ddcbf37 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1724216 > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63019} Bug: v8:7703 Change-Id: I28726f534dfd17dd695a3ba5653873368e7a44b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872403Reviewed-by:
-
Dominik Inführ authored
This CL ensures that recorded slots are either in the sweeping or the old-to-new remembered set after mark-compact depending on whether the page was already swept or not. All pages that are swept during the evacuation phase also have their remembered sets merged. is_local() is renamed to is_compaction_space() and non-virtual. The PagedSpace now not only knows whether it is a compaction space or not but also for which collection through the compaction_space_kind_ field. This allows RefillFreeList to merge the remembered sets immediately also for the mark-compact collection. Change-Id: I7457f8393d73f3e8d6b6ebedc46ebc36af509729 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868613Reviewed-by:
-
Andreas Haas authored
R=jkummerow@chromium.org Bug: v8:9810 Change-Id: I85fa659a67b1f9f2d94cdc6107e19f9da1889fd0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872401Reviewed-by:
-
Simon Zünd authored
This CL removes the 'v8_enable_embedded_builtins' GN argument and sets the 'V8_EMBEDDED_BUILTIN' define unconditionally. Removing the now obsolete 'define' and corresponding C++ code will be done in a separate CL. R=machenbach@chromium.org Bug: v8:8519 Change-Id: Ibaa3e958121931c0ce14baf48ad401fab87c5337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864929 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Parenthesized variable names are valid references for assignment. To make sure we can properly mark the variable as assigned, we should push parenthesized variables to the outer expression scope after the parenthesized expression is guaranteed to not be an arrow head; so that the variable list of the parent is complete. Technically we could probably get by with simply pushing a single variable, since more complex expressions aren't valid parenthesized assignment targets: (a) = ... and [(a),(b)] = ... are valid, but ([a,b]) = ... isn't. It doesn't really seem worth it though. Bug: chromium:1015372 Change-Id: I095c35126742a14d0171537b9795f7258c33ab4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872389 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64455}
-
David Carlier authored
Those two BSD flavors supports this API since long years and underlyingly it is a ChaCha flavor with good performances. Change-Id: Ic4266f5ef3e17af95de97844a6b7ebba4a56802d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869200Reviewed-by:
-
Clemens Backes authored
This reverts commit 392a1217. Reason for revert: Several failures on mac64 gc stress: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac64%20GC%20Stress/9747 Original change's description: > Reland "Reland "[runtime] Remove extension slots from context objects"" > > This is a reland of c48096d4 > > Original change's description: > > Reland "[runtime] Remove extension slots from context objects" > > > > This is a reland of c07c02e1 > > > > Original change's description: > > > [runtime] Remove extension slots from context objects > > > > > > Context objects have an extension slot, which contains further > > > additional data that depends on the type of the context. > > > > > > This CL removes the extension slot from contexts that don't need > > > them, hence reducing memory. > > > > > > The following contexts will still have an extension slot: native, > > > module, await, block and with contexts. See objects/contexts.h for > > > what the slot is used for. > > > The following contexts will not have an extension slot anymore (they > > > were not used before): script, catch and builtin contexts. > > > Eval and function contexts only have the extension slot if they > > > contain a sloppy eval. > > > > > > Bug: v8:9744 > > > Change-Id: I8ca56c22fa02437bbac392ea72174ebfca80e030 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863191 > > > Commit-Queue: Victor Gomes <victorgomes@google.com> > > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > > > Auto-Submit: Victor Gomes <victorgomes@google.com> > > > Cr-Commit-Position: refs/heads/master@{#64372} > > > > TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org > > > > Bug: v8:9744 > > Change-Id: I0749cc2d8f59940c25841736634a70047116d647 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869192 > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > > Auto-Submit: Victor Gomes <victorgomes@google.com> > > Cr-Commit-Position: refs/heads/master@{#64380} > > TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org > > Bug: v8:9744 > Change-Id: I621ffe98722f8c4defaf277b8d1666484ba2963f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872400 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@google.com> > Cr-Commit-Position: refs/heads/master@{#64451} TBR=ulan@chromium.org,jgruber@chromium.org,petermarshall@chromium.org,leszeks@chromium.org,verwaest@chromium.org,victorgomes@google.com Change-Id: I99a71180c6a00a87478867a8210ff9ceb46cb3ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9744 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872405Reviewed-by:
-
Dan Elphick authored
If the same VariableProxy is added to a ThreadedList twice, it will introduce a cycle which would cause a DCHECK failure on the next Add. This makes it DCHECK as soon as an element is added that already has a "next" value set. Change-Id: I720ff6100d8d43e264726039ddaf97c205a5062f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872391 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Victor Gomes authored
This is a reland of c48096d4 Original change's description: > Reland "[runtime] Remove extension slots from context objects" > > This is a reland of c07c02e1 > > Original change's description: > > [runtime] Remove extension slots from context objects > > > > Context objects have an extension slot, which contains further > > additional data that depends on the type of the context. > > > > This CL removes the extension slot from contexts that don't need > > them, hence reducing memory. > > > > The following contexts will still have an extension slot: native, > > module, await, block and with contexts. See objects/contexts.h for > > what the slot is used for. > > The following contexts will not have an extension slot anymore (they > > were not used before): script, catch and builtin contexts. > > Eval and function contexts only have the extension slot if they > > contain a sloppy eval. > > > > Bug: v8:9744 > > Change-Id: I8ca56c22fa02437bbac392ea72174ebfca80e030 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863191 > > Commit-Queue: Victor Gomes <victorgomes@google.com> > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > > Auto-Submit: Victor Gomes <victorgomes@google.com> > > Cr-Commit-Position: refs/heads/master@{#64372} > > TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org > > Bug: v8:9744 > Change-Id: I0749cc2d8f59940c25841736634a70047116d647 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869192 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Auto-Submit: Victor Gomes <victorgomes@google.com> > Cr-Commit-Position: refs/heads/master@{#64380} TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org Bug: v8:9744 Change-Id: I621ffe98722f8c4defaf277b8d1666484ba2963f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872400Reviewed-by:
-
Georg Neis authored
... and make the printing more consistent. Bug: v8:9518 Change-Id: I6e8b595124974ec7f8e5003624bd33d2b0787ac0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864948Reviewed-by:
-
Tobias Tebbi authored
Name mangling is hard to get right and not easy to read. This CL replaces the remaining name mangling of types and generics with simpler names that are not always unique, but then fixes them up by appending a unique counter. For struct types, this required an @export annotation since we use some struct types in CSA. Drive-by-fixes: - Overwrite the copy constructor of Type to clear the list of alias names when creating a new type. - Change the existing append-a-number scheme to have different counters for each name. This the number of changed names when adding something and is more readable. Bug: v8:7793 Change-Id: Ied11ea1a251130f4562ddc0d81967368349e0bf6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866650 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
lybvinci authored
When is_component_build is true, cctest will compile error, because the dependencies is not exported.these files will failed:test-utils -arm64.cc,test-strings.cc. Change-Id: I4bcdde08199f21454ec6d7e230d9d096c0315eac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873447Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#64448}
-
