- 27 Oct, 2017 10 commits
-
-
Michal Majewski authored
This is a reland of 5442e8b2 Original change's description: > Reland "Reuse arch/mode discovery in deopt fuzzer" > > This is a reland of a24c7c9a > Original change's description: > > Reuse arch/mode discovery in deopt fuzzer > > > > Bug: v8:6917 > > Change-Id: I1b7169c8702c8649812b17579d38d64de676ed60 > > Reviewed-on: https://chromium-review.googlesource.com/723420 > > Commit-Queue: Michał Majewski <majeski@google.com> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48838} > > Bug: v8:6917 > Change-Id: I03b2c288257d44c2df9d0fa6cf4750d1c5719d59 > Reviewed-on: https://chromium-review.googlesource.com/735719 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48916} Bug: v8:6917 Change-Id: I81419466d359b786c2a1b3a9aad3a86ed136f6f0 Reviewed-on: https://chromium-review.googlesource.com/738252Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#48997}
-
Igor Sheludko authored
This should avoid changes in code serializer in a follow-up class literals improvement CL. Bug: v8:5799 Change-Id: I4e4386333bcc7abb30399d4e9abba4eee80ca932 Reviewed-on: https://chromium-review.googlesource.com/733037 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#48996}
-
Clemens Hammacher authored
This adds two tests to verify that the --liftoff flag has the indented effect, and that Liftoff compilation is off by default. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ie7e13184b5068f572b78dbdf7abbcded6d859fc5 Reviewed-on: https://chromium-review.googlesource.com/733561 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48995}
-
Benedikt Meurer authored
We now represent the SameValue operation explicitly in TurboFan and the operation can thus participate in all kinds of optimizations. Especially we get rid of the JSCall node in the general case, which blocks several optimizations across the call. The general, baseline performance is now always on par with StrictEqual. Once the StrictEqual operator is also a simplified operator, we should start unifying the type based optimizations in SimplifiedLowering. In the micro-benchmark we go from testStrictEqual: 1422 ms. testObjectIs: 1520 ms. testManualSameValue: 1759 ms. to testStrictEqual: 1426 ms. testObjectIs: 1357 ms. testManualSameValue: 1766 ms. which gives the expected result. Bug: v8:7007 Change-Id: I0de3ff6ff6209ab4c3edb69de6a16e387295a9c8 Reviewed-on: https://chromium-review.googlesource.com/741228Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48994}
-
Georg Neis authored
... and use them to complete the BigInt function. Bug: v8:6791 Change-Id: Ia36db86b92d1a0cfcb783516e04d6c0e3750f194 Reviewed-on: https://chromium-review.googlesource.com/737643 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48993}
-
Georg Neis authored
R=jkummerow@chromium.org Bug: v8:6791 Change-Id: I9eb5b9aeeb060d660ec41b7a3287089edd833197 Reviewed-on: https://chromium-review.googlesource.com/737796Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#48992}
-
Jakob Kummerow authored
Bug: v8:6791, v8:6995 Change-Id: I79d04d9e8fbe156570875e3ecc2a1a87c9a794ee Reviewed-on: https://chromium-review.googlesource.com/740918Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48991}
-
Jaroslav Sevcik authored
This enables proper wiring into ithe control flow chain. Bug: v8:7002,chromium:777574 Change-Id: Idba59944ff6ab3c10c204bb74ace61d812e6297c Reviewed-on: https://chromium-review.googlesource.com/738183Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48990}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f034b7d..e1ba03b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5da4837..52d748d Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/fb9e0ad..4ea1d22 TBR=machenbach@chromium.org,hablich@chromium.org Change-Id: Ifc6d7a2335abbff46a8e304067e26d101b90064d Reviewed-on: https://chromium-review.googlesource.com/741243Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#48989}
-
Camillo Bruni authored
This is an intermediate CL to move the complete --trace-map infrastructure to a log-based version. Change-Id: I0673052b1b87fe338e38dc609434a52af6a0652d Reviewed-on: https://chromium-review.googlesource.com/738835 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48988}
-
- 26 Oct, 2017 30 commits
-
-
Alexei Filippov authored
This is a reland of c34042cc Original change's description: > [heap-profiler] Do not treat WeakMap values as weak. > > For the WeakHashTable objects only mark keys as weak while leaving values as strong references. > > BUG=chomium:773722 > > Change-Id: Iabd5ba293d05fe68a2af6503fcdd711ecc182482 > Reviewed-on: https://chromium-review.googlesource.com/730771 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48985} TBR=ulan@chromium.org Bug: chomium:773722 Change-Id: Icede16fde528d147cde5c3f6c72f2029876b099f Reviewed-on: https://chromium-review.googlesource.com/740722Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#48987}
-
Alexei Filippov authored
This reverts commit c34042cc. Reason for revert: Wrong table type was used Original change's description: > [heap-profiler] Do not treat WeakMap values as weak. > > For the WeakHashTable objects only mark keys as weak while leaving values as strong references. > > BUG=chomium:773722 > > Change-Id: Iabd5ba293d05fe68a2af6503fcdd711ecc182482 > Reviewed-on: https://chromium-review.googlesource.com/730771 > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48985} TBR=ulan@chromium.org,alph@chromium.org,mlippautz@chromium.org Change-Id: Ia2ddef5b2422d4cbb8c4710e24ed0885a9a5b284 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chomium:773722 Reviewed-on: https://chromium-review.googlesource.com/740721Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#48986}
-
Alexei Filippov authored
For the WeakHashTable objects only mark keys as weak while leaving values as strong references. BUG=chomium:773722 Change-Id: Iabd5ba293d05fe68a2af6503fcdd711ecc182482 Reviewed-on: https://chromium-review.googlesource.com/730771 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48985}
-
Bill Budge authored
Bug:chromium:756050 Change-Id: Ib65c9c4c19266eb1c6119367397be0769cfcc7a1 TBR=ulan@chromium.org Change-Id: Ib65c9c4c19266eb1c6119367397be0769cfcc7a1 Reviewed-on: https://chromium-review.googlesource.com/740083Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#48984}
-
Leszek Swirski authored
Add the --trace-feedback-updates flag (disabled by default, enabled by the v8_enable_trace_feedback_updates gn arg), which traces updates to feedback slots. Change-Id: Ib8f02f958e2adf04abda5d4ed680e29fa04895ab Reviewed-on: https://chromium-review.googlesource.com/725814Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#48983}
-
Georg Neis authored
Bug: v8:6791 Change-Id: I10bb316284ba3a0e326daad4f9b995f88d76c2a2 Reviewed-on: https://chromium-review.googlesource.com/739501Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#48982}
-
Bill Budge authored
- Moves base::OS memory management calls into platform-posix.cc, using preprocessor to adjust for each platform. Bug: chromium:756050 Change-Id: I2af4dce4379ad1fe9e22e5ab5c6d6a7faa3655b3 Reviewed-on: https://chromium-review.googlesource.com/738890 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48981}
-
Toon Verwaest authored
This reverts commit cb84b6f6. Reason for revert: <INSERT REASONING HERE> Original change's description: > [lazy-accessor-pairs] Don't take the fast paths if the context needs to be switched > > This works in the ICs since compiled handlers are not shared anymore. > > As drive-by cleanup I also removed custom code to deal with compiled handler sharing for primitive and access-checked objects. > > Bug: chromium:759734 > Change-Id: Ifb394221c2398f42ea9305acc02845db6004c680 > Reviewed-on: https://chromium-review.googlesource.com/738381 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48979} TBR=jarin@chromium.org,ishell@chromium.org,verwaest@chromium.org Change-Id: I9b7424252cbc3f18efd6b6b5b3818651c2863f5c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:759734 Reviewed-on: https://chromium-review.googlesource.com/739487Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#48980}
-
Toon Verwaest authored
This works in the ICs since compiled handlers are not shared anymore. As drive-by cleanup I also removed custom code to deal with compiled handler sharing for primitive and access-checked objects. Bug: chromium:759734 Change-Id: Ifb394221c2398f42ea9305acc02845db6004c680 Reviewed-on: https://chromium-review.googlesource.com/738381 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#48979}
-
Igor Sheludko authored
Rename |property_attributes| to |initial_property_attributes| and ensure that it is used as a storage of values only for AccessorInfos installed in API Templates (i.e. ObjectTemplate and FunctionTemplate). When an AccessorInfo is installed directly into an existing JS object (via JSObject::SetAccessor) or into a DescriptorArray (when certain V8 objects' shapes are configured) it is not necessary to thread attributes being set through the AccessorInfo instance. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ibe61026f08c42549756f694129a286635ffe5769 Reviewed-on: https://chromium-review.googlesource.com/730425 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#48978}
-
jgruber authored
This is the first step towards lazy-deserializing bytecode handlers. Bytecode handler code objects are now serialized into the builtins snapshot area (which, like many other related concepts, has become somewhat of a misnomer now that it contains both builtins and handlers). Handlers are still eagerly-deserialized upon Isolate creation. This will change in follow-up CLs. Bug: v8:6624 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I7b257f76f5e9e90d5f7b183980bae7bc621171fc Reviewed-on: https://chromium-review.googlesource.com/738030 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#48977}
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: Ia312b8c6ca8608f8ac96e8caefd061900b40079b Reviewed-on: https://chromium-review.googlesource.com/739481Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48976}
-
Daniel Clifford authored
Bug: chromium:778574 Change-Id: I014b16b9deabab07ca7dfb662ea8cb0dbf9c8987 Reviewed-on: https://chromium-review.googlesource.com/738148 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48975}
-
Ulan Degenbaev authored
This fixes jumbo build by renaming Pseudorandom function after https://chromium-review.googlesource.com/738204 Bug: chromium:777177 Change-Id: I86aa403928ad85ddd7dd779a8a43af9e34161928 Reviewed-on: https://chromium-review.googlesource.com/737637Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48974}
-
Michael Starzinger authored
R=ulan@chromium.org Change-Id: I1ce0dbe909ffe3da784d5196e1c1d89f322f05c3 Reviewed-on: https://chromium-review.googlesource.com/739321Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48973}
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: I2bf361cab6da5e57302fb83d384b5f7e8e847c9a Reviewed-on: https://chromium-review.googlesource.com/738145Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48972}
-
Michael Starzinger authored
This moves the initialization of the {Code::stub_key} field into the allocator for {Code} objects, essentially making the field in question immutable after allocation. R=verwaest@chromium.org BUG=v8:6792 Change-Id: I8ba2ffeea792d0d566995c08e3572ae63a7c1e94 Reviewed-on: https://chromium-review.googlesource.com/739141 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#48971}
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: I7a458991921b5241c11db8999be433f4b33ce639 Reviewed-on: https://chromium-review.googlesource.com/738144Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48970}
-
Junliang Yan authored
Bug: Change-Id: I4ea086564ff4a7782c0c1bc232d9929fd73fd9f6 Reviewed-on: https://chromium-review.googlesource.com/738537Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#48969}
-
Michael Starzinger authored
R=ulan@chromium.org Change-Id: I141daeffde426a75293ffa0565c867d73a81cbfc Reviewed-on: https://chromium-review.googlesource.com/738776Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48968}
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: If91b709779912c37b88f3c57e46f7910b59cc240 Reviewed-on: https://chromium-review.googlesource.com/737870 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48967}
-
Michael Starzinger authored
This move the {Code::next_code_link} into the data container, making it possible to mutate the field even when {Code} objects are protected. It also introduces a dedicated body descriptor for the container allowing for tagged fields to be part of the container. R=ulan@chromium.org BUG=v8:6792 Change-Id: I56a9d53e8bb35aeb0a7036e3abf3ebee1ba2928d Reviewed-on: https://chromium-review.googlesource.com/738184 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48966}
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: I1bb1e47ebf16e55e63ed4bbd9ce9eb0c01e8b754 Reviewed-on: https://chromium-review.googlesource.com/735440 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#48965}
-
Daniel Bevenius authored
This commit changes the pararmeter names in the comment for NewConsString which currently do not match the actual parameter names in the function definition or the declaration in code-stub-assembler.cc. Bug: Change-Id: I162a2027cc37512de8a09e520a1fb13c9445fa97 Reviewed-on: https://chromium-review.googlesource.com/657017Reviewed-by: Daniel Clifford <danno@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#48964}
-
Peter Marshall authored
Bug: v8:6992 Change-Id: I7b440e5fba9d86cca5b96438a31023580ad7dba2 Reviewed-on: https://chromium-review.googlesource.com/738229 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#48963}
-
Ulan Degenbaev authored
Both the top_ pointer and the top_on_previous_step_ pointer can be one byte beyond the current page. Page::FromAddress call should take that into account. Bug: chromium:777177 Change-Id: I9cbb5bc6eab932afc6d0c915fd70a9a7b20ba62c Reviewed-on: https://chromium-review.googlesource.com/738204 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#48962}
-
Michael Starzinger authored
R=leszeks@chromium.org Change-Id: I74ea24beb97976674891d869cbcad341c1eb4a05 Reviewed-on: https://chromium-review.googlesource.com/737996Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48961}
-
Michał Majewski authored
This reverts commit 5442e8b2. Reason for revert: https://crbug.com/v8/7006 Original change's description: > Reland "Reuse arch/mode discovery in deopt fuzzer" > > This is a reland of a24c7c9a > Original change's description: > > Reuse arch/mode discovery in deopt fuzzer > > > > Bug: v8:6917 > > Change-Id: I1b7169c8702c8649812b17579d38d64de676ed60 > > Reviewed-on: https://chromium-review.googlesource.com/723420 > > Commit-Queue: Michał Majewski <majeski@google.com> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48838} > > Bug: v8:6917 > Change-Id: I03b2c288257d44c2df9d0fa6cf4750d1c5719d59 > Reviewed-on: https://chromium-review.googlesource.com/735719 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48916} TBR=machenbach@chromium.org,majeski@google.com Change-Id: Ibbc16bb7115c8e8b93bd8f39065742d3c2d7739f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917, v8:7006 Reviewed-on: https://chromium-review.googlesource.com/737807 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48960}
-
Michał Majewski authored
This reverts commit 697b2c09. Reason for revert: <INSERT REASONING HERE> Original change's description: > Setting up the environment for testrunner refactored > > Bug: v8:6917 > Change-Id: Ibc3c738ef807d37d8b76f440d9765c4d0405c021 > Reviewed-on: https://chromium-review.googlesource.com/735421 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48923} TBR=machenbach@chromium.org,majeski@google.com Change-Id: Iafb29f1f13decc6e6ed00ed6e815008fcde1dc44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917 Reviewed-on: https://chromium-review.googlesource.com/737635Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48959}
-
Georg Neis authored
R=jkummerow@chromium.org Bug: Change-Id: I2aaf7160f874985374b7b975912bf93261fdef4d Reviewed-on: https://chromium-review.googlesource.com/737831 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#48958}
-