- 20 Jun, 2018 19 commits
-
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: v8:7187 Change-Id: I9c64d637501f074464b1fe3637df50be447603ab Reviewed-on: https://chromium-review.googlesource.com/1098934 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53875}
-
Yang Guo authored
This reverts commit 9d406a02. Reason for revert: Layout Test failures: https://ci.chromium.org/buildbot/client.v8.fyi/V8-Blink%20Linux%2064/24236 Original change's description: > Reland "[array] Change QuickSort to TimSort for Array.p.sort" > > This is a reland of 6bb82368 > > Original change's description: > > [array] Change QuickSort to TimSort for Array.p.sort > > > > Bug: v8:7382 > > Change-Id: I7f125a62867eb586d2720a2c641fb5f4012b284d > > Reviewed-on: https://chromium-review.googlesource.com/1100881 > > Commit-Queue: Simon Zünd <szuend@google.com> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#53838} > > Bug: v8:7382 > Change-Id: I499d782feaeb36df154e00a11d3b03cd41442347 > Reviewed-on: https://chromium-review.googlesource.com/1107497 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Simon Zünd <szuend@google.com> > Cr-Commit-Position: refs/heads/master@{#53864} TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com Change-Id: I877834301d98174b148e42dee42f598a62c544de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7382 Reviewed-on: https://chromium-review.googlesource.com/1107757Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53874}
-
Dan Elphick authored
Replace all implicit Handle<T>(T*) constructors in src/bootstrapper.cc with explicit ones that use a local variable or parameter. (All done using Leszek's awesome new tool!) Bug: v8:7786 Change-Id: Iec01fda502dd121bc1815d5dab73bd09bb3e5aa6 Reviewed-on: https://chromium-review.googlesource.com/1107697Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53873}
-
Creddy authored
This is a reland of 380dba0a Original change's description: > [runtime][gc] Drop AllocationSite::weak_next field for sub-literals > > Use AllocationSite without Weaknext field for all the allocations in nested > literal except for Root. The nested field is sufficient to link all the > allocations in a nested literal. Only the Root is added to heap weak_alloc_list > for GC to traverse > > Change-Id: I946e63292c6d168197cd2a087f697c73cc431272 > Reviewed-on: https://chromium-review.googlesource.com/1101323 > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53813} Change-Id: Ic451fb3600b87f8f69748b1659ff89a80c9322fa Reviewed-on: https://chromium-review.googlesource.com/1106257Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Chandan Reddy <chandanreddy@google.com> Cr-Commit-Position: refs/heads/master@{#53872}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ic16e1da4ca50070ceff7f9a441250db2d20a868f Reviewed-on: https://chromium-review.googlesource.com/1104471 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53871}
-
Georg Neis authored
There's no need to assume anything when we don't reduce the node. R=bmeurer@chromium.org Change-Id: Ic39b6e634c662824a72affd91318ca024f3e1055 Reviewed-on: https://chromium-review.googlesource.com/1105832Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53870}
-
Leszek Swirski authored
Fix assumption that only top level code won't have outer scope infos. Bug: v8:7690 Change-Id: Ia6eec7b406632ad301e7db557597204c7ca66730 Reviewed-on: https://chromium-review.googlesource.com/1107622Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#53869}
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I6a6347d7394ddeacbb185a2e6e5187898bfca2dc Reviewed-on: https://chromium-review.googlesource.com/1106173Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#53868}
-
Théotime Grohens authored
This CL adds a constexpr int31 == operator that returns a constexpr bool value. It also fixes a bug that this introduces because branch generation for ternary operators incorrectly assumed that the condition value was bool, whereas it can also be constexpr bool now. Change-Id: Ie7d3497c9d1112c121b4a29561fe065b5bf01fb6 Reviewed-on: https://chromium-review.googlesource.com/1106343Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#53867}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:854503 Change-Id: I07ae21bee95c2ef781824c6b98929ceb3786b1dd Reviewed-on: https://chromium-review.googlesource.com/1107559Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#53866}
-
Georg Neis authored
This is in order to check if we can get rid of the cache. Bug: v8:7790 Change-Id: Id6625ffc440665b090f999564b006506f947ae45 Reviewed-on: https://chromium-review.googlesource.com/1107620Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53865}
-
Simon Zünd authored
This is a reland of 6bb82368 Original change's description: > [array] Change QuickSort to TimSort for Array.p.sort > > Bug: v8:7382 > Change-Id: I7f125a62867eb586d2720a2c641fb5f4012b284d > Reviewed-on: https://chromium-review.googlesource.com/1100881 > Commit-Queue: Simon Zünd <szuend@google.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53838} Bug: v8:7382 Change-Id: I499d782feaeb36df154e00a11d3b03cd41442347 Reviewed-on: https://chromium-review.googlesource.com/1107497Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#53864}
-
Georgia Kouveli authored
We can instead pass the deopt id in a register, where before we were passing the deopt entry address. This removes the need for the deopt tables altogether, saving 192kB. Change-Id: I479d4de1a0245de328720b6b03a1955c8c63f696 Reviewed-on: https://chromium-review.googlesource.com/1076472Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#53863}
-
Georg Neis authored
Also fix an oversight in my previous CL. R=jarin@chromium.org Bug: v8:7790 Change-Id: I61c783392b7b7b38ea28dc44dc1e932d15b55bc6 Reviewed-on: https://chromium-review.googlesource.com/1106170Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53862}
-
Yang Guo authored
GCC 4.9 used on some Node.js CI machines complains when the control reaches the end of a non-void function and no return is encountered. R=bmeurer@google.com, ofrobots@google.com, yangguo@google.com Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I5af0192cb187eccbf34dbb60ff3ac2e4774af803 Reviewed-on: https://chromium-review.googlesource.com/1105619Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53861}
-
Clemens Hammacher authored
The reference to the {NativeModule} (stored in a {Managed}) should live on the {WasmModuleObject}, not on the individual {WasmCompiledModule} objects. R=titzer@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I21dfa088c9643d36d9fd5052a145e7e2af5e47f9 Reviewed-on: https://chromium-review.googlesource.com/1106380 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53860}
-
Michael Achenbach authored
TBR=santa Bug: chromium:854503 Change-Id: I88ae0256b74cbc62df6ef81069d55eb894171a35 Reviewed-on: https://chromium-review.googlesource.com/1107064Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53859}
-
Clemens Hammacher authored
The {ModuleEnv} already contains a pointer to the {WasmModule}, no need to pass it explicitly. R=titzer@chromium.org Change-Id: Icf0e8ea8b25c33dd5bcaeab2a4a746376e73813d Reviewed-on: https://chromium-review.googlesource.com/1105828 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53858}
-
Clemens Hammacher authored
Our tests currently don't set {WasmModule::num_declared_functions} correctly. This CL fixes that. This enables the use of {WasmModule::num_declared_functions} instead of {NativeModule::num_functions_ - NativeModule::num_imported_functions_}. Drive-by: Fix {std::vector} reservation to reserve enough space for all functions during decoding. R=titzer@chromium.org Change-Id: I6d7783aed1c0de3275fc72787dec17c38ff8c73b Reviewed-on: https://chromium-review.googlesource.com/1106166 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53857}
-
- 19 Jun, 2018 21 commits
-
-
Junliang Yan authored
Port 825c7481 R=tebbi@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: If067828166e44b99f48add7e929d6be8b585f34b Reviewed-on: https://chromium-review.googlesource.com/1106877Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53856}
-
Bill Budge authored
This reverts commit 21c0d77e. Reason for revert: Compile failure in bootstrapper.cc Original change's description: > [async] Optimize await and AsyncFromSyncIterator > > Simplify the promise wrapping in await and > %AsyncFromSyncIteratorPrototype%.next/return/throw to reuse the PromiseResolve > primitive. Now await takes 1 tick instead of 3 on the microtask queue. > > Change-Id: I7e99b8689eb8fcb09c48915b11c1e06684dc0f1a > Reviewed-on: https://chromium-review.googlesource.com/1090272 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53853} TBR=kozyatinskiy@chromium.org,littledan@chromium.org,gsathya@chromium.org,bmeurer@chromium.org,domenic@chromium.org,mathias@chromium.org,mslekova@chromium.org Change-Id: Ia631acdfcd5c1f9c28c1540c8da16cdf076abf87 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1106566Reviewed-by: Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#53855}
-
Junliang Yan authored
Change-Id: I3aa30ac6a04b914cdd278a9c016467296a42ef8f Reviewed-on: https://chromium-review.googlesource.com/1105058Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53854}
-
Maya Lekova authored
Simplify the promise wrapping in await and %AsyncFromSyncIteratorPrototype%.next/return/throw to reuse the PromiseResolve primitive. Now await takes 1 tick instead of 3 on the microtask queue. Change-Id: I7e99b8689eb8fcb09c48915b11c1e06684dc0f1a Reviewed-on: https://chromium-review.googlesource.com/1090272 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53853}
-
Junliang Yan authored
Port 733b7c82 Original Commit Message: This introduces the concept of a jump table for WebAssembly, which is used for every direct and indirect call to any WebAssembly function. For lazy compilation, it will initially contain code to call the WasmCompileLazy builtin, where it passes the function index to be called. For non-lazy-compilation, it will contain a jump to the actual code. The jump table allows to easily redirect functions for lazy compilation, tier-up, debugging and (in the future) code aging. After this CL, we will not need to patch existing code any more for any of these operations. R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= v8:7758 Change-Id: I1a370910ffa56dbdd609be6922067842a6adf1df Reviewed-on: https://chromium-review.googlesource.com/1105060 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53852}
-
Dominik Inführ authored
Disables all optimizations for WeakMaps/WeakSets. Bug: chromium:844008 Change-Id: I5395ce981bbdd0e8e03ba0821103afde0889cf56 Reviewed-on: https://chromium-review.googlesource.com/1102513 Commit-Queue: Dominik Inführ <dinfuehr@google.com> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#53851}
-
Brian Stell authored
R=gsathya@chromium.org Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If842ab4850fc8d75bebb5331188ee237c5f1e9d7 Reviewed-on: https://chromium-review.googlesource.com/1097419Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Nebojša Ćirić <cira@chromium.org> Commit-Queue: Brian Stell <bstell@chromium.org> Cr-Commit-Position: refs/heads/master@{#53850}
-
Jakob Kummerow authored
This reverts commit 6bb82368. Reason for revert: breaks "nosnap" tests: CSA_ASSERT failure, array OOB read, see: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/19207 Original change's description: > [array] Change QuickSort to TimSort for Array.p.sort > > Bug: v8:7382 > Change-Id: I7f125a62867eb586d2720a2c641fb5f4012b284d > Reviewed-on: https://chromium-review.googlesource.com/1100881 > Commit-Queue: Simon Zünd <szuend@google.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53838} TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com Change-Id: I986ab4c3a65666bd06be086c1503d01b6e9e34b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7382 Reviewed-on: https://chromium-review.googlesource.com/1106717Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#53849}
-
Michael Starzinger authored
This removes special casing in the handling of {RelocInfo::CODE_TARGET} for cases where such references appeared in {WasmCode}. Such references can only appear in real {Code} objects and also only target real {Code} objects by now. R=clemensh@chromium.org Change-Id: I87c55c60cd6344bb67fa8c8d04b66fb523d07ba7 Reviewed-on: https://chromium-review.googlesource.com/1104680 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53848}
-
Clemens Hammacher authored
Direct jumps only work for offset up to 64 MB on arm. For longer jumps, use indirect branches (load target from constant pool into the pc register). R=mstarzinger@chromium.org CC=pierre.langlois@arm.com Bug: v8:7758 Change-Id: I1cf66b7d1bfb62cfcd6b1619c02816909a1f651e Reviewed-on: https://chromium-review.googlesource.com/1105996 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53847}
-
Michael Starzinger authored
This makes sure we use WebAssembly runtime stubs when performing value coercions in wrapper code that is compiled into {WasmCode}. It hence removes the last {RelocInfo::CODE_TARGET} references in {WasmCode}. R=clemensh@chromium.org BUG=v8:7424 Change-Id: Ic96e541abe98f90796a6506b09ff99557743b6f7 Reviewed-on: https://chromium-review.googlesource.com/1104462 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53846}
-
Georg Neis authored
This encapuslates some of the heap accesses done by JSNativeContextSpecialization::ReduceJSLoadGlobal and JSNativeContextSpecialization::ReduceJSStoreGlobal. Bug: v8:7790 Change-Id: Ib6c63903809927d6094af22519285cb9d0bbff7a Reviewed-on: https://chromium-review.googlesource.com/1106141Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53845}
-
Clemens Hammacher authored
After the removal of the --skip-compiling-wasm-funcs flag, this helper does not help that much any more, and contains unneeded logic. This CL just inlines the computation in the caller. R=titzer@chromium.org Bug: v8:7754 Change-Id: I99cf006ffe9c33d79bea2ce186354c38bc63f6af Reviewed-on: https://chromium-review.googlesource.com/1105767Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53844}
-
Tobias Tebbi authored
Bug: chromium:849098 Change-Id: Iec81d08cf6edb6040445650cadf802a34b65b8e1 Reviewed-on: https://chromium-review.googlesource.com/1092749 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#53843}
-
Dan Elphick authored
Like Heap::InFromSpace, it doesn't use any members, so should be made static. Also clean up call sites to not call via a heap pointer. Change-Id: If55484ddac51351d789c73093f1f7ebf1c568bea Reviewed-on: https://chromium-review.googlesource.com/1088618Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53842}
-
Toon Verwaest authored
Change-Id: I5fd42cd70aaba15cfef32eea54232f8292aaa874 Reviewed-on: https://chromium-review.googlesource.com/1105775Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#53841}
-
Peter Marshall authored
Bug: chromium:854066 Change-Id: Icabd9bf5e00868822b9debfb9bbb5d3932726465 Reviewed-on: https://chromium-review.googlesource.com/1105774 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53840}
-
Théotime Grohens authored
This CL adds the incorrect return type of the conditional expression in 'if constexpr' conditionals to the error message displayed if the return type is different from 'constexpr bool'. Change-Id: I58be4c140fa6fc475dc907a9ec872005fcb7d839 Reviewed-on: https://chromium-review.googlesource.com/1105768Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#53839}
-
Simon Zünd authored
Bug: v8:7382 Change-Id: I7f125a62867eb586d2720a2c641fb5f4012b284d Reviewed-on: https://chromium-review.googlesource.com/1100881 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53838}
-
Théotime Grohens authored
This CL moves the ToBoolean function from data-view.tq to base.tq. It used to be in data-view.tq because we couldn't call macros from one file to the other but this has been fixed now, and it makes more sense to have it there. Change-Id: Id201979eacbeb4307ff7d515db48377490d5bed7 Reviewed-on: https://chromium-review.googlesource.com/1104683Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#53837}
-
Sigurd Schneider authored
This CL enables embedded builtins to get benchmark feedback. We need this feedback to identify and address remaining performance problems. Bug: v8:6666 Change-Id: I8f77f218e656b55ddabe1236eb2a1d14a5ac6233 Reviewed-on: https://chromium-review.googlesource.com/1105834Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53836}
-