- 10 Jul, 2015 11 commits
-
-
verwaest authored
BUG=chromium:507980 LOG=n Review URL: https://codereview.chromium.org/1234553002 Cr-Commit-Position: refs/heads/master@{#29570}
-
hablich authored
BUG= TBR=machenbach@chromium.org,vogelheim@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1235573002 Cr-Commit-Position: refs/heads/master@{#29569}
-
yangguo authored
If we do it too early, we might get a constant pool between the reloc info and the actual slot. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1229673005 Cr-Commit-Position: refs/heads/master@{#29568}
-
ishell authored
BUG=chromium:490021 LOG=N Review URL: https://codereview.chromium.org/1235563002 Cr-Commit-Position: refs/heads/master@{#29567}
-
epertoso authored
Review URL: https://codereview.chromium.org/1230173002 Cr-Commit-Position: refs/heads/master@{#29566}
-
ulan authored
BUG=chromium:508584 LOG=NO Review URL: https://codereview.chromium.org/1230163002 Cr-Commit-Position: refs/heads/master@{#29565}
-
bmeurer authored
EnumtSet has been deprecated for quite some time, and replaced with the more general and type safe base::Flags template class. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1229233002 Cr-Commit-Position: refs/heads/master@{#29564}
-
machenbach authored
BUG=v8:4279 LOG=n NOTRY=true TBR=jarin@chromium.org Review URL: https://codereview.chromium.org/1235493005 Cr-Commit-Position: refs/heads/master@{#29563}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1213623020 Cr-Commit-Position: refs/heads/master@{#29562}
-
yangguo authored
Break point at calls are currently set via IC. To change this, we need to set debug break slots instead. We also need to distinguish those debug break slots as calls to support step-in. To implement this, we add a data field to debug break reloc info to indicate non-call debug breaks or in case of call debug breaks, the number of arguments. We can later use this to find the callee on the evaluation stack in Debug::PrepareStep. BUG=v8:4269 R=ulan@chromium.org LOG=N Review URL: https://codereview.chromium.org/1222093007 Cr-Commit-Position: refs/heads/master@{#29561}
-
machenbach authored
BUG=v8:4279 LOG=n NOTRY=true TBR=jarin@chromium.org Review URL: https://codereview.chromium.org/1233603002 Cr-Commit-Position: refs/heads/master@{#29560}
-
- 09 Jul, 2015 14 commits
-
-
adamk authored
When running without a snapshot, the GlobalEval function gets lazy compiled. By the time we compile it, its name is "eval", which causes the parser to choke (functions named "eval" aren't allowed in strict mode!). Instead, we now always skip checking the function name when lazy-parsing, as the name has already been checked appropriately by the preparser. Also cleaned up other cases that don't require name checking by introducing FunctionNameValidity enum and passing appropriate values throughout the parser and preparser. This lets us pass an additional 18 test262 tests. BUG=v8:4198 LOG=n Review URL: https://codereview.chromium.org/1227093005 Cr-Commit-Position: refs/heads/master@{#29559}
-
arv authored
Instead of updating the SharedFuntionInfo set the name property on the function directly. BUG=v8:4278 LOG=N R=verwaest@chromium.org, littledan@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1227523003 Cr-Commit-Position: refs/heads/master@{#29558}
-
binji authored
When quit() is called, d8 shell exits without cleanup. If a worker is running, it might be holding the context_mutex_, which if destroyed will DCHECK. BUG=4279 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1231473002 Cr-Commit-Position: refs/heads/master@{#29557}
-
arv authored
The function returned from Function.prototype.bind should have the same [[Prototype]] as the receiver. BUG=v8:3889 LOG=N R=adamk@chromium.org, verwaest@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1217603005 Cr-Commit-Position: refs/heads/master@{#29556}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#29555}
-
machenbach authored
TBR=bmeurer@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1228073002 Cr-Commit-Position: refs/heads/master@{#29554}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#29553}
-
bmeurer authored
This basically means that we must not use the b(Label*) version here, but the b(int) version instead to jump over the constant pool. BUG=v8:4292 LOG=y Review URL: https://codereview.chromium.org/1224243002 Cr-Commit-Position: refs/heads/master@{#29552}
-
rmcilroy authored
Review URL: https://codereview.chromium.org/1225683010 Cr-Commit-Position: refs/heads/master@{#29551}
-
bmeurer authored
The b, bl and blx methods that take labels basically ignore the constant pool check and just block the constant pool for the next instruction. This way a long enough sequence of those instructions will block can potentially block the constant pool emission for too long. BUG=v8:4292 LOG=y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1223093004 Cr-Commit-Position: refs/heads/master@{#29550}
-
yangguo authored
R=mstarzinger@chromium.org BUG=chromium:507977 LOG=N Review URL: https://codereview.chromium.org/1230653004 Cr-Commit-Position: refs/heads/master@{#29549}
-
rmcilroy authored
Use NumAllocatableRegisters() instead of kMaxNumAllocatableRegisters in ArchDefaultRegisterConfiguration::ArchDefaultRegisterConfiguration() otherwise the compiler DCHECKS if triggered during snapshot builds on Arm where only 16 DoubleRegisters are avaiable instead of 32. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1230473006 Cr-Commit-Position: refs/heads/master@{#29548}
-
bmeurer authored
That parameter is just confusing and completely unused. Review URL: https://codereview.chromium.org/1228763003 Cr-Commit-Position: refs/heads/master@{#29547}
-
yangguo authored
The invariant is that as long as there is a debug info on the shared function info, no accessor IC is compiled for its code. That way we can guarantee that stepping into accessors, which requires a debug info, works for accessors. Review URL: https://codereview.chromium.org/1220283009 Cr-Commit-Position: refs/heads/master@{#29546}
-
- 08 Jul, 2015 15 commits
-
-
littledan authored
The breakage to Chrome seems to be based on @@isConcatSpreadable and turning that part off with this patch fixes the Maps Tips & Tricks test case. BUG=chromium:507553 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1226063002 Cr-Commit-Position: refs/heads/master@{#29545}
-
adamk authored
Revert of [turbofan] Optimize string "length" property access based on types. (patchset #2 id:20001 of https://codereview.chromium.org/1216593003/) Reason for revert: Causes crash when running benchmarks/octane/regexp.js on ARM: http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2492/steps/Benchmarks/logs/regexp Original issue's description: > [turbofan] Optimize string "length" property access based on types. > > Optimize string "length" property access based on static type > information if possible, but also optimistically optimize the access > based on type feedback from the LoadIC. > > R=jarin@chromium.org > > Committed: https://crrev.com/17add22ff4b9c5ca638502e7708f0d9d99baca40 > Cr-Commit-Position: refs/heads/master@{#29543} TBR=mstarzinger@chromium.org,jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1224083002 Cr-Commit-Position: refs/heads/master@{#29544}
-
bmeurer authored
Optimize string "length" property access based on static type information if possible, but also optimistically optimize the access based on type feedback from the LoadIC. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1216593003 Cr-Commit-Position: refs/heads/master@{#29543}
-
mbrandy authored
Port 8f13b655 Original commit message: - Add a TurboFanIC class, derived from TurboFanCodeStub, that automatically distinguishes between versions of the IC called from optimized and unoptimized code. - Add appropriate InterfaceDescriptors for both the versions of the stub called from unoptimized and optimized code - Change the MathFloor TF stub generator to output either the for-optimized or for-unoptimized version based on the minor_key parameter. R=danno@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1207253003 Cr-Commit-Position: refs/heads/master@{#29542}
-
binji authored
This one occurred when serializing an object. When the property getter threw an exception, that value was skipped, but the property count wasn't updated. The deserializer then tried to deserialize the wrong value. BUG=chromium:506549 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1220193004 Cr-Commit-Position: refs/heads/master@{#29541}
-
caitpotter88 authored
BUG=508074 LOG=N R=arv@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1222713013 Cr-Commit-Position: refs/heads/master@{#29540}
-
danno authored
- Add a TurboFanIC class, derived from TurboFanCodeStub, that automatically distinguishes between versions of the IC called from optimized and unoptimized code. - Add appropriate InterfaceDescriptors for both the versions of the stub called from unoptimized and optimized code - Change the MathFloor TF stub generator to output either the for-optimized or for-unoptimized version based on the minor_key parameter. Committed: https://crrev.com/8f13b655b8a10dae2116dd18b32f09337bb2d410 Cr-Commit-Position: refs/heads/master@{#29534} Review URL: https://codereview.chromium.org/1225943002 Cr-Commit-Position: refs/heads/master@{#29539}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1214673007 Cr-Commit-Position: refs/heads/master@{#29538}
-
machenbach authored
BUG=chromium:508074 LOG=n NOTREECHECKS=true NOTRY=true TBR=ishell@chromium.org Review URL: https://codereview.chromium.org/1215023016 Cr-Commit-Position: refs/heads/master@{#29537}
-
arv authored
Allow let in sloppy mode with --harmony-sloppy Allow ES'15 const in sloppy mode with --harmony-sloppy --no-legacy-const Functions in block are not done yet. They are only let bound in the block at this point. BUG=v8:3305, v8:2198 LOG=N R=littledan@chromium.org, rossberg@chromium.org, adamk@chromium.org Review URL: https://codereview.chromium.org/1219853004 Cr-Commit-Position: refs/heads/master@{#29536}
-
danno authored
Revert of Add unoptimized/optimized variants of MathFloor TF code stub (patchset #4 id:60001 of https://codereview.chromium.org/1225943002/) Reason for revert: Failure on compiling runtime.js on windows Original issue's description: > Add unoptimized/optimized variants of MathFloor TF code stub > > - Add a TurboFanIC class, derived from TurboFanCodeStub, that > automatically distinguishes between versions of the IC called from > optimized and unoptimized code. > - Add appropriate InterfaceDescriptors for both the versions of the > stub called from unoptimized and optimized code > - Change the MathFloor TF stub generator to output either the > for-optimized or for-unoptimized version based on the minor_key > parameter. > > Committed: https://crrev.com/8f13b655b8a10dae2116dd18b32f09337bb2d410 > Cr-Commit-Position: refs/heads/master@{#29534} TBR=mvstanton@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1220783006 Cr-Commit-Position: refs/heads/master@{#29535}
-
danno authored
- Add a TurboFanIC class, derived from TurboFanCodeStub, that automatically distinguishes between versions of the IC called from optimized and unoptimized code. - Add appropriate InterfaceDescriptors for both the versions of the stub called from unoptimized and optimized code - Change the MathFloor TF stub generator to output either the for-optimized or for-unoptimized version based on the minor_key parameter. Review URL: https://codereview.chromium.org/1225943002 Cr-Commit-Position: refs/heads/master@{#29534}
-
mbrandy authored
Port 4b38c158 Original commit message: We actually need round to zero truncation to implement the counterpart of LDoubleToI in TurboFan, which tries to convert a double to an integer as required for keyed load/store optimizations. Drive-by-cleanup: Reduce some code duplication in the InstructionSelector implementations. R=bmeurer@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1220373003 Cr-Commit-Position: refs/heads/master@{#29533}
-
ishell authored
BUG=chromium:508074 LOG=N Review URL: https://codereview.chromium.org/1217493005 Cr-Commit-Position: refs/heads/master@{#29532}
-
machenbach authored
This prepares for making multiple measurements of one trace. For this, the suite/trace configurations need to be independent of the measurement instances. BUG=chromium:507213 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1227033002 Cr-Commit-Position: refs/heads/master@{#29531}
-