- 06 Nov, 2020 8 commits
-
-
Marja Hölttä authored
Do one, the other one was obsolete. Bug: v8:11074 Change-Id: I6f42aade9d6413f754ff5821ae9394045166eaa2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2521151Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#71004}
-
Nico Hartmann authored
Bug: v8:11074 Change-Id: I6d58d523254915a6b0d6542d8f80ddc6cee71dee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2520907Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#71003}
-
Clemens Backes authored
The inspector fuzzer is running into timeouts most of the time currently, because the test explicitly needs to quit execution. Make fuzzing more efficient by adding a watchdog thread which stop execution after 2 seconds. This will still result in valid test cases, i.e. everything that was executed within those two seconds will count as covered code. Drive-by: Slightly simplify the storage of task runners. No need to clear the vector after termination. R=szuend@chromium.org Bug: chromium:1142437, chromium:1145285 Change-Id: I7b5fe7ddcbce731fbc3d74ee8c43f7249f34b918 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2520906 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#71002}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/92c40db..dc348c1 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/98881a1..6302c11 Rolling v8/buildtools/linux64: git_revision:e002e68a48d1c82648eadde2f6aafa20d08c36f2..git_revision:53d92014bf94c3893886470a1c7c1289f8818db0 Rolling v8/third_party/aemu-linux-x64: uqYfh08DTmvjUgXl-HxNY1ptIb0KpyuY0I9MFaci9-AC..E6ldKaGAf4ys3koLahqmkG71_M2ITgf9doIhan2oKMEC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/888c272..b8b4d61 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/655afeb..91bb750 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8cd0fc1..e84c9a3 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4c43492..192a0ed TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I50d5bf3d254cee9af97d9775e170a97a931dbab8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2521440Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#71001}
-
Mythri A authored
DecideToPretenureDuringCompilation expects a particular number of allocation sites. So enable lazy feedback allocation always in the test. It is possible to make the test work for --no-lazy-feedback-allocation too, but the test already runs in a controlled environment by setting various flags so it is OK to enable lazy feeedback allocation to keep test simple Bug: v8:10219 Change-Id: I8b979b6df7e7cc27299704823ab691f96abe5431 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2521591Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#71000}
-
Vicky Kontoura authored
This CL addresses the behaviour of the tiering strategy for the case of the start function. The start function is currently called as an exported function, but never stored as one. This results in crashes if the start function tries to tier up (e.g. if the threshold for the tiering strategy is set to 1). Bug: v8:10982 Change-Id: Ic57d581022d84715621ce558988c6512c3200e30 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517698Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Vicky Kontoura <vkont@google.com> Cr-Commit-Position: refs/heads/master@{#70999}
-
Almothana Athamneh authored
This reverts commit 73ed5430. Reason for revert: The underlying change in GN that required the GN change is going to be out for a while so we will revert this change for now. Original change's description: > Disassociate runtime_deps from the stamp file > > Bug: v8:11102 > Change-Id: I40ce923a42097bf76a4b53c61bab1ef983523f64 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519557 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70968} TBR=machenbach@chromium.org,almuthanna@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:11102 Change-Id: Id5a1eccfc3d4b552ab0184d283dbcf8ce5ca4255 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2521912Reviewed-by:
-
Zhi An Ng authored
Bug: v8:11074 Change-Id: I7b34b6a647bf9ad317bdb97a344739302f892957 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519184Reviewed-by:
-
- 05 Nov, 2020 21 commits
-
-
Milad Fa authored
Power 9 offers new Vector Extract instructions which now can be used to implement Extract Lane opcodes. Change-Id: Ie81960a5cc9ca3f5af4bf248a720859951f43ed3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2521361Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#70996}
-
Z Nguyen-Huu authored
StringPrototypeTrim, StringPrototypeTrimStart, StringPrototypeTrimEnd Bug: v8:8996 Change-Id: Ic1155b072d7de888f81a739236d224d00ae46c79 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2511529 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#70995}
-
Michael Achenbach authored
This reverts commit 26f10ecd. Reason for revert: GC stress failures: https://crbug.com/v8/11114 Original change's description: > [torque] allow exported classes with custom C++ class > > Introduce a new annotation @customCppClass that can be used for > non-extern @export classes, that is, generate everything, remove > boilerplate from all the internal lists and switches, but allow > a custom C++ class, which in turn also allows overwriting the generated > print and verify functions. > > Port DescriptorArray and StrongDescriptorArray as an example. > > Bug: v8:7793 > Change-Id: I744e52fb4102ac49c0097f1c95bb17d301975bf0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2489687 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Reviewed-by: Seth Brenith <seth.brenith@microsoft.com> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70989} TBR=ulan@chromium.org,tebbi@chromium.org,seth.brenith@microsoft.com,nicohartmann@chromium.org Change-Id: I4631db66a76f41cf62b400e8ee64df27e641a320 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7793,v8:11114 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2521911Reviewed-by:
-
Mythri A authored
This cl implements tiering up support from Turboprop to TurboFan behind turboprop_as_midtier flag. More specifically: 1. Scales down the bytecode size when updating the interrupt budget in optimized code (TP / NCI). 2. Runtime profiler tiers up from TP->TF with --turboprop-as-midtier 3. Looks for the correct code kind when looking for optimized code in the feedback vector. 4. After servicing the optimization marker continues with mid-tier optimized code if it exists Bug: v8:9684 Change-Id: Iaf5783e75555c50c97901504fd122f62ff30be5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2480363 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Backes authored
This reverts commit 0147db5a. Reason for revert: Data races: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/34056 Original change's description: > [super] Optimize super property access in JSNativeContextSpecialization > > Generalize the existing property lookup machinery > (JSNCS::ReduceNamedAccess) to handle the case where the > lookup_start_object and the receiver are different objects. > > Design doc: https://docs.google.com/document/d/1b_wgtExmJDLb8206jpJol-g4vJAxPs1XjEx95hwRboI/edit#heading=h.xqthbgih7l2l > > Bug: v8:9237 > Change-Id: I28b6d87ce6537acd8cf972bbe7dc6d63d581aadc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2487122 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70988} TBR=marja@chromium.org,mvstanton@chromium.org,neis@chromium.org Change-Id: Ib5ddb919ae569fe5ddf266d986f1c8bc0fe9621a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9237 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2520908Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70992}
-
Thibaud Michaud authored
This is a reland of c6c86944 The code offset is allowed to be null if there is no function in the module. Original change's description: > [wasm] Fix code offset after module cache hit > > If the module cache was hit, we didn't set the code offset in the > decoded module. Hence it was reported as 0 to the DevTools frontend, > leading to subsequent errors. > Note that this error can only happen if multiple isolates share the same > module, which we cannot easily test in v8. Sharing within a single > isolate is implemented via the script cache, so we won't report another > script via CDP. > > R=thibaudm@chromium.org > > Bug: chromium:1114143 > Change-Id: I3218a3b12cf5be09d685e3f371f858ab799cef80 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519560 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70967} Bug: chromium:1114143 Change-Id: I4609cfc61fbd8b5092781dc9308f5651bcc76c42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517695 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Camillo Bruni authored
The setup order in the logger was slightly off and we skipped on writing the log entries for the loaded shared-library. This causes a lot of unaccounted ticks with the ticks-processor. Bug: v8:11108 Change-Id: I260eb846da4cce0ead7cdb6e90fd0b02d3cd8eaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517697Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#70990}
-
Tobias Tebbi authored
Introduce a new annotation @customCppClass that can be used for non-extern @export classes, that is, generate everything, remove boilerplate from all the internal lists and switches, but allow a custom C++ class, which in turn also allows overwriting the generated print and verify functions. Port DescriptorArray and StrongDescriptorArray as an example. Bug: v8:7793 Change-Id: I744e52fb4102ac49c0097f1c95bb17d301975bf0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2489687Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#70989}
-
Marja Hölttä authored
Generalize the existing property lookup machinery (JSNCS::ReduceNamedAccess) to handle the case where the lookup_start_object and the receiver are different objects. Design doc: https://docs.google.com/document/d/1b_wgtExmJDLb8206jpJol-g4vJAxPs1XjEx95hwRboI/edit#heading=h.xqthbgih7l2l Bug: v8:9237 Change-Id: I28b6d87ce6537acd8cf972bbe7dc6d63d581aadc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2487122 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#70988}
-
Pierre Langlois authored
The MOVI instruction writes an immediate into every lane of a vector. In order to support all immediates, we split it into two 64-bit writes. However if the top and bottom 64 bits are identical, we can skip the second write. Bug: v8:11033 Change-Id: Idfb74471de815d278a84c78d204d534d19214b2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507691Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
For an "#if defined(MAP_JIT)" test to work as expected, <sys/mman.h> must be included in the compilation unit. Bug: chromium:1144200 Change-Id: Ia0bf35ec1872c02457f1fbc0ee6689c7f7d27d4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517689Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#70986}
-
Pierre Langlois authored
The hardfloat calling convention reserves registers d0 to d7 for passing double parameters, any parameters after that will be passed on the stack. We do not pass more than a couple of double parameters at a time when calling C functions from generated code in V8, so this hasn't been an issue but it could be in the future. Change-Id: I44971ef0943894c201ddb908031ba9cf6fc0bc8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2507692Reviewed-by:
-
Clemens Backes authored
Calling {Exit} does not stop execution in the current thread (or process), it just tells the two task runners to stop. Hence following code would still be executed. This CL replaces the calls to {Exit} to {FATAL} for internal errors where we want to stop immediately. R=szuend@chromium.org Bug: chromium:1142437 Change-Id: I70c1c39da28a3cd040214d46eddf61f05a12bce7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519568Reviewed-by: -
Georg Neis authored
This is helpful for debugging. At the moment it reports any installations of code dependencies and, by implying --trace-deopt-verbose, any deopts due to dependency changes. Change-Id: I910a6dc165cc3586eaf7e5f322c90924359ae6ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519566 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#70983}
-
Jakob Gruber authored
This reverts commit c3b2b64b. Reason for revert: Scheduled revert. The flag flip is in 88.0.4315.0. Group report links: https://chromeperf.appspot.com/group_report?rev=70949 https://chromeperf.appspot.com/group_report?rev=823663 Original change's description: > [nci] Enable --turbo-nci behind --future to gather perf data > > .. to be reverted in a day or two. > > Bug: v8:8888 > Change-Id: Iee156da614b50c351ca9a07cc497177c92de865d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512907 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Lutz Vahl <vahl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70949} TBR=machenbach@chromium.org,jgruber@chromium.org,vahl@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8888,v8:11087 Change-Id: I57411474d885dd69613a85f5fa3a801a573fcd08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517690Reviewed-by:
-
Sathya Gunasekaran authored
For minimorphic-polymorphic checks, instead of loading the feedback vector in an inlined unrolled loop, just inline the maps present in the feedback vector at compile time and call out to the builtin if these map checks fail. Change-Id: I4672bc2c774027935aa245382625b9aa64be1d10 Bug: v8:10582 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2460812Reviewed-by:
-
Liu yu authored
This reverts commit 7257dc93. Reason for revert: - New test fail on mips64el: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8864502401132417824/+/steps/Check/0/logs/modules-import-large/0 Original change's description: > [mips] Remove arguments adaptor frame > > Port: 958d8e9f > > Bug: v8:10201 > > Change-Id: I27d29f2a1f1d5f659d558b5fd776b88474d9b140 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2513867 > Auto-Submit: Liu yu <liuyu@loongson.cn> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70964} TBR=jgruber@chromium.org,liuyu@loongson.cn Change-Id: Iddca9684995409fb9a1f3340b3a1931b1b5b472b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519189Reviewed-by:
-
Michael Achenbach authored
This reverts commit 689fbbc2. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20debug%20builder/49553 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/92c40db..01b3fe4 > > Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/98881a1..b6526d9 > > Rolling v8/buildtools/linux64: git_revision:f5f465b52e5df6d4de9fbe67cc79f1914ba4dbfc..git_revision:e002e68a48d1c82648eadde2f6aafa20d08c36f2 > > Rolling v8/third_party/aemu-linux-x64: uqYfh08DTmvjUgXl-HxNY1ptIb0KpyuY0I9MFaci9-AC..GcTt9uPsoI1ThLZlKalBAGZLijn8zwDw_BQtJwWpS08C > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/888c272..b8b4d61 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/655afeb..8ca189d > > Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8cd0fc1..e84c9a3 > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4c43492..952382f > > Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb > > Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb > > Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb > > TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: If1d65d05063942b39f6986df8472d5ae6fd241c5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2520379 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#70978} TBR=machenbach@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8cdb3536acd7757108c5ab2113a4afcbf027ef01 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517691Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/92c40db..01b3fe4 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/98881a1..b6526d9 Rolling v8/buildtools/linux64: git_revision:f5f465b52e5df6d4de9fbe67cc79f1914ba4dbfc..git_revision:e002e68a48d1c82648eadde2f6aafa20d08c36f2 Rolling v8/third_party/aemu-linux-x64: uqYfh08DTmvjUgXl-HxNY1ptIb0KpyuY0I9MFaci9-AC..GcTt9uPsoI1ThLZlKalBAGZLijn8zwDw_BQtJwWpS08C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/888c272..b8b4d61 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/655afeb..8ca189d Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/8cd0fc1..e84c9a3 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4c43492..952382f Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb Rolling v8/tools/luci-go: git_revision:1a022d3a4c50be4207ee93451255d71896416596..git_revision:576741d3eed0fa33971fb34cd823650e6f5b47fb TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If1d65d05063942b39f6986df8472d5ae6fd241c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2520379Reviewed-by:
-
Zhi An Ng authored
Integer splats (especially for sizes < 32-bits) does not directly translate to a single instruction on x64. We can do better for special values, like 0, which can be lowered to `xor dst dst`. We do this check in the instruction selector, and emit a special opcode kX64S128Zero. Also change the xor operation for kX64S128Zero from xorps to pxor. This can help reduce any potential data bypass delay (search for this on agner's microarchitecture manual for more details.). Since integer splats are likely to be followed by integer ops, we should remain in the integer domain, thus use pxor. For i64x2.splat the codegen goes from: xorl rdi,rdi vmovq xmm0,rdi vmovddup xmm0,xmm0 to: vpxor xmm0,xmm0,xmm0 Also add a unittest to verify this optimization, and necessary raw-assembler methods for the test. Bug: v8:11093 Change-Id: I26b092032b6e672f1d5d26e35d79578ebe591cfe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2516299Reviewed-by:
-
Devlin Cronin authored
Add a new function on the public API to allow serializing a function to a string using the built-in toString() implementation, allowing serialization without worrying about untrusted author script overriding the toString() implementation. This is similar in nature to Object::ObjectProtoToString() (but that only returns "[object Function]" for any passed function). Add tests for the same. Bug: chromium:1144841 Change-Id: Ie4c29b870034c0817c23bf91f9424f956098823d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2514768Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#70976}
-
- 04 Nov, 2020 11 commits
-
-
Milad Fa authored
Power 9 offers new Vector Insert instructions which now can be used to implement Replace Lane opcodes. Also changed the input register to be the same as output. Change-Id: Ie71b4d44bf715d2f619ee55144ef18e9e727ed9a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2518617Reviewed-by:
-
Michael Achenbach authored
This reverts commit c6c86944. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Blink%20Linux%20Debug/6762 https://test-results.appspot.com/data/layout_results/V8_Blink_Linux_Debug/6762/blink_web_tests%20%28retry%20shards%20with%20patch%29/layout-test-results/results.html Original change's description: > [wasm] Fix code offset after module cache hit > > If the module cache was hit, we didn't set the code offset in the > decoded module. Hence it was reported as 0 to the DevTools frontend, > leading to subsequent errors. > Note that this error can only happen if multiple isolates share the same > module, which we cannot easily test in v8. Sharing within a single > isolate is implemented via the script cache, so we won't report another > script via CDP. > > R=thibaudm@chromium.org > > Bug: chromium:1114143 > Change-Id: I3218a3b12cf5be09d685e3f371f858ab799cef80 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519560 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70967} TBR=clemensb@chromium.org,thibaudm@chromium.org Change-Id: I61528d5000d703ce36ad2ba88cae043220f5f9f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1114143 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519569Reviewed-by:
-
Victor Gomes authored
This is a reland of adceb459 Redesign test to not be OS dependent. Original change's description: > [x64][ia32] Add stack overflow check in InvokePrologue > > In case of no arguments adaptor frame, we massage the arguments in InvokePrologue pushing undefined objects if the actual argument count is below the parameter count. This CL adds a stack overflow check before pushing these undefined objects to the stack. > > Change-Id: I2a88bf6fdfd17958f6f6884143a67d50ea842fd2 > Bug: v8:10201 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2491039 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#70927} Bug: v8:10201 Change-Id: Ifab3413b748cdf3bb998a5080cd1fcb3b67a737b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2517921Reviewed-by:
-
Frank Tang authored
ICU68-1 change the output skeleton format. So we need to change resolvedOptions code for 68 migration. Chromium roll https://chromium-review.googlesource.com/c/chromium/src/+/2474093 Bug: v8:10945 Change-Id: I3b2c7fbe8abb22df8fa51287c498ca3245b8c55b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477431 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#70972}
-
Victor Gomes authored
Change-Id: I81ace5b6abf883c80bea1fada94a66888b16745a Bug: chromium:1144672, v8:10201 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2512923Reviewed-by:
-
Daniel Vogelheim authored
Rename-only CL: Rename "code kind" to "code like". The reason is CL feedback when using this feature, and a desire for consistency across V8 + Blink. An additional benefit would be to disambiguate from the v8::internal::CodeKind type, which is unrelated to any of this. Original CL: crrev.com/c/v8/v8/+/2339618 CL whose review prompted this change: crrev.com/c/2340905 Bug: chromium:1096017 Change-Id: Id59016fc2906ab6cd1414e598338b3963811b92f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509598Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Convert Profile, CodeMap and their helpers to ES6 classes. Code cleanup will happen in a separate step. Bug: v8:10667 Change-Id: Icfb28f6d9ef7f00efba93b347fdf210a9af36a49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2509591 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Almothana Athamneh authored
Bug: v8:11102 Change-Id: I40ce923a42097bf76a4b53c61bab1ef983523f64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519557Reviewed-by:
-
Clemens Backes authored
If the module cache was hit, we didn't set the code offset in the decoded module. Hence it was reported as 0 to the DevTools frontend, leading to subsequent errors. Note that this error can only happen if multiple isolates share the same module, which we cannot easily test in v8. Sharing within a single isolate is implemented via the script cache, so we won't report another script via CDP. R=thibaudm@chromium.org Bug: chromium:1114143 Change-Id: I3218a3b12cf5be09d685e3f371f858ab799cef80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519560Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#70967}
-
Jakob Gruber authored
The various compilation caches are tricky to understand. Hopefully some addtl. documentation helps. Bug: v8:8888 Change-Id: I20f2778b5548fcc38724aca600ccf770c240758d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2516476 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Camillo Bruni authored
The new api removes the unused CompileOptions argument. Change-Id: Ie3c48cda5247da9ce87d70a90b7ab9c43d5e8e37 Bug: chromium:1061857 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498698Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
