- 10 Oct, 2017 5 commits
-
-
Michael Starzinger authored
This makes sure that frames representing builtin stub continuations not only materialize all stack slots, but also spilled register values. Note that this also applies when the stub frame is not the top-most frame. R=jarin@chromium.org TEST=mjsunit/regress/regress-6907 BUG=v8:6907 Change-Id: I01a2edf5629de6aac61ceea350d1ab5f91dc2dc1 Reviewed-on: https://chromium-review.googlesource.com/707245Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48415}
-
Michael Achenbach authored
The new deopt stress is implemented for x64 only. NOTRY=true TBR=sergiyb@chromium.org Bug: v8:6900 Change-Id: I542cb89de643c477875893f6b0b73ced44108b9e Reviewed-on: https://chromium-review.googlesource.com/708259 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#48414}
-
Michael Achenbach authored
Bug: chromium:754168 Change-Id: Ie3c80b7f566f6738893cc30f26b35b7862eccc6c Reviewed-on: https://chromium-review.googlesource.com/706996 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#48413}
-
Alexei Filippov authored
BUG=chromium:760649 TBR=cbruni@chromium.org Change-Id: I9fcd6e25f78f3d6cbd563c77c96a5b175d1ba125 Reviewed-on: https://chromium-review.googlesource.com/707901Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#48412}
-
Eric Holk authored
This flag was originally added as a staging mechanism to let us land and test guard regions without the full trap handler feature landing. Additionally, we thought we might enable guard regions without trap handlers on some systems. Trap handlers are now supported, and there's not a real compelling reason for why we need guard regions without trap handlers. Keeping the separate flag leads to confusion, since some code treats guard regions and trap handlers the same, while other code treats them as independent. Removing this flag and its associated special cases makes everything more uniform and predictable. R=gdeepti@chromium.org Change-Id: Icebab91d1f1e0c55e7a35c75b880085d37fa14ae Reviewed-on: https://chromium-review.googlesource.com/706570Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#48411}
-
- 09 Oct, 2017 35 commits
-
-
Toon Verwaest authored
Bug: Change-Id: I0c2dabebbfa709589c19b1c48ec8de4c7f7a3952 Reviewed-on: https://chromium-review.googlesource.com/707151 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#48410}
-
Alexei Filippov authored
The RuntimeCallStats object happen to be created on the main thread, but then got used in a worker. Make sure the thread checks do not fire false positives in this case. BUG=chromium:760649 Change-Id: I8f2a2b4d1da1bc48416987ea378688ec15b9d955 Reviewed-on: https://chromium-review.googlesource.com/706181Reviewed-by:
-
Eric Holk authored
This was causing trouble with Fuchsia, since mksnapshot was built and run on Linux which supports trap handlers, while Fuchsia does not yet. This change causes the external references to match between Fuchsia and Linux. Bug: chromium:772057 Change-Id: I8e8f3539e3f5c4b798c364101ef2d16b5137f16d Reviewed-on: https://chromium-review.googlesource.com/706109Reviewed-by:
-
Tobias Tebbi authored
This reverts commit 6ddb5e7d. Reason for revert: chromium:772873 chromium:772872 Original change's description: > Reland^2 "[turbofan] eagerly prune None types and deadness from the graph" > > Now, the EffectControlLinearizer connects all occurrences of Unreachable to the > graph end. This fixes issues with later phases running DeadCodeElimination and > introducing new DeadValue nodes when processing uses of Unreachable. > > This is a reland of 3c4bc27f > Original change's description: > > Reland "[turbofan] eagerly prune None types and deadness from the graph" > > > > This is a reland of e1cdda25 > > Original change's description: > > > [turbofan] eagerly prune None types and deadness from the graph > > > > > > In addition to using the {Dead} node to prune dead control nodes and nodes that > > > depend on them, we introduce a {DeadValue} node representing an impossible value > > > that can occur at any position in the graph. The extended {DeadCodeElimination} > > > prunes {DeadValue} and its uses, inserting a crashing {Unreachable} node into > > > the effect chain when possible. The remaining uses of {DeadValue} are handled > > > in {EffectControlLinearizer}, where we always have access to the effect chain. > > > In addition to explicitly introduced {DeadValue} nodes, we consider any value use > > > of a node with type {None} as dead. > > > > > > Bug: chromium:741225 > > > Change-Id: Icc4b636d1d018c452ba1a2fa7cd3e00e522f1655 > > > Reviewed-on: https://chromium-review.googlesource.com/641250 > > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#48208} > > > > Bug: chromium:741225 > > Change-Id: I21316913dae02864f7a6d7c9269405a79f054138 > > Reviewed-on: https://chromium-review.googlesource.com/692034 > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#48232} > > Bug: chromium:741225 > Change-Id: I5702ec34856c075717162153adc765774453c45f > Reviewed-on: https://chromium-review.googlesource.com/702264 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48366} TBR=jarin@chromium.org,tebbi@chromium.org Change-Id: Ib0f59b8463681abf6a9158112515aefae3c76b5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:741225 Reviewed-on: https://chromium-review.googlesource.com/707275Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#48407}
-
Benedikt Meurer authored
We don't need an explicit diamond in JSBuiltinReducer to produce a Boolean. The NumberEqual operator already produces a Boolean, so we just need to negate the result. Change-Id: I442b0d98a4ab83002757906d6cc104682b87a853 Reviewed-on: https://chromium-review.googlesource.com/707434Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48406}
-
Ulan Degenbaev authored
This ensures that platform is initialized before the isolate and properly restores the previous platform at the end of the test. Bug: Change-Id: I2771b7538362c400c5ff61411222beb7d7e62b02 Reviewed-on: https://chromium-review.googlesource.com/707111 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#48405}
-
Benedikt Meurer authored
Rename the MapLookupHashIndex builtin to FindOrderedHashMapEntry and also rename the TurboFan operators LookupHashStorageIndex and LookupSigned32HashStorageIndex to FindOrderedHashMapEntry and FindOrderedHashMapEntryForInt32Key respectively. This way the naming is more consistent and it's immediately obvious from the operator name that this operator deals with OrderedHashMaps, which wasn't clear before. Also fix the result of the operation to be either -1 or the index of the entry relative to the hash table start (that is, no longer eagerly add hash table start plus value offset to the entry index). This removes this non-foldable integer additon from TurboFan code for both Map#get and Map#has. Drive-by-fix: Also provide more concrete types for the FindOrderedHashMapEntry operators. Bug: v8:5049 Change-Id: I418d107b806f3031a52a525cffc20456dc2342db Reviewed-on: https://chromium-review.googlesource.com/707414Reviewed-by:
-
Benedikt Meurer authored
We use the naming convention <Constructor>Prototype<Method> for builtins that implement methods on a certain builtin constructors prototype. Fix the collection builtins (Map and Set) to match this naming convention. Bug: v8:5049 Change-Id: I8ced50c2ac9ebc8f4390bcbbc6aec426a0026813 Reviewed-on: https://chromium-review.googlesource.com/707318Reviewed-by:
-
Georg Neis authored
R=jkummerow@chromium.org Bug: v8:6791 Change-Id: I7b3efcd0033ecb8c872342cd573f416fd22daf73 Reviewed-on: https://chromium-review.googlesource.com/707006Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#48402}
-
Toon Verwaest authored
Bug: Change-Id: I78403ce3c36f3c8276358f0bafff88131b2c7c00 Reviewed-on: https://chromium-review.googlesource.com/707316Reviewed-by:
-
Benedikt Meurer authored
The contract in TurboFan is that "the hole" is never passed to "user JavaScript", which we unfortunately still don't check strictly. Now the inlined code for Array#forEach properly checks for "the hole", but the type of the element Node passed to the callback function doesn't reflect that. So introduce a proper TypeGuard here to reflect this check. This will also improve code generation for iteration of HOLEY arrays better and might improve performance a bit. Bug: v8:1956 Change-Id: Ib6b3c444b16fcf44551bda1b39f976d66b9362ab Reviewed-on: https://chromium-review.googlesource.com/705954Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48400}
-
Benedikt Meurer authored
We no longer use the terminology "fast elements", so drop the "Fast" from both NewFastSmiOrObjectElements and NewFastDoubleElements operator names. Bug: v8:6399, v8:6901 Tbr: jarin@chromium.org Change-Id: Icc204623f2b459b0d0e172e26ddd73e29fe6c884 Reviewed-on: https://chromium-review.googlesource.com/707246Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48399}
-
Toon Verwaest authored
Bug: Change-Id: I0f050d9ca57738267bcf461ac101f781a2e01fdf Reviewed-on: https://chromium-review.googlesource.com/707148 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: Change-Id: Ic305df479b7e059b312bb06842814b992e2ab140 Reviewed-on: https://chromium-review.googlesource.com/707147 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: chromium:747960 No-Tree-Checks: true No-Try: true No-Presubmit: true Change-Id: Ia2a5964e7229d08a9b88f60c609daad0f9571287 Reviewed-on: https://chromium-review.googlesource.com/707237 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:694255 Change-Id: I5c0c0b58cdcf3cf745670148724e3c6ecc34d485 Reviewed-on: https://chromium-review.googlesource.com/707149Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48395}
-
Toon Verwaest authored
Bug: Change-Id: I62e95cebbc02ac867e396796f298b004f7f2ee4d Reviewed-on: https://chromium-review.googlesource.com/707150Reviewed-by:
-
Toon Verwaest authored
Bug: Change-Id: I8055db7268bfaca31aa2fe41d5882acd2649a9e8 Reviewed-on: https://chromium-review.googlesource.com/707143 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Martyn Capewell authored
Missed from the earlier ObjectTriple removal, commit fc413158. Bug: Change-Id: I2fd9c17b4a4d888d81dc0b51586bec6f191cc7ed Reviewed-on: https://chromium-review.googlesource.com/707138Reviewed-by:
-
Toon Verwaest authored
Bug: Change-Id: I67a0062a5a2f5ce16f9b83e1fa7a8b91042e75c1 Reviewed-on: https://chromium-review.googlesource.com/707105 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48391}
-
Ulan Degenbaev authored
The marked bytes counter needs to be updated before decrementing the pending task counter. Bug: chromium:694255 Change-Id: I19c4dfbdccfb32ded5b7bb707dc93d53e188e34a Reviewed-on: https://chromium-review.googlesource.com/707140Reviewed-by:
-
Michael Achenbach authored
Bug: chromium:772804 Change-Id: I4aa8c2661de576a3411d5547cf9e974c039281f3 Reviewed-on: https://chromium-review.googlesource.com/706995 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Bug: Change-Id: Idd2a12c9f99430de4d83543bc09cae9df1598813 Reviewed-on: https://chromium-review.googlesource.com/707071 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Mike Stanton authored
We can improve performance of inlined Array.prototype.map if we statically know the type of the callback return result is a SignedSmall. Indeed, we no longer need bother with transitioning the output array, because we can store a SignedSmall (aka "Smi") anywhere. Bug: v8:6896 Change-Id: I140ce9a7c15ff77d05afeda6cda58f0560d922c8 Reviewed-on: https://chromium-review.googlesource.com/707139Reviewed-by:
-
Toon Verwaest authored
Bug: Change-Id: I8589ea37ab776d867794125d35e1e51b16d6e9a3 Reviewed-on: https://chromium-review.googlesource.com/707068 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:772804 Change-Id: Ia3079f08c728febf14a413c2677cc5f20c54ba5a Reviewed-on: https://chromium-review.googlesource.com/706793Reviewed-by:
-
Toon Verwaest authored
Bug: Change-Id: Ifde89f90fe18a0747f4b7b9511fbdc64df31555b Reviewed-on: https://chromium-review.googlesource.com/707063 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This ensures the JSFunction objects materialized by the deoptimizer have the correct instance size (depending on the given map). There are corner cases where the instance size might vary due to in-object properties. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-772610 BUG=chromium:772610 Change-Id: I4808c7260db1adbd1cdc3871c2a946475e4934f2 Reviewed-on: https://chromium-review.googlesource.com/707109Reviewed-by:
-
Michael Achenbach authored
Bug: chromium:772804 Change-Id: I845a5ca4ff79c713eb6361ff99e4e09fe4c5c71d Reviewed-on: https://chromium-review.googlesource.com/706792Reviewed-by:
-
Toon Verwaest authored
Bug: Change-Id: I315d0017179e2f0a9883647b91fd4f0a762eade0 Reviewed-on: https://chromium-review.googlesource.com/707054 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:694255 Change-Id: I5dc6157126544f20bca0ddee967e1d08d69bb060 Reviewed-on: https://chromium-review.googlesource.com/707104Reviewed-by:
-
Clemens Hammacher authored
args[i] automatically returns undefined if i < 0 || i >= args.Length(). R=mstarzinger@chromium.org, titzer@chromium.org Change-Id: I215545fa54ce23440f1de49b48786e568831bc82 Reviewed-on: https://chromium-review.googlesource.com/704586Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48379}
-
Michal Majewski authored
Adds the counter to x64 only. Bug: v8:6900 Change-Id: Ia290102b38f029a0b71c40e4b00ecc5f07dfa59c Reviewed-on: https://chromium-review.googlesource.com/704678 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Benedikt Meurer authored
Avoid the zero-extensions required for int32 based addressing on 64-bit architectures by restructuring the initialization loops to work on words. This recovers a bit of the regression on the Kraken audio-fft and audio-beat-detection benchmarks that was introduced by the initial CL. Bug: chromium:772669, v8:6399, v8:6901 Change-Id: I4753c254be89f2bcc7b0ea5073e469e3507408bd Reviewed-on: https://chromium-review.googlesource.com/707098Reviewed-by:
-
Mike Stanton authored
In call reductions for Array.prototype.map and forEach, loads weren't wired appropriately into the effect chain, hampering the efficacy of load elimination. Bug: Change-Id: If5a386b66669d7173d5cadc6d8d3ff023daed810 Reviewed-on: https://chromium-review.googlesource.com/707073Reviewed-by:
-
