1. 03 Jul, 2013 15 commits
    • mstarzinger@chromium.org's avatar
      Fix GDBJIT compilation on Mac after r15467. · 0a6b0645
      mstarzinger@chromium.org authored
      R=machenbach@chromium.org
      
      Review URL: https://codereview.chromium.org/18259007
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15474 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      0a6b0645
    • olivf@chromium.org's avatar
      Convert UnaryOpStub to a HydrogenCodeStub · 0d2fed8f
      olivf@chromium.org authored
      BUG=
      R=danno@chromium.org
      
      Review URL: https://codereview.chromium.org/17229005
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15473 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      0d2fed8f
    • yangguo@chromium.org's avatar
      Add 4K more memory for HugeConsStringOutOfMemory test case · 1963ec4b
      yangguo@chromium.org authored
      R=yangguo@chromium.org
      
      Review URL: https://codereview.chromium.org/18068007
      
      Patch from Haitao Feng <haitao.feng@intel.com>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15472 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      1963ec4b
    • yurys@chromium.org's avatar
      Fix test-cpu-profiler/FunctionCallSample flakiness under GC stress testing · 44dfaa2a
      yurys@chromium.org authored
      The test flakes on "V8 GC Stress" bots and the sample looks like this:
      [Top down]:
         90     0   (root) [-1] #0 1
          1     1    (program) [-1] #0 2
         89    89    (garbage collector) [-1] #0 3
      which means that almost all samples are inside GC and we have no |start| node in the collected profile.
      
      Running the test with different combinations of --gc-interval=500 and --stress-compaction flags gives the results quoted below. They don't give a ground to require |start| node presense in the profile when doing GC stress testing. So this change makes the |start| node optional in the collected profile if GC stress testing is on.
      
      $ ./out/ia32.debug/cctest --gc-interval=500 --stress-compaction --trace-gc  test-cpu-profiler/FunctionCallSample
      [10291]       76 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 49.5 ms (+ 0.2 ms in 1 steps since start of marking, biggest step 0.2 ms) [StackGuard GC request] [GC in old space requested].
      [10291]      110 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 25.3 ms [Logger::LogCompiledFunctions] [GC in old space requested].
      [10291]      135 ms: Mark-sweep 0.4 (17.8) -> 0.4 (17.8) MB, 22.8 ms [Logger::LogAccessorCallbacks] [GC in old space requested].
      [10291]      179 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 39.9 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [Runtime::PerformGC] [GC in old space forced by flags].
      [10291]      209 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 29.1 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [Runtime::PerformGC] [GC in old space forced by flags].
      [10291]      240 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 29.1 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [Runtime::PerformGC] [GC in old space forced by flags].
      [Top down]:
         99     0   (root) [-1] #0 1
          4     4    start [-1] #16 3
         93    93    (garbage collector) [-1] #0 4
          2     2    (program) [-1] #0 2
      
      $ ./out/ia32.debug/cctest --gc-interval=500  --trace-gc  test-cpu-profiler/FunctionCallSample
      [10328]       46 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 14.9 ms [Logger::LogCompiledFunctions] [GC in old space requested].
      [10328]       61 ms: Mark-sweep 0.4 (17.8) -> 0.4 (17.8) MB, 12.9 ms [Logger::LogAccessorCallbacks] [GC in old space requested].
      [10328]       65 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]       67 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]       69 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       70 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       72 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       73 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       75 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       77 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       78 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       80 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       81 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       83 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       85 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       86 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       88 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       89 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       91 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       93 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       94 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]       96 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       97 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]       99 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      101 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      102 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      104 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      105 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      107 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      109 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      110 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      112 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      113 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]      115 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      117 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      118 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      120 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      121 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      123 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      125 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      126 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      128 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      129 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      131 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      133 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      134 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      136 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      137 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      139 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      141 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      142 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      144 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]      145 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      147 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      149 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      150 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      152 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      153 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.3 ms [Runtime::PerformGC].
      [10328]      155 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      157 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      158 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      160 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      162 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [10328]      163 ms: Scavenge 0.5 (17.8) -> 0.4 (17.8) MB, 1.2 ms [Runtime::PerformGC].
      [Top down]:
         95     0   (root) [-1] #0 1
         12    11    start [-1] #16 3
          1     1      bar [-1] #16 4
         81    81    (garbage collector) [-1] #0 5
          2     2    (program) [-1] #0 2
      
      $ ./out/ia32.debug/cctest --stress-compaction --trace-gc  test-cpu-profiler/FunctionCallSample
      [10355]       76 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 49.9 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [StackGuard GC request] [GC in old space requested].
      [10355]      110 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 25.5 ms [Logger::LogCompiledFunctions] [GC in old space requested].
      [10355]      135 ms: Mark-sweep 0.4 (17.8) -> 0.4 (17.8) MB, 22.9 ms [Logger::LogAccessorCallbacks] [GC in old space requested].
      [10355]      189 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 49.8 ms (+ 0.2 ms in 1 steps since start of marking, biggest step 0.2 ms) [StackGuard GC request] [GC in old space requested].
      [10355]      234 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 42.5 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [StackGuard GC request] [GC in old space requested].
      [10355]      278 ms: Mark-sweep 0.5 (17.8) -> 0.4 (17.8) MB, 42.5 ms (+ 0.1 ms in 1 steps since start of marking, biggest step 0.1 ms) [StackGuard GC request] [GC in old space requested].
      [Top down]:
        135     0   (root) [-1] #0 1
          6     6    start [-1] #16 3
        127   127    (garbage collector) [-1] #0 4
          2     2    (program) [-1] #0 2
      
      BUG=None
      R=jkummerow@chromium.org, loislo@chromium.org
      
      Review URL: https://codereview.chromium.org/18068012
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15471 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      44dfaa2a
    • yurys@chromium.org's avatar
      Relax test expectations for test-cpu-profiler/FunctionApplySample · 41c9adff
      yurys@chromium.org authored
      The profile may look a bit different on the bots (see below). We expected this only under GC stress testing, the change makes regular expectations the same.
      
      [Top down]:
         68     0   (root) [-1] #0 1
          1     1    (program) [-1] #0 2
         67    65    start [-1] #16 3
          2     0      (unresolved function) [-1] #0 4
          2     2        apply [-1] #0 5
      
      BUG=None
      TBR=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/18331012
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15470 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      41c9adff
    • mstarzinger@chromium.org's avatar
      Fix compilation on x64 after r15466 · 45264ffb
      mstarzinger@chromium.org authored
      R=mstarzinger@chromium.org
      
      Review URL: https://codereview.chromium.org/18643002
      
      Patch from Jochen Eisinger <jochen@chromium.org>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15469 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      45264ffb
    • yurys@chromium.org's avatar
      Correctly report stack trace when current function is FunctionApply builtin · 559e1d45
      yurys@chromium.org authored
      When pc is inside FunctionApply builtin function the top frame may be either
      2) Internal stack frame created by FunctionApply itself.
      In this case we know its caller's pc and can correctly resolve calling function.
      1) Frame of the calling JavaScript function that invoked .apply(). In this case we have no practical reliable way to find out the caller's pc so we mark the caller's frame as 'unresolved'.
      
      All this logic is implemented in ProfileGenerator. SafeStackFrameIterator is extended to provide type of the current top stack frame (iteration actually starts from the caller's frame as we know top function from pc).
      
      BUG=252097
      R=jkummerow@chromium.org, loislo@chromium.org
      
      Review URL: https://codereview.chromium.org/18269003
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15468 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      559e1d45
    • mstarzinger@chromium.org's avatar
      Enable GDBJIT interface for standalone by default. · 2c942ea6
      mstarzinger@chromium.org authored
      R=jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/18638002
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15467 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      2c942ea6
    • mstarzinger@chromium.org's avatar
      Fix GDBJIT for Linux after r15460. · 13b60ec6
      mstarzinger@chromium.org authored
      R=danno@chromium.org
      
      Review URL: https://codereview.chromium.org/18363007
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15466 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      13b60ec6
    • bmeurer@chromium.org's avatar
      Reintroduce runtime zone to Isolate. · e3f34a58
      bmeurer@chromium.org authored
      In case tcmalloc is not being used, the malloc()/free() overhead
      can be significant for several runtime functions like StringReplace.
      Therefore we reintroduce the runtime_zone into Isolate and reenable
      the segment caching functionality of Zone.
      
      There's now also a simpler version of ZoneScope w/o nesting capabilities.
      
      BUG=v8:2759
      R=danno@chromium.org, yangguo@chromium.org
      
      Review URL: https://codereview.chromium.org/18635003
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15465 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      e3f34a58
    • jkummerow@chromium.org's avatar
      Import the v8-i18n extension into v8 · 56ab3e34
      jkummerow@chromium.org authored
      This adds the gyp flag v8_enable_i18n_support (off by default), and the
      v8 flag FLAG_enable_i18n (on by default, but without effect if
      v8_enable_i18n_support is off).
      
      BUG=v8:2745
      R=cira@chromium.org, danno@chromium.org, jkummerow@chromium.org
      
      Review URL: https://codereview.chromium.org/18487004
      
      Patch from Jochen Eisinger <jochen@chromium.org>.
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15464 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      56ab3e34
    • yangguo@chromium.org's avatar
      Fix small mistake in d8.js. · f23ed09e
      yangguo@chromium.org authored
      R=mvstanton@chromium.org
      BUG=v8:2756
      
      Review URL: https://codereview.chromium.org/18572009
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15463 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      f23ed09e
    • yangguo@chromium.org's avatar
      Log deopts with --log-timer-events. · ae126e12
      yangguo@chromium.org authored
      R=jkummerow@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/17599007
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15462 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      ae126e12
    • mstarzinger@chromium.org's avatar
      9bd31287
    • danno@chromium.org's avatar
      Make MachO gdbjit support compile again · 57f46c01
      danno@chromium.org authored
      R=mstarzinger@chromium.org
      
      Review URL: https://chromiumcodereview.appspot.com/18621002
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15460 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      57f46c01
  2. 02 Jul, 2013 25 commits