- 14 Sep, 2018 22 commits
-
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ie0591d8f32ebd4b9681ef9eeec092e30b73bd0b8 Reviewed-on: https://chromium-review.googlesource.com/1224172Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55902}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie05d919cfd5cc4447c00603c8a46e975ad85cce3 Reviewed-on: https://chromium-review.googlesource.com/1224378Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55901}
-
Clemens Hammacher authored
This test was disabled because of flakes. This should be fixed now. R=ahaas@chromium.org Bug: v8:7872 Change-Id: I288f3776ca7f946caf20a66f1cdf5d37bd6ba245 Reviewed-on: https://chromium-review.googlesource.com/1224376Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55900}
-
Michael Achenbach authored
The test debug-live-edit-recursion flakily fails predictable testing and should match the status file rule debug-liveedit-* that skips the other ~10 liveedit tests. Bug: v8:8147 Change-Id: I9d88b44d97daa09914e0fa46fb204e85c1e7344c Reviewed-on: https://chromium-review.googlesource.com/1224430Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55899}
-
Clemens Hammacher authored
This implements the five sign extension opcodes for ia32 and x64 (and bails out on other architectures). R=titzer@chromium.org Bug: v8:6600 Change-Id: Ibb8bae0e229e276b346f2d054b51864a0995a096 Reviewed-on: https://chromium-review.googlesource.com/1174533 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55898}
-
Jakob Gruber authored
This reverts commit 99e13e58. Reason for revert: Reverting in favor of a general mechanism for this in Torque. Original change's description: > [builtins] Add FastCallFunction builtin that elides some checks > > This CL adds a new "Call" stub that can be used by builtins that will > call the same JS call-back function often (e.g. compare function in > Array.p.sort). The checks have to be done upfront once, but can then > be omitted. > > R=jgruber@chromium.org > > Bug: v8:7861 > Change-Id: Id6e4ca27c3d488a7b1f708cbcb4cbe6cc382513e > Reviewed-on: https://chromium-review.googlesource.com/1208574 > Commit-Queue: Simon Zünd <szuend@google.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55769} TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7861 Change-Id: I47260993ef2a16bd5348bb0b46da4d34d33ea10b Reviewed-on: https://chromium-review.googlesource.com/1226871 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55897}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I8546c58afbac278a764067173570b433dff6674d Reviewed-on: https://chromium-review.googlesource.com/1224413Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55896}
-
Clemens Hammacher authored
We are currently wrapping the pointer to the instruction start in a Foreign. The argument buffer, which is also a raw pointer, is passed directly though. This CL changes this to also pass the code entry as a raw pointer. R=mstarzinger@chromium.org Change-Id: Id7344efa589a5297339ec01c3cfa7688bcc706b3 Reviewed-on: https://chromium-review.googlesource.com/1226970Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55895}
-
Florian Sattler authored
NOTRY=true Change-Id: I28637031771ab994c3f4b7fe642eddfce9c69b16 Reviewed-on: https://chromium-review.googlesource.com/1225976Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55894}
-
Creddy authored
This reland of the commit e938b7a3. Original change's description: > Enable OneShot optimizations by default > > BUG=v8:8072 > > Change-Id: I2068d66644628fe1de7a6be30b8d43ecfae04e93 > Reviewed-on: https://chromium-review.googlesource.com/1220047 > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55875} TBR=cbruni@chromium.org,chandanreddy@google.com Change-Id: I2152d4f3886913ef7ffabf8611c3448299560d2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8072 Reviewed-on: https://chromium-review.googlesource.com/1224933 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55893}
-
Georg Neis authored
Tbr: hpayer@chromium.org Change-Id: I3f10ee70a9f9990e0259095826ac40371a96bac5 Reviewed-on: https://chromium-review.googlesource.com/1225756 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55892}
-
Georg Neis authored
Change-Id: If90c13658713cbfdf06200e49773e67495dce85b Reviewed-on: https://chromium-review.googlesource.com/1225754Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55891}
-
Georg Neis authored
Bug: v8:7790 Change-Id: I3077883a8509a988090d2c051e5bd85c139a38e6 Reviewed-on: https://chromium-review.googlesource.com/1224326 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#55890}
-
Georg Neis authored
Additionally: - Remove partiality from ContextRef::previous as long as we don't need it. - Fix a nasty bug in serialization dispatch (the order of types was incorrect). Bug: v8:7790 Change-Id: I354a69cf37e1dcdd691aab8af668c5cef165cf1e Reviewed-on: https://chromium-review.googlesource.com/1224438Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55889}
-
Michael Achenbach authored
This reverts commit 836773c0. Reason for revert: Breaks full-debug support: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20full%20debug/5493 Original change's description: > Implement v8::internal::MicrotaskQueue::EnqueueMicrotask > > This adds `queue` and `pending_microtask_count` as members of > v8::internal::MicrotaskQueue, and implements its EnqueueMicrotask. > The implementation itself is similar to Isolate::EnqueueMicrotask. > > Bug: v8:8124 > Change-Id: Idb5c50b2add96b72cbe9e36aeec7cb568072f0cb > Reviewed-on: https://chromium-review.googlesource.com/1205430 > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55884} TBR=ulan@chromium.org,adamk@chromium.org,hpayer@chromium.org,tzik@chromium.org Change-Id: I299884eb6b41fcbff7c486cad636ab7b9821dfe3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8124 Reviewed-on: https://chromium-review.googlesource.com/1225752Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55888}
-
Stephan Herhut authored
Reduce the number of workers in the atomic compare-exchange test to make it run faster on systems with few cores. Bug: v8:8164 Change-Id: I4de22863e1f2a44d9da4416161d08f5acfcece22 Reviewed-on: https://chromium-review.googlesource.com/1224771 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55887}
-
Benedikt Meurer authored
This adds support to TurboFan's representation selection for the Word64 representation, and makes use of that to handle indices for memory access and allocation instructions (i.e. LoadElement, StoreElement, Allocate, etc.). These instructions had previously used Word32 as representation for the indices / sizes, and then internally converted it to the correct representation (aka Word64 on 64-bit architectures) later on, but that was kind of brittle, and sometimes led to weird generated code. The change thus only adds support to convert integer values in the safe integer range from all kinds of representations to Word64 (on 64-bit architectures). We don't yet handle the opposite direction and none of the representation selection heuristics for the numeric operations were changed so far. This will be done in follow-up CLs. This CL itself is supposed to be neutral wrt. functionality, and only serves as a starting point, and a cleanup for the (weird) implicit Word64 index/size handling. Bug: v8:7881, v8:8015, v8:8171 Design-Document: http://bit.ly/turbofan-word64 Change-Id: I3c6961a0e96cbc3fb8ac9d3e1be8f2e5c89bfd25 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel Reviewed-on: https://chromium-review.googlesource.com/1224932 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55886}
-
Benedikt Meurer authored
This truncation doesn't have a proper meaning anyways and has never been used inside the representation selection. For pointer fields we also don't need to pass on a truncation anyways. Bug: v8:8015 Change-Id: I5ff49e20b70fa70d6bcf7401a357cd7ad9f1a938 Reviewed-on: https://chromium-review.googlesource.com/1226870 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#55885}
-
tzik authored
This adds `queue` and `pending_microtask_count` as members of v8::internal::MicrotaskQueue, and implements its EnqueueMicrotask. The implementation itself is similar to Isolate::EnqueueMicrotask. Bug: v8:8124 Change-Id: Idb5c50b2add96b72cbe9e36aeec7cb568072f0cb Reviewed-on: https://chromium-review.googlesource.com/1205430 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55884}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: If9a66df529dc5870f6d5146d9a83d22367ffdc59 Reviewed-on: https://chromium-review.googlesource.com/1224114Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55883}
-
Michael Achenbach authored
TBR=herhut@chromium.org NOTRY=true Bug: v8:8164 Change-Id: Ifcf4b7bce70b8dd1c4aba129a9061dfb6056474e Reviewed-on: https://chromium-review.googlesource.com/1226612Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55882}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8e97ee7..e021b7c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/03b5af9..3e07166 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dfce68b..b5e8781 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I19544c94e5df4eb0a98d0187ed181abba809d4c0 Reviewed-on: https://chromium-review.googlesource.com/1226413 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55881}
-
- 13 Sep, 2018 18 commits
-
-
Adam Klein authored
Also fix type-check to check receiver for JSReceiver, not JSObject, and add a test for DateTimeFormat verifying that it already has the proper behavior. Bug: chromium:881023 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I950c86094dfb9634e0b7e49bcbbb022fa81a71f7 Reviewed-on: https://chromium-review.googlesource.com/1225612 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55880}
-
Junliang Yan authored
R=joransiu@ca.ibm.com Change-Id: Icfbd76b8da133bf39960f1c172cd872876e2cf3e Reviewed-on: https://chromium-review.googlesource.com/1225672Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55879}
-
Aseem Garg authored
This CL enables source maps support for wasm. Devtools should be able to pick up source_mapping_url parsed here and load the corresponding source maps. R=kozyatinskiy@chromium.org,clemensh@chromium.org,titzer@chromium.org,yangguo@chromium.org BUG=v8:8081 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1db0ff597d229e7db8d383fe9ee081c7fa4e7648 Reviewed-on: https://chromium-review.googlesource.com/1185973 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55878}
-
Benedikt Meurer authored
Previously the [[ArrayBufferByteLength]] internal field was represented as a boxed number (i.e. either Smi or HeapNumber) in safe integer range. This is the first step to change the representation of all the array buffer and array buffer view length/offset fields to unboxed integers, to eventually support the full range of 4GiB (and potentially even more) for typed arrays and array buffers. This will allow WebAssembly memories with 4GiB to be usable. Tbr: yangguo@chromium.org Bug: v8:7881, v8:8015, v8:8171 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic6c6c8fe087afee898254cd903e82a55bfc173a9 Reviewed-on: https://chromium-review.googlesource.com/1222309Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55877}
-
Deepti Gandluri authored
This reverts commit e938b7a3. Reason for revert: Reverting because of gc-stress failures - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/18299 Original change's description: > Enable OneShot optimizations by default > > BUG=v8:8072 > > Change-Id: I2068d66644628fe1de7a6be30b8d43ecfae04e93 > Reviewed-on: https://chromium-review.googlesource.com/1220047 > Commit-Queue: Chandan Reddy <chandanreddy@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55875} TBR=cbruni@chromium.org,chandanreddy@google.com Change-Id: If3bfb5e142a873f534f831da413d26e78d2e3716 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8072 Reviewed-on: https://chromium-review.googlesource.com/1224481Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#55876}
-
Creddy authored
BUG=v8:8072 Change-Id: I2068d66644628fe1de7a6be30b8d43ecfae04e93 Reviewed-on: https://chromium-review.googlesource.com/1220047 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55875}
-
Yuki Shiino authored
It turned out that the original implementation was broken from the beginning. This patch fixes the API to return the correct one. GetIncumbentContext was implemented at https://chromium-review.googlesource.com/c/v8/v8/+/536728 Change-Id: Iba29171bac10ed82575a8079396768a9d5af3b13 Bug: chromium:883036 Reviewed-on: https://chromium-review.googlesource.com/1219368 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55874}
-
Clemens Hammacher authored
Minor fixes of things found in the code walkthrough. R=titzer@chromium.org Bug: v8:8015 Change-Id: If28be312fb7b8e5add214161a98d25145cdf8de5 Reviewed-on: https://chromium-review.googlesource.com/1224433 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55873}
-
Camillo Bruni authored
Bug: v8:8163 Change-Id: I2aacbb13dc16772b173d56051a84399b8c34d4f2 Reviewed-on: https://chromium-review.googlesource.com/1224417 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55872}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3a09bb6936853bca448f425d4266365deb6671d4 Reviewed-on: https://chromium-review.googlesource.com/1220146Reviewed-by: Marja Hölttä <marja@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55871}
-
Clemens Hammacher authored
Just a minor fix to skip the third GC after which we fail anyway. R=ulan@chromium.org Bug: v8:7621 Change-Id: I4dd6bcedc20ecb75dc06af02649ff5c7b67317d0 Reviewed-on: https://chromium-review.googlesource.com/1224434Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55870}
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:8015 Change-Id: Ib40817fffe64a7b8774b7f33adf7552284859064 Reviewed-on: https://chromium-review.googlesource.com/1224435Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55869}
-
Florian Sattler authored
Change-Id: Ia442ada5d15cfaa74877b07857a01d5040a7e0f2 Reviewed-on: https://chromium-review.googlesource.com/1224416Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55868}
-
Clemens Hammacher authored
Store it as FixedArray instead of Object. Use the empty array as uninitialized value instead of undefined. R=titzer@chromium.org Bug: v8:8015 Change-Id: I53275dc5fd2c3a0db1e021ee4da0fc0694e2053e Reviewed-on: https://chromium-review.googlesource.com/1224372Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55867}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ib3b6bdeb404ed6fe9c69107b4683a99c96dd8352 Reviewed-on: https://chromium-review.googlesource.com/1224053Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55866}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ibe5906fa96f2d7327bce1eff70637a2d00f99668 Reviewed-on: https://chromium-review.googlesource.com/1224030Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55865}
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:8015 Change-Id: I4baed1edb43e6aa8b345a515b1f732019eac3bd6 Reviewed-on: https://chromium-review.googlesource.com/1224415Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#55864}
-
Clemens Hammacher authored
HeapObject::GetHeap and HeapObject::GetIsolate are gone since https://crrev.com/c/1140319 (landed in July), hence we can clean up the using declarations to force use of the methods declared in NeverReadOnlySpaceObject. R=delphick@chromium.org Bug: v8:7786 Change-Id: Iec4edd394ac57a3f378dd1a9a100320e82cf8ea5 Reviewed-on: https://chromium-review.googlesource.com/1224414Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55863}
-