- 03 Mar, 2020 14 commits
-
-
Camillo Bruni authored
Call the @@hasInstance trap only when required by the spec. Bug: chromium:1052647 Change-Id: I7a0a3133c7b6280c6a3215e379bf02e9c22ffe55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2082560 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#66558}
-
Ulan Degenbaev authored
The scope disables garbage collection and should be only used in heap, deserializer, isolate bootstrap, and testing. Change-Id: Ide95926ef32fd9362cd9134e883e1bd626cc3b11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083292Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#66557}
-
Michael Achenbach authored
TBR=santa Change-Id: Ie318314abb2384df22deee4e3e33e2a7139e8d7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083482Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66556}
-
Shu-yu Guo authored
Bug: v8:10293 Change-Id: If585e7860721cb2de37a0de5bf135e7a4e226190 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081338 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66555}
-
Camillo Bruni authored
Newer gdb versions require the return type to be specified. Change-Id: Ia9c160858036e9cbbe1ced123bbcc79d9efb78b4 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2082561Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#66554}
-
Clemens Backes authored
The histograms were removed from chrome. This CL cleans up the V8 code to stop reporting samples. R=ahaas@chromium.org Bug: chromium:1053285 Change-Id: I7c6ff36ac9bb5d86e81e5f36849903a95a8ed618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083478Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66553}
-
Zhou, Zhiguo authored
Bug: v8:9909 Change-Id: Id89ddb429c90f3f454a581d75b783ff56775b01e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049247 Commit-Queue: Zhiguo Zhou <zhiguo.zhou@intel.com> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66552}
-
Matheus Marchini authored
Improve postmortem metadata generated by gen-postmortem-metadata by also including weak and synchronous accessors, as well as CHECKED and CHECKED2 variants of all accessors currently considered by gen-postmortem-metadata. Also improve type collection by parsing TORQUE_INSTANCE_CHECKERS_SINGLE_FULLY_DEFINED, as we were missing several types with the previous heuristic (like StackTraceFrame, PromiseReaction, and many others). This will include 96 new v8dbg constants which can be used by debuggers like llnode. R=hpayer@google.com, verwaest@google.com, victorgomes@google.com Change-Id: Ia9bea21eec38b92d255c3636c6a284eb27e9ed9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056126Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66551}
-
Jakob Gruber authored
This is a reland of c6c9d4bf Original change's description: > Update unicode-regexp-ignore-case-noi18n expectations > > There appear to be one or several bugs in noi18n mode such that > expectations in this test are no longer met. This CL updates > expectations to the current behavior and re-enables the test so we at > least preserve coverage in the other cases. > > The behavior in question should be investigated in the future > (low priority). > > Bug: v8:10120 > Change-Id: Ib7c9a18133a386e6e39ee54d68ce4106d9b28c84 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081815 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66524} Bug: v8:10120 Change-Id: Ib2ee68e26c2aebe2eeab3ec9f7bc263fd79f3773 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083291 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
Port d303f4fb https://crrev.com/c/2081816 Original Commit Message: In the past we've used the isolate argument to signal whether we were in unicode mode (nullptr) or not (the real isolate). This is no longer needed, and in fact breaks no-i18n mode which always expects to have a real isolate. Change-Id: I90a69a38cb4e74da46b3030843bc84d6d53571c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2082932 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
Ng Zhi An authored
Implements i8x16.abs, i16x8.abs, and i32x4.abs. Bug: v8:10233 Change-Id: I32391e8f895fea808180561d89a4fd24fbead3bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067845 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#66548}
-
Ng Zhi An authored
Bug: v8:9561 Change-Id: Ia9d1c263f4dc382f8b772e3cba57a4f14235b310 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069402Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b03644a..c6ac51f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9ca9c52..4576851 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I93e5506a0a4f9f8830ccdd11623d6bac88584556 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083667Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#66546}
-
Ng Zhi An authored
Bug: v8:9561 Change-Id: I733df8856ad8266a637794a9401118937e6bf006 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069401Reviewed-by:
-
- 02 Mar, 2020 26 commits
-
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10108 Change-Id: I3bdb4c2abe0b1db1babec370921463dbdfcd0a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074403 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
The spec was changed in February TC39 to make ToInteger always normalize -0 to +0. This only observably affects Atomics.store. Bug: v8:10271 Change-Id: I0e8f6c35cef982eae242cf6619f6f24fa75b1759 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2076509Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
Some opcodes are introduced in V8 for prototyping, and performance measurements that are not officially a part of the current SIMD proposal but may be included in future, gate these by a separate flag. Change-Id: Icc6a9e89c6196c8ff144d2e0193d707e1f60c38b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2079539 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10108 Change-Id: I72294ae6fa62209e078b3d00151207524b32e67e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074401 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Negating 1 << 31 as a signed integer overflows and causes undefined behaviour hence SetS390OverflowCode may never get set. Change-Id: I91379a53752de322cee4541cf44fb65338a614e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081335Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#66540}
-
Milad Farazmand authored
Also adding to and modifying some of the F32x4 operations. Change-Id: Ia57dcd70a3bad2f1ec4ccc64ff2cb02b9c83aa22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081832Reviewed-by:
-
Leszek Swirski authored
During class boilerplate allocation, we were overestimating the number of computed properties before allocating the computed property array, and the array after. But, we can reasonably easily get an exact size for the computed properties array, and avoid the right trimming entirely. This will simplify off-thread class boilerplate allocation, where the off-thread heap doesn't currently implement right trimming. Bug: chromium:1011762 Change-Id: Icf450340aa4e215c2063f4dd964ca7b80ef033c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083029 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#66538}
-
Andreas Haas authored
Implements AtomicWait on 64-bit platforms. Note that this implementation does not use {PrepareCall}, as planned originally. This will be done in a separate CL, to prepare the implementation for 32-bit platforms. This CL for now unblocks the implementation on x64. R=clemensb@chromium.org Bug: v8:10108 Change-Id: I52eb752364b231043975f62913c2ef9579321038 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074400 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: -
Toon Verwaest authored
This reverts commit 90b39673. Reason for revert: These functions are in use by d8-js.cc Original change's description: > [cleanup] Remove three unused proxy runtime functions > > R=jgruber@chromium.org > > Bug: v8:9183 > Change-Id: I789295e5bbea682b2e46ccf5a55c69dc74f0ed72 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617669 > Auto-Submit: Simon Zünd <szuend@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61632} TBR=jgruber@chromium.org,szuend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9183, v8:10289 Change-Id: Ibd8566151f036efe73c869dcfd2cfee2a559489b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083299Reviewed-by:
-
Seth Brenith authored
This is a reland of 25d16574 Changes from original: replaced slow test with fast test Original change's description: > [runtime] Improve handling of enumeration index on global dictionary > > Bug: chromium:1056054 > Change-Id: Ie1f2da98bc54a2ad5189cbe2ee1686fe1ef7019a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2079035 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#66504} Bug: chromium:1056054 Change-Id: I45b9a096b1e37bf1dc5e792f106cdfadd47fabf9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080855Reviewed-by:
-
Milad Farazmand authored
Port d303f4fb Original Commit Message: In the past we've used the isolate argument to signal whether we were in unicode mode (nullptr) or not (the real isolate). This is no longer needed, and in fact breaks no-i18n mode which always expects to have a real isolate. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I2b8ede3c89738a6cec59f8e32657a3c8c815fe6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081888Reviewed-by:
-
Andreas Haas authored
Stack parameters in the StubCallDescriptor were set to the wrong type. I changed it now so that for stack parameters that are specified in the CallInterfaceDescriptor, type specified type is used. All other parameters are assumed to be tagged, as it has been until now. Original change's description: > [wasm] Refactor AtomicWait implementation > > The existing implementation included aspects that are not > straight-forward to implement in Liftoff and seemed inefficient: > * Convert the timeout in WebAssembly code from I64 to F64, just to > convert it back in the runtime. > * On 32-bit platforms this conversion needs an additional C-call. > * Split the I64 expected value from I64 into two I32 values in the > wasm-compiler. > * Ideally the int64-lowering takes care of 32-bit specific handling. > > With this CL the timeout and the expected value are passed as I64 to > the runtime (a builtin moves the I64 into a bigint for that). The > int64-lowering takes care of 32-bit platforms. There are special > builtins for 32-bit platforms, but they are written such that ideally > also the int64-lowering could create them. Bug: v8:10108 Change-Id: Ib87b543666708457c0d686208a86e46cdca3f9a2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080362Reviewed-by:
-
Georg Neis authored
Change-Id: Ibba52fe0c94dbb95ec66bc88d0a1e9a254094013 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2080364 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Clemens Backes authored
The frame created by the WasmDebugBreak builtin now has a separate frame type, which will (later) allow to inspect the spilled registers. Once Liftoff supports reference types, this frame will also need special GC support for spilled heap references. R=jkummerow@chromium.org Bug: v8:10222 Change-Id: I110e51d1e6d09b0f44dcdd1cdcaafa2eaa64fddd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083013Reviewed-by:
-
Liviu Rau authored
Bug: chromium:1055078 Change-Id: Ifa421501cd19f445c2e0c0c87ab33563cef205cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2077677 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Bug: chromium:1055060 Change-Id: I9fd06642ba47d1452b33b0e97715dd2e64943c6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083027Reviewed-by:
-
Leszek Swirski authored
Use macros to unify how HashTable (and subclasses) are marked as externally specialised, and how those specialisations are initialised. This cleanup will make it easier in the future to also add specialisations of HashTable methods for Isolate/OffThreadIsolate. Bug: chromium:1011762 Change-Id: Ibb62cf30d3ba40170e1d35ab72ada0f74963a5c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083023 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Igor Sheludko authored
This will help detecting TaggedIndex-related issues earlier. Bug: v8:10047 Change-Id: Ibd150e8ff77ec807977e0ee1b54c880620840bac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071261 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: chromium:1051017 Change-Id: I1729c059f4bc4fc75615fa0aa8dacf44dc56dad4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066968 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#66526}
-
Clemens Backes authored
This reverts commit c6c9d4bf. Reason for revert: Fails on noi18n bot: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20noi18n%20-%20debug/30737 Original change's description: > Update unicode-regexp-ignore-case-noi18n expectations > > There appear to be one or several bugs in noi18n mode such that > expectations in this test are no longer met. This CL updates > expectations to the current behavior and re-enables the test so we at > least preserve coverage in the other cases. > > The behavior in question should be investigated in the future > (low priority). > > Bug: v8:10120 > Change-Id: Ib7c9a18133a386e6e39ee54d68ce4106d9b28c84 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081815 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66524} TBR=jkummerow@chromium.org,jgruber@chromium.org Change-Id: I960b90fe3679ef4c04782ca9ac9b91454e636dbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10120 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083024Reviewed-by:
-
Jakob Gruber authored
There appear to be one or several bugs in noi18n mode such that expectations in this test are no longer met. This CL updates expectations to the current behavior and re-enables the test so we at least preserve coverage in the other cases. The behavior in question should be investigated in the future (low priority). Bug: v8:10120 Change-Id: Ib7c9a18133a386e6e39ee54d68ce4106d9b28c84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081815 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Victor Gomes authored
Bug: v8:10201 Change-Id: I7c91e912feab227378810c91afe3de61e0e2fda8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081817 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Georg Neis authored
Remove some duplication and make it easier to type a specific operation with given input types. Change-Id: I70d0424a1d1bd6330aa381568728d8313d5ad25d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2078541 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Enable ArrayBufferExtensions by default. The last CL (https://crrev.com/c/2078585) that tried to enable this was reverted because of a TSAN failure. This was fixed in https://crrev.com/c/2078586. Bug: v8:10064 Change-Id: I2c3e0f2614323ea1521f2085b3c2bda5b69418ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083012Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#66521}
-
Jakob Gruber authored
In the past we've used the isolate argument to signal whether we were in unicode mode (nullptr) or not (the real isolate). This is no longer needed, and in fact breaks no-i18n mode which always expects to have a real isolate. Bug: v8:10120 Change-Id: I2f848c4ff8c2ff0e9b84278cbcdf3c3670e44e58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081816Reviewed-by:
-
Igor Sheludko authored
Bug: v8:10047, v8:10257 Change-Id: Idf7f5e0faf6b8d41795bb362b2473392cdb6e73d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2077682Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#66519}
-
