- 08 Oct, 2021 10 commits
-
-
Benedikt Meurer authored
The V8Debugger maintains a list of async stack traces that were captured so far, two mappings pointing weakly to async stack traces in this (one mapping for tasks and one mapping for stored async stack traces). The V8Debugger regularly prunes the list (and cleans up the stale weak pointers afterwards) by going through the list in insertion order and removing items until the number is below half the limit of 128k entries. This approach wastes a lot of memory, since the list grows very big before this manual collection starts, and it doesn't pay any attention to whether the stack traces are still in active use or not. Also the limit of 128k seems incredibly high (and arbitrary). This leads to crashes observed in applications with lots of async task activity (i.e. huge Angular applications) as soon as the debugger is attached. This CL performs a quickfix by reducing the limit for async stack traces to a more reasonable number of 8k. We will need to follow up with a proper fix that ensures that we only hold on strongly to async stack traces that are still in need. Also-By: jarin@chromium.org Fixed: chromium:1258000 Bug: chromium:1257637, chromium:1254279, chromium:1203218 Change-Id: I2c482a688df4c6df575a0045d443db89d89b3d73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211709 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77301}
-
Junliang Yan authored
Change-Id: I64f1d8868b3bc732d0014baaf4c87a7b6a0c68db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212814Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77300}
-
Patrick Thier authored
Previously, StoreStoreElimination handled allocations as "can observe anything". This is pretty conservative and prohibits elimination of repeated double stores to the same field. With this CL allocations are changed to "observes initializing stores". This way it is guaranteed that initializing stores to a freshly created object are not eliminated before allocations (that can trigger GC), but allows elimination of non-initializing, unobservable stores in the presence of allocations. Bug: v8:12200 Change-Id: I5ef1ca8892a84a3b332e081e2fa6285d0eba9d46 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211585 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77299}
-
Samuel Groß authored
This allocator was only required to ensure zero-initialization of pages returned by the BoundedPageAllocator. With crrev/c/3208812, this is now possible in a (hopefully) more efficient way by using the kAllocatedPagesMustBeZeroInitialized PageInitializationMode. Bug: chromium:1218005 Change-Id: I504248107a54c90285aa9a3a616b334aaa3fcb7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211583Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#77298}
-
Igor Sheludko authored
... introduced in https://chromium-review.googlesource.com/c/v8/v8/+/3182231 Bug: v8:11880, chromium:1254494 Change-Id: I40bdb5b062adc74ed1dc63d9a334184fcac451b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212509 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77297}
-
Samuel Groß authored
On Windows pre 8.1, reserving a large virtual memory region for the cage is too expensive as it (apparently) creates PTEs. As such, we can only create a cage with the minimum size and without guard regions. Bug: chromium:1218005 Change-Id: Ib19b9a08f8c965d9739c1d539a0153b32a290826 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212507Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#77296}
-
Manos Koukoutos authored
For debugging purposes, we print the validation error if the module generated by WasmCompileFuzzer fails to validate. Change-Id: I79d2827e489194d02150484ab5a196e979a302af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211574Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77295}
-
Lu Yahan authored
Change-Id: Iba439f2de9da359baeebd23482880013939b3066 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212059 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#77294}
-
Liu Yu authored
Port: 9d3c9d47 Bug: v8:7748 Change-Id: Id2fbd5c8dd5be1ea1932f48c03657f636bfb28bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3213351Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#77293}
-
Ng Zhi An authored
R=gdeepti@chromium.org Bug: v8:12207 Change-Id: I3eafe4b2cf2d37fd4f8a9792fb96bf7b92a4c61b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3208456Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77292}
-
- 07 Oct, 2021 18 commits
-
-
Ng Zhi An authored
x64 already had logic to enable a lower CPU extension if a higher level one was supported. Add this to ia32. And also add SSSE3->SSE3 logic. Drive-by cleanup to remove an extra CpuFeatureScope. Bug: v8:11154 Change-Id: I12e3aa990cc07149da213911c624468a39f4e1a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212811Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77291}
-
Frank Tang authored
This is a reland of a1e6efd8 Fix Android issue by checking the resources is not filtering out. Original change's description: > [intl] Fix consistency in Intl API > > Fix several edge cases consistency issues with ICU discovered by test262 test by > using Intl Enumeration API > 1. Work around ICU short coming of always fallback in currency display > name so when the fallback is "none" in DisplayNames, the force fallback > code will produce the correct undefined from the of(currency_code) method. > 2. Always check numbering system is not algorithm based numbering system > to fix DateTimeFormat/RelativeTimeFormat/NumberFormat > resolvedOptions().numberingSystem when the reqested numberingSystem is one > of the numbering systems that we filter out the resources and not supported. > 3. Generalize the iso8601 bit solution in DateTimeFormat and rename it to > alt_calendar bit to also fix DateTimeFormat resolvedOptions report > calendar as "islamic" while requesting "islamic-rgsa". > 4. Work around reporting inconsistency of currency code and display name > in ICU. > > Bug: v8:12209 > Change-Id: Ibd349ee55426fad7d6f20a5e93fb35ff7438e111 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3153576 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77242} Bug: v8:12209 Change-Id: I96e1ba33e97f6a4abbe20e23a8fdff6cdf8bc131 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207380Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#77290}
-
Milad Fa authored
Port 9d3c9d47 Original Commit Message: So far the slot is set to 0; in an upcoming CL it will be used for an actual feedback vector. R=jkummerow@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Idbaa1d11fbfe81cf1106e4796c82ae6a1d6c1a11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3212330Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77289}
-
Maria Tîmbur authored
Add support for the i8 and i16 packed types. Because i8 and i16 do not exist as value types we need an i32 to instantiate a packed field. Bug: v8:11954 Change-Id: Ib311fee537c4c9e4aed0ac366172b9b5fb1ee88e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3210267 Commit-Queue: Maria Tîmbur <mtimbur@google.com> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#77288}
-
Jakob Kummerow authored
This patch adds infrastructure for collecting feedback about call_ref call targets in Liftoff code, and using that feedback for turning such calls into inlineable direct calls when building Turbofan graphs. The feature is considered experimental quality and hence off by default, --wasm-speculative-inlining turns it on. Bug: v8:7748 Change-Id: I0d0d776f8a71c3dd2c9124d3731f3cb06d4f5821 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3205902 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77287}
-
Camillo Bruni authored
- Add Context extension slot verification - Fix ScriptContextTable printing - Make Context::scope_info() inlinable Bug: chromium:1244145 Change-Id: Ide71866885f3f92de6561dfef6911ee52c6094f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211578 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#77286}
-
Samuel Groß authored
Currently, when compiling with V8_VIRTUAL_MEMORY_CAGE enabled, the behavior of the BoundedPageAllocator changes from simply making freed pages inaccessible to decommitting them, which guarantees that they will be zero-initialized after the next allocation. As this seems to cause some performance regressions on Mac, this CL introduces a new enum that specifies how the allocator should behave: kAllocatedPagesMustBeZeroInitialized causes the pages to be decommitted during FreePages() and ReleasePages() and thus guarantees zero-initialization during AllocPages(). kAllocatedPagesCanBeUninitialized only causes the pages to be made inaccessible, and so does not generally guarantee zero-initialization for AllocPages(). Finally, this CL also removes some dead code in allocation.cc. Bug: chromium:1257089 Change-Id: I53fa52c8913df869bee2b536efe252780d1ad893 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3208812 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77285}
-
Jakob Gruber authored
Certain collators and subject strings may take this new fast path without calling into the (slow) ICU comparison functions. This CL can be roughly split into three topics: 1. The fast path check, precomputed and implemented as a whitelist on the current locale string. 2. The actual fast path, which checks subject string eligibility and performs L1 and L3 collation weight comparisons all in one pass. 3. Resuming from an aborted fast-path into the generic path. A longer overview is available at https://docs.google.com/document/d/1oyDwjYn2JyHsx2YnJJKhjX0WMNQXb8ao86-DRzqiYNg/edit?usp=sharing JetStream2/cdjs scores improve by roughly 40%. Bug: v8:12196 Change-Id: I5e1bbd731a36c361af9667f9104d6fa15c42e117 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149463Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77284}
-
v8-ci-autoroll-builder authored
This is a reland of 2ca7641f The tools/clang change was reverted to make sure we don't experience timeouts like https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/8083/overview Bug: v8:12293 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ebad853..c40c33e > > Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/9959b06..fdbb919 > > Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/a002c72..15999e7 > > Rolling v8/third_party/aemu-linux-x64: FAd7QuRV-mCjbKgg2SO4BBlRCvGIsI672THjo3tEIZAC..ekZcu3VD0XVbtKxyJwVgI96y6Sr0eYcdLkgCt6ejF0gC > > Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/7a11b79..1a68ade > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c0b9d25..ee3f2f4 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0e2fb33..281edf7 > > Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/3b49be0..075810f > > Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/3f44383..4df07a2 > > Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dfa96e8..bffc82b > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c06edd1..8640ca8 > > Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:293cb303c8d63cc435a32b2fd1e834db15bfc069 > > Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:293cb303c8d63cc435a32b2fd1e834db15bfc069 > > Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:293cb303c8d63cc435a32b2fd1e834db15bfc069 > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Change-Id: I99dbd70ee899e1d1c9fafcf72509f2f50b1ae8a5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3210331 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#77275} Change-Id: Ia209b986eea61444d768782f58d4ba9391934f3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211569Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77283}
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:12281 Change-Id: Ice1465c2656c0ffd95b6297039f40762a176ddb4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211581Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77282}
-
Camillo Bruni authored
Change-Id: I2ef2314deb2384dfdca06bd46f2d3640787c2011 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211579 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#77281}
-
Lutz Vahl authored
R=hablich@chromium.org, vahl@chromium.org Change-Id: I9b30abad9500a1d89dd42f43dfe3e54fb4aed23c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211573Reviewed-by: Lutz Vahl <vahl@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Auto-Submit: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/heads/main@{#77280}
-
Jakob Kummerow authored
So far the slot is set to 0; in an upcoming CL it will be used for an actual feedback vector. Bug: v8:7748 Change-Id: I79f7502757d2cd8b07ced7105bf7532f5bc9b4f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3205898 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77279}
-
Michael Lippautz authored
In addition, trigger the observer only every ~256KiB to avoid excessive incremental marking steps on fragemented heaps that have to set up LABs repeatedly. Bug: v8:12285 Change-Id: Id3d85d2c3f96d9d914c731f998df827898e1863d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3208810 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77278}
-
Michael Achenbach authored
This reverts commit 2ca7641f. Reason for revert: https://crbug.com/v8/12293 https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20CFI/8083/overview Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ebad853..c40c33e > > Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/9959b06..fdbb919 > > Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/a002c72..15999e7 > > Rolling v8/third_party/aemu-linux-x64: FAd7QuRV-mCjbKgg2SO4BBlRCvGIsI672THjo3tEIZAC..ekZcu3VD0XVbtKxyJwVgI96y6Sr0eYcdLkgCt6ejF0gC > > Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/7a11b79..1a68ade > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c0b9d25..ee3f2f4 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0e2fb33..281edf7 > > Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/3b49be0..075810f > > Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/3f44383..4df07a2 > > Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dfa96e8..bffc82b > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c06edd1..8640ca8 > > Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:293cb303c8d63cc435a32b2fd1e834db15bfc069 > > Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:293cb303c8d63cc435a32b2fd1e834db15bfc069 > > Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:293cb303c8d63cc435a32b2fd1e834db15bfc069 > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Change-Id: I99dbd70ee899e1d1c9fafcf72509f2f50b1ae8a5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3210331 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#77275} Bug: v8:12293 Change-Id: Id647e0dbd0abbfd5a2c119f74f9a5c6f6c6ca22e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211566 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77277}
-
Samuel Groß authored
The current implementation of the default ArrayBufferAllocator for the virtual memory cage is highly inefficient as it simply forwards all requests to the cage's PageAllocator. With this CL, this allocator is now only used when the heap sandbox is enabled, in which case ArrayBuffer backing stores must be located inside the cage. In all other cases, in particular when only the virtual memory cage is enabled, the backing stores can be located outside the cage and so the malloc-based ArrayBufferAllocator is used. This change only affects configurations in which V8's default ArrayBufferAllocator is used. Bug: chromium:1218005 Change-Id: I39cb5de3034ccd4b6975dc5193d8c7309857433b Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3205018Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77276}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ebad853..c40c33e Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/9959b06..fdbb919 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/a002c72..15999e7 Rolling v8/third_party/aemu-linux-x64: FAd7QuRV-mCjbKgg2SO4BBlRCvGIsI672THjo3tEIZAC..ekZcu3VD0XVbtKxyJwVgI96y6Sr0eYcdLkgCt6ejF0gC Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/7a11b79..1a68ade Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c0b9d25..ee3f2f4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0e2fb33..281edf7 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/3b49be0..075810f Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/3f44383..4df07a2 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dfa96e8..bffc82b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c06edd1..8640ca8 Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:293cb303c8d63cc435a32b2fd1e834db15bfc069 Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:293cb303c8d63cc435a32b2fd1e834db15bfc069 Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:293cb303c8d63cc435a32b2fd1e834db15bfc069 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I99dbd70ee899e1d1c9fafcf72509f2f50b1ae8a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3210331Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77275}
-
Shu-yu Guo authored
Bug: v8:11990 Change-Id: I405f6bd73812e3cbd99c9b4230f08390648022b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3210233 Commit-Queue: Shu-yu Guo <syg@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77274}
-
- 06 Oct, 2021 12 commits
-
-
Ng Zhi An authored
R=gdeepti@chromium.org Bug: v8:12207 Change-Id: Ic0d408b3c7ecf69e45a794c6c96159df2bee80e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3180376Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77273}
-
Dominik Inführ authored
IsActive() is only supposed to be used in DCHECKs and supporting this is going to get harder when introducing safepoints across multiple isolates because there won't be this single counter anymore to check. With AssertActive() we can just invoke AssertHold() on our mutex. No functional changes. Bug: v8:11708 Change-Id: Ic8d17738afdc90e92e6b54f615ec9757a826cc64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207903 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77272}
-
Igor Sheludko authored
... to support creation of fillers in external code space. Bug: v8:11880 Change-Id: I47b352b8b44733c529b6b0cb2b39cf676ce83923 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3208813 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77271}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/50dd431..61339fd2 Bug: v8:7834, v8:12288, v8:11544, v8:11989 Change-Id: Ie7c799f1c757554bd66619fe65433921d4419d52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3206773Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#77270}
-
Milad Fa authored
Port 7c08633b Original Commit Message: Replace 'virtual' by 'override' when overriding methods. This uncovered one method which was unnecessarily virtual: {RegExpMacroAssemblerARM64::CheckCharacters}. R=clemensb@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I542aeae836b5b78284291ed39844a5c166ed06ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3208811Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77269}
-
Dominik Inführ authored
We are going to introduce safepoints across multiple isolates, with this the name GlobalSafepoint might be misleading. Use IsolateSafepoint as name to emphasise this class reaches a safepoint for a single isolate only. No functional changes. Bug: v8:11708 Change-Id: I8254031dd0bc8e6dcf9f7353297803c37dba47ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207901 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77268}
-
Clemens Backes authored
Marking the labels as unused is only needed when we abort code generation. Otherwise the DCHECKs in the label destructors are useful to catch bugs. R=jgruber@chromium.org Bug: v8:12244 Change-Id: I63198f98a7acd1f2528d31964c01bc6815ba99a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3205899 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77267}
-
Vasili Skurydzin authored
Change-Id: I49a4e2f05028279cd69d3909a9ca80f4c0acb1c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3208649Reviewed-by: Milad Fa <mfarazma@redhat.com> Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Vasili Skurydzin <vasili.skurydzin@ibm.com> Cr-Commit-Position: refs/heads/main@{#77266}
-
Milad Fa authored
Liftoff is temporarily disabled on PPC. After https://crrev.com/c/3202593 the newly skipped tests are failing with this error: ``` Check failed: tester.native_module()->GetCode(0)->is_liftoff() ``` Change-Id: I681a27930909fd6ac4e5087c2d03608b891a6066 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3208070Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77265}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Ia277cf58a0eea431c4f19198914c1539fd03bc06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207898 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77264}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I5b0200560c5d77c1218142ca686c4e71c5106600 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3208027 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77263}
-
Michael Achenbach authored
This reverts commit 8860a022. Reason for revert: https://crbug.com/v8/12292 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ebad853..98d97fd > > Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/9959b06..fd29545 > > Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/a002c72..15999e7 > > Rolling v8/third_party/aemu-linux-x64: FAd7QuRV-mCjbKgg2SO4BBlRCvGIsI672THjo3tEIZAC..3M11fN4tUefKOZExDkJbUXnPiJICCo0TwPwoejHowg8C > > Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/7a11b79..1a68ade > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c0b9d25..4b10835 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0e2fb33..281edf7 > > Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/3b49be0..075810f > > Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/dfa96e8..bffc82b > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c06edd1..8640ca8 > > Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:ec7a06c4fcde59629839f8e89c52a08d647e75f4 > > Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:ec7a06c4fcde59629839f8e89c52a08d647e75f4 > > Rolling v8/tools/luci-go: git_revision:a373a19da0fbbbe81b2b684e3797260294393e40..git_revision:ec7a06c4fcde59629839f8e89c52a08d647e75f4 > > TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Change-Id: I007b32f3475eb71678e50dbf4efa15a88ec85ff6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3206022 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#77247} Bug: v8:12292 Change-Id: I637676d821c9687fc25ce5b42700a018364f9b7a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207902 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77262}
-