- 10 Oct, 2016 32 commits
-
-
kozyatinskiy authored
* Inspector should depend on v8_libbase, v8 depedency is added in conditions section. * Inlined sources since they aren't used outside of this gyp file. BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2408833002 Cr-Commit-Position: refs/heads/master@{#40139}
-
heimbuef authored
BUG=v8:5409 Committed: https://crrev.com/a124feb0760896c8be61de08004a08c3bc9b4b3f Committed: https://crrev.com/fc840361e357a571c709e0239ae82cc089800b3f Review-Url: https://codereview.chromium.org/2348303002 Cr-Original-Original-Commit-Position: refs/heads/master@{#39633} Cr-Original-Commit-Position: refs/heads/master@{#40048} Cr-Commit-Position: refs/heads/master@{#40138}
-
heimbuef authored
BUG=v8:5409 Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e Committed: https://crrev.com/316669f62ea3834395bf4caab7bc3d7c32f6bbc6 Review-Url: https://codereview.chromium.org/2335343007 Cr-Original-Original-Commit-Position: refs/heads/master@{#39631} Cr-Original-Commit-Position: refs/heads/master@{#40044} Cr-Commit-Position: refs/heads/master@{#40137}
-
bradnelson authored
BUG=v8:5053 TEST=None R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2395333003 Cr-Commit-Position: refs/heads/master@{#40136}
-
titzer authored
R=bradnelson@chromium.org,aseemgarg@chromium.org BUG= Review-Url: https://codereview.chromium.org/2408823002 Cr-Commit-Position: refs/heads/master@{#40135}
-
neis authored
- Make testcfg.py ignore files ending in "_FIXTURE.js", which are not supposed to be tested standalone but only as imports to other modules. - Refine test262.status to match where we are with the modules implementation. BUG=v8:1569 R=adamk@chromium.org Review-Url: https://codereview.chromium.org/2400713004 Cr-Commit-Position: refs/heads/master@{#40134}
-
adamk authored
Unifies the approaches used for storing the specifier -> module mapping and the module -> directory mapping, using std::unordered_maps for both and storing them per-Context. This requires adding a method to the v8::Module API to get a hash code for a Module, but allows slimming down the API in return: gone are SetEmbedderData/GetEmbedderData, along with the fourth argument to ResolveModuleCallback. Besides a simpler API, this allows d8 to get closer to the HTML loader, which requires each Realm to have a persistent module map (though this capability is not yet exercised by any tests). BUG=v8:1569 Review-Url: https://codereview.chromium.org/2393303002 Cr-Commit-Position: refs/heads/master@{#40133}
-
mlippautz authored
R=ulan@chromium.org BUG= Review-Url: https://codereview.chromium.org/2409553003 Cr-Commit-Position: refs/heads/master@{#40132}
-
adamk authored
StringFromCodePointOperator needed to derive from Operator1<UnicodeEncoding> rather than plain old Operator. This was thankfully caught by the CFI build. R=bmeurer@chromium.org, caitp@chromium.org BUG=v8:5498 Review-Url: https://codereview.chromium.org/2398403003 Cr-Commit-Position: refs/heads/master@{#40131}
-
gsathya authored
Review-Url: https://codereview.chromium.org/2397373004 Cr-Commit-Position: refs/heads/master@{#40130}
-
neis authored
Extend a test of namespace imports such that it accesses the object inside a with statement (inside a sloppy function). Drive-by-fix: remove duplicate initialization of embedder data (probably due to bad merge). R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2405603003 Cr-Commit-Position: refs/heads/master@{#40129}
-
mythria authored
Revert of [Interpreter] Collect feedback about Oddballs in Subtract Stub. (patchset #2 id:20001 of https://codereview.chromium.org/2406843002/ ) Reason for revert: breaks win32-debug bot. Original issue's description: > [Interpreter] Collect feedback about Oddballs in Subtract Stub. > > BUG=v8:4280, v8:5400 > LOG=N > > Committed: https://crrev.com/d5d283b27d406486e2f8d7b44c6d2b3db4f98458 > Cr-Commit-Position: refs/heads/master@{#40124} TBR=leszeks@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280, v8:5400 Review-Url: https://codereview.chromium.org/2407923002 Cr-Commit-Position: refs/heads/master@{#40128}
-
petermarshall authored
Also add a test for when the first argument is null or undefined, as there are no tests that cover this currently. BUG=v8:5364 Review-Url: https://codereview.chromium.org/2399423003 Cr-Commit-Position: refs/heads/master@{#40127}
-
mtrofin authored
The spurious failures were caused by the compiled module template and its corresponding owning object getting out of sync due to memory allocations (which may trigger GC) between the points each were fetched. Specifically, the {original} was first obtained; then a GC may happen when cloning the {code_table}. At this point, the {original}'s owner may have been collected, getting us down the path of not cloning. When time comes to patch up globals, we incorrectly try to patch them assuming the global start is at 0 (nullptr), which in fact it isn't. This change roots early, in a GC-free area, both objects. Additionally, it avoids publishing to the instances chain the new instance until the very end. This way: - the objects used to create the new instance offer a consistent view - the instances chain does not see the object we try to form. If something fails, we can safely retry. - since the owner is rooted, the state of the front of the instances chain stays unchanged - with the same compiled module we started from. So the early belief that we needed to clone is not invalidated by any interspersed GC. This situation suffers from a sub-optimality discussed in the design document, in that, in a memory constrained system, the following snippet may surprisingly fail: var m = new WebAssembly.Module(...); var i1 = new WebAssembly.Instance(m); i1 = null; var i2 = new WebAssembly.Instance(m); //may fail. This will be addressed subsequently. BUG=v8:5451 Review-Url: https://codereview.chromium.org/2395063002 Cr-Commit-Position: refs/heads/master@{#40126}
-
titzer authored
R=rossberg@chromium.org BUG=chromium:575167 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux64_msan_rel Committed: https://crrev.com/640ae3f9d20dcae915dbfa978bf48944cd4d0dc3 Review-Url: https://codereview.chromium.org/2403823002 Cr-Original-Commit-Position: refs/heads/master@{#40121} Cr-Commit-Position: refs/heads/master@{#40125}
-
mythria authored
BUG=v8:4280, v8:5400 LOG=N Review-Url: https://codereview.chromium.org/2406843002 Cr-Commit-Position: refs/heads/master@{#40124}
-
machenbach authored
Revert of [wasm] Base address for data segments can also be the value of a global variable. (patchset #1 id:1 of https://codereview.chromium.org/2403823002/ ) Reason for revert: msan not happy: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/11332 Original issue's description: > [wasm] Base address for data segments can also be the value of a global variable. > > R=rossberg@chromium.org > BUG=chromium:575167 > > Committed: https://crrev.com/640ae3f9d20dcae915dbfa978bf48944cd4d0dc3 > Cr-Commit-Position: refs/heads/master@{#40121} TBR=rossberg@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2402373002 Cr-Commit-Position: refs/heads/master@{#40123}
-
jgruber authored
This CL ports RegExp.prototype.test, RegExp.prototype.match and RegExp.prototype.search to C++. Performance regressions are expected but should be improved in an upcoming CL. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2394713003 Cr-Commit-Position: refs/heads/master@{#40122}
-
titzer authored
R=rossberg@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403823002 Cr-Commit-Position: refs/heads/master@{#40121}
-
jochen authored
Before, some code paths just invoked job->FinalizeJob() and then manually installed the compilation result. Unify these. BUG=v8:5394 R=mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2399203003 Cr-Commit-Position: refs/heads/master@{#40120}
-
jgruber authored
Again, fast paths could be added for unmodified JSRegExp instances. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2392463005 Cr-Commit-Position: refs/heads/master@{#40119}
-
petermarshall authored
Revert of [builtins] Move StringIncludes to a builtin. (patchset #4 id:60001 of https://codereview.chromium.org/2399423003/ ) Reason for revert: String.includes crashes when called with null or undefined as the first param Original issue's description: > [builtins] Move StringIncludes to a builtin. > > BUG=v8:5364 > > Committed: https://crrev.com/b374d719e79a5b32168c25c0cda30056f5e6e36c > Cr-Commit-Position: refs/heads/master@{#40110} TBR=franzih@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5364 Review-Url: https://codereview.chromium.org/2407793002 Cr-Commit-Position: refs/heads/master@{#40118}
-
bbudge authored
- Adds an optional representation field to VReg and TestOperand structs. - Adds a simple FP allocation test to register-allocator-unittest.cc. - Adds some simple FP tests to move-optimizer-unittest.cc. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2400513002 Cr-Commit-Position: refs/heads/master@{#40117}
-
zhengxing.li authored
port 1beb89f2 (r39827) original commit message: This patch simplifies code for speeding up marking and removes write barrier counter. The step size is now computed based in two parts: - bytes to mark in order to keep up with allocation, - bytes to mark in order to make progress. BUG= Review-Url: https://codereview.chromium.org/2407733003 Cr-Commit-Position: refs/heads/master@{#40116}
-
machenbach authored
Costs ~600MB, but only if target_os is android - and the android_tools already require ~7.4GB. BUG=chromium:654353 NOTRY=true Review-Url: https://codereview.chromium.org/2408633002 Cr-Commit-Position: refs/heads/master@{#40115}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#40114}
-
zhengxing.li authored
The CL #39795 (https://codereview.chromium.org/2345593003 ) added MultiReturnSelect_f32/MultiReturnSelect_f64 tests. Because those tests need 2 float point return registers and x87 only has 1 FP return register, Those tests failed at x87 port. This CL skips MultiReturnSelect_f32/MultiReturnSelect_f64 tests for x87. BUG= Review-Url: https://codereview.chromium.org/2405743002 Cr-Commit-Position: refs/heads/master@{#40113}
-
marja authored
If an inner function only declares a variable but doesn't use it, Parser and PreParser produced different unresolved variables, and that confused the pessimistic context allocation. This is continuation to https://codereview.chromium.org/2388183003/ This CL fixes more complicated declarations (which are not just one identifier). For this, PreParser needs to accumulate identifiers used in expressions. In addition, this CL manifests FLAG_lazy_inner_functions in tests, so that we get clusterfuzz coverage for it. BUG=chromium:650969, v8:5501 Review-Url: https://codereview.chromium.org/2400613003 Cr-Commit-Position: refs/heads/master@{#40112}
-
jochen authored
BUG=v8:5412 R=jgruber@chromium.org,machenbach@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe Review-Url: https://codereview.chromium.org/2372983003 Cr-Commit-Position: refs/heads/master@{#40111}
-
petermarshall authored
BUG=v8:5364 Review-Url: https://codereview.chromium.org/2399423003 Cr-Commit-Position: refs/heads/master@{#40110}
-
bmeurer authored
There were once plans to generate cross-context code with TurboFan, however that doesn't fit into the model anymore, and so all of this is essentially dead untested code (and thus most likely already broken in subtle ways). With this mode still in place it would also be a lot harder to make inlining based on SharedFunctionInfo work. BUG=v8:2206,v8:5499 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2406803002 Cr-Commit-Position: refs/heads/master@{#40109}
-
mtrofin authored
Updated the deserialization API to avoid copying uncompiled bytes. BUG= Review-Url: https://codereview.chromium.org/2404673002 Cr-Commit-Position: refs/heads/master@{#40108}
-
- 09 Oct, 2016 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/472d19e..17093d4 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2401273002 Cr-Commit-Position: refs/heads/master@{#40107}
-
- 08 Oct, 2016 3 commits
-
-
mvstanton authored
And not by pointer address. BUG= Review-Url: https://codereview.chromium.org/2390823011 Cr-Commit-Position: refs/heads/master@{#40106}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#40105}
-
v8-autoroll authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/e0fa02a..b403fa6 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/792a87c..472d19e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clan/+log/30c5a8b..36879c7 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2405683002 Cr-Commit-Position: refs/heads/master@{#40104}
-
- 07 Oct, 2016 4 commits
-
-
adamk authored
These tests were marked as NO_VARIANTS under debug, but they were timing out under turbofan_opt as well on the CFI bot (see, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/6765). R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2400463003 Cr-Commit-Position: refs/heads/master@{#40103}
-
adamk authored
This allows us to stop using a Symbol, set as the name of the Module's SharedFunctionInfo, as our storage for a hash. As part of this, centralize the code for generating a random, non-zero hash code in one place (there were previously two copies of this code, and I needed to call it from a third file). BUG=v8:5483 TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2395233003 Cr-Commit-Position: refs/heads/master@{#40102}
-
kozyatinskiy authored
This problem was detected only on linux64_gyp bot. It's safe to convert length string into int from size_t. R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2402583004 Cr-Commit-Position: refs/heads/master@{#40101}
-
hablich authored
Revert of Pool implementation for zone segments (patchset #13 id:520001 of https://codereview.chromium.org/2335343007/ ) Reason for revert: blocks roll: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/294283/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Pool implementation for zone segments > > BUG=v8:5409 > > Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e > Committed: https://crrev.com/316669f62ea3834395bf4caab7bc3d7c32f6bbc6 > Cr-Original-Commit-Position: refs/heads/master@{#39631} > Cr-Commit-Position: refs/heads/master@{#40044} TBR=jochen@chromium.org,jkummerow@chromium.org,verwaest@chromium.org,yangguo@chromium.org,heimbuef@google.com NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=v8:5409 Review-Url: https://codereview.chromium.org/2400343002 Cr-Commit-Position: refs/heads/master@{#40100}
-