- 16 Oct, 2018 35 commits
-
-
Jakob Gruber authored
This reverts commit 65070355. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20noi18n%20-%20debug/23308 Original change's description: > [ia32,root] Add indirect calls and jumps through virtual register > > This adds a temporary mechanism for isolate-independent calls and > jumps. The problem was that - as ia32 doesn't have a scratch register > - Call and Jump cannot call through a register. This CL adds a > so-called virtual register (= a pointer-sized field) on IsolateData. > > The virtual register can be removed once pc-relative calls are > implemented and all builtins have been embedded. > > Bug: v8:6666 > Change-Id: I1f9d8a25643fad0b3919dd813dbe219d20fcc6bc > Reviewed-on: https://chromium-review.googlesource.com/c/1282991 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56693} TBR=sigurds@chromium.org,jgruber@chromium.org,ishell@chromium.org Change-Id: I782651140eee3e75d57ad57d614a981e420fdfeb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1283051Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#56694}
-
Jakob Gruber authored
This adds a temporary mechanism for isolate-independent calls and jumps. The problem was that - as ia32 doesn't have a scratch register - Call and Jump cannot call through a register. This CL adds a so-called virtual register (= a pointer-sized field) on IsolateData. The virtual register can be removed once pc-relative calls are implemented and all builtins have been embedded. Bug: v8:6666 Change-Id: I1f9d8a25643fad0b3919dd813dbe219d20fcc6bc Reviewed-on: https://chromium-review.googlesource.com/c/1282991 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56693}
-
Sigurd Schneider authored
Change-Id: If476aa8a759bbf6360ef1fc68dbc3e624f8731e5 Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1282971Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56692}
-
Georg Neis authored
Bug: v8:895691 Change-Id: Ic92cb250555d097b01f894b4b7b9ae5b2eea6668 Reviewed-on: https://chromium-review.googlesource.com/c/1282990 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: Ibc8a086c5761c732b454fbb6cc1e06abb9f5e90f Bug: v8:7777 Reviewed-on: https://chromium-review.googlesource.com/c/1283032Reviewed-by:
-
🎉 Mathias Bynens authoredThis is a reland of 0d91db0b. Proposal repository: https://github.com/tc39/proposal-well-formed-stringify Intent to ship: https://groups.google.com/d/msg/v8-users/IRu3bAC_pLM/pFwz2ti1AgAJ TBR=gsathya@chromium.org Bug: v8:7782 Change-Id: I53d006650e2b4099a111d2e5bc067e4a2c7cf4a0 Reviewed-on: https://chromium-review.googlesource.com/c/1282993Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#56689}
-
Sigurd Schneider authored
Change-Id: Ie77197db54b6d9117ba3e8823e1308e9419f766d Bug: v8:8312 Reviewed-on: https://chromium-review.googlesource.com/c/1282227 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56688}
-
Adam Klein authored
All of the places where MicrotasksScope is placed on the stack are callbacks from JavaScript, so microtasks would never run microtasks inside one of these methods. Change-Id: I6dc36971189d6479138b58b90e3b9acae0c3ef73 Reviewed-on: https://chromium-review.googlesource.com/c/1277721Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#56687}
-
Sathya Gunasekaran authored
Previously when class names were computed and set as part of StoreDataPropertyInLiteral calls, it was observable to static fields as these static fields are initialized right after the classes were constructed but before the class names were installed. This caused the name property to be undefined for this case. Instead, this patch always forces the creation of a name property on the class constructor when static class fields are used. This patch does kill the class boilerplate optimization, but currently all static class fields are installed using a runtime call to CreateDataProperty so this isn't any worse when using static class fields. In the future, this can be optimized away by storing the name on the boilerplate. There is spec discussion here: https://github.com/tc39/proposal-class-fields/issues/85 There isn't a resolution yet, there's still discussion about whether to have the name be undefined always for static class field initializers. But, I don't think that's useful as it would always kill our boilerplate optimization (like this patch does ..., but without the future optimization potential). Bug: v8:5367 Change-Id: I14afdf7ece3f2d9fa3c659d2c0bc3806e0b17abb Reviewed-on: https://chromium-review.googlesource.com/c/1281002Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
This does not change the behavior, just makes it more explicit rather than relying on the "presubmit" string being present in the builder name, which is about to be deprecated. R=machenbach@chromium.org, tandrii@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:893955 Change-Id: I99724b42510a93012dd40e338b1ff8f4047c1276 Reviewed-on: https://chromium-review.googlesource.com/c/1280582Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:6666, v8:7777 Change-Id: I842e61731a6df22f9bcdaa92cb6841af5c8ef796 Reviewed-on: https://chromium-review.googlesource.com/c/1280228Reviewed-by:
-
Michael Achenbach authored
This reverts commit c45bc57d. Reason for revert: Seen output once, that is enough. Original change's description: > [test] Temporary debug output for hanging tests > > TBR=sigurds@chromium.org,sergiyb@chromium.org > > Bug: v8:8292 > Change-Id: Ic03e2884ef645231807762f6b0210e69c5f9ac74 > Reviewed-on: https://chromium-review.googlesource.com/c/1282604 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56674} TBR=machenbach@chromium.org,sigurds@chromium.org,sergiyb@chromium.org Change-Id: Id5a2414682a9795998b86369368276e95c11394c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8292 Reviewed-on: https://chromium-review.googlesource.com/c/1283112Reviewed-by:
-
Tobias Tebbi authored
This bug surfaced in builds with some versions of libstdc++ (use_custom_libcxx=false), because of an additional debug check in std::min_element. Change-Id: I799c0a282101373ecf743eed61f911886ca23dc8 Reviewed-on: https://chromium-review.googlesource.com/c/1282989Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56682}
-
Dan Elphick authored
In preparation for sharing RO_SPACE between all Isolates within a process, this first pulls RO_SPACE out of the Startup snapshot and puts it in its own ReadOnly snapshot. The snapshot is first populated with the read-only roots. After that the StartupSerializer serializes as before but starting from the first mutable root. References to objects in the ReadOnly snapshot that aren't themselves roots are added to a new cache called ReadOnlyObjectCache which functions like the PartialSnapshotCache but lives in the ReadOnlySerializer rather than the StartupSerializer. These cache entries are referenced using a new bytecode: ReadOnlyObjectCache. (To make room for this, the ApiReference bytecode has been moved). To reduce code duplication, the StartupSerializer has been refactored to create a new base class RootSerializer, which ReadOnlySerializer also subclasses. The base class is responsible primarily for keeping track of already serialized roots and visiting the roots. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Iff26042886130ae22eccf2e11b35f6f226f4a792 Bug: v8:8191 Reviewed-on: https://chromium-review.googlesource.com/c/1244676 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Hai Dang authored
This improves the performance of ExtractFixedArray and CloneFastJSArray for double arrays, which in turn improve the performance of cloning double arrays with slice() or spreading. This, however, does not improve performance of spreading holey double arrays, because spreading needs extra work to convert holes to undefined. Bug: v8:7980 Change-Id: Ib8aed74abbb0b06982a3b754e134fa415cb7de2d Reviewed-on: https://chromium-review.googlesource.com/c/1280308Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: Ibacdc7b41a96fc7c7d4ff44552fe6d86ec2ef1aa Bug: v8:8312 Reviewed-on: https://chromium-review.googlesource.com/c/1282605 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:6666, v8:7777 Change-Id: I0d1306bb96e12c81e876888b0ca69cae5855fbc3 Reviewed-on: https://chromium-review.googlesource.com/c/1273100Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
The InstructionSelector on x64 was missing the ability to properly match comparisons of memory operands with zero, i.e. it used to turn something like Word32Equal(Load[Uint8](o, i), Int32Constant(0)) into movzbl reg, [o,i] cmp 0, reg even requiring a temporary register. Now with this change it generates the proper cmpb [o,i], 0 sequence. R=sigurds@chromium.org Bug: v8:8238 Change-Id: I52a71bbf95c85e11cb275f0f4a5726a6873cde95 Reviewed-on: https://chromium-review.googlesource.com/c/1281342Reviewed-by:
-
Tobias Tebbi authored
This bug does not affect the Torque run on tip-of-tree, but surfaced in https://crrev.com/c/1196693. The logic in Stack::DeleteRange was completely wrong and does not work if the number of moved elements is bigger than the number of deleted elements. Change-Id: I5433b3b06e2e54646104493e9bc5e77b9763a521 Reviewed-on: https://chromium-review.googlesource.com/c/1282103Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I673c4bddca876dd506be4979bbf2208e6f0af329 Bug: v8:6666 Also-By: jgruber@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1280326 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Achenbach authored
TBR=sigurds@chromium.org,sergiyb@chromium.org Bug: v8:8292 Change-Id: Ic03e2884ef645231807762f6b0210e69c5f9ac74 Reviewed-on: https://chromium-review.googlesource.com/c/1282604 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This adds root-relative access in a couple of spots (e.g.: LoadRoot, CompareRoot, PushRoot, Push, Move, etc.). Some methods now dispatch based on whether the given Immediate is an embedded object. ShouldGenerateIsolateIndependentCode() was added as a porting crutch: it forces isolate-independent code for builtins even though the builtin is not in the Builtins::IsIsolateIndependent() whitelist. This allows us to easily figure out which builtins can be white-listed with --print-embedded-builtin-candidates. Newly isolate-independent builtins are now whitelisted. Drive-by: Remove dead CompareRoot and JumpIfRoot helpers. Bug: v8:6666 Change-Id: I6b5f6f71b90ac22e7e15482af0617b0ca1c319da Reviewed-on: https://chromium-review.googlesource.com/c/1280665 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Dan Elphick authored
Change Heap::IterateStrongRoots to never iterate the read-only roots. In doing so remove VISIT_ALL_BUT_READ_ONLY and VISIT_ONLY_STRONG_FOR_SERIALIZATION. All such uses should now use VISIT_ALL and VISIT_ONLY_STRONG. Where ReadOnlyRoots iteration is required, this adds ReadOnlyRoots(isolate)->Iterate() at the call site. Add new begin, end, strong_mutable_roots_begin and strong_mutable_roots_end methods to RootsTable and try and make the existing uses a little more consistent. Bug: v8:8191 Change-Id: Ie9d0f9e5186db418428e2fafd38432b0bd879daa Reviewed-on: https://chromium-review.googlesource.com/c/1278500 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Florian Sattler authored
Change-Id: Ic8fe43e65fddec16b3c5c029acebda5ba1805e08 Reviewed-on: https://chromium-review.googlesource.com/c/1275812Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#56671}
-
Georg Neis authored
As well as a few other things in JSNativeContextSpecialization. Bug: v8:7790 Change-Id: Ic13abec45797bb4c6cc66a140180122529c7288d Reviewed-on: https://chromium-review.googlesource.com/c/1280327Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56670}
-
Jakob Gruber authored
If `out` is empty accessing `out.back()` is invalid. TBR=yangguo@chromium.org Bug: chromium:894934 Change-Id: I7286c5b6a9857f1cdb2bcaf383094bee65bac393 Reviewed-on: https://chromium-review.googlesource.com/c/1282565Reviewed-by:
-
Frank Tang authored
Bug: v8:5751 Change-Id: I51c76880059ab5ce62032777d01d7e44849e874a Reviewed-on: https://chromium-review.googlesource.com/c/1275808Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#56668}
-
Sigurd Schneider authored
Change-Id: If4b0725000a7a6bb7da6399b107a965d8cb4c86f Bug: v8:6666 Reviewed-on: https://chromium-review.googlesource.com/c/1271075 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This is a reland of fefd9230 Original change's description: > [ia32,root] Disable root indirections in irregexp code > > Irregexp code spills and restores ebx at boundaries, and clobbers it > inbetween. Root-relative loads are disabled in this region. > > Bug: v8:6666 > Change-Id: I9c68bc8ef88d324da609996a8457ac9e30a9b6fc > Reviewed-on: https://chromium-review.googlesource.com/c/1280762 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56639} Bug: v8:6666 Change-Id: I92fe74e790ab9b2937a3b15db85bad45e6443083 Reviewed-on: https://chromium-review.googlesource.com/c/1280226Reviewed-by:
-
Benedikt Meurer authored
The code for the initialization of the wrapper promise was using the generic InitializeJSObjectFromMap() helper, which generates a loop to initialization all fields of some generic object. In this particular case we're constructing a JSPromise, so we only need to initialize the elements and properties pointers, since all the other fields are taken care of by the PromiseInit() call on the next line anyways. Bug: v8:7253, v8:8238 Change-Id: If11963d1f94607ed9e48788f597c81c7344aafbe Reviewed-on: https://chromium-review.googlesource.com/c/1281602Reviewed-by:
-
Michael Achenbach authored
TBR=sigurds@chromium.org NOTRY=true Bug: v8:8310 Change-Id: I83b250ffa89deb59fc10434806db25893ffed375 Reviewed-on: https://chromium-review.googlesource.com/c/1282564Reviewed-by:
-
🎉 Mathias Bynens authoredThis reverts commit 0d91db0b. Reason for revert: <INSERT REASONING HERE> Original change's description: > Ship well-formed JSON.stringify
🎉 > > Proposal repository: > https://github.com/tc39/proposal-global > > Intent to ship: > https://groups.google.com/d/msg/v8-users/IRu3bAC_pLM/pFwz2ti1AgAJ > > Bug: v8:7782 > Change-Id: Iaf790f134917796deac0e84cc931828934a6e589 > Reviewed-on: https://chromium-review.googlesource.com/c/1260122 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56650} TBR=gsathya@chromium.org,mathias@chromium.org Change-Id: Ie214a72a01fa81f754fd411808eb0bb748f89dbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7782 Reviewed-on: https://chromium-review.googlesource.com/c/1282563Reviewed-by: -
Benedikt Meurer authored
There's a AsyncBuiltinsAssembler::InitializeNativeClosure() helper which is used by the `await` builtins to initialize the native closures, which are registered as fulfill/reject handlers. This helper initializes a JSFunction based on the builtin SharedFunctionInfo. Since we are dealing with builtins here, there's no point in using the fully generic helper CodeStubAssembler::GetSharedFunctionInfoCode(), but we can immediately assume that the SharedFunctionInfo::function_data() field contains a Smi builtin index (guarded by TNode CASTs). This almost cuts the generated code size for the `await` builtins in a half, and might also yield some performance improvements due to reduced register and instruction cache pressure. Bug: v8:7253, v8:8238 Change-Id: I3415c2f9e0f04a7154c4bf4c3fe8156854dbfe13 Reviewed-on: https://chromium-review.googlesource.com/c/1281604Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9578c43..e583af8 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/2dff9c9..13a00f1 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5aac72d..2be20fd Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dd78844..7d7bbc3 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I262810f51342a3323fc8ce9fa9fcd972e362e2fe Reviewed-on: https://chromium-review.googlesource.com/c/1281839 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56661}
-
Sathya Gunasekaran authored
- Add a new Intl::ResolveLocale method and uses it in all the intl objects. - Fix CanonicalizeLocaleList to call out to HasProperty as per spec. - Add calls to CanonicalizeLocaleList where it was previously missing. - Change CanonicalizeLocaleListJS calls to CanonicalizeLocaleList now that we have migrated ResolveLocale. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I4249d2045c1556f18d570b00f7c92cbc3fa52077 Reviewed-on: https://chromium-review.googlesource.com/c/1270255Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56660}
-
- 15 Oct, 2018 5 commits
-
-
Bangfu Tao authored
This patch adds support for "gm.py android_arm.release.check" and similar invocations. Change-Id: I6e2204cb00f574d759b9e142ecabd2582153f707 Reviewed-on: https://chromium-review.googlesource.com/c/1278629 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#56659}
-
Johannes Henkel authored
This is in preparation of referencing this type from the code generated by third_party/inspector_protocol/code_generator.py. v8 will not use protocol::Binary, that is, the .pdl file for v8 won't have binary fields. Therefore, we need not provide an implementation for this type. My overall WIP change is in here, and happy to explain more: https://chromium-review.googlesource.com/c/chromium/src/+/1244719 Bug: chromium:891377 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7336be5f6a60e6ad143290eca09dea59ff4b56a8 Reviewed-on: https://chromium-review.googlesource.com/c/1277714Reviewed-by:
-
Hai Dang authored
Array.prototype.map is currently not preserving PACKEDness. Use a for-loop instead. Bug: v8:7980 Change-Id: I08aff1cbcd84b9de260a5a1e2c68b9cfb5c3d888 Reviewed-on: https://chromium-review.googlesource.com/c/1280329 Commit-Queue: Hai Dang <dhai@google.com> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: Ic8beb18bf37343405e8f4443a9f0991bd365e8df Reviewed-on: https://chromium-review.googlesource.com/c/1280227Reviewed-by:
-
Michael Lippautz authored
Also fully deprecate AbortTracing. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I852d28d8ce0f02b3a048b1061de29c9fce71ce62 Reviewed-on: https://chromium-review.googlesource.com/c/1278811 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
