- 04 Feb, 2016 34 commits
-
-
cbruni authored
BUG=v8:4724, v8:1543 LOG=N Review URL: https://codereview.chromium.org/1668853002 Cr-Commit-Position: refs/heads/master@{#33747}
-
oth authored
Port of class literal support from the ast-graph-builder implementation. R=rmcilroy@chromium.org,mstarzinger@chromium.org BUG=v8:4280,v8:4682 LOG=N Review URL: https://codereview.chromium.org/1666943003 Cr-Commit-Position: refs/heads/master@{#33746}
-
mstarzinger authored
R=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1662293002 Cr-Commit-Position: refs/heads/master@{#33745}
-
neis authored
Note: This is currently only used by yield*, we still need to support it in other places (such as for-of loops). It can be used manually of course. (This CL does not touch the full-codegen implementation of yield* because that code is already dead. The yield* desugaring already supports return and doesn't need to be touched.) BUG=v8:3566 LOG=y Review URL: https://codereview.chromium.org/1639343005 Cr-Commit-Position: refs/heads/master@{#33744}
-
neis authored
R=littledan@chromium.org BUG= Review URL: https://codereview.chromium.org/1667503004 Cr-Commit-Position: refs/heads/master@{#33743}
-
jfb authored
The test currently only shows the JavaScript stack frames, I'll then add support for interleaved WebAssembly stack frames and update the test. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1661383002 Cr-Commit-Position: refs/heads/master@{#33742}
-
mvstanton authored
(RELAND: the problem before was a missing write barrier for adding the code entry to the new closure. It's been addressed with a new macro instruction and test. The only change to this CL is the addition of two calls to __ RecordWriteCodeEntryField() in the platform CompileLazy builtin.) We get less "pollution" of type feedback if we have one vector per native context, rather than one for the whole system. This CL moves the vector appropriately. We rely more heavily on the Optimized Code Map in the SharedFunctionInfo. The vector actually lives in the first slot of the literals array (indeed there is great commonality between those arrays, they can be thought of as the same thing). So we make greater effort to ensure there is a valid literals array after compilation. This meant, for performance reasons, that we needed to extend FastNewClosureStub to support creating closures with literals. And ultimately, it drove us to move the optimized code map lookup out of FastNewClosureStub and into the compile lazy builtin. The heap change is trivial so I TBR Hannes for it... Also, Yang has had a look at the debugger changes already and approved 'em. So he is TBR style too. And Benedikt reviewed it as well. TBR=hpayer@chromium.org, yangguo@chromium.org, bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1668103002 Cr-Commit-Position: refs/heads/master@{#33741}
-
littledan authored
R=neis Review URL: https://codereview.chromium.org/1667103002 Cr-Commit-Position: refs/heads/master@{#33740}
-
yangguo authored
R=mstarzinger@chromium.org, rmcilroy@chromium.org BUG=v8:4690 LOG=N Review URL: https://codereview.chromium.org/1667073002 Cr-Commit-Position: refs/heads/master@{#33739}
-
zhengxing.li authored
Unstructured control flow caused by excpetion handling leads to a wrong x87 stack state. This patch is to reset the x87 state at the hanlder entry point. Thanks for help from weiliang.lin@intel.com. BUG= Review URL: https://codereview.chromium.org/1668463006 Cr-Commit-Position: refs/heads/master@{#33738}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1667083002 Cr-Commit-Position: refs/heads/master@{#33737}
-
yangguo authored
Synchronize calls in the heap iterator have been put there for the serializer, which never actually made use of them. This CL fixes that. R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1667063002 Cr-Commit-Position: refs/heads/master@{#33736}
-
neis authored
This CL deals with yield* by desugaring it in the parser. Hence the full-codegen implementation of it becomes obsolete and can be removed in a future CL. The only change in semantics should be that the results of the iterator's next and throw methods are checked to be objects, which didn't happen before but is required by the spec. BUG= Review URL: https://codereview.chromium.org/1643903003 Cr-Commit-Position: refs/heads/master@{#33735}
-
yangguo authored
Code compiled during snapshot are overwhelmingly for functions that are only used for bootstrapping. It makes no sense to include them in the startup snapshot, which bloats up the snapshot size and slows down deserialization. Snapshot sizes for comparison, for ia32: w/o --ignition: 484k w/ --ignition: 537k bytecode removed: 489k R=rmcilroy@chromium.org,mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1667693002 Cr-Commit-Position: refs/heads/master@{#33734}
-
mstarzinger authored
This implements proper context switching while unwinding the stack due to an exception being handled in interpreted code. The context under which the handler is scoped is being preserved in a dedicated register while the try-block is running. Both, the stack unwinding machinery as well as the graph builder, restore the context from that register. R=rmcilroy@chromium.org,bmeurer@chromium.org BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1665833002 Cr-Commit-Position: refs/heads/master@{#33733}
-
mythria authored
Removes skips for two tests in cctest that are no longer crashing with ignition. BUG=v8:4680 LOG=N Review URL: https://codereview.chromium.org/1668843003 Cr-Commit-Position: refs/heads/master@{#33732}
-
machenbach authored
BUG= Review URL: https://codereview.chromium.org/1668833002 Cr-Commit-Position: refs/heads/master@{#33731}
-
rmcilroy authored
Moves the stack check from the function entry trampoline to instead be after function activation using an explicit StackCheck bytecode. Also add stack checks on back edges of loops. BUG=v8:4280,v8:4678 LOG=N Review URL: https://codereview.chromium.org/1665853002 Cr-Commit-Position: refs/heads/master@{#33730}
-
yangguo authored
This is to avoid polluting fuzzer seeds with the --ignition flag until we figure out something better. TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1661333002 Cr-Commit-Position: refs/heads/master@{#33729}
-
sigurds authored
This is also a refactoring of the merge function in escape analysis. BUG=v8:4586 LOG=n Review URL: https://codereview.chromium.org/1654163003 Cr-Commit-Position: refs/heads/master@{#33728}
-
machenbach authored
Crashes after https://codereview.chromium.org/1667673003 BUG=v8:4280 LOG=N NOTRY=true TBR=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1669783002 Cr-Commit-Position: refs/heads/master@{#33727}
-
yangguo authored
This change adds the basic infrastructure to record source positions for bytecode. R=rmcilroy@chromium.org, vogelheim@chromium.org BUG=v8:4960 LOG=N Review URL: https://codereview.chromium.org/1662983002 Cr-Commit-Position: refs/heads/master@{#33726}
-
machenbach authored
BUG=v8:4280 LOG=N NOTRY=true TBR=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/1661193003 Cr-Commit-Position: refs/heads/master@{#33725}
-
machenbach authored
BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1667673003 Cr-Commit-Position: refs/heads/master@{#33724}
-
titzer authored
This cleans up and simplifyies handling the bytes followin an opcode with little helper structs that will be useful in the interpreter and already have been in keeping OpcodeArity and OpcodeLength up to date with the decoder. R=bradnelson@chromium.org, ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1664883002 Cr-Commit-Position: refs/heads/master@{#33723}
-
mythria authored
Adds implementation and tests for rest parameters to interpreter. BUG=v8:4280,v8:4683 LOG=N Review URL: https://codereview.chromium.org/1664593003 Cr-Commit-Position: refs/heads/master@{#33722}
-
ahaas authored
The goal of the Int64Reducer is to replace all int64 nodes in a tf graph with a set of int32 nodes such that 64 bit tf functions can be executed on 32 bit platforms. At the moment the Int64Reducer only replaces Int64Constants, TruncateInt64ToInt32, and Word64And. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1655883002 Cr-Commit-Position: refs/heads/master@{#33721}
-
bmeurer authored
The parser should have never done this. The AstNumbering takes care of disabling compilers for certain language constructs. TBR=rossberg@chromium.org Review URL: https://codereview.chromium.org/1669523004 Cr-Commit-Position: refs/heads/master@{#33720}
-
hablich authored
With the combination of the WATCHLISTS feature and create_release.py it is possible to notify the mailing list v8-merges@googlegroups.com on pending merges. On master this notification is deactivated. R=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1663003003 Cr-Commit-Position: refs/heads/master@{#33719}
-
mvstanton authored
BUG= Review URL: https://codereview.chromium.org/1647123002 Cr-Commit-Position: refs/heads/master@{#33718}
-
bmeurer authored
The spec requires all Math functions to first call ToNumber on all arguments before doing any other observable operation. So early return in case of Infinity is not valid. Drive-by-fix: Remove the use of %_Arguments / %_ArgumentsLength and use (strict) arguments instead of allocating a temporary InternalArray explicitly. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1669773002 Cr-Commit-Position: refs/heads/master@{#33717}
-
bmeurer authored
No need to micro-optimize here, and in almost all cases here, using arguments should result in roughly the same code w/ Crankshaft anyway. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1664513007 Cr-Commit-Position: refs/heads/master@{#33716}
-
mtrofin authored
So far, we've been moving down gaps wholesale. This change moves individual move operations instead. This improves some benchmarks, and should overall reduce code size, because it improves the chance of reducing the number of moves. For example, there are improvements on x64 in Emscripten (Bullet, in particular) , JetStream geomean, Embenchen (zlib). In the process of making this change, I noticed we can separate the tasks performed by the move optimizer, as follows: - group gaps into 1 - push gaps down, jumping instructions (these 2 were together before) - merge blocks (and then push gaps down) - finalize We can do without a finalization list. This avoids duplicating storage - we already have the list of instructions; it also simplifies the logic, since, with this change, we may process an instruction's gap twice. Compile time doesn't regress much (see pathological cases), but we may want to avoid the allocations of the few sets used in the new code. I'll do that in a subsequent change. BUG= Review URL: https://codereview.chromium.org/1634093002 Cr-Commit-Position: refs/heads/master@{#33715}
-
v8-autoroll authored
Rolling v8/buildtools to e27b1f1459452013ce59c9d5dbc93c88982cb76e Rolling v8/tools/clang to 6449b18afaa80290fd8930c3a42c80908505f41f TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1660143007 Cr-Commit-Position: refs/heads/master@{#33714}
-
- 03 Feb, 2016 6 commits
-
-
aseemgarg authored
R=bradnelson@chromium.org BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4203 TEST=asm-wasm.js LOG=N Review URL: https://codereview.chromium.org/1664993002 Cr-Commit-Position: refs/heads/master@{#33713}
-
adamk authored
This removes --harmony-completion, --harmony-concat-spreadable, and --harmony-tolength and moves the appropriate tests from harmony/ to es6/. Review URL: https://codereview.chromium.org/1667453002 Cr-Commit-Position: refs/heads/master@{#33712}
-
mbrandy authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1663133002 Cr-Commit-Position: refs/heads/master@{#33711}
-
mbrandy authored
Port 44ec23ac R=hpayer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:561449 LOG=n Review URL: https://codereview.chromium.org/1669463002 Cr-Commit-Position: refs/heads/master@{#33710}
-
kozyatinskiy authored
A lot of deverlopers use deprecated sourceURL syntax. We should add console warning message before removing this. Original CL: https://codereview.chromium.org/1495633002/ BUG=chromium:558998 LOG=Y R=yangguo@chromium.org,hablich@chromium.org,adamk@chromium.org Review URL: https://codereview.chromium.org/1654223003 Cr-Commit-Position: refs/heads/master@{#33709}
-
mythria authored
Skips cctest/test-heap/NoWeakHashTableLeakWithIncrementalMarking that is crashing on arm64. BUG=v8:4280 LOG=N NOTRY=true Review URL: https://codereview.chromium.org/1660613005 Cr-Commit-Position: refs/heads/master@{#33708}
-